Repository navigation
Commit 1bdf674
fix(spec): the packageless-overlay-write-closed upgrade entry names both closed overlay write addresses (#29535)
<!-- claude-projects-attribution: {"github_login":"os-warren"} -->
_Requested by **Warren** · [project
thread](https://claude.ai/code/project/chan_01U5RdnAAmkSQmZbqh6FtqZ8?thread=cmsg_01U5RdnAAmkSQmZbqh6FtqZ8WDoJDMZf2EGw5BXNyAhGUU)_
Fixes #29393
Clause-②: no (migration entry prose; no accept set moves)
Metadata-protocol: none
## 维护者速读
- 改了什么:只改文字。未发布的升级条目 `packageless-overlay-write-closed`(ADR-0087 语义迁移)的
`surface` 与 `reason`
现在同时点名两个被关闭的覆盖写入地址:不带包的写入,和点名只读基础包本身(`?package=基础包`)的保存、发布、回滚,并点名这两种写入各自存下的行;`replacement`
补上绑定在基础包上的行的迁移与处置(与 CLI 打印的一致)。
- 为什么改:#28905 在同一版本里关闭了第二个地址,但这条升级条目只写了第一个;升级指南由它生成,运维读不到第二个地址。来源:合同复核记录
6577747588 的 S3。
- 风险与回滚:无运行时改动,只影响生成的升级指南与 spec-changes 文字。回滚即 revert 本 PR。
-
先看:`packages/spec/src/migrations/entries/semantic/18.packageless-overlay-write-closed.ts`
的 `surface`(两个编号地址)、`reason`(新增两句)与 `replacement`(绑定行的
`foreign_declaration` 处置)。
- 两分钟验证:`pnpm --filter @objectstack/spec check:upgrade-guide`,预期 exit
0;用 `--out` 生成的指南里该条目出现 `naming the read-only package itself` 与
`publish-drafts`。
- 需要你做的:无,席位落地。
## What changes
Text only, one entry.
`packages/spec/src/migrations/entries/semantic/18.packageless-overlay-write-closed.ts`
(unreleased ADR-0087 semantic entry, shipping in the same release as the
two closes):
- `surface` now names both closed addresses onto a view, dashboard,
report, translation or email template an installed read-only package
ships: (1) the write naming no package, worded as before; (2) the write
naming the read-only package itself: a save in draft or publish mode or
a per-item publish with `?package=BASE`, `POST
/api/v1/packages/BASE/publish-drafts` holding such a draft, and a
rollback of a row bound to the package, where the pair can be ensured,
the base records a version and the override write gate admits the
declared body (a delete naming the package keeps the write). The
stored-rows clause now covers both: package-less rows, and rows bound to
the read-only package itself (the rows `os migrate packageless-overlays`
also moves since #29392).
- `reason` gains two sentences: what each address stored (a row of no
package, which no export carries; a row bound to the package, declaring
nothing, served in place of its own document), and the named close
(refused `403 NOT_OVERRIDABLE` naming the pair and the `overrides`
declaration where the pair can take the declared override; a delete
naming the package stays open, and so does every write the pair could
not take, an email template locale the base does not ship among them).
Everything else in `reason` is unchanged.
- `replacement` (claim amendment 6584492790): the movable rows `--apply`
moves are package-less OR bound to the read-only package itself (the
preview's "bound to", `--json` `boundToBase`, which the ceremony lists
and moves since #29392). An unmoved package-less row keeps its
package-less write; an unmoved bound row keeps its delete naming the
package. A bound `foreign_declaration` row gets the remedy the cli
prints (`reasonOf`, the `boundToBase` arm, in
`packages/cli/src/commands/migrate/packageless-overlays.ts`): delete it
naming the package, then save its body into the pair, declaring
`overrides`, since a save naming the package is closed; the package-less
remedy is unchanged. The failed-move tail: a bound row keeps its delete
naming the package, and the save naming it where the pair could not take
the override (for those two causes `namedBaseCloseSubject` answers
null). The TO both closes share (write into `BASE.custom`, declaring
`overrides`) is unchanged. `acceptanceCriteria` is untouched.
- The header comment above the entry names both closed addresses and
both kinds of stored row.
- `.changeset/29393-overlay-write-entry-both-addresses.md`:
`@objectstack/spec` patch, both declaration lines, one sentence each for
`surface`/`reason` and `replacement`.
Measured against the code on `origin/main` (399df5b):
`namedBaseOverlayWriteRefusal` / `namedBaseCloseSubject` in
`packages/metadata-protocol/src/protocol-packaged-base-refusal.ts`, and
the #28905 changeset's Now refused / Still open lists, which the new
wording follows clause for clause.
### The card's conditional line (commit revert path)
The card says to add a line if the S1 card decides the commit revert
path stays open. The S1 card is #29390; its seat ruling (comment
6579511992) is fork **A**: the revert's restore limb is closed with the
same sentence, so the path does not stay open. No such line is added.
#29390 has no PR yet; when it lands, its own ADR-0087 disposition
decides whether this entry's address (2) also names the commit revert
and package rollback.
## Why
Contract review 6577747588 of PR #29270, should-fix S3 (the dev's open
question 1, answered A): the upgrade guide is generated from this entry,
and a reader should meet both closed addresses in one entry. Triage
6582524180 set p1: it lands before the 18.3.0 cut.
## Tests
No test pins this entry's text (`git grep` for the entry id hits only
the entry and two changesets). The checks that read it, on b99d86a:
- `pnpm --filter @objectstack/spec exec vitest run --maxWorkers=2
src/migrations scripts/upgrade-guide-docs.test.ts
scripts/upgrade-guide-surface-span.test.ts` under the lock, after `pnpm
--filter @objectstack/spec build` (VERDICT command-exit 0): Test Files 7
passed (7), Tests 226 passed (226), VERDICT command-exit 0 (also 226/226
on 6b1ea51 and ecf1fd4).
- `check:upgrade-guide` exit 0 (protocol 18.0.0, 2 hop sections);
`check:spec-changes` exit 0.
- Generated with `tsx scripts/build-upgrade-guide.ts --out` to a scratch
file: the entry renders as one surface code span holding both numbered
addresses; `naming the read-only package itself` 2 hits,
`publish-drafts` 5 hits, `boundToBase` 1 hit, `ship the name): delete it
naming no package` 1 hit, `and the save naming it where the pair could
not take the override` 1 hit.
## Acceptance notes
- No checked-in artifact regenerates from this entry: the upgrade guide
and `spec-changes.json` are generated in memory at PR time and at
publish (`build-upgrade-guide.ts` header), and the docs pages are
gitignored.
## Verification
<details><summary>Derived gates on ecf1fd4 (b99d86a is a prose-only
follow-up in the same file)</summary>
- Prerequisite builds under the lock: `pnpm --filter @objectstack/spec
build` (VERDICT command-exit 0); `turbo run build --concurrency=2` over
the objectql, lint, formula, client and client-react closures (VERDICT
command-exit 0, 38/38 tasks).
- `node scripts/pm/dispatch-gates.mjs --commands --repo
objectstack-ai/objectstack` re-derived on ecf1fd4: 76 families (2 paths
vs merge base 399df5b, +50/-19). Each run once, stdin from /dev/null,
exit captured before any pipe: 75 exit 0 (the teardown self-test after
its pinned fixture `621a4876` was fetched on the first round).
- `pnpm check:dual-build-cjs-loads`: exit 3 (PREREQUISITE NOT MET: 68
workspace packages unbuilt). NOT MEASURED locally; CI runs it on a full
build.
- `dispatch-gates --ran`: 76 derived, 75 run, 1 NOT-MEASURED
(dual-build, from its recorded exit 3), 0 UNRUN.
- `check-changeset-no-major.mjs --base origin/main --event` with this
body: exit 0; LEVEL AXIS reads `Clause-②: no` + `Metadata-protocol:
none`, patch.
- On b99d86a (the review's three text fixes, same file): spec build,
the migrations and upgrade-guide tests (226/226), `check:upgrade-guide`
and `check:spec-changes` exit 0. The derived set is a property of the
changed paths, which did not change.
- `check:dev-prereqs` (local-only family): exit 1, the workspace is not
fully built (68 of 106 packages); a reading of this container, not of
the diff.
</details>
## Human Minimum
- [x] 1. Schemas start as Zod; `packages/spec` holds no runtime logic
(prose only).
- [x] 2. No name added.
- [x] 3. No formatter ran; `pnpm lint` is CI's run.
- [x] 4. One issue, one branch off `main`, one pull request.
- [x] 5. Patch changeset with both declaration lines, here and in the
changeset.
- [x] 6. `packages/spec` touched: no checked-in artifact regenerates
from this entry (the guide and spec-changes are generated in memory at
PR time).
- [x] 7. No hand edits to `content/docs/references/`,
`packages/*/CHANGELOG.md` or `content/docs/releases/`.
- [x] 8. English.
---
_Generated by [Claude
Code](https://claude.ai/code/session_01JQwxbWytk9Ec5dXr38QrwZ)_
<!-- signed: domain:spec#3 · os-warren ·
session_01JQwxbahe4v7GBD94QeSnir -->
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent dbca3ef commit 1bdf674
2 files changed
Lines changed: 66 additions & 29 deletions
File tree
- .changeset
- packages/spec/src/migrations/entries/semantic
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
13 | 18 | | |
14 | 19 | | |
15 | 20 | | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
24 | 35 | | |
25 | 36 | | |
26 | 37 | | |
27 | 38 | | |
28 | | - | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
29 | 42 | | |
30 | 43 | | |
31 | 44 | | |
| |||
35 | 48 | | |
36 | 49 | | |
37 | 50 | | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
43 | 57 | | |
44 | | - | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
45 | 62 | | |
46 | 63 | | |
47 | 64 | | |
48 | 65 | | |
49 | 66 | | |
50 | | - | |
| 67 | + | |
| 68 | + | |
51 | 69 | | |
52 | 70 | | |
53 | 71 | | |
54 | | - | |
55 | | - | |
56 | | - | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
57 | 77 | | |
58 | 78 | | |
59 | 79 | | |
60 | 80 | | |
61 | 81 | | |
62 | | - | |
63 | | - | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
64 | 90 | | |
65 | 91 | | |
66 | 92 | | |
| |||
0 commit comments