|
2003 | 2003 | }, |
2004 | 2004 | { |
2005 | 2005 | "id": "integration-system.connector-auth-kind-application", |
2006 | | - "title": "Declarative connector static auth kinds (none/api-key/basic/bearer) resolve credentialRef at materialization and land on the wire in exactly their header/query shape; an unresolvable credentialRef degrades its instance, naming the reference, instead of failing the boot; oauth2 has NO authorable spelling (EE tier)", |
| 2006 | + "title": "Declarative connector static auth kinds (none/api-key/basic/bearer) resolve credentialRef at materialization and land on the wire in exactly their header/query shape; an unresolvable credentialRef degrades its instance, naming the reference, instead of failing the boot; every authored auth kind refuses an inline secret, and oauth2 is open tier with strict keys and a required grant (ADR-0143 D1)", |
2007 | 2007 | "since": "v15.1", |
2008 | 2008 | "status": "active", |
2009 | | - "revision": 5, |
| 2009 | + "revision": 6, |
2010 | 2010 | "priority": "P1", |
2011 | 2011 | "surface": "api", |
2012 | 2012 | "fixtures": { |
|
2026 | 2026 | "basic → Authorization: Basic base64(username:password) — username authored in metadata (not a secret), password resolved from credentialRef (rest-connector.ts; connector-auth.zod.ts)", |
2027 | 2027 | "api-key, header form → header [headerName ?? 'X-API-Key']: <key> (rest-connector.ts; default applied at resolution, plugin.ts)", |
2028 | 2028 | "api-key, query form → paramName rides the query string and the header is NOT set (rest-connector.ts)", |
2029 | | - "rejection: auth type 'oauth2' — not an arm of ConnectorInstanceAuthSchema (none/bearer/api-key/basic only, connector-auth.zod.ts); OAuth2 token acquisition is the enterprise tier (ResolvedConnectorAuth doc, connector-auth.zod.ts)", |
| 2029 | + "rejection: an inline secret on ANY ConnectorInstanceAuthSchema kind — bearer token / accessToken, api-key key / apiKey, basic password, oauth2 clientSecret / accessToken / refreshToken, app-credential app secret, signed secret — each kind is a strict object that refuses the key by name at `auth`, the message pointing at credentialRef (or, for a token, saying the platform obtains it at run time) (connector-auth.zod.ts; ADR-0143 D3). oauth2 itself is an open-tier arm (ADR-0143 D1 reverses the ADR-0097 §3 enterprise placement): it is refused only without a `grant`, or with one outside authorization_code / client_credentials, at `auth.grant`; a kind outside the seven arms (e.g. 'oauth1') is refused at `auth.type`", |
2030 | 2030 | "rejection: inline `authentication` with any non-'none' type on an authored entry — the #7990 publish refusal (connector.zod.ts)", |
2031 | 2031 | "NOT enumSource-pinnable: the four static kinds are arms of a discriminated union of object schemas, not a named z.enum export — hand-enumerated here (4), guarded by the rejection variants instead" |
2032 | 2032 | ], |
|
2035 | 2035 | "dispatch each instance's `request` action (through a runtime flow: POST /api/v1/automation with a start → connector_action node, then POST /api/v1/automation/NAME/trigger, the vehicle QA run #24615 used on a stock-shaped boot; no HTTP route dispatches a connector action directly) at an echo path; capture what the upstream received per instance", |
2036 | 2036 | "read the authored rows back over GET /api/v1/meta and GET /api/v1/automation/connectors; grep both full bodies for every resolved secret value", |
2037 | 2037 | "unset QA_BEARER_TOK and boot again; capture the boot log's degrade line verbatim, the bearer instance's entry on GET /api/v1/automation/connectors, and what a dispatch to it (the step-2 vehicle) answers", |
2038 | | - "author one instance with auth {type:'oauth2', ...} and one catalog/instance entry with inline authentication {type:'api-key', key:'x'}; build both; capture the two rejections", |
| 2038 | + "in a scratch copy, author and build (objectstack compile) one entry per case, each alone: the well-formed oauth2 control {type:'oauth2', grant:'client_credentials', tokenUrl:'https://example.invalid/token', clientId:'qa', credentialRef:'QA_OAUTH_SECRET'} (expected to build clean); that control without `grant`; that control plus clientSecret:'x'; that control plus accessToken:'x'; a bearer auth plus token:'x'; an auth {type:'oauth1', credentialRef:'X'}; and a catalog/instance entry with inline authentication {type:'api-key', key:'x'}; capture the control's clean build and each rejection's text and path", |
2039 | 2039 | "run the pins: packages/connectors/connector-rest/src/rest-connector.test.ts (wire shapes), packages/services/service-automation/src/connector-materialization.test.ts (credentialRef resolution, env fallback, and the missing ref degrading its instance on an in-process boot, named), packages/services/service-automation/src/connector-credential-door.test.ts (missing → degraded, set → ready, clear → degraded again, in-process) and packages/spec/src/integration/connector-provider.test.ts (the #7990 inline-`authentication` refusal at schema level)" |
2040 | 2040 | ], |
2041 | 2041 | "acceptance": [ |
|
2058 | 2058 | "evidence": "the served boot's degrade line, the degraded descriptor and the dispatch failure" |
2059 | 2059 | }, |
2060 | 2060 | { |
2061 | | - "clause": "oauth2 is refused at AUTHORING, not degraded at runtime: auth {type:'oauth2'} fails parse (invalid discriminator — ConnectorInstanceAuthSchema has exactly the four static arms; the EE-tier boundary is documented on ResolvedConnectorAuth), and an inline `authentication` with a non-'none' type is refused with the located #7990 message steering to auth:{type,credentialRef} — there is no door through which an OAuth2 flow or an inline secret enters open-edition metadata", |
| 2061 | + "clause": "no inline secret enters open-edition metadata through any auth door, refused at AUTHORING, not degraded at runtime: every ConnectorInstanceAuthSchema kind (the four static ones and ADR-0143's oauth2, app-credential and signed) refuses an inline secret by name (unrecognized_keys at `auth`, the message pointing at credentialRef); an oauth2 auth is strict — `clientSecret` meets the credentialRef guidance, `accessToken` / `refreshToken` the runtime-token guidance — and one with no `grant` fails parse at `auth.grant` (invalid discriminator, authorization_code | client_credentials); an unknown kind (auth {type:'oauth1'}) fails at `auth.type`; and an inline `authentication` with a non-'none' type is refused with the located #7990 message steering to auth:{type,credentialRef}. oauth2 itself is open tier (ADR-0143 D1): the well-formed control — {type:'oauth2', grant:'client_credentials', tokenUrl, clientId, credentialRef} — builds clean", |
2062 | 2062 | "oracle": "build", |
2063 | | - "verify": "the two build rejections against connector-auth.zod.ts (union arms) and connector.zod.ts (the superRefine message, quoted fragments verbatim). The inline-`authentication` half is pinned at schema level by packages/spec/src/integration/connector-provider.test.ts ('rejects inline `authentication` secrets on a catalog descriptor' / '… on a provider-bound instance (§3)'), evidence beside the build. The oauth2 half has no pin: spec/src/integration/connector.test.ts parses oauth2 under AuthConfigSchema, the runtime shape, and no case feeds oauth2 to ConnectorInstanceAuthSchema, so drive that build by hand", |
2064 | | - "evidence": "the two error texts" |
| 2063 | + "verify": "each build rejection (objectstack compile on a scratch copy) read against connector-auth.zod.ts (the strict per-kind shapes and their guidance, ConnectorInstanceOAuth2AuthSchema's `grant` discriminator, the closed ConnectorInstanceAuthSchema union) and connector.zod.ts (the #7990 superRefine message, quoted fragments verbatim), with the well-formed oauth2 control built beside them and read clean. Schema-level pins, evidence beside the build and never its pass: packages/spec/src/integration/connector-auth-static-kinds.test.ts (each static kind's inline secret refused by name), connector-auth-grant-kinds.test.ts (oauth2 clientSecret and refreshToken refused, an unknown grant at auth.grant, the app-credential app secret, an unknown kind at type), connector-auth-signed.test.ts (every signed inline-secret spelling) and connector-provider.test.ts ('rejects inline `authentication` secrets on a catalog descriptor' / '… on a provider-bound instance (§3)'). No pin feeds an oauth2 auth with no `grant` or with an inline `accessToken`, so drive those two builds by hand", |
| 2064 | + "evidence": "each error text, and the control's clean build" |
2065 | 2065 | }, |
2066 | 2066 | { |
2067 | 2067 | "clause": "no resolved secret ever appears in a served body: GET /api/v1/automation/connectors descriptors and every /meta read of the scratch entries are free of all three secret values (grep the FULL bodies) — basic's username may appear (schema-declared non-secret), its password must not", |
|
2072 | 2072 | ], |
2073 | 2073 | "negative": [ |
2074 | 2074 | "a resolved secret appearing in any listing/meta/descriptor body is a cleartext-credential FAIL of P0 severity regardless of this item's priority", |
2075 | | - "an oauth2-authored entry building clean — or an inline non-'none' `authentication` publishing — is a FAIL against the #7990/ADR-0097 refusal doors", |
| 2075 | + "an inline secret on any authored auth kind building clean (oauth2's clientSecret / accessToken / refreshToken included), an oauth2 auth with no `grant` or an unknown kind building clean, or an inline non-'none' `authentication` publishing is a FAIL against the #7990 / ADR-0097 §3 / ADR-0143 D3 refusal doors; the well-formed oauth2 control being refused is a FAIL against ADR-0143 D1 (outbound OAuth is open tier)", |
2076 | 2076 | "a missing credentialRef failing the boot, materializing a connector that calls its upstream without the credential, or leaving the instance absent from GET /api/v1/automation/connectors instead of a degraded entry naming the reference is a FAIL against the degrade contract (ADR-0097, the amendment notes under §6 and under Runtime reconcile)" |
2077 | 2077 | ], |
2078 | 2078 | "traps": [ |
2079 | 2079 | "stale-dist" |
2080 | 2080 | ], |
2081 | 2081 | "automated": { |
2082 | 2082 | "kind": "unit", |
2083 | | - "ref": "packages/connectors/connector-rest/src/rest-connector.test.ts (per-kind wire shapes through a stubbed fetch) + packages/services/service-automation/src/connector-materialization.test.ts (credentialRef resolution incl. env fallback; its missing-ref case asserts the degraded reason names the ref and the factory is not called, on an in-process kernel, so it is evidence for acceptance[2], never its pass) + packages/services/service-automation/src/connector-credential-door.test.ts (missing → degraded → set → ready → clear → degraded, in-process; evidence for acceptance[2] too) + packages/spec/src/integration/connector-provider.test.ts (the #7990 inline-`authentication` refusal of acceptance[3] and negative[1], at schema level). No pin covers the oauth2 discriminator refusal, the LIVE echo-upstream leg, or the served boot's degrade line" |
| 2083 | + "ref": "packages/connectors/connector-rest/src/rest-connector.test.ts (per-kind wire shapes through a stubbed fetch) + packages/services/service-automation/src/connector-materialization.test.ts (credentialRef resolution incl. env fallback; its missing-ref case asserts the degraded reason names the ref and the factory is not called, on an in-process kernel, so it is evidence for acceptance[2], never its pass) + packages/services/service-automation/src/connector-credential-door.test.ts (missing → degraded → set → ready → clear → degraded, in-process; evidence for acceptance[2] too) + packages/spec/src/integration/connector-provider.test.ts (the #7990 inline-`authentication` refusal of acceptance[3] and negative[1], at schema level) + packages/spec/src/integration/connector-auth-static-kinds.test.ts, connector-auth-grant-kinds.test.ts and connector-auth-signed.test.ts (the per-kind inline-secret refusals, oauth2's strict keys and unknown grant, and the closed kind union of acceptance[3], at schema level). No pin covers a grant-less oauth2 auth, an inline oauth2 `accessToken`, the LIVE echo-upstream leg, or the served boot's degrade line" |
2084 | 2084 | }, |
2085 | 2085 | "source": [ |
2086 | | - "packages/spec/src/shared/connector-auth.zod.ts#ConnectorAuthConfigSchema (ConnectorAuthConfigSchema — the runtime shape; ResolvedConnectorAuth = the static open tier, OAuth2 named as the enterprise tier), (ConnectorInstanceAuthSchema — the authored shape: credentialRef instead of inline secrets, four arms, no oauth2)", |
| 2086 | + "packages/spec/src/shared/connector-auth.zod.ts#ConnectorAuthConfigSchema (ConnectorAuthConfigSchema — the runtime shape, four static arms since ADR-0143 D7 retired its oauth2 variant; ResolvedConnectorAuth = the static subset a provider factory receives at materialization, the grant-bearing kinds resolving per dispatch instead, D4), (ConnectorInstanceAuthSchema — the authored shape: credentialRef instead of inline secrets, seven strict arms — none / bearer / api-key / basic and ADR-0143 D2's open-tier oauth2, app-credential and signed; ConnectorInstanceOAuth2AuthSchema discriminates on `grant`)", |
2087 | 2087 | "packages/spec/src/integration/connector.zod.ts#authentication (the #7990 inline-`authentication` publish refusal, both message variants)", |
2088 | 2088 | "packages/services/service-automation/src/plugin.ts#resolveInstanceAuth (resolveInstanceAuth — the resolved credentialRef value → ResolvedConnectorAuth; api-key headerName default applied) + plugin.ts#degradeConnectorForCredential (a reference no source answers for degrades its instance, naming it, at boot and on a reload) + connector-credentials.ts#missingCredentialReason (the reason text)", |
2089 | 2089 | "packages/connectors/connector-rest/src/rest-connector.ts#applyAuth (applyAuth — the wire shapes per kind) + rest-provider.ts (the factory receives the RESOLVED static subset)", |
|
2120 | 2120 | "date": "2026-10-31", |
2121 | 2121 | "change": "acceptance[2] and negative[2] follow the degrade rule of #27237 (ADR-0097, the amendment notes under §6 and under Runtime reconcile): an unresolvable credentialRef degrades its instance, naming the reference, instead of failing the boot, so the clause is now an api one (the degraded descriptor, the boot's warn line, the dispatch failure) and the negative fails a boot that dies on it. The title, fixtures.requires[2] (the env → sys_connector_credential → host resolver chain), steps[3], steps[5], automated.ref and source[2] follow; the cited pin 'fails boot loudly when credentialRef does not resolve' no longer exists, and its successor 'degrades the instance, naming the reference, when credentialRef does not resolve' plus connector-credential-door.test.ts take its place. Read on main 501c864d", |
2122 | 2122 | "ref": "#27429" |
| 2123 | + }, |
| 2124 | + { |
| 2125 | + "revision": 6, |
| 2126 | + "date": "2026-11-02", |
| 2127 | + "change": "acceptance[3] and negative[1] re-pointed to ADR-0143 D1 (Accepted 2026-10-28), which made outbound connector OAuth open tier and reversed the ADR-0097 §3 enterprise placement this item pinned. QA run #29151 (18.3.0 W4-L2, 7fa9873f) FAILed both: an oauth2 instance builds clean, as the ADR says it must. ConnectorInstanceAuthSchema now has seven strict arms (none, bearer, api-key, basic, oauth2, app-credential, signed). The title, variants[5], steps[4], acceptance[3], negative[1], automated.ref and source[0] now assert the contract that holds: an inline secret is refused by name on every kind; oauth2 keys are strict (clientSecret → the credentialRef guidance, accessToken / refreshToken → the runtime-token guidance); an oauth2 auth with no `grant` fails at auth.grant; an unknown kind fails at auth.type; the #7990 inline-`authentication` refusal stands; and a well-formed oauth2 control building clean is the expected outcome, refusing it the FAIL. acceptance[3].verify drops the AuthConfigSchema oauth2 note (that runtime variant was retired by D7) and cites the three per-kind pins. No item yet covers the per-dispatch grant kinds (oauth2 / app-credential / signed) at runtime. Read on main 0d15f895", |
| 2128 | + "ref": "#29154" |
2123 | 2129 | } |
2124 | 2130 | ] |
2125 | 2131 | }, |
|
0 commit comments