Skip to content

Commit 305271e

Browse files
committed
refactor(objectql): move the validate body out of engine.ts into engine-validate.ts
The write preview's body moves unedited into a new module behind ValidateHost; the method keeps its name, modifiers, signature, docblock and position, and hands the body the members it reads. Six helpers the body shares with insert/update gain export in place and are imported back, never copied. The preview parity pin reads the preview's calls from the new module, and the system-context site register follows the moved isSystem read. Two staying docblocks stop linking the constant the previous cut moved. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FEkQ5oafXXU7gvgcHxdZb9
1 parent fe53769 commit 305271e

5 files changed

Lines changed: 643 additions & 493 deletions

File tree

‎content/docs/permissions/system-context.mdx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -529,13 +529,13 @@ and CI refuses one that differs from what the tree produces.
529529
| `packages/objectql/src/engine-referential-integrity.ts#assertReferencesResolve` | 1 | 23 |
530530
| `packages/objectql/src/engine-referential-integrity.ts#masterDetailHeadersCallerReads` | 1 | 29c |
531531
| `packages/objectql/src/engine-secret-internal-fields.ts#stripSearchCompanionFromRead` | 1 | 27 |
532+
| `packages/objectql/src/engine-validate.ts#validate` | 1 | 21b |
532533
| `packages/objectql/src/engine.ts#dependentCountIsDisclosable` | 1 | 28 |
533534
| `packages/objectql/src/engine.ts#inheritsElevation` | 1 | 1b |
534535
| `packages/objectql/src/engine.ts#insert` | 3 | 21, 22 |
535536
| `packages/objectql/src/engine.ts#isSystem` | 1 | 64 |
536537
| `packages/objectql/src/engine.ts#recordReferenceCheckElevation` | 1 | 29 |
537538
| `packages/objectql/src/engine.ts#update` | 4 | 19, 20 |
538-
| `packages/objectql/src/engine.ts#validate` | 1 | 21b |
539539
| `packages/observability/src/perf-timing.ts#isPerfDisclosurePrincipal` | 1 | 13 |
540540
| `packages/plugins/organizations/src/organizations-plugin.ts#start` | 1 | 62 |
541541
| `packages/plugins/plugin-approvals/src/approval-service.ts#comment` | 1 | 43 |

‎packages/objectql/src/engine-readable-ids-permission-formula.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ export interface ReadableIdsPermissionFormulaHost {
109109
* the read is REFUSED, loud (D5's envelope), ⛔ never composed partway and
110110
* never answered "no restriction".
111111
*/
112-
const READABLE_IDS_MAX_CHAIN_DEPTH = 8;
112+
export const READABLE_IDS_MAX_CHAIN_DEPTH = 8;
113113

114114
/** The body of `ObjectQL#composeReadableIdsChain`; the method's docblock there is its contract. */
115115
export async function composeReadableIdsChain<N>(

0 commit comments

Comments
 (0)