Skip to content

Commit 3dcea42

Browse files
ci(scaffold-e2e): give the image run an explicit database (Refs #30120) (#30714)
<!-- claude-projects-attribution: {"github_login":"os-elon-musk"} --> _Requested by **Elon** · [project thread](https://claude.ai/code/project/chan_01WedDzV26nniwxv7jC88B9D?thread=cmsg_01WedDzV26nniwxv7jC88B9DBFhkQHTZPTwLSqiWCH7wN5)_ Refs #30120 Clause-②: no Metadata-protocol: none Skills-docs: none — CI wiring only ## 维护者速读 - 改了什么:scaffold-e2e 的镜像启动步骤多传一个显式数据库地址(SQLite 文件)。 - 为什么改:#30120 之后官方镜像缺少显式数据库地址就拒绝启动,这一步会变红。 - 风险与回滚:只加一个环境变量;今天镜像不读它,零行为变化;回滚即删这一行。 - 先看:`.github/workflows/scaffold-e2e.yml` 中 "Docker build and run (scaffolded Dockerfile)" 步骤的 docker run。 - 两分钟验证:看本 PR 的 scaffold-e2e 检查,预期绿色、容器照常报健康。 - 需要你做的:这是受管路径(.github/workflows),请 os-zhuang 或 hotlong 批准;之后由席位在 #30120 主 PR 之前落地。 ## What changes One line in `.github/workflows/scaffold-e2e.yml`, step "Docker build and run (scaffolded Dockerfile)": the `docker run -d --name e2e ...` call gains `-e OS_DATABASE_URL="file:/tmp/e2e.db"` before the two secret lines. Why: ruling A3 on #30120 makes the official image refuse to start unless `OS_DATABASE_URL`, `OS_AUTH_SECRET` and `OS_SECRET_KEY` are all set explicitly (an explicit `file:` URL passes). This step sets only the two secrets, so once the #30120 main PR lands, its scaffold-e2e job goes red. The step only probes health, so an explicit SQLite file inside the container is enough. Until #30120 lands the variable is simply unused, so this PR is safe to land first; it must land before or together with the #30120 main PR. ## Verification - Hunk located by text on `origin/main` @ 788715e; the patch applies cleanly at its recorded position. - Pins: `git grep` for `--name e2e` hits only the workflow itself. `packages/create-objectstack` tests that extract the workflow's real `run:` blocks pass on the branch head 6a8d5ba: `scaffold-e2e-boot-probe.test.ts`, `template-ci-workflow.test.ts`, `runtime-image.test.ts` — Test Files 3 passed, Tests 40 passed (lock VERDICT command-exit 0). - Derived gates (`node scripts/pm/dispatch-gates.mjs --commands`) on head 6a8d5ba: 38 commands, all exit 0; `--ran` reconciliation: 38 derived, 38 run, 0 NOT-MEASURED, 0 UNRUN. - No changeset: the diff publishes nothing (`skip-changeset`). --- _Generated by [Claude Code](https://claude.ai/code/session_016WV4cytQjG9X1CrCgytUM5)_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
1 parent e8a9387 commit 3dcea42

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

‎.github/workflows/scaffold-e2e.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -511,6 +511,7 @@ jobs:
511511
# and then died at second 3 cost the full 60s and reported "never
512512
# became healthy" instead of "it is not running, here is why".
513513
docker run -d --name e2e -p 18080:8080 \
514+
-e OS_DATABASE_URL="file:/tmp/e2e.db" \
514515
-e OS_SECRET_KEY="$(openssl rand -hex 32)" \
515516
-e OS_AUTH_SECRET="$(openssl rand -hex 32)" \
516517
e2e-app

0 commit comments

Comments
 (0)