Skip to content

Commit 4391c50

Browse files
fix(plugin-dashboard): a compareTo KPI tile shows its number when the reader picks All time (#26027)
<!-- claude-projects-attribution: {"github_login":"os-steve"} --> _Requested by **Steve** · [project thread](https://claude.ai/code/project/chan_01FdL1XeUyvVNxLreh3F4Qi9?thread=cmsg_01FdL1XeUyvVNxLreh3F4Qi9KA65exXwidHdYJ3vG9pE5U)_ Fixes #25970 Clause-②: no Metadata-protocol: none ## What changes A dataset-bound widget with `compareTo` now asks for a comparison only when its resolved filter carries a date condition on the compared field (on any field when `compareTo.dimension` is omitted). When the filter dates nothing, which is what the reader's **All time** on the dashboard date filter produces, the widget sends the same query a widget without `compareTo` sends and the tile shows its number with no comparison badge. - `ui/packages/plugin-dashboard/src/DatasetWidget.tsx`: new exported `filterDatesField(filter, dimension?)`. The widget's declared comparison becomes `declaredCompareTo`; the `compareTo` the query, the signature and the overlay read is that value only when `filterDatesField` holds. No window is lowered either, so `runtimeFilter` is untouched in that case. - `ui/packages/plugin-dashboard/SKILL.md`: the "When NOT to use `compareTo`" line now separates a date condition that is not a closed window (still an error) from a filter that dates nothing (no comparison, no error). ## Mechanism, measured Picking All time calls `onChange(undefined)` (`DashboardFilterBar.tsx`, the ALL sentinel). `buildWidgetScopedFilter` skips an empty value, so `DashboardRenderer` merges no condition and the widget's own `filter` reaches `DatasetWidget` unchanged: the date key is ABSENT, not an open range. For the HotCRM "Selected Period" tile that means a runtime filter with no date at all, the case this PR omits the comparison for. ## The ruling this PR implements (the seat's delegated call) - An author-declared one-bound window (`$gte` only, e.g. a YTD tile) **stays an error**. The executor and the spec define `compareTo` only on a two-bound window, so the widget still sends `compareTo`, and the executor's refusal names the fix. HotCRM's YTD / QTD / 12M tiles written as one bound keep erroring until they are written as a closed pair. - Two dated fields with no `compareTo.dimension` stay the executor's ambiguity error. - The omission applies only when the filter carries no date condition on the compared field at all. "A date condition" is any ISO-date operand under the field, at any depth and in any position (`$or` / `$not` included), deliberately wider than the windows `extractDateWindows` lowers. A custom range with only a start date picked in the filter bar (`{ $gte }`) therefore also keeps erroring. ## Tests At head `b256ae44`: - `ui/packages/plugin-dashboard` whole package, `vitest run --maxWorkers=2 packages/plugin-dashboard/` under the verify lock: Test Files 188 passed (188), Tests 1842 passed, 6 skipped. - New in `DatasetWidget.compareTo.test.tsx`: `filterDatesField` unit cases, and four widget cases against a source that answers the way the executor does: no filter, a non-date filter, a named dimension left undated (all three send no `compareTo` and render the number with no badge), and a one-bound `$gte` window (still sends `compareTo` and shows the refusal). - New `DashboardRenderer.compareToAllTime-25970.test.tsx` drives the real Radix select: under the default `this_quarter` range the tile compares, then after picking All time the last selection is exactly the no-comparison query, the number shows, and no badge appears. A YTD tile (`$gte` only, opted out of the dashboard filter) keeps the refusal. - Four existing fixtures declared `compareTo` with no dated filter and had the mock answer a `__compare` column the real executor would have refused (`DatasetWidget.test.tsx` forwarding case, `colorVariant`, `comboPresentation`, `dimensionlessMeasures-11261`). Each now states a closed window. The objectui#7495 control (bar vs pie with no window) now uses a one-bound filter so its refusal still has something to refuse. - `pnpm --filter @object-ui/plugin-dashboard type-check`: exit 0; `tsc -p tsconfig.test.json --listFiles` includes both changed compareTo test files. - Ablation, once: the omission condition replaced with the bare declared value through `scripts/ablation-replace.mjs` (anchor x1 to x0, marker x0 to x1, restored blob equal to HEAD). The three omission cases and the All-time dashboard case went red (4 failed, 36 passed); the one-bound and YTD cases stayed green, as they pin unchanged behaviour. ## Gates `node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack` at `b256ae44`: 46 derived commands, each run, every one exit 0. `--ran` with exit codes: "46 derived famil(ies) accounted for — 46 run, 0 NOT-MEASURED (a DERIVED zero)". `node scripts/check-sdui-manifest.mjs` is among them after the re-record; `node scripts/check-changeset-fixed.mjs` (roster under `.changeset`) also exit 0. Type-check lanes, Test Core and the wide-population families are CI's. ## Acceptance notes - A widget whose author wrote `compareTo` with no date anywhere and no dashboard date filter bound to it now shows no comparison silently, where it used to show the refusal. At runtime that case cannot be told apart from the reader's All time, and the ruling puts the reader's case first. Catching it would belong at authoring time (a lint on `compareTo` over a widget that no date filter can reach); not filed here. - The dataset-bound path of `ObjectChart` (`ui/packages/plugin-charts`) does not forward `compareTo` to `queryDataset` at all, so it never hit this refusal. Observation only. --- _Generated by [Claude Code](https://claude.ai/code/session_01RJW3o457EFFwmLN1429vn9)_ --------- Co-authored-by: Claude <noreply@anthropic.com>
1 parent 07bdecd commit 4391c50

12 files changed

Lines changed: 318 additions & 19 deletions
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
---
2+
'@object-ui/plugin-dashboard': patch
3+
---
4+
5+
fix(plugin-dashboard): a `compareTo` KPI tile shows its number when the reader picks All time, instead of the executor's "compareTo needs a dated window to shift" error
6+
7+
Clause-②: no
8+
Metadata-protocol: none
9+
10+
- **Before.** A dataset-bound widget with `compareTo` always sent `compareTo` to the dataset executor, but lowered a `timeDimensions` window only when its resolved filter held a closed `{ $gte, $lte }` date pair. Picking **All time** on the dashboard's date-range filter removes that pair, so the executor refused the query and the tile showed a 400 error where its number belonged. The same tile without `compareTo` showed its number.
11+
- **Now.** When the resolved filter carries no date condition at all on the compared field (on any field when `compareTo.dimension` is omitted), the widget asks for no comparison: the query is the one a widget without `compareTo` sends, and the tile shows its number with no comparison badge.
12+
- **Unchanged: an author-written window that is not closed stays an error.** A one-bound window (`{ $gte: '{current_year_start}' }`, a YTD tile), an exclusive bound or a single day is still sent with `compareTo`, and the executor still refuses it and names the fix. The executor and the spec define a comparison only against a two-bound window. Two dated fields with no `compareTo.dimension` stay the executor's ambiguity error.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"package":"ui/packages/plugin-dashboard","sources":33,"sha256":"c8aaf01c370229a85b2dedb0a4927d9edca345d3f029c35e6d732ca637b6dc08","manifestSha256":"1f6e1ccb925a678eaa393f9091dfc7d0285e4e3626e0a5c61a5474687debabb7"}
1+
{"package":"ui/packages/plugin-dashboard","sources":33,"sha256":"20c947f73887cf0051d66da0c9daca4045ead2401c7adf47a0b15cad9c51efc7","manifestSha256":"1f6e1ccb925a678eaa393f9091dfc7d0285e4e3626e0a5c61a5474687debabb7"}

‎ui/e2e/dashboard-metric-tile-height.spec.ts‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,11 @@ const metric = (id, title, layout, extra) => ({
139139
id, type: 'metric', title, dataset: 'opportunity_metrics', values: ['total_amount'], layout, ...extra,
140140
});
141141
const BARE = (layout) => metric('bare', 'Total Pipeline', layout);
142-
const DELTA = (layout) => metric('delta', 'Pipeline vs prior', layout, { compareTo: { kind: 'previousPeriod' } });
142+
// A comparison is asked only over a dated window, so the delta tile states one.
143+
const DELTA = (layout) => metric('delta', 'Pipeline vs prior', layout, {
144+
filter: { close_date: { $gte: '2026-04-01', $lte: '2026-06-30' } },
145+
compareTo: { kind: 'previousPeriod' },
146+
});
143147
144148
// Each case is its own dashboard (see the header). 12 columns, a quarter-width tile.
145149
const CASES = [

‎ui/packages/plugin-dashboard/SKILL.md‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -162,10 +162,14 @@ running over a window nobody asked for.
162162

163163
### When NOT to use `compareTo`
164164

165-
- Filters with no bounded date range — there is no window to shift, and the
166-
widget reports that instead of rendering a comparison. Date the widget (a
165+
- Filters whose date condition is not a closed `$gte`/`$lte` window — a
166+
one-bound YTD `{ $gte: '{current_year_start}' }`, an exclusive `$lt` bound,
167+
a single day. There is no window to shift, and the widget reports that
168+
instead of rendering a comparison. Date the widget with a closed pair (a
167169
date-macro `$gte`/`$lte` pair, or a dashboard date-range filter bound to it)
168-
or omit `compareTo` entirely.
170+
or omit `compareTo` entirely. A filter that dates **nothing** on the compared
171+
field — the reader picked All time on the dashboard date filter — is not an
172+
error: the widget asks for no comparison and shows its number with no badge.
169173
- Pie / donut / funnel charts — comparison overlays are not visually
170174
meaningful and are silently ignored.
171175
- Scatter charts, and the `bubble` widget type that renders as one — a scatter

‎ui/packages/plugin-dashboard/src/DatasetWidget.tsx‎

Lines changed: 58 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,9 @@ function boundedDateWindow(value: unknown): [string, string] | null {
323323
* lowered under the name the author wrote. Zero of them, or two, is the
324324
* executor's error to raise — it names the candidates (`resolveCompareDimension`).
325325
* Guessing one renderer-side would trade a loud error for a quietly wrong
326-
* window, which is the failure class objectstack#5011 set out to end.
326+
* window, which is the failure class objectstack#5011 set out to end. The one
327+
* zero-window filter that never reaches the executor is a filter that dates
328+
* nothing at all — see `filterDatesField`, which the widget asks first.
327329
*/
328330
export function extractDateWindows(filter: unknown): {
329331
windows: DatasetTimeWindow[];
@@ -390,6 +392,46 @@ export function extractDateWindows(filter: unknown): {
390392
};
391393
}
392394

395+
/**
396+
* Does a RESOLVED runtime filter state any date condition on `dimension` — or,
397+
* with no dimension named, on any field at all? (objectstack#25970)
398+
*
399+
* A comparison needs a window, and a filter can lack one for two different
400+
* reasons. The AUTHOR wrote a date condition that is not a closed window (a
401+
* one-bound YTD `{ $gte }`, an exclusive bound, a single day): that is a
402+
* metadata mistake, and it stays the executor's loud refusal — the executor
403+
* and the spec define a comparison only against a two-bound window. Or the
404+
* filter dates nothing at all, which is what a READER produces by picking All
405+
* time on the dashboard's date-range filter: `DashboardRenderer` then merges no
406+
* condition for it, and the author cannot prevent the choice. With no window
407+
* there is no earlier period to compare against, so that widget asks for no
408+
* comparison and shows its number, instead of a normal filter choice breaking
409+
* the tile.
410+
*
411+
* "A date condition" is any ISO-date operand under the field, at any depth and
412+
* in any position (`$or` / `$not` included) — deliberately wider than the
413+
* windows `extractDateWindows` lowers, so every author-written date shape still
414+
* reaches the executor and is told why it cannot be compared.
415+
*/
416+
export function filterDatesField(filter: unknown, dimension?: string): boolean {
417+
const datesValue = (value: unknown): boolean => {
418+
if (typeof value === 'string') return ISO_DATE_RE.test(value);
419+
if (Array.isArray(value)) return value.some(datesValue);
420+
if (value && typeof value === 'object') return Object.values(value as object).some(datesValue);
421+
return false;
422+
};
423+
const walk = (node: unknown): boolean => {
424+
if (Array.isArray(node)) return node.some(walk);
425+
if (!node || typeof node !== 'object') return false;
426+
return Object.entries(node as Record<string, unknown>).some(([key, value]) =>
427+
key.startsWith('$')
428+
? walk(value)
429+
: (dimension == null || key === dimension) && datesValue(value),
430+
);
431+
};
432+
return walk(filter);
433+
}
434+
393435
/** Single-value KPI widget types — rendered as a number, not a chart. */
394436
const METRIC_TYPES = new Set(['metric', 'kpi', 'gauge', 'solid-gauge', 'bullet']);
395437

@@ -694,7 +736,11 @@ export function DatasetWidget({ widget, dataSource, heading }: { widget: any; da
694736
// overlay the renderer then dropped. Gated on the CHART branch, not on the
695737
// widget type: a pie widget with no dimensions renders as a metric tile
696738
// (`isMetric`), which does show the comparison as a delta, so it keeps it.
697-
const compareTo: CompareToConfig | undefined =
739+
//
740+
// This is the comparison the widget DECLARES for what it renders. Whether it
741+
// is asked for also depends on the resolved filter (a reader's All time dates
742+
// nothing), so the query and the overlay read `compareTo`, settled below.
743+
const declaredCompareTo: CompareToConfig | undefined =
698744
!isMetric && !isTable && chartTypeIgnoresCompareTo(chartType) ? undefined : widget?.compareTo;
699745
// pivot with ≥2 dims → a true cross-tab: last dim spreads across as columns,
700746
// the rest go down as rows. Computed up-front so the fetch can also request
@@ -805,6 +851,16 @@ export function DatasetWidget({ widget, dataSource, heading }: { widget: any; da
805851
// widget's query byte-identical keeps this change to the path it is about.
806852
// See `extractDateWindows` for why the windows are MOVED and why the choice
807853
// of dimension is left to the executor.
854+
//
855+
// A filter that dates nothing on the compared field — the dashboard's date
856+
// filter set to All time, with no date in the widget's own filter — asks for
857+
// no comparison at all: no `compareTo`, no window lowered, the same query and
858+
// tile as a widget without `compareTo` (objectstack#25970). Any date
859+
// condition the author wrote, a one-bound `{ $gte }` included, still goes to
860+
// the executor, whose refusal names the fix (`filterDatesField`).
861+
const compareTo = declaredCompareTo && filterDatesField(runtimeFilter, declaredCompareTo.dimension)
862+
? declaredCompareTo
863+
: undefined;
808864
const { windows: compareWindows, rest: selectionFilter } = useMemo(
809865
() => (compareTo
810866
? extractDateWindows(runtimeFilter)
Lines changed: 96 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,96 @@
1+
// Copyright (c) 2026 ObjectStack. Licensed under the Apache-2.0 license.
2+
3+
/**
4+
* objectstack#25970 — a `compareTo` KPI tile on a dashboard whose reader picks
5+
* All time in the date filter shows its number, with no comparison badge and
6+
* no error.
7+
*
8+
* All time is a supported filter choice the author cannot prevent: the filter
9+
* bar stores no value, `DashboardRenderer` merges no condition, and the
10+
* widget's resolved filter dates nothing. The tile used to send `compareTo`
11+
* anyway and render the executor's "compareTo needs a dated window to shift"
12+
* refusal in place of its number. A window the AUTHOR wrote as one bound (YTD)
13+
* keeps that refusal: the executor and the spec define a comparison only
14+
* against a two-bound window.
15+
*
16+
* Drives the real Radix select with user-event; the data source answers the
17+
* way the executor does (`resolveCompareDimension`).
18+
*/
19+
20+
import { afterEach, describe, expect, it, vi } from 'vitest';
21+
import { cleanup, render, screen, waitFor, within } from '@testing-library/react';
22+
import userEvent from '@testing-library/user-event';
23+
import type { DashboardComponentSchema } from '@object-ui/types';
24+
import { DashboardRenderer } from '../DashboardRenderer';
25+
26+
afterEach(cleanup);
27+
28+
const REFUSAL =
29+
'Dataset query failed: 400 Bad Request — [dataset-executor] compareTo needs a dated window to shift';
30+
31+
const makeQueryDataset = () =>
32+
vi.fn(async (_dataset: string, selection: any) => {
33+
const shiftable = (selection.timeDimensions ?? []).some((t: any) => t.dateRange);
34+
if (selection.compareTo && !shiftable) throw new Error(REFUSAL);
35+
return {
36+
rows: [selection.compareTo ? { revenue: 120, revenue__compare: 100 } : { revenue: 120 }],
37+
fields: [],
38+
};
39+
});
40+
41+
/** The selection of the LAST `queryDataset` call for a given dataset. */
42+
const lastSelection = (queryDataset: ReturnType<typeof makeQueryDataset>, dataset: string): any => {
43+
const calls = queryDataset.mock.calls.filter((c) => c[0] === dataset);
44+
return calls.length ? calls[calls.length - 1][1] : undefined;
45+
};
46+
47+
const schema: DashboardComponentSchema = {
48+
type: 'dashboard',
49+
dateRange: { field: 'close_date', defaultRange: 'this_quarter' },
50+
widgets: [
51+
// Dated by the dashboard filter alone — the "Selected Period" tile.
52+
{
53+
id: 'selected', type: 'metric', title: 'Selected period', dataset: 'sales', values: ['revenue'],
54+
compareTo: { kind: 'previousPeriod' },
55+
},
56+
// Dated by its own one-bound window, opted out of the dashboard filter — the YTD tile.
57+
{
58+
id: 'ytd', type: 'metric', title: 'Year to date', dataset: 'sales_ytd', values: ['revenue'],
59+
filter: { close_date: { $gte: '{current_year_start}' } },
60+
filterBindings: { dateRange: false },
61+
compareTo: { kind: 'previousPeriod' },
62+
},
63+
],
64+
};
65+
66+
describe('DashboardRenderer — a compareTo tile under All time (#25970)', () => {
67+
it('compares under the default range, then shows the bare number under All time', async () => {
68+
const user = userEvent.setup();
69+
const queryDataset = makeQueryDataset();
70+
render(<DashboardRenderer schema={schema} dataSource={{ queryDataset }} />);
71+
72+
// Control: the default range is a closed window, so the comparison runs.
73+
await waitFor(() => expect(screen.getAllByTestId('dataset-compare-trend')).toHaveLength(1));
74+
expect(lastSelection(queryDataset, 'sales').compareTo).toEqual({ kind: 'previousPeriod' });
75+
expect(lastSelection(queryDataset, 'sales').timeDimensions).toEqual([
76+
{ dimension: 'close_date', dateRange: [expect.any(String), expect.any(String)] },
77+
]);
78+
79+
await user.click(within(screen.getByTestId('dashboard-filter-dateRange')).getByRole('combobox'));
80+
await user.click(await screen.findByRole('option', { name: 'All time' }));
81+
82+
await waitFor(() => expect(lastSelection(queryDataset, 'sales')).toEqual({ dimensions: [], measures: ['revenue'] }));
83+
// The YTD tile never shows a number (see below), so this one is the selected-period tile.
84+
expect(await screen.findByText('120')).toBeInTheDocument();
85+
expect(screen.queryByTestId('dataset-compare-trend')).not.toBeInTheDocument();
86+
// The one refusal left on the page is the YTD tile's.
87+
expect(screen.getAllByRole('alert')).toHaveLength(1);
88+
});
89+
90+
it('keeps the refusal for an author-written one-bound window', async () => {
91+
const queryDataset = makeQueryDataset();
92+
render(<DashboardRenderer schema={schema} dataSource={{ queryDataset }} />);
93+
expect(await screen.findByRole('alert')).toHaveTextContent(/dated window to shift/);
94+
expect(lastSelection(queryDataset, 'sales_ytd').compareTo).toEqual({ kind: 'previousPeriod' });
95+
});
96+
});

‎ui/packages/plugin-dashboard/src/__tests__/DatasetWidget.colorVariant.test.tsx‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,12 +152,14 @@ describe('DatasetWidget metric card — the declared colorVariant (#3359)', () =
152152

153153
it('keeps the comparison trend row untouched by the accent', async () => {
154154
const rows = [{ revenue: 510000, revenue__compare: 400000 }];
155-
const plain = await renderMetric({ compareTo: { kind: 'previousPeriod' } }, rows);
155+
// A comparison is asked only over a dated window (objectstack#25970).
156+
const filter = { close_date: { $gte: '2026-04-01', $lte: '2026-06-30' } };
157+
const plain = await renderMetric({ filter, compareTo: { kind: 'previousPeriod' } }, rows);
156158
const plainHtml = plain.innerHTML;
157159
cleanup();
158160
// The delta row renders (that is what makes this case worth pinning) …
159161
expect(plainHtml).toContain('data-testid="dataset-compare-trend"');
160-
const tinted = await renderMetric({ compareTo: { kind: 'previousPeriod' }, colorVariant: 'danger' }, rows);
162+
const tinted = await renderMetric({ filter, compareTo: { kind: 'previousPeriod' }, colorVariant: 'danger' }, rows);
161163
// … and the tinted render differs from it in exactly one place: the value's
162164
// class attribute. The trend's own up/down colouring is data-driven and must
163165
// not inherit the widget's accent.

‎ui/packages/plugin-dashboard/src/__tests__/DatasetWidget.comboPresentation.test.tsx‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,12 @@ describe('DatasetWidget — a comparison overlay carries no merged mark (objectu
213213
fields,
214214
})),
215215
};
216-
await renderWidget(comboWidget({ compareTo: { kind: 'previousYear' }, chartConfig: retiredComboChartConfig }), src);
216+
await renderWidget(comboWidget({
217+
// A comparison is asked only over a dated window (objectstack#25970).
218+
filter: { due_date: { $gte: '2026-01-01', $lte: '2026-12-31' } },
219+
compareTo: { kind: 'previousYear' },
220+
chartConfig: retiredComboChartConfig,
221+
}), src);
217222

218223
const series = lastChartSchema.series;
219224
expect(series.map((s: any) => [s.dataKey, s.variant])).toEqual([

‎ui/packages/plugin-dashboard/src/__tests__/DatasetWidget.compareTo.ignoredFamilies-7495.test.tsx‎

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,13 @@ describe('DatasetWidget — no dated window: an ignoring family draws its chart
168168
* The dataset executor refuses a `compareTo` it has no dated window to shift
169169
* (a dataset-invalid error). A widget that forwarded `compareTo` showed that
170170
* refusal in place of its chart; one that forwards nothing is never refused.
171+
*
172+
* The filter dates its field with ONE bound, so it is a date condition that is
173+
* no closed window: a filter that dates nothing at all is asked no comparison
174+
* by every family (objectstack#25970), which would leave the control below
175+
* nothing to refuse.
171176
*/
177+
const ONE_BOUND = { owner: 'u1', close_date: { $gte: '2026-01-01' } };
172178
const refusingSource = () => ({
173179
queryDataset: vi.fn(async (_dataset: string, selection: any) => {
174180
if (selection?.compareTo && !selection?.timeDimensions?.length) {
@@ -181,10 +187,10 @@ describe('DatasetWidget — no dated window: an ignoring family draws its chart
181187
}),
182188
});
183189

184-
it('a pie with compareTo and an undated filter renders the pie', async () => {
190+
it('a pie with compareTo and no closed window renders the pie', async () => {
185191
const src = refusingSource();
186192
const { queryByRole } = renderWidget(
187-
{ type: 'pie', dataset: 'sales', dimensions: ['stage'], values: ['revenue'], filter: { owner: 'u1' }, compareTo: { kind: 'previousYear' } },
193+
{ type: 'pie', dataset: 'sales', dimensions: ['stage'], values: ['revenue'], filter: ONE_BOUND, compareTo: { kind: 'previousYear' } },
188194
src,
189195
);
190196

@@ -196,7 +202,7 @@ describe('DatasetWidget — no dated window: an ignoring family draws its chart
196202
it('CONTROL: a bar with the same compareTo and filter still asks, and shows the refusal', async () => {
197203
const src = refusingSource();
198204
const { findByRole } = renderWidget(
199-
{ type: 'bar', dataset: 'sales', dimensions: ['stage'], values: ['revenue'], filter: { owner: 'u1' }, compareTo: { kind: 'previousYear' } },
205+
{ type: 'bar', dataset: 'sales', dimensions: ['stage'], values: ['revenue'], filter: ONE_BOUND, compareTo: { kind: 'previousYear' } },
200206
src,
201207
);
202208

0 commit comments

Comments
 (0)