Skip to content

Commit 43ae284

Browse files
docs(skills): drop the removed feature_flags settings manifest from plugin-development (#30726)
<!-- claude-projects-attribution: {"github_login":"os-elon-musk"} --> _Requested by **Elon** · [project thread](https://claude.ai/code/project/chan_01WedDzV26nniwxv7jC88B9D?thread=cmsg_01WedDzV26nniwxv7jC88B9DGkdjxdHsKhS4HATauzmjF1)_ Fixes #30275 Clause-②: no Metadata-protocol: none ## 维护者速读 - **改了什么**:`objectstack-platform` 技能包的插件开发参考页里,删掉「`feature_flags` 设置清单(`ai_enabled` / `beta_*`、`OS_FEATURE_FLAGS_*`)」这条,改成现行答案:插件需要组织级开关时,自己声明一份设置清单并注册到 `settings` 服务。 - **为什么改**:该命名空间已从设置服务移除,读它会被拒、那些环境变量不起作用;客户的 AI 照旧文档写代码或指导管理员会做无用功。 - **风险与回滚**:只改一条文档与一个 changeset,运行时零改动;回滚即 revert 本 PR。 - **先看**:① `skills/objectstack-platform/references/plugin-development.md` 的「Feature Flags」节第一条;② `.changeset/30275-plugin-dev-feature-flags-bullet.md`。 - **两分钟验证**:`node scripts/check-skills-token-ratchet.mjs | grep plugin-development`,预期 3125 tokens(上限 3137),且 `git grep -n feature_flags -- skills/` 无输出。 - **需要你做的**:批准合并(`skills/**` 属 Tier H,需人合)。 ## What changes - `skills/objectstack-platform/references/plugin-development.md`, section "Feature Flags": the bullet teaching a `feature_flags` settings manifest (`ai_enabled` / `beta_*` toggles, env overrides via `OS_FEATURE_FLAGS_*`) is replaced by the live answer: there is no shared flags namespace; a plugin that needs an org toggle declares its own `SettingsManifest` and registers it on the `settings` service (ADR-0007 cascade). The next bullet (`PUBLIC_AUTH_FEATURES`, the deployment-level capability flags) is unchanged. - `.changeset/30275-plugin-dev-feature-flags-bullet.md`: `'@objectstack/skills': patch`, with both declaration lines. ## Why PR #30272 (#30204) removed the `feature_flags` namespace from `@objectstack/service-settings`. On `origin/main` `badf24df`, `builtinSettingsManifests` no longer lists it, and `settings-service.test.ts` pins `getManifest('feature_flags')` to `SETTINGS_UNKNOWN_NAMESPACE` with `OS_FEATURE_FLAGS_AI_ENABLED` set and inert. A customer agent reading the old bullet would write checks against a namespace that is refused, or tell an administrator to set an env var that does nothing. The replacement is read off `main` code: `SettingsManifest` is re-exported from `@objectstack/service-settings` "so plugin authors only need one import" (`src/index.ts`), `SettingsServicePlugin` registers its service under `'settings'` (`settings-service-plugin.ts`), and `SettingsService.registerManifest(manifest)` is a public method (`settings-service.ts`). ## Tests Docs-only change in the published skills bundle; no code or test changed. Size readings (`node scripts/check-skills-token-ratchet.mjs`, both on this tree): - `references/plugin-development.md`: 359 → 358 lines, 3137 → 3125 tokens (ceiling 3137, unchanged). - Package `objectstack-platform`, all SKILL.md: unchanged (no SKILL.md touched). - Whole shipped bundle: 226234 → 226222 tokens. ## Acceptance notes - Acceptance 2: `git grep -n -i 'feature_flags\|OS_FEATURE_FLAGS'` over `skills/**` on `origin/main` `badf24df` hits only the three lines of this bullet. No eval of any package prompts for them, so no eval is edited (and `evals/config-plugins-ops.json`, held by PR #30704, is untouched). - Acceptance 3: PR #30272 is merged; this text matches `main`. ## Verification Local gates on head `997decb3` (after merging `origin/main`): the 43 families `node scripts/pm/dispatch-gates.mjs --commands` derives from this diff, plus `pnpm lint` (exit 0). `--ran` reconciliation: 43 derived, 41 run green, 2 NOT MEASURED, 0 unrun. NOT MEASURED (declared narrowing): `check:dual-build-cjs-loads` and `check:lean-entry-closure` exit 3 (prerequisite: built `dist/` for every package). They judge build output, which a Markdown edit and a changeset cannot move; no whole-tree build was run for an S docs card, and CI runs them on a built tree. <details> <summary>Gate exit codes (head 997decb)</summary> ``` node scripts/check-adr-0087-registration.mjs --base origin/main :: exit 0 node scripts/check-adr-0087-registration.mjs --self-test :: exit 0 node scripts/check-changeset-no-major.mjs --base origin/main :: exit 0 node scripts/check-closing-keyword-parity.mjs :: exit 0 node scripts/check-closing-keyword-parity.mjs --self-test :: exit 0 node scripts/check-comment-mask-corpus.mjs :: exit 0 node scripts/check-doc-route-spelling.mjs --advisory :: exit 0 node scripts/check-doc-route-spelling.mjs --self-test :: exit 0 node scripts/check-dts-emitted.mjs --self-test :: exit 0 node scripts/check-empty-changeset.mjs --base origin/main :: exit 0 node scripts/check-empty-changeset.mjs --self-test :: exit 0 node scripts/check-skills-token-ratchet.mjs :: exit 0 node scripts/check-skills-token-ratchet.mjs --self-test :: exit 0 node scripts/ci/assert-turbo-remote-cache.mjs --self-test :: exit 0 node scripts/ci/plan-test-core-shards.mjs --self-test :: exit 0 node scripts/ci/prune-turbo-cache.mjs --self-test :: exit 0 node scripts/pm/release-rehearsal-clone.mjs --self-test :: exit 0 node scripts/release-pending-publish.mjs --self-test :: exit 0 pnpm --filter @objectstack/lint run check:doc-formula-expressions :: exit 0 pnpm --filter @objectstack/spec run check:skill-refs :: exit 0 pnpm check:agent-test-spelling :: exit 0 pnpm check:changeset-gate-self-tests :: exit 0 pnpm check:ci-filter-parity :: exit 0 pnpm check:closed-ceremony-text :: exit 0 pnpm check:corpus-claim-drift :: exit 0 pnpm check:cross-package-test-inputs :: exit 0 pnpm check:doc-authoring :: exit 0 pnpm check:driver-memory-census :: exit 0 pnpm check:dts-closure :: exit 0 pnpm check:dual-build-cjs-loads :: exit 3 pnpm check:gitlink-declared :: exit 0 pnpm check:lean-entry-closure :: exit 3 pnpm check:nul-bytes :: exit 0 pnpm check:pm-governed-merges :: exit 0 pnpm check:pm-skill-id-lint :: exit 0 pnpm check:published-files :: exit 0 pnpm check:refd-timer-probe :: exit 0 pnpm check:role-word :: exit 0 pnpm check:skill-compatibility :: exit 0 pnpm check:skill-frame-sync :: exit 0 pnpm check:skill-identifier-liveness :: exit 0 pnpm check:sourcemap-no-sources-content :: exit 0 pnpm check:watch-hint-literal :: exit 0 pnpm lint :: exit 0 ``` </details> <details> <summary>Token ratchet (head 997decb)</summary> ``` check-skills-token-ratchet: skills/objectstack-platform/references/plugin-development.md is 3125 tokens (ceiling 3137; headroom 12). check-skills-token-ratchet: 57 authored bundle file(s) within their ceilings; 10 generator-owned file(s) and 29 eval fixture(s) measured, not ratcheted. ``` </details> --- _Generated by [Claude Code](https://claude.ai/code/session_016WV4d1cT65NsbTucMW55wZ)_ Co-authored-by: Claude <noreply@anthropic.com>
1 parent 2d04cd2 commit 43ae284

2 files changed

Lines changed: 12 additions & 3 deletions

File tree

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
---
2+
'@objectstack/skills': patch
3+
---
4+
5+
docs(skills): `objectstack-platform`'s plugin-development reference no longer teaches the removed `feature_flags` settings namespace
6+
7+
Clause-②: no
8+
Metadata-protocol: none
9+
10+
The "Feature Flags" section listed a `feature_flags` settings manifest with `ai_enabled` / `beta_*` toggles and `OS_FEATURE_FLAGS_*` env overrides. That namespace was removed from `@objectstack/service-settings` (reading it is refused with `SETTINGS_UNKNOWN_NAMESPACE`, and the env vars do nothing). The bullet now gives the live answer: a plugin that needs an org toggle declares its own `SettingsManifest` and registers it on the `settings` service.

‎skills/objectstack-platform/references/plugin-development.md‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -351,9 +351,8 @@ descriptor) was itself dead: no endpoint ever served it. Runtime capability disc
351351

352352
The live toggle surfaces are runtime configuration, not authored metadata:
353353

354-
- **`feature_flags` settings manifest** (`@objectstack/service-settings`) — org-tunable
355-
toggles like `ai_enabled` / `beta_*`, resolvable at runtime and env-overridable via
356-
`OS_FEATURE_FLAGS_*` (ADR-0007 settings cascade).
354+
- **Org toggles** — no shared flags namespace exists; a plugin that needs one declares
355+
its own `SettingsManifest` and registers it on the `settings` service (ADR-0007 cascade).
357356
- **Auth capability gates** — `requiresFeature` on actions/params lowers to the
358357
`PUBLIC_AUTH_FEATURES` registry (`kernel/public-auth-features.ts`), the fixed
359358
deployment-level flags plugin-auth advertises to anonymous clients.

0 commit comments

Comments
 (0)