You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 469499e
Browse filesBrowse the repository at this point in the historyBrowse files
test(ui): re-point the cbp master oracle legs to the optional master
Under ADR-0055 §1 as amended (ruling A), the spec reads an object's only
master_detail that is not required as an optional master: a cbp object
whose lone master_detail omits `required` now parses, as required: false.
Five app-shell tests used that shape as a refused control.
- Four control legs (object-fields-io, ObjectFieldInspector,
ObjectSettingsPanel, PackageOwdOverviewPanel save): the shape parses
with required: false before Studio writes required: true, and with
required: true after.
- Two display-agreement rows (owd-sharing deriveMasterObject,
PackageOwdOverviewPanel shapes): the omitted row records that the parse
admits it while the reader names no master, as the runtime does for an
unparsed object.
Test-only; Studio source unchanged.
Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016WV4cxZsyeZedvM4Ea8Ahs
Copy file name to clipboardExpand all lines: ui/packages/app-shell/src/views/metadata-admin/inspectors/ObjectFieldInspector.cbpRequiredMaster-12326.test.tsx
+14-4Lines changed: 14 additions & 4 deletions
Original file line number
Diff line number
Diff line change
@@ -7,8 +7,12 @@
7
7
*
8
8
* Since `@objectstack/spec` 18 (objectstack#23100, ADR-0055 §1) such an object
9
9
* derives its master from exactly one `master_detail` declared
10
-
* `required: true`; the save door refuses any other value. The installed
11
-
* spec's `ObjectSchema` is the oracle for the object each edit leaves behind.
10
+
* `required: true`. Since ADR-0055 §1 as amended (objectstack#30905 ruling A)
11
+
* the spec also reads an object's only `master_detail` that is not required as
12
+
* an OPTIONAL master, whose rows may name none; the designer keeps writing
13
+
* `required: true`, so the master it shows is one every row names. The
14
+
* installed spec's `ObjectSchema` is the oracle for the object each edit
15
+
* leaves behind.
12
16
*/
13
17
14
18
import'@testing-library/jest-dom/vitest';
@@ -104,13 +108,19 @@ describe('ObjectFieldInspector — a controlled_by_parent master is required, lo
0 commit comments