Skip to content

Commit 4bfbd05

Browse files
committed
test(plugin-approvals): the opening cross-check is soft, so every case reaches its notified assertion
Claude-Session: https://claude.ai/code/session_011TdZ8GjixNZFLz1xJD9zzK Co-authored-by: Claude <noreply@anthropic.com>
1 parent 5938ec9 commit 4bfbd05

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

‎packages/plugins/plugin-approvals/src/remind-notified-per-person.integration.test.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,8 @@ describe('a reminder counts the reminders it hands over, one per distinct approv
165165
const reminders = audiencesOf('approval.reminder', req.id);
166166
const opened = audiencesOf('approval.requested', req.id);
167167
expect(opened.length, `${flow}: the opening told someone`).toBeGreaterThan(0);
168-
expect(reminders, `${flow}: the reminder reached whom the opening reached`).toEqual(opened);
168+
// Soft, so a broken fan-out still reaches the case's own `notified` assertion.
169+
expect.soft(reminders, `${flow}: the reminder reached whom the opening reached`).toEqual(opened);
169170
return { req, stored, notified: out.notified, reminders };
170171
};
171172

0 commit comments

Comments
 (0)