Skip to content

Commit 4d56914

Browse files
docs(qa): drop the retired currency prompt from the studio-authoring app step (#30929)
<!-- claude-projects-attribution: {"github_login":"os-elon-musk"} --> _Requested by **Elon** · [project thread](https://claude.ai/code/project/chan_01WedDzV26nniwxv7jC88B9D?thread=cmsg_01WedDzV26nniwxv7jC88B9DS2Sz1Hknq77i9cR8qyBuN5)_ domain:devx#1 · os-elon-musk · session_016WV4cxgByzkYcBriVXdDBA Fixes #30876 Clause-②: no Metadata-protocol: none ## 维护者速读 - **改了什么**:`studio-authoring.json` 里 `studio-authoring.app-and-nav-properties` 的 steps[1] 删掉「先关掉 'Set the default currency' 弹窗」的括注,改为指向 RUNNER.md 现行说法(首登清单是 Home 上的非模态卡片,不遮挡应用);条目 revision 7→8 并追加 history。 - **为什么改**:PR #30868 (#30206) 已撤掉该弹窗,QA 跑者照旧等弹窗会白等或误报缺陷。 - **风险与回滚**:纯文档,一个文件 +8/-2;回滚即 revert。 - **需要你做的**:无,席位落地。 ## What changes One file, `docs/qa/platform-checklist/areas/studio-authoring.json`, item `studio-authoring.app-and-nav-properties`: - `steps[1]`: the parenthetical "a fresh organization first shows the 'Set the default currency' prompt over the page; dismiss it with 'Not now', RUNNER environment facts" becomes "no dialog opens over it: a fresh organization's first-run checklist is a non-modal card on Home only, RUNNER environment facts", matching the RUNNER.md environment fact PR #30868 wrote. - `revision` 7 → 8, with a `history` row (ref #30876). The revision-7 history row that introduced the prompt note is append-only and stays as written. ## Why PR #30868 (#30206) retired the boot-time currency / time zone dialog and updated RUNNER.md, but this one area step still told runners to wait for and dismiss it. A runner waits for a dialog that never comes, or files its absence as a false finding. Grep of `docs/qa/` (outside `runs/`, which are historical run records) for `default currency`, `Not now` and `currency prompt`: the only other hit is the revision-7 history row above. ## Verification - `node scripts/check-platform-checklist.mjs` (the checklist's own validator): exit 0 (16 areas, 360 items). - `node scripts/check-platform-checklist.mjs --changed-from origin/main`: exit 0 (no anchored files in the change set). - `node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack`: 16 families derived, all run, all exit 0; `--ran` reconciliation: 16 derived, 16 run, 0 NOT-MEASURED. Gates ran on 8f337c17; the pushed head 0a76f9c has the same tree (commit message reworded only, to drop the card trailer). <details><summary>Gates ran</summary> ``` node scripts/check-adr-links.mjs :: exit 0 node scripts/check-adr-links.mjs --self-test :: exit 0 node scripts/check-closing-keyword-parity.mjs :: exit 0 node scripts/check-closing-keyword-parity.mjs --self-test :: exit 0 node scripts/check-comment-mask-corpus.mjs :: exit 0 node scripts/ci/plan-test-core-shards.mjs --self-test :: exit 0 pnpm --filter @objectstack/lint run check:doc-formula-expressions :: exit 0 pnpm check:ci-filter-parity :: exit 0 pnpm check:cross-package-test-inputs :: exit 0 pnpm check:doc-authoring :: exit 0 pnpm check:driver-memory-census :: exit 0 pnpm check:gitlink-declared :: exit 0 pnpm check:nul-bytes :: exit 0 pnpm check:platform-checklist :: exit 0 pnpm check:refd-timer-probe :: exit 0 pnpm check:watch-hint-literal :: exit 0 ``` </details> ## Human Minimum - [x] 1. Schemas start as Zod; `packages/spec` holds no runtime logic. (not touched) - [x] 2. Every name I added uses the casing for its kind. (no names added) - [x] 3. No formatter ran. (`pnpm lint` not run locally for a one-file JSON docs edit; CI runs it) - [x] 4. One issue, one branch off an up-to-date `main`, one pull request. - [x] 5. A change that publishes carries a changeset, and both declaration lines are filled in here and in the changeset. (docs only: skip-changeset) - [x] 6. `packages/spec` touched: its generated artifacts are regenerated and committed. (not touched) - [x] 7. No hand edits to `content/docs/references/`, `packages/*/CHANGELOG.md` or `content/docs/releases/`. - [x] 8. Title, body and comments are in English. - [x] The *Before Submitting* list in CONTRIBUTING.md is done. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_016WV4cxgByzkYcBriVXdDBA Co-authored-by: Claude <noreply@anthropic.com>
1 parent d3e58c1 commit 4d56914

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

‎docs/qa/platform-checklist/areas/studio-authoring.json‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3664,7 +3664,7 @@
36643664
"title": "App and menu-entry keys reach the running app: branding, areas and context selectors render; an entry's viewName, recordId / recordMode, filters, badge, requiresObject and visible each change what the entry does or who sees it; hidden takes an app off the switcher and nothing else — and Studio's menu-entry inspector edits them",
36653665
"since": "v18",
36663666
"status": "active",
3667-
"revision": 7,
3667+
"revision": 8,
36683668
"priority": "P2",
36693669
"surface": "mixed",
36703670
"personas": [
@@ -3684,7 +3684,7 @@
36843684
},
36853685
"steps": [
36863686
"write the app through PUT /api/v1/meta/app/APP?mode=draft&package=PKG: branding { primaryColor, accentColor, logo } (a runner-environment note: give logo a same-origin URL such as /_console/vite.svg, which the console build ships from ui/apps/console/public; an external logo URL is blocked by the runner container's egress proxy and never renders), two areas each holding some entries, a contextSelector, and menu entries: an object entry with viewName (the second list view), one with recordId + recordMode 'edit', one with filters, one with badge + badgeVariant, one with requiresObject naming an object that does not exist, and one with a visible predicate false for the member (e.g. 'org_owner' in current_user.positions: the seeded admin holds org_owner, not org_admin, because an organization's owner membership maps to org_owner alone, packages/spec/src/identity/eval-user.zod.ts, so an 'org_admin' predicate is false for both personas and proves nothing). Make this app the package's FIRST app (steps[4]); publish",
3687-
"as admin and as the member (each in its own context, identity proved with GET /api/v1/auth/get-session), open the app (a fresh organization first shows the 'Set the default currency' prompt over the page; dismiss it with 'Not now', RUNNER environment facts) and read the chrome colours and logo, the areas switcher, the context selector, and click each entry",
3687+
"as admin and as the member (each in its own context, identity proved with GET /api/v1/auth/get-session), open the app (no dialog opens over it: a fresh organization's first-run checklist is a non-modal card on Home only, RUNNER environment facts) and read the chrome colours and logo, the areas switcher, the context selector, and click each entry",
36883688
"GET /api/v1/meta/app?id=APP as each persona and list the entries each receives",
36893689
"set hidden: true on a second app of the package (through the API) and publish; as the member read the App Switcher, the Home launcher, the avatar menu and GET /api/v1/meta/app?id=SECOND; open its URL directly",
36903690
"open the app in /_console/studio/PKG/interfaces, select each entry and read its inspector. Studio's Interfaces pillar opens only the package's FIRST app (the first app the package lists, else its first app draft) and draws only that app's top-level `navigation`: an entry that lives only inside `areas` has no rail row (ui/packages/app-shell/src/views/studio-design/StudioDesignSurface.tsx, the Interfaces pillar's app load). So the app steps[0] writes must be the package's first, and its top-level navigation must hold at least one entry carrying each key acceptance[5] names; the area entries' runtime effect is read in acceptance[0]–[3], not here"
@@ -3784,6 +3784,12 @@
37843784
"date": "2026-11-04",
37853785
"change": "steps[1] and acceptance[5].verify corrected from QA run #29893 (W5-STUDIO, at 589049b0): a fresh organization's first visit shows the default-currency prompt, and the Studio View picker writes the qualified OBJECT.KEY view name, not the bare key steps[0] writes. Read at base f68b47ca",
37863786
"ref": "#29906"
3787+
},
3788+
{
3789+
"revision": 8,
3790+
"date": "2026-11-06",
3791+
"change": "steps[1] no longer tells the runner to dismiss the 'Set the default currency' prompt: PR #30868 (#30206) retired that boot-time dialog for a non-modal first-run checklist card on Home, which does not cover the app (RUNNER environment facts). No clause changed. Read at base 0e882086",
3792+
"ref": "#30876"
37873793
}
37883794
]
37893795
},

0 commit comments

Comments
 (0)