test: type the new pins' engine options and drop the REST pin's console spies

Claude-Session: https://claude.ai/code/session_01ADHkmQQoWsHzMSsiaM89mr
Co-authored-by: Claude <noreply@anthropic.com>

Author: claude

packages/objectql/src/engine-cascade-summary-rollback.test.ts

@@ -142,7 +142,7 @@ const ids = (rows: Row[]) => rows.map((r) => r.id).sort();
 describe('a cascade dependent\'s ERR_SUMMARY_RECOMPUTE never answers for a parent delete that did not land', () => {
   it('atomic plan: the parent delete refuses with another error, and nothing stored changes', async () => {
     const { engine, driver } = await makeEngine(true);
-    const err: any = await engine.delete('acct', { where: { id: 'a1' } } as any).then(() => null, (e: unknown) => e);
+    const err: any = await engine.delete('acct', { where: { id: 'a1' } }).then(() => null, (e: unknown) => e);
     expect(err).toBeInstanceOf(Error);
     expect(err.code).toBeUndefined();
     expect(err.cause?.code).toBe('ERR_SUMMARY_RECOMPUTE');
@@ -154,7 +154,7 @@ describe('a cascade dependent\'s ERR_SUMMARY_RECOMPUTE never answers for a paren
 
   it('a runtime that cannot roll back: the parent is still stored, and the caller is refused', async () => {
     const { engine, driver } = await makeEngine(false);
-    const err: any = await engine.delete('acct', { where: { id: 'a1' } } as any).then(() => null, (e: unknown) => e);
+    const err: any = await engine.delete('acct', { where: { id: 'a1' } }).then(() => null, (e: unknown) => e);
     expect(err).toBeInstanceOf(Error);
     expect(err.code).toBeUndefined();
     expect(err.cause?.code).toBe('ERR_SUMMARY_RECOMPUTE');
@@ -165,7 +165,7 @@ describe('a cascade dependent\'s ERR_SUMMARY_RECOMPUTE never answers for a paren
 
   it('a predicate delete (multi) on a runtime that cannot roll back: refused the same way, the parent still stored', async () => {
     const { engine, driver } = await makeEngine(false);
-    const err: any = await engine.delete('acct', { where: { name: 'A' }, multi: true } as any).then(() => null, (e: unknown) => e);
+    const err: any = await engine.delete('acct', { where: { name: 'A' }, multi: true }).then(() => null, (e: unknown) => e);
     expect(err).toBeInstanceOf(Error);
     expect(err.code).toBeUndefined();
     expect(err.cause?.code).toBe('ERR_SUMMARY_RECOMPUTE');
@@ -175,7 +175,7 @@ describe('a cascade dependent\'s ERR_SUMMARY_RECOMPUTE never answers for a paren
   it('a caller\'s own transaction that the refusal rolls back: refused with another error, nothing stored', async () => {
     const { engine, driver } = await makeEngine(true);
     const err: any = await engine
-      .transaction(async (trx: any) => engine.delete('line', { where: { id: 'l1' }, context: trx } as any))
+      .transaction(async (trx: any) => engine.delete('line', { where: { id: 'l1' }, context: trx }))
       .then(() => null, (e: unknown) => e);
     expect(err).toBeInstanceOf(Error);
     expect(err.code).toBeUndefined();
@@ -199,7 +199,7 @@ describe('a cascade dependent\'s ERR_SUMMARY_RECOMPUTE never answers for a paren
 
   it('CONTROL the dependent\'s own delete landed: ERR_SUMMARY_RECOMPUTE, carrying its result', async () => {
     const { engine, driver } = await makeEngine(true);
-    const err: any = await engine.delete('line', { where: { id: 'l1' } } as any).then(() => null, (e: unknown) => e);
+    const err: any = await engine.delete('line', { where: { id: 'l1' } }).then(() => null, (e: unknown) => e);
     expect(err?.code).toBe('ERR_SUMMARY_RECOMPUTE');
     expect(err.written).toBe(true);
     expect(ids(driver.rowsOf('line'))).toEqual(['l2']);
@@ -209,7 +209,7 @@ describe('a cascade dependent\'s ERR_SUMMARY_RECOMPUTE never answers for a paren
     const { engine, driver } = await makeEngine(true);
     let caught: any;
     await engine.transaction(async (trx: any) => {
-      await engine.delete('line', { where: { id: 'l1' }, context: trx } as any).catch((e: unknown) => { caught = e; });
+      await engine.delete('line', { where: { id: 'l1' }, context: trx }).catch((e: unknown) => { caught = e; });
     });
     expect(caught?.code).toBe('ERR_SUMMARY_RECOMPUTE');
     expect(driver.rolledBack).toHaveLength(0);

packages/rest/src/data-delete-cascade-summary-rollback.test.ts

@@ -31,7 +31,7 @@
  * publish gate refused it would be.
  */
 
-import { describe, it, expect, beforeAll, afterAll, vi } from 'vitest';
+import { describe, it, expect, beforeAll, afterAll } from 'vitest';
 import { mkdtempSync, rmSync } from 'node:fs';
 import { tmpdir } from 'node:os';
 import { join } from 'node:path';
@@ -86,12 +86,8 @@ function makeRes() {
 const dir = mkdtempSync(join(tmpdir(), 'os-cascade-rollup-'));
 let engine: ObjectQL;
 let call: (method: string, path: string, req: Record<string, unknown>) => Promise<any>;
-let warn: ReturnType<typeof vi.spyOn>;
-let errorLog: ReturnType<typeof vi.spyOn>;
 
 beforeAll(async () => {
-  warn = vi.spyOn(console, 'warn').mockImplementation(() => {});
-  errorLog = vi.spyOn(console, 'error').mockImplementation(() => {});
   engine = new ObjectQL();
   engine.registerDriver(
     new SqlDriver({ client: 'better-sqlite3', connection: { filename: join(dir, 'cascade.sqlite') }, useNullAsDefault: true }) as any,
@@ -127,14 +123,12 @@ beforeAll(async () => {
 });
 
 afterAll(async () => {
-  warn.mockRestore();
-  errorLog.mockRestore();
   try { await engine.destroy(); } catch { /* noop */ }
   rmSync(dir, { recursive: true, force: true });
 });
 
 const rowIds = async (object: string) =>
-  ((await engine.find(object, { fields: ['id'] } as any)) as Array<{ id: string }>).map((r) => r.id).sort();
+  ((await engine.find(object, { fields: ['id'] })) as Array<{ id: string }>).map((r) => r.id).sort();
 
 describe('a DELETE whose cascade a dependent\'s failing roll-up stops answers a refusal', () => {
   it('DELETE of the account answers 500 INTERNAL_ERROR, and nothing is deleted', async () => {