Skip to content

Commit 5055b10

Browse files
fix(metadata-protocol): a dependent package's same-named row no longer replaces the base package's item on the read naming no package (#28304)
<!-- claude-projects-attribution: {"github_login":"os-project-manager"} --> _Requested by **Leehom** · [project thread](https://claude.ai/code/project/chan_01TenzsRopZj4jMbvjX8uz1X?thread=cmsg_01TenzsRopZj4jMbvjX8uz1X5bnPyhuoRnXAyyEN1Y3CwG)_ Part of #28238 Clause-②: no Metadata-protocol: none ## 维护者速读 - **改了什么:** 不指定包读取一个视图(以及分层读取的 effective)时,若某个代码包自带这个名字,就从该代码包取内容:它自己的存储行,否则无包覆盖行(Setup 写的那种,仍然优先于代码),否则代码原件。依赖包用同名存的那一行不再顶替基础包。 - **为什么改:** showcase 实测:依赖包 `com.default.acme-custom` 存了 2 列的 `showcase_task.default`,不指定包读取就答 2 列,还挂着基础包的 `_packageId`;Studio 按基础包读看到 7 列,用户看到 2 列。 - **风险与回滚:** 只改读取取内容的地址;不指定包的保存、删除和读取返回的 `version` 仍落在依赖包那一行(写地址不动,已钉住)。回滚即还原 `packagelessContentPackage` 的两个调用点。 - **先看:** `packages/metadata-protocol/src/protocol-environment-rows.ts` 的 `packagelessContentPackage`;`protocol.ts` 里 `readMetaItem` 的 `contentPackageId` 一段;新测试 `packages/objectql/src/protocol-packageless-read-dependent-package.test.ts`。 - **两分钟验证:** `pnpm --filter @objectstack/metadata-protocol build && pnpm --filter @objectstack/objectql exec vitest run src/protocol-packageless-read-dependent-package.test.ts`,应见 5 passed。 - **需要你做的:** 卡片还差一半没修:console 应用仍渲染 2 列,因为它读的是不带包的视图列表(每个包一条、同名取最后一条)。这一半要你在卡片的决策里拍板,本 PR 只修三个按名读取。 ## What changes The by-name read (`getMetaItem`) and the layered read (`getMetaItemLayered`) that name no package now take their stored content from `packagelessContentPackage` (new, `protocol-environment-rows.ts`). It adds the code packages that ship the name as candidates beside the stored rows' bindings: - No code package ships the name, or the one stored binding is a package that ships it: unchanged, the write address's package (#23291). - Exactly one code package ships it: that package. Its own stored row, else the package-unbound row, else the code item. A row bound to another package is never served for it. - Several ship it and no stored row is bound to one of them: `null`, the package-unbound row alone, else the code item. Several ship it and a row is bound to one: unchanged (`undefined`, best effort). `readMetaItem` applies it to the active rows it already read; `packagelessReadAddress` (the layered read's address) applies it after `packagelessAddress`, and its host gains `shippedArtifactsOf`. `packagelessAddress` itself is untouched, so the package-less save, delete and the read's `version` resolve exactly as before. Three content spreads now test `!== undefined`, so `null` reaches `findServedOverlayRow` as the package-unbound row. Files: `protocol-environment-rows.ts`, `protocol-lock-version-gates.ts`, `protocol.ts` (the `readMetaItem` lines, the `packagelessReadAddress` host and docblock, two spreads in `getMetaItem` and one in `getMetaItemLayered`), the new test, a `patch` changeset. ## Tests `packages/objectql/src/protocol-packageless-read-dependent-package.test.ts`, over the real `ObjectQL` engine, its `SchemaRegistry` and an in-memory driver. The dependent package is installed through the package door with `dependencies: { com.example.showcase: '*' }`, and its row is written through the draft save and the per-item publish naming it, as the card's steps wrote it. 1. The card's three reads answer base / dependent / base (6 / 2 / 6 columns), the package-less answer carries `_packageId: com.example.showcase`, the layered read's `effective` is the base's with `overlay: null`, and the list scoped to the base serves the base's columns. 2. The write address does not move: `packagelessAddress` still answers the dependent package, a package-less save writes the dependent package's row and mints no other, and the read naming no package still serves the base. 3. CONTROL: a writable package's own item (a name no code package ships) is served to the read naming no package, with its own `_packageId` (#23291). 4. CONTROL: a package-unbound row wins over the code package on the read naming no package and the read naming the base. 5. Beside the dependent package's row, the package-unbound row is what the read naming no package and the layered read serve (the dependent package's row was, before), and the read naming the dependent package serves its own row. <details><summary>Red on base 69ce01d: 3 failed, 1 passed (cases 1, 2, 5 red; 3 green; 4 added after)</summary> The three production files written back to their base blobs, `@objectstack/metadata-protocol` rebuilt, the pin file run (4 cases then), then restored with `git checkout HEAD --` (`git diff HEAD` empty) and rebuilt. ``` × the card's three steps answer base / dependent / base, and the layered read and the base's list agree × the write address does not move: a save naming no package still writes the dependent package's row × CONTROL: a package-unbound row still wins over the code package, beside the dependent package's row too AssertionError: expected [ 'title', 'status' ] to deeply equal [ Array(6) ] AssertionError: expected [ 'title' ] to deeply equal [ Array(6) ] AssertionError: expected [ 'title', 'status' ] to deeply equal [ 'title', 'priority' ] Tests 3 failed | 1 passed (4) ``` The third was named CONTROL then; the red showed it is a changed answer, so it was split into the plain control (case 4) and case 5. </details> <details><summary>Ablation: the old one-shipper answer restored reds 3 of 5; the restore leg is green</summary> `node scripts/ablation-replace.mjs` on `protocol-environment-rows.ts`, anchor `if (shippers.size === 1) return [...shippers][0];` → `return (globalThis as any).ABL28238 ?? (address.packageId ?? undefined);` (the write address's package, as before). Anchor 1 → 0, blob `1a530197d936` → `992e059d588a`; `ablation-dist-preflight` found the marker in `dist/index.js` and `dist/index.cjs`. ``` × the card's three steps answer base / dependent / base, and the layered read and the base's list agree × the write address does not move: a save naming no package still writes the dependent package's row × beside the dependent package's row, the package-unbound row is what the read naming no package serves Tests 3 failed | 2 passed (5) ablation-replace: ok restored: blob == HEAD (1a53019) and `git diff HEAD` is empty ``` Restore leg: rebuild, `ablation-dist-preflight --absent` (marker absent from all 24 built files), `Tests 5 passed (5)`. </details> <details><summary>Package suites</summary> - `@objectstack/metadata-protocol`: `Test Files 284 passed | 4 skipped (288)`, `Tests 21860 passed | 26 skipped`. Includes `protocol.item-read-overlay-cache.test.ts`, `meta-overlay-cache.test.ts` and `protocol.packageless-save-address.test.ts` (the #23291 / #23165 / #23495 / #23715 pins). - `@objectstack/objectql` (`--project local`): `Test Files 501 passed (501)`, `Tests 9755 passed`. - `typecheck` of both packages (objectql's includes `check:test-typecheck`): exit 0. - `eslint --no-inline-config` on `packages/metadata-protocol` and the new test: exit 0. </details> ## Acceptance notes **The card's acceptance is half met.** Live on `examples/app-showcase` (`pnpm dev -- --fresh`), the card's steps (the showcase's list now has 7 columns, not 6): | | base 69ce01d | this branch | |---|---|---| | `?package=com.example.showcase` | 7 | 7 | | `?package=com.default.acme-custom` | 2 | 2 | | no `package` | **2** | **7** | | `?layers=true` `effective` | 2 | 7 | | `GET /meta/view?package=com.example.showcase` | one item, 7 | one item, 7 | | `GET /meta/view` (no package), items named `showcase_task.default` | 7 and 2, both `_packageId: com.example.showcase` | unchanged | | `/_console/apps/com.example.showcase/showcase_task` headers (Playwright) | Title, Status | **Title, Status** | The app still renders 2. The console reads views only from the list naming no package (`ui/packages/app-shell/src/providers/MetadataProvider.tsx`, `EAGER_TYPES` and `composeObjects(..., readType('view'))`), and `mergeViewsIntoObjects` keys each view by name, so the last item of a name wins: the dependent package's slot. That list keeps one slot per package that holds a name by design (`readFlattenedMetaItems`, #21934: the env-wide list "holds every package's body of a name"), and the dependent package's slot wears the base's `_packageId` (the artifact envelope `mergeArtifactProtection` grafts). Changing either is a choice between a server list rule and a console merge rule, so it goes to the card as a decision; this PR does not touch the list. - **Write address unchanged, by order.** A package-less save of this name still lands in the dependent package's row, and the package-less read's `version` is `null` when no row is served (the base has no row). So a package-less save followed by a package-less read does not read back what it wrote, for this one shape. The epic's write gate (N-09: undeclared same-name refused at publish) closes the shape at its source. - **Declared override: nothing to pin.** `main` has no override declaration yet (N-08), so "no change to declared overrides" holds trivially. - **Draft reads unchanged.** The strict draft read and `previewDrafts` naming no package still follow the draft address (`packagelessDraftAddress`), which is the write side. - **A disabled base.** `shippedArtifactsOf` includes a disabled package's artifact, so a disabled base's name now resolves to the base on the package-less read, which the read then withholds as a disabled package's item, where it used to serve the dependent package's row (read from the code, not measured). ## Verification <details><summary>Derived gates on 21fa3e7 (62 commands, `dispatch-gates.mjs --commands --repo objectstack-ai/objectstack`)</summary> `dispatch-gates --ran`: 62 derived, 62 run, 0 NOT-MEASURED; every one exit 0. `check-plugin-teardown-shape --self-test` first answered 3 (its positive control commit was outside this shallow clone); after `git fetch --depth=1 origin 621a487…` it answered 0, and that is the code recorded. ``` node scripts/check-adr-0087-registration.mjs --base origin/main :: exit 0 node scripts/check-adr-0087-registration.mjs --self-test :: exit 0 node scripts/check-changeset-no-major.mjs --base origin/main :: exit 0 node scripts/check-closing-keyword-parity.mjs :: exit 0 node scripts/check-closing-keyword-parity.mjs --self-test :: exit 0 node scripts/check-comment-mask-adoption.mjs :: exit 0 node scripts/check-comment-mask-adoption.mjs --self-test :: exit 0 node scripts/check-comment-mask-corpus.mjs :: exit 0 node scripts/check-dts-emitted.mjs --self-test :: exit 0 node scripts/check-empty-changeset.mjs --base origin/main :: exit 0 node scripts/check-empty-changeset.mjs --self-test :: exit 0 node scripts/check-engine-split-ratio.mjs --self-test :: exit 0 node scripts/check-issue-citations.mjs :: exit 0 node scripts/check-plugin-teardown-shape.mjs :: exit 0 node scripts/check-plugin-teardown-shape.mjs --self-test :: exit 0 node scripts/ci/assert-turbo-remote-cache.mjs --self-test :: exit 0 node scripts/ci/plan-test-core-shards.mjs --self-test :: exit 0 node scripts/ci/prune-turbo-cache.mjs --self-test :: exit 0 node scripts/docs-audit/check-affected-docs.mjs :: exit 0 node scripts/docs-audit/check-drift-comment.mjs :: exit 0 node scripts/pm/release-rehearsal-clone.mjs --self-test :: exit 0 node scripts/release-pending-publish.mjs --self-test :: exit 0 pnpm --filter @objectstack/spec run check:duration-unit-keys :: exit 0 pnpm check:changeset-gate-self-tests :: exit 0 pnpm check:ci-filter-parity :: exit 0 pnpm check:closed-ceremony-text :: exit 0 pnpm check:cross-package-test-inputs :: exit 0 pnpm check:dispatcher-error-vocabulary :: exit 0 pnpm check:doc-authoring :: exit 0 pnpm check:driver-memory-census :: exit 0 pnpm check:dts-closure :: exit 0 pnpm check:dual-build-cjs-loads :: exit 0 pnpm check:durability-log-level :: exit 0 pnpm check:engine-double-contract :: exit 0 pnpm check:error-status-conformance :: exit 0 pnpm check:filter-alias-parity :: exit 0 pnpm check:gitlink-declared :: exit 0 pnpm check:issue-citations :: exit 0 pnpm check:keyed-text-bounds :: exit 0 pnpm check:lean-entry-closure :: exit 0 pnpm check:logger-receiver-detach :: exit 0 pnpm check:nul-bytes :: exit 0 pnpm check:objectql-double-limit :: exit 0 pnpm check:org-identifier :: exit 0 pnpm check:page-declaration-shape :: exit 0 pnpm check:platform-object-tenancy-census :: exit 0 pnpm check:pm-changeset-deadline-census :: exit 0 pnpm check:published-files :: exit 0 pnpm check:query-options-erasure :: exit 0 pnpm check:refd-timer-probe :: exit 0 pnpm check:registry-log-declared :: exit 0 pnpm check:rest-log-spy-declared :: exit 0 pnpm check:slot-lookup :: exit 0 pnpm check:sourcemap-no-sources-content :: exit 0 pnpm check:system-context-census :: exit 0 pnpm check:test-source-alias :: exit 0 pnpm check:tier-file-adoption :: exit 0 pnpm check:type-check-coverage :: exit 0 pnpm check:type-check-debt :: exit 0 pnpm check:undeclared-dep-imports :: exit 0 pnpm check:watch-hint-literal :: exit 0 pnpm check:where-matcher :: exit 0 ``` Not run locally, declared to CI: `test:repo` (Test Core), the artifact-roster and wide-population families, the type-check lanes. `pnpm lint` scoped to the two touched packages: exit 0. </details> --- _Generated by [Claude Code](https://claude.ai/code/session_01FEkQ5nQHuymasPwjX3mAr2)_ --------- Co-authored-by: Claude <noreply@anthropic.com>
1 parent b1e1dcf commit 5055b10

5 files changed

Lines changed: 394 additions & 12 deletions

File tree

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
---
2+
'@objectstack/metadata-protocol': patch
3+
---
4+
5+
fix(metadata-protocol): a same-named row in a dependent package no longer replaces the base package's item for a read that names no package
6+
7+
Clause-②: no
8+
Metadata-protocol: none
9+
10+
When a writable package that depends on a code package saved an item under a name the code package ships (`showcase_task.default` saved into `com.default.acme-custom`), `GET /api/v1/meta/view/showcase_task.default` with no `package` served the dependent package's copy, under the code package's `_packageId`, and so did the layered read's `effective`. The code package that ships the name was not a candidate of that read: the dependent package's row won by being the only stored row.
11+
12+
The by-name read and the layered read that name no package now take their stored content from the code package that ships the name: its own stored row, else the package-unbound row (the overlay Setup writes, which still wins over the code item), else the code item. A read naming the dependent package still serves its own row, and a writable package's own item, a name no code package ships, is still served to the read naming no package. Where a package-less save, delete and the read's `version` land does not move.

‎packages/metadata-protocol/src/protocol-environment-rows.ts‎

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,11 @@
1111
* - `findServedOverlayRow` — the stored row a by-name read serves;
1212
* - `packagelessAddress` — the package a write that names none addresses.
1313
*
14+
* [#28238] Beside them, `packagelessContentPackage`: the package a by-name
15+
* read that names none takes its stored content from, given that address and
16+
* the code packages that ship the name. Not a moved body: the rule the two
17+
* by-name reads share.
18+
*
1419
* A MOVE, not a redesign. Each function below is the body of the
1520
* `ObjectStackProtocolImplementation` method of the same name as it stood,
1621
* re-indented one level and otherwise unedited.
@@ -159,3 +164,49 @@ export async function packagelessAddress(
159164
const candidates = [...bindings].sort();
160165
return { packageId: candidates.length === 1 ? candidates[0] ?? null : null, candidates, unbound };
161166
}
167+
168+
/**
169+
* [#28238, ADR-0048 §3.3] The package a by-name read that names no package
170+
* takes its stored CONTENT from: {@link findServedOverlayRow}'s `packageId`
171+
* for {@link ObjectStackProtocolImplementation.getMetaItem} and
172+
* {@link ObjectStackProtocolImplementation.getMetaItemLayered}, so the plain
173+
* read and the layered read's `effective` serve one row.
174+
*
175+
* `address` is the item's package-less write address
176+
* ({@link packagelessAddress}, at `active`); `shipped` is every artifact an
177+
* installed code package registered under the name
178+
* (`ObjectStackProtocolImplementation#shippedArtifactsOf`). The code packages
179+
* that ship the name are candidates of the address beside the stored rows'
180+
* bindings:
181+
*
182+
* - no code package ships the name, or the one package the stored rows are
183+
* bound to ships it: the write address's package, as before (#23291) —
184+
* else `undefined`, any row, the best-effort first match;
185+
* - exactly one code package ships it: that package. Its own stored row,
186+
* else the package-unbound row (ADR-0005), else its code item. A row bound
187+
* to another package, the only stored row of a dependent package that saved
188+
* the same name, is never served for it: that row stood in for the base's
189+
* item on every read naming no package and in the base's own app;
190+
* - several ship it, and no stored row is bound to one of them: `null`, the
191+
* package-unbound row alone, else the code item the registry answers;
192+
* several ship it and a row is bound to one: `undefined`, as before.
193+
*
194+
* Content only, and the read's alone. The write address does not move: a
195+
* save, a delete and the read's `version` still resolve
196+
* {@link packagelessAddress}'s `packageId`.
197+
*/
198+
export function packagelessContentPackage(
199+
address: { readonly packageId: string | null; readonly candidates: readonly string[] },
200+
shipped: readonly unknown[],
201+
): string | null | undefined {
202+
const shippers = new Set<string>();
203+
for (const artifact of shipped) {
204+
const id = (artifact as { _packageId?: unknown } | null | undefined)?._packageId;
205+
if (typeof id === 'string' && id !== '' && id !== 'sys_metadata') shippers.add(id);
206+
}
207+
if (shippers.size === 0 || (address.packageId !== null && shippers.has(address.packageId))) {
208+
return address.packageId ?? undefined;
209+
}
210+
if (shippers.size === 1) return [...shippers][0];
211+
return address.candidates.some((id) => shippers.has(id)) ? undefined : null;
212+
}

‎packages/metadata-protocol/src/protocol-lock-version-gates.ts‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
import type { ObjectStackProtocolImplementation, MetadataAuditEntry } from './protocol.js';
5151
import { canonicalMetaType } from './protocol.js';
5252
import { SysMetadataRepository, unboundItemDraftAddress } from './sys-metadata-repository.js';
53+
import { packagelessContentPackage } from './protocol-environment-rows.js';
5354
import { resolveItemLockLazily } from './item-lock.js';
5455
import { ConflictError } from '@objectstack/metadata-core';
5556
import { PLURAL_TO_SINGULAR } from '@objectstack/spec/shared';
@@ -111,6 +112,7 @@ export interface LockVersionGateHost {
111112
receiptVersion: ObjectStackProtocolImplementation['receiptVersion'];
112113
recordMetadataAudit: ObjectStackProtocolImplementation['recordMetadataAudit'];
113114
rethrowUnlessMetadataStoreUnprovisioned: ObjectStackProtocolImplementation['rethrowUnlessMetadataStoreUnprovisioned'];
115+
shippedArtifactsOf: ObjectStackProtocolImplementation['shippedArtifactsOf'];
114116
storedHashDigest: ObjectStackProtocolImplementation['storedHashDigest'];
115117
storedHeadAt: ObjectStackProtocolImplementation['storedHeadAt'];
116118
}
@@ -437,9 +439,10 @@ export async function readVersionToken(
437439

438440
/** The body of `ObjectStackProtocolImplementation#packagelessReadAddress`; the method's docblock there is its contract. */
439441
export async function packagelessReadAddress(
440-
this: Pick<LockVersionGateHost, 'packagelessAddress'>,
441-
type: string, name: string, member?: string): Promise<string | undefined> {
442-
return (await this.packagelessAddress(PLURAL_TO_SINGULAR[type] ?? type, name, member)).packageId ?? undefined;
442+
this: Pick<LockVersionGateHost, 'packagelessAddress' | 'shippedArtifactsOf'>,
443+
type: string, name: string, member?: string): Promise<string | null | undefined> {
444+
const singular = PLURAL_TO_SINGULAR[type] ?? type;
445+
return packagelessContentPackage(await this.packagelessAddress(singular, name, member), this.shippedArtifactsOf(singular, name));
443446
}
444447

445448
/** The body of `ObjectStackProtocolImplementation#strictDraftReadAddress`; the method's docblock there is its contract. */

‎packages/metadata-protocol/src/protocol.ts‎

Lines changed: 22 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@ import { refuseUnmintableMetaType } from './protocol-unmintable-meta-type.js';
438438
// [#25467 cut 33] The deployment's SDUI component manifest, and the load-time page `requires` report against it.
439439
import { reportPageRequiresAbsentAtLoad, resolveSduiManifest } from './protocol-sdui-manifest.js';
440440
// [#25467 cut 35] The environment's own `sys_metadata` rows: the family read, the one-row read, the served row and the package-less address.
441-
import { findEnvironmentRow, findEnvironmentRows, findServedOverlayRow, packagelessAddress } from './protocol-environment-rows.js';
441+
import { findEnvironmentRow, findEnvironmentRows, findServedOverlayRow, packagelessAddress, packagelessContentPackage } from './protocol-environment-rows.js';
442442
// [#25467 cut 35] The stored rows of a collection, folded over the registered ones.
443443
import { foldStoredCollection } from './protocol-stored-collection-fold.js';
444444
// [#25467 cut 35] The environment-wide package uninstall verb.
@@ -10844,12 +10844,18 @@ export class ObjectStackProtocolImplementation implements
1084410844
// The package-less binding ({@link packagelessReadAddress}'s), selected
1084510845
// from those rows; the `version` below ({@link readVersionToken})
1084610846
// takes the same binding instead of reading it again.
10847-
const packagelessBinding = readState === 'active' && !request.packageId
10848-
? (await this.packagelessAddress(
10847+
const packagelessAddressed = readState === 'active' && !request.packageId
10848+
? await this.packagelessAddress(
1084910849
PLURAL_TO_SINGULAR[request.type] ?? request.type, request.name, member, 'active', activeRows,
10850-
)).packageId
10850+
)
1085110851
: undefined;
10852-
const contentPackageId = request.packageId || (packagelessBinding ?? undefined);
10852+
const packagelessBinding = packagelessAddressed?.packageId;
10853+
// [#28238] The content, though, is {@link packagelessContentPackage}'s:
10854+
// the code package that ships the name is a candidate too, so a row
10855+
// another package stored under the name is not served for it.
10856+
const contentPackageId = request.packageId || (packagelessAddressed
10857+
? packagelessContentPackage(packagelessAddressed, this.shippedArtifactsOf(request.type, request.name))
10858+
: undefined);
1085310859

1085410860
// ADR-0033 draft-overlay preview (non-strict): when the caller opts in
1085510861
// (admin-gated upstream), prefer a `state='draft'` row if one exists, else
@@ -10868,7 +10874,7 @@ export class ObjectStackProtocolImplementation implements
1086810874
state: 'draft',
1086910875
...(draftContentAddress
1087010876
? { packageId: draftContentAddress.packageId }
10871-
: contentPackageId ? { packageId: contentPackageId } : {}),
10877+
: contentPackageId !== undefined ? { packageId: contentPackageId } : {}),
1087210878
...memberOption(member),
1087310879
}))?.row;
1087410880
// [#23715] Two or more packages and no package-unbound draft:
@@ -10928,7 +10934,7 @@ export class ObjectStackProtocolImplementation implements
1092810934
state: readState,
1092910935
...(readState === 'draft' && draftContentAddress
1093010936
? { packageId: draftContentAddress.packageId }
10931-
: contentPackageId ? { packageId: contentPackageId } : {}),
10937+
: contentPackageId !== undefined ? { packageId: contentPackageId } : {}),
1093210938
...memberOption(member),
1093310939
}, activeRows))?.row;
1093410940
// [#23715] Two or more packages and no package-unbound draft: the
@@ -11559,7 +11565,7 @@ export class ObjectStackProtocolImplementation implements
1155911565
type: request.type,
1156011566
name: request.name,
1156111567
state: 'active',
11562-
...(contentPackageId ? { packageId: contentPackageId } : {}),
11568+
...(contentPackageId !== undefined ? { packageId: contentPackageId } : {}),
1156311569
...memberOption(member),
1156411570
});
1156511571
overlayLockLayer = await this.overlayLockLayerAt({
@@ -17077,11 +17083,18 @@ export class ObjectStackProtocolImplementation implements
1707717083
* layered read's `effective` and `/published` serve one row. [#23715] The
1707817084
* strict draft read asks {@link strictDraftReadAddress} instead: the draft
1707917085
* its `version` names.
17086+
*
17087+
* [#28238] The code packages that ship the name are candidates too
17088+
* ({@link packagelessContentPackage}, the rule {@link getMetaItem} applies
17089+
* to the rows it already read): a row bound to another package is not
17090+
* served for a name one code package ships, and `null` is the
17091+
* package-unbound row alone. The write address does not move.
1708017092
*/
17081-
private packagelessReadAddress(type: string, name: string, member?: string): Promise<string | undefined> {
17093+
private packagelessReadAddress(type: string, name: string, member?: string): Promise<string | null | undefined> {
1708217094
// [#25467 cut 5] The body moved to `protocol-lock-version-gates.ts` (see `LockVersionGateHost`).
1708317095
const host: ThisParameterType<typeof packagelessReadAddress> = {
1708417096
packagelessAddress: (...a) => this.packagelessAddress(...a),
17097+
shippedArtifactsOf: (...a) => this.shippedArtifactsOf(...a),
1708517098
};
1708617099
return packagelessReadAddress.call(host, type, name, member);
1708717100
}

0 commit comments

Comments
 (0)