Skip to content

Commit 516119d

Browse files
docs(pm-dispatch): runbook patrol names the per-seat patrol and dedupes review claims by seat (#28759)
<!-- claude-projects-attribution: {"github_login":"marchtian"} --> _Requested by **田騏** · [project thread](https://claude.ai/code/project/chan_01VmuUhXU9SSUzqJYyXSmYSi?thread=cmsg_01VmuUhXU9SSUzqJYyXSmYSiHXKqxUqDPJKZyNHP7BoqTb)_ Fixes #28740 Clause-②: no Metadata-protocol: none ## 维护者速读 - 改了什么:派发手册〈巡查常设项〉三行措辞:标题与跨账户复审行由「每项目巡查」改为「每席巡查」,复核认领去重从「他账户」改为「他席(同账户亦然)」。 - 为什么改:技能其余处已是「每席一个巡查」;旧去重按账户判,同一账户在同项目坐多席时两席都会放行,可能对同一 PR 重复复核。 - 风险与回滚:纯文面改动,不动脚本与门禁;「剔除本账户署名的 PR」这条复核独立性规则保持按账户不变。回滚即还原这一个提交。 - 先看:`.claude/skills/pm-dispatch/references/dispatch-runbook.md` 第 45 行(去重键从账户改为席位)。 - 两分钟验证:`git grep 每项目巡查 -- .claude` 应零命中;`pnpm check:pm-skill-ratchet` 应通过(净行数 0)。 - 需要你做的:审阅并批准本 PR(规则文本改动以维护者批准为裁决),之后由席位落地。 ## What changes `.claude/skills/pm-dispatch/references/dispatch-runbook.md`, section 巡查常设项, three lines (3 insertions, 3 deletions, net 0): - L39 heading: 「每项目巡查与总监席摘要」 becomes 「每席巡查与总监席摘要」. - L44 cross-account review line: 「每项目巡查跑」 becomes 「每席巡查跑」. Its exclusion 「剔除本账户署名的 PR」 is the review-independence rule and stays keyed to the account. - L45 review-claim dedupe: 「已有他账户的认领即跳过」 becomes 「已有他席认领即跳过(同账户亦然)」, so a PR already claimed by another seat is skipped even when that seat sits on the same account. The `Claim:` form (会话、账户) is unchanged; no new field. ## Tests Prose-only change to a governed skill reference; no code, no package, no test surface. `skip-changeset`: nothing publishes. ## Acceptance notes - Byte widths after the edit: L39 50 B, L44 108 B, L45 119 B, all within the 120-byte cap (`check-skill-line-ratchet.mjs`). The first L45 spelling measured 122 B and was shortened by dropping one particle. - `git grep 每项目巡查` over the whole tree: 0 hits after the edit. The only other mention of the section, `lanes/director.md` L74, cites it as 巡查常设项 and still resolves. - Read against `contract-review.md` and `seat-lifecycle.md`: neither keys reviewer independence or the review-claim dedupe differently; `cross-repo-coordination.md` already uses 他席 for another seat's claim. ## Verification Local gate subset at head `640da54552`, derived by `node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack`, every exit code captured before any pipe. <details><summary>17 derived families + 3 named by the order, all exit 0</summary> ``` node scripts/check-closing-keyword-parity.mjs :: exit 0 node scripts/check-closing-keyword-parity.mjs --self-test :: exit 0 node scripts/check-comment-mask-corpus.mjs :: exit 0 node scripts/pm/check-harness-current.mjs --self-test :: exit 0 pnpm --filter @objectstack/lint run check:doc-formula-expressions :: exit 0 (first run exit 3, prerequisite not built; rerun after building formula + lint) pnpm check:agent-test-spelling :: exit 0 pnpm check:cross-package-test-inputs :: exit 0 pnpm check:doc-authoring :: exit 0 pnpm check:driver-memory-census :: exit 0 pnpm check:gitlink-declared :: exit 0 pnpm check:nul-bytes :: exit 0 pnpm check:pm-governed-merges :: exit 0 pnpm check:pm-skill-id-lint :: exit 0 pnpm check:pm-skill-ratchet :: exit 0 pnpm check:refd-timer-probe :: exit 0 pnpm check:skill-frame-sync :: exit 0 pnpm check:watch-hint-literal :: exit 0 pnpm check:pm-governed-prose :: exit 0 pnpm check:pm-settings-deny-roster :: exit 0 node scripts/check-skills-token-ratchet.mjs :: exit 0 ``` `--ran` reconciliation: 17 derived, 17 run, 0 NOT-MEASURED, 0 UNRUN (a derived zero: all 17 carry an exit code). </details> 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
1 parent b9b877c commit 516119d

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

‎.claude/skills/pm-dispatch/references/dispatch-runbook.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,13 @@
3636
- 写序:标签翻转只在认领评论写成功之后,两笔不原子。
3737
- 评论失败而标签已翻即制造一记真半状态;顺序反了就带重试义务,重试未成即回滚标签。
3838

39-
## 巡查常设项(每项目巡查与总监席摘要)
39+
## 巡查常设项(每席巡查与总监席摘要)
4040

4141
- 座位贴活性归总监席摘要:扫 `label:pm:seat` 挂 `🟢 <github-login>` 的贴,Routine 席读调度器。
4242
- 判据只认在任者自有产出(评论、认领、改正文)及其作者与时间戳,⛔ 收到的通知不算。
4343
- >24h 无自有产出 ⇒ 当场降级:改 `⏳ vacant` + 摘 assignee 同笔 + 证据评论(时间戳与链接)。
44-
- 跨账户复审:每项目巡查跑 `is:pr is:open label:needs:contract-review`,剔除本账户署名的 PR。
45-
- 复核前在 PR 留 `Claim:` 形评论(会话、账户);已有他账户的认领即跳过,⛔ 不双做。
44+
- 跨账户复审:每席巡查跑 `is:pr is:open label:needs:contract-review`,剔除本账户署名的 PR。
45+
- 复核前在 PR 留 `Claim:` 形评论(会话、账户);已有他席认领即跳过(同账户亦然),⛔ 不双做。
4646
- 复核照 `contract-review.md`;PASS 同笔摘标记、FAIL 不摘;总监席摘要列等候逾 24h 的 PR。
4747
- 车道巡查同跑:hold/closed 解锁重验回队;本仓无卡 fork PR 按 `external-contributions.md` 立卡。
4848

0 commit comments

Comments
 (0)