Repository navigation
Commit 5399bbc
feat(console): second-pass i18n for Audit Log, Flow Runs, Agent Connect and share links (#13503)
Part of #13460
Clause-②: no
Metadata-protocol: none
Claim: comment 6393192822 (Seat: domain:ui#4).
## What changed
Second pass of #13460, following the conventions of #13489:
`useObjectTranslation()` with `t(key, { defaultValue })` where the
inline default is the `en` value byte for byte, and `withSlots` for a
sentence with an inline element. No new lint gate.
- **System → Audit Log** (`AuditLogPage.tsx`) reads
`console.system.auditLog.*`: the header, the presets row (a refused
preset's reason is now a code, worded at render), the filters, the empty
and error states, the table heads, the pagination and the detail drawer.
`formatDate` is untouched (#13458 is waiting on a ruling).
- **Developer → Flow Runs** (`FlowRunsPage.tsx`) reads
`console.developer.flowRuns.*`. "Click Run Flow" and "the Test Run
panel" name those controls by their translated labels, and "Paused at
screen" puts the node name in a slot.
- **Integrations → Connect an AI agent** (`AgentConnectSection.tsx`)
reads `console.developer.agentConnect.*`. The disabled notice and the
steps keep their inline code inside one translated sentence. Copy, Done
and Download reuse existing keys.
- **ShareDialog** (`packages/components`) reads `shareDialog.*`. The
expiry and audience choices are literal `t()` calls built per render, so
the dead-key and call-site gates read them. A failure keeps the server's
message, or names the step that failed in the viewer's language.
- **Public share landing `/s/:token`** (`SharedRecordPage.tsx`) reads
`sharedRecord.*`. Failures are kept as codes and worded at render.
- All ten packs carry the 135 new keys (25 + 24 + 36 + 30 + 20).
- **Dev-only surfaces moved under `dev/`.**
`apps/console/src/components/PerformanceDashboard.tsx` (no importers)
moved to `apps/console/src/dev/`. `packages/components/src/debug/` moved
to `packages/components/src/dev/`. The package index re-exports `./dev`,
so its exports are unchanged.
## Tests
- New:
`apps/console/src/pages/consolePagesLocale-secondPass-13460.test.tsx`
renders the four console surfaces under zh through a real
`I18nProvider`, reads its expectations from the pack, and checks that no
`{{slot}}` or slot mark leaks. Each surface also has a provider-less
English control.
- New:
`packages/components/src/__tests__/share-dialog-locale-13460.test.tsx`
covers the ShareDialog chrome under zh, the `recordLabel` hole, and an
English control.
- Updated: `AgentConnectSection.keyNameConfirm-13383.test.tsx` queries
the new echoed keys. `displayLocale-9909.test.tsx` and
`ariaLabelLiteralCensus-12145.test.ts` follow the `debug/` to `dev/`
move.
## Verification
- 32 affected test files under the verify lock: 32 passed, 223 tests
passed (VERDICT 0).
- `vitest run packages/i18n/`: 87 files, 1353 tests passed, 13 skipped.
- `turbo run type-check` for console, components and i18n: 38 of 38
tasks passed.
- `check-i18n-call-site-keys`, `check-i18n-en-drift`,
`check-i18n-designer-table-parity`: pass. `check-i18n-dead-keys` lists
none of the new keys.
- `check-changeset-presence`, `check-changeset-no-major`,
`check-changeset-claims`, `check-pending-changeset-literals`,
`check:new-line-citations`: pass.
- eslint on the touched files: 0 errors (warnings only).
- NOT MEASURED: the full repo test suite, a browser run of the pages,
and translation quality beyond the pack tests.
## Acceptance notes: what is left for #13460
These are not in this PR:
- data-table row titles ('Open record', 'Cancel changes', 'Save row')
- ObjectView 'Loading chart…'
- react-page messages
- ResourceEditPage 'From type' / 'From name' / 'Path'
- ConnectAgentWidget product names
- the StudioDesignSurface placeholder
- the console `*-preview.tsx` dev entries (not moved), and the copy
inside `apps/console/src/dev/*`
- Flow Runs client-capability diagnostics ('meta.getItems is not
available on this client' and similar)
- the ShareDialog audience and permission badges, which show raw enum
values (enum labels belong to #13353)
- the 'Agent key' name prefill
The brand lines "Powered by ObjectStack" and "Read-only · Shared via
ObjectStack" on the share landing are left literal on purpose.
`metadata-admin/datasource/**` (#13353) and the three `formatDate`
helpers (#13458) are excluded as the claim asks.
Deviation: commit 58af2ad ends with a harness-supplied `Co-Authored-By`
trailer that names the model, not the model-free pair from AGENTS.md.
History is not rewritten, because force-push is forbidden here. Please
drop that line from the squash message when landing.
- [x] Adds no product-specific widget, dialog, hook or string (see
AGENTS.md › Product-neutral renderer)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_018yk9f7S7q4BrEeWZGRcTKF
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent db9af10 commit 5399bbc
25 files changed
Lines changed: 2221 additions & 214 deletions
File tree
- .changeset
- apps/console/src
- dev
- pages
- developer
- system
- packages
- components/src
- __tests__
- dev
- i18n/src
- __tests__
- locales
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
File renamed without changes.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
| |||
49 | 50 | | |
50 | 51 | | |
51 | 52 | | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
52 | 67 | | |
53 | 68 | | |
54 | 69 | | |
| |||
58 | 73 | | |
59 | 74 | | |
60 | 75 | | |
| 76 | + | |
61 | 77 | | |
62 | 78 | | |
63 | 79 | | |
64 | 80 | | |
65 | 81 | | |
66 | 82 | | |
67 | | - | |
| 83 | + | |
68 | 84 | | |
69 | 85 | | |
70 | 86 | | |
| |||
80 | 96 | | |
81 | 97 | | |
82 | 98 | | |
83 | | - | |
84 | | - | |
85 | | - | |
| 99 | + | |
86 | 100 | | |
87 | 101 | | |
88 | 102 | | |
| |||
99 | 113 | | |
100 | 114 | | |
101 | 115 | | |
102 | | - | |
| 116 | + | |
103 | 117 | | |
104 | 118 | | |
105 | | - | |
| 119 | + | |
| 120 | + | |
106 | 121 | | |
107 | 122 | | |
108 | 123 | | |
109 | 124 | | |
110 | 125 | | |
111 | | - | |
| 126 | + | |
112 | 127 | | |
113 | 128 | | |
114 | 129 | | |
115 | 130 | | |
116 | | - | |
| 131 | + | |
117 | 132 | | |
118 | 133 | | |
119 | 134 | | |
120 | 135 | | |
121 | 136 | | |
122 | | - | |
| 137 | + | |
| 138 | + | |
123 | 139 | | |
124 | 140 | | |
125 | 141 | | |
| |||
129 | 145 | | |
130 | 146 | | |
131 | 147 | | |
132 | | - | |
| 148 | + | |
133 | 149 | | |
134 | 150 | | |
135 | 151 | | |
| |||
167 | 183 | | |
168 | 184 | | |
169 | 185 | | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
170 | 210 | | |
171 | 211 | | |
172 | 212 | | |
173 | 213 | | |
174 | | - | |
| 214 | + | |
175 | 215 | | |
176 | 216 | | |
177 | 217 | | |
| |||
189 | 229 | | |
190 | 230 | | |
191 | 231 | | |
192 | | - | |
| 232 | + | |
193 | 233 | | |
194 | | - | |
| 234 | + | |
195 | 235 | | |
196 | 236 | | |
197 | | - | |
| 237 | + | |
198 | 238 | | |
199 | 239 | | |
200 | 240 | | |
| |||
204 | 244 | | |
205 | 245 | | |
206 | 246 | | |
207 | | - | |
| 247 | + | |
208 | 248 | | |
209 | | - | |
| 249 | + | |
210 | 250 | | |
211 | 251 | | |
212 | 252 | | |
| |||
216 | 256 | | |
217 | 257 | | |
218 | 258 | | |
219 | | - | |
| 259 | + | |
220 | 260 | | |
221 | 261 | | |
222 | 262 | | |
223 | 263 | | |
224 | 264 | | |
225 | 265 | | |
226 | 266 | | |
227 | | - | |
| 267 | + | |
228 | 268 | | |
229 | | - | |
| 269 | + | |
230 | 270 | | |
231 | | - | |
| 271 | + | |
232 | 272 | | |
233 | 273 | | |
234 | 274 | | |
235 | 275 | | |
236 | 276 | | |
237 | 277 | | |
238 | | - | |
| 278 | + | |
239 | 279 | | |
240 | 280 | | |
241 | 281 | | |
242 | | - | |
243 | | - | |
| 282 | + | |
| 283 | + | |
244 | 284 | | |
245 | 285 | | |
246 | 286 | | |
| |||
255 | 295 | | |
256 | 296 | | |
257 | 297 | | |
258 | | - | |
| 298 | + | |
259 | 299 | | |
260 | 300 | | |
261 | 301 | | |
| |||
269 | 309 | | |
270 | 310 | | |
271 | 311 | | |
272 | | - | |
| 312 | + | |
273 | 313 | | |
274 | 314 | | |
275 | 315 | | |
276 | | - | |
| 316 | + | |
277 | 317 | | |
278 | 318 | | |
279 | 319 | | |
| |||
298 | 338 | | |
299 | 339 | | |
300 | 340 | | |
301 | | - | |
| 341 | + | |
302 | 342 | | |
303 | 343 | | |
304 | 344 | | |
| |||
307 | 347 | | |
308 | 348 | | |
309 | 349 | | |
310 | | - | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
311 | 354 | | |
312 | 355 | | |
313 | 356 | | |
| |||
0 commit comments