Skip to content

Commit 588ceba

Browse files
committed
fix(lint,spec): future-tense the flow-input-unknown-object consequence; drop the tracker number from the objectName hint (#29442)
Review 6588554525 should-fixes: the finding message now says a wrong name "will be refused once the start doors enforce the declaration", matching the planned key, and the authorHint on flow.variables[].objectName no longer names a tracker issue. The two code comments that made the same present-tense claim follow. Claude-Session: https://claude.ai/code/session_01JQwxbaiSvS6eyjEknCGKao Co-authored-by: Claude <noreply@anthropic.com>
1 parent 46cc4e9 commit 588ceba

2 files changed

Lines changed: 12 additions & 9 deletions

File tree

‎packages/lint/src/validate-flow-trigger-readiness.ts‎

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -201,9 +201,10 @@ export interface FlowTriggerReadinessFinding {
201201
export const FLOW_TRIGGER_UNKNOWN_OBJECT = 'flow-trigger-unknown-object';
202202
/**
203203
* #29442 (#29425 ruling A) — a start input declared a record reference
204-
* (`variables[].objectName`) names an object this stack does not define. Every
205-
* door that starts the flow by name loads such an input from that object, so a
206-
* wrong name refuses every start that supplies the input. The same hedge and
204+
* (`variables[].objectName`) names an object this stack does not define. Once
205+
* the start doors enforce the declaration (planned), every door that starts the
206+
* flow by name will load such an input from that object, so a wrong name will
207+
* refuse every start that supplies the input. The same hedge and
207208
* the same closure verdict as `flow-trigger-unknown-object`: advisory with no
208209
* package closure, an error under one.
209210
*/
@@ -935,10 +936,11 @@ export function validateFlowTriggerReadiness(
935936
// family has a use for.
936937

937938
// 1i. #29442 (#29425 ruling A) — a start input declared a record reference
938-
// names an object this stack does not define. Every door that starts
939-
// the flow by name loads the input from exactly that name in the
940-
// caller's scope, so a wrong name refuses every start that supplies
941-
// the input. Judged like the trigger's object (1 and 1b-i): a `sys_`
939+
// names an object this stack does not define. Once the start doors
940+
// enforce the declaration (planned), every door that starts the flow
941+
// by name will load the input from exactly that name in the caller's
942+
// scope, so a wrong name will refuse every start that supplies the
943+
// input. Judged like the trigger's object (1 and 1b-i): a `sys_`
942944
// name is a platform object and is not judged, and the verdict is the
943945
// closure's when one is stated. The schema owns the declaration's
944946
// shape (input-only, an object name); this rule reads only the name.
@@ -959,7 +961,8 @@ export function validateFlowTriggerReadiness(
959961
{
960962
message:
961963
`declares input '${variableName}' the id of a record of object '${objectName}', which this ` +
962-
`stack does not define — if the name is wrong, every start that supplies the input is refused.` +
964+
`stack does not define — if the name is wrong, every start that supplies the input will be ` +
965+
`refused once the start doors enforce the declaration.` +
963966
suggestName(objectName, objectNames),
964967
hint:
965968
`Set the input's objectName to the object's exact registered name, or ignore this if another ` +

‎packages/spec/liveness/flow.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@
9595
"verifiedAt": "2026-11-02",
9696
"evidence": "packages/spec/src/automation/flow.zod.ts#FlowVariableSchema (the superRefine that refuses `objectName` on a variable that is not an input — the one place the key is read today)",
9797
"authorWarn": true,
98-
"authorHint": "Keep it, but nothing reads it yet: no start door loads a declared input from its object until the server half of #29425 ruling A ships, so an id the caller cannot read still starts a run.",
98+
"authorHint": "Keep it, but nothing reads it yet: no start door loads a declared input from its object until the start doors ship that check, so an id the caller cannot read still starts a run.",
9999
"note": "PLANNED RECORD (#29442, the spec half of #29425 ruling A 6580257050): an input's declaration that its value is the id of one record of the named object. Parsed, refused on a non-input (the evidence above) and linted (`flow-input-unknown-object` in packages/lint/src/validate-flow-trigger-readiness.ts). No door reads it: the start doors' third question (packages/runtime/src/flow-start-admission.ts, `flowDeclaredRecordReads` / `refuseUnreadableFlowStartRecords` in action-execution.ts) judges only inputs the definition reads in plain sight. Carrier: the #29425 server half, Blocked-by #29442 (every start door loads a declared input in the caller's scope, 404 RECORD_NOT_FOUND / 400 VALIDATION_FAILED). Flip to `live` on the commit that cites that reader, drop `authorWarn` / `authorHint` and the describe's planned sentence in that same edit."
100100
}
101101
}

0 commit comments

Comments
 (0)