Skip to content

Commit 5a31503

Browse files
committed
test(plugin-approvals): each reminder case asserts notified before the emitted audiences
Claude-Session: https://claude.ai/code/session_011TdZ8GjixNZFLz1xJD9zzK Co-authored-by: Claude <noreply@anthropic.com>
1 parent 4bfbd05 commit 5a31503

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

‎packages/plugins/plugin-approvals/src/remind-notified-per-person.integration.test.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -204,8 +204,8 @@ describe('a reminder counts the reminders it hands over, one per distinct approv
204204
// The scene: the stored slate really lists her twice, so a count of 1 is the rule, not an empty slate.
205205
expect(stored).toEqual(['u_alice', 'u_alice']);
206206

207-
expect(reminders).toEqual([['u_alice']]);
208207
expect(notified).toBe(1);
208+
expect(reminders).toEqual([['u_alice']]);
209209

210210
// Unchanged: the reminder itself — topic, deep link, per-approver dedup key — and its one audit row.
211211
const [reminder] = emits.filter((e) => e.topic === 'approval.reminder' && e.source?.id === req.id);
@@ -220,29 +220,29 @@ describe('a reminder counts the reminders it hands over, one per distinct approv
220220
it('an approver authored as the same email in two groups is handed one reminder and counted once', async () => {
221221
const { stored, notified, reminders } = await remindOn('twice_by_email');
222222
expect(stored).toEqual([ALICE_EMAIL, ALICE_EMAIL]);
223-
expect(reminders).toEqual([[ALICE_EMAIL]]);
224223
expect(notified).toBe(1);
224+
expect(reminders).toEqual([[ALICE_EMAIL]]);
225225
});
226226

227227
it('control: two distinct approvers are each handed a reminder, and both are counted', async () => {
228228
const { stored, notified, reminders } = await remindOn('two_people');
229229
expect(stored).toEqual(['u_alice', 'u_bob']);
230-
expect(reminders).toEqual([['u_alice'], ['u_bob']]);
231230
expect(notified).toBe(2);
231+
expect(reminders).toEqual([['u_alice'], ['u_bob']]);
232232
});
233233

234234
it('a position:* literal on the slate adds nothing, and the person beside it is still reminded', async () => {
235235
const { stored, notified, reminders } = await remindOn('person_and_literal');
236236
expect(stored).toEqual(['u_alice', 'position:nobody_holds']);
237-
// The literal names no one: no emit carries it, and it adds nothing to the count.
238-
expect(reminders).toEqual([['u_alice']]);
237+
// The literal names no one: it adds nothing to the count, and no emit carries it.
239238
expect(notified).toBe(1);
239+
expect(reminders).toEqual([['u_alice']]);
240240
});
241241

242242
it("an account's id and its email are two addresses: two reminders, as at the opening", async () => {
243243
const { stored, notified, reminders } = await remindOn('id_and_email');
244244
expect(stored).toEqual(['u_alice', ALICE_EMAIL]);
245-
expect(reminders).toEqual([['u_alice'], [ALICE_EMAIL]]);
246245
expect(notified).toBe(2);
246+
expect(reminders).toEqual([['u_alice'], [ALICE_EMAIL]]);
247247
});
248248
});

0 commit comments

Comments
 (0)