Skip to content

Commit 5d9b4d7

Browse files
committed
test(lint): the shipped field ledger now warns on externalId too
Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L9qibvE77Ed7MKdzPxJTQQ
1 parent dbb70e1 commit 5d9b4d7

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

‎packages/lint/src/lint-liveness-properties.test.ts‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1673,9 +1673,12 @@ describe('the object/field walk, against a synthetic ledger directory (#19268)',
16731673
// `planned` + `authorWarn` — the inbound-mail correspondent flag on an email
16741674
// field, declared ahead of the mailbox ingest that reads it — and left this
16751675
// set when that reader landed and the row flipped `live` (#22871): a
1676-
// verdict that moved, so it was never a stable subject either. The
1677-
// synthetic slot below is warned by nothing shipped.
1678-
expect([...authorWarnedProperties('field')]).toEqual(['conditionalRequired']);
1676+
// verdict that moved, so it was never a stable subject either.
1677+
// `externalId` joined the set when #25753 graded it `dead` (no upsert reads
1678+
// it). It parses, so it is a stable subject the block above could take
1679+
// back; it keeps the synthetic slot so that block does not move with one
1680+
// more verdict. The synthetic slot below is warned by nothing shipped.
1681+
expect([...authorWarnedProperties('field')]).toEqual(['conditionalRequired', 'externalId']);
16791682
expect(
16801683
lintLivenessProperties({
16811684
objects: [{ name: 'widget', fields: [{ name: 'a', synthWarnedSlot: true }] }],

0 commit comments

Comments
 (0)