Repository navigation
Commit 62b3ec3
domain:server#1 · os-project-manager · session_01R1q2xdtYgU6FKrZ7LgjPCC
Fixes #28874
Clause-②: no
Metadata-protocol: none
## 维护者速读
- **改了什么**:三处注释改为说实话:代码包的 `objectExtensions` 从不存成 `object_extension`
条目,也不进 metadata 服务;ObjectQL 引擎的 `registerApp` 把每条注册为目标对象的 `'extend'`
贡献者。该类型的条目只有 `/api/v1/meta` 写入口存下的行。
- **为什么改**:原注释说制品加载器把它们存成该类型的条目,或作为单独集合存进 metadata 服务,误导读者。措辞与 #28873 的
spec 注册表行注释一致。
- **风险与回滚**:无行为变化,只改注释。回滚即还原本 PR。
-
**先看**:`packages/metadata-protocol/src/protocol-object-extension-item.ts`
头部注释。
- **两分钟验证**:`git diff origin/main -- packages/` 只有注释行。
- **需要你做的**:无,席位落地。
## What changes
Comment only, in three docblocks.
1. `packages/metadata-protocol/src/protocol-object-extension-item.ts`,
header (the card's site). It said "`object_extension` is the type the
artifact loader already stores a code package's `objectExtensions`
under". It now says they are never stored as items of this type:
`registerApp` registers each one as an `'extend'` contributor, and the
artifact loader maps the collection to this type but files no item from
it, because an extension carries `extend` and no `name`. This type's
items are the rows the `/api/v1/meta` doors write.
2. `packages/metadata-protocol/src/protocol.ts`, the
`foldObjectExtendersFromRegistry` docblock (triage's second site). It
said an artifact deployment registers `objects` and `objectExtensions`
into the metadata service "as SEPARATE collections". It now says only
`objects` reach that service, and gives the reason above.
3. **Third site, same drift:** `packages/objectql/src/registry.ts`, the
public `SchemaRegistry#foldObjectExtendersOnto` docblock, said the same
"stored as SEPARATE collections". Corrected the same way.
Read before writing:
- `packages/metadata/src/plugin.ts`: `ARTIFACT_FIELD_TO_TYPE` maps
`objectExtensions` to `object_extension`, and `artifactItemSlot` returns
no slot for a body with no `name`, so each registration loop skips it.
- `packages/objectql/src/engine.ts`: the `registerApp`
`objectExtensions` loop calls `registerObject(…, 'extend', priority)`.
A `git grep` for the drift phrases finds no other site.
**Changeset: patch** on `@objectstack/metadata-protocol` and
`@objectstack/objectql`. The corrected docblocks ship in each package's
`dist` declarations, and AGENTS.md rule 3 gives `none` a patch. ⛔ No
`packages/spec/**`, no code change, no new gate.
## Tests
<details><summary>Typecheck, lint, gates</summary>
No behaviour change, so there is no new test. Head `c1c35ba7`, after a
whole-repo `pnpm build` (exit 0):
- `pnpm typecheck` in full: metadata-protocol exit 0, objectql exit 0
(test-typecheck ledger unchanged);
- `eslint --no-inline-config src`: exit 0 for both packages;
- `dispatch-gates.mjs --commands` derived 57 (including
`check:dts-closure`, `check-dts-emitted`, the comment-mask and
drift-comment gates), all run, every exit 0. `--ran`: 57 derived, 57
run, 0 NOT-MEASURED.
</details>
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01FEkQ5oTRCUNQ4EA3YV84sZ
Co-authored-by: Claude <noreply@anthropic.com>
1 parent ff88105 commit 62b3ec3
4 files changed
Lines changed: 34 additions & 13 deletions
File tree
- .changeset
- packages
- metadata-protocol/src
- objectql/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
12 | 15 | | |
13 | 16 | | |
14 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9350 | 9350 | | |
9351 | 9351 | | |
9352 | 9352 | | |
9353 | | - | |
9354 | | - | |
9355 | | - | |
9356 | | - | |
| 9353 | + | |
| 9354 | + | |
| 9355 | + | |
| 9356 | + | |
| 9357 | + | |
| 9358 | + | |
| 9359 | + | |
9357 | 9360 | | |
9358 | 9361 | | |
9359 | 9362 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5326 | 5326 | | |
5327 | 5327 | | |
5328 | 5328 | | |
5329 | | - | |
5330 | | - | |
5331 | | - | |
5332 | | - | |
| 5329 | + | |
| 5330 | + | |
| 5331 | + | |
| 5332 | + | |
| 5333 | + | |
| 5334 | + | |
| 5335 | + | |
| 5336 | + | |
5333 | 5337 | | |
5334 | 5338 | | |
5335 | 5339 | | |
| |||
0 commit comments