Skip to content

Commit 6ae9d0e

Browse files
committed
fix(app-shell): no rule above the name-visible toggle when a user field shows it alone
Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QsR2jSxKwWNhQ9e5AS942Y
1 parent c5e024b commit 6ae9d0e

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

‎ui/packages/app-shell/src/views/metadata-admin/inspectors/ObjectFieldInspector.tsx‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1116,6 +1116,7 @@ export function ObjectFieldInspector({
11161116
<DisplayPatchLock>
11171117
<ReferenceNameVisibleField
11181118
value={def.referenceNameVisible === true}
1119+
divided={type === 'lookup'}
11191120
onCommit={(on) => (on ? patchDef({ referenceNameVisible: true }) : unsetDefKey('referenceNameVisible'))}
11201121
disabled={locked}
11211122
locale={locale}
@@ -2528,17 +2529,20 @@ function ReferenceNameVisibleField({
25282529
value,
25292530
onCommit,
25302531
disabled,
2532+
divided,
25312533
locale,
25322534
}: {
25332535
value: boolean;
25342536
onCommit: (on: boolean) => void;
25352537
disabled?: boolean;
2538+
/** Ruled off from the controls above it (a lookup's picker config); a `user` field shows it alone. */
2539+
divided?: boolean;
25362540
locale?: string;
25372541
}) {
25382542
const id = React.useId();
25392543
const helpId = `${id}-help`;
25402544
return (
2541-
<div className="space-y-1 border-t pt-2.5" data-testid="field-reference-name-visible">
2545+
<div className={divided ? 'space-y-1 border-t pt-2.5' : 'space-y-1'} data-testid="field-reference-name-visible">
25422546
<label htmlFor={id} className="flex items-center gap-2 text-xs cursor-pointer select-none">
25432547
<input
25442548
id={id}

0 commit comments

Comments
 (0)