Skip to content

Commit 70209b8

Browse files
test(ui): pin the 19th flow value-ledger entry, connector_action input.* (#28193)
<!-- claude-projects-attribution: {"github_login":"os-tesla"} --> _Requested by **Tesla** · [project thread](https://claude.ai/code/project/chan_01AXsQkLFKRdQCqQ3RTr6Jao?thread=cmsg_01AXsQkLFKRdQCqQ3RTr6JaoP61wgAn6oVSrkKUd7MGMz4)_ Fixes #28185 Fixes #28184 Clause-②: no Metadata-protocol: none ## 维护者速读 - 改了什么:只改一个测试文件,在 flow 值账本的固定清单里补上第 19 条 `connector_action:input.*`,并在注释里说明它来自 #27968 / #28150。 - 为什么改:#28150 给表达式账本新增了这一条,但 ui 里的测试还钉着旧的 18 条,导致 `main` 上 `Test UI` 变红,合并队列里的每个 PR 都被踢出。 - 风险与回滚:仅测试,不发布任何包,不改运行时行为;"六个键值映射"那条断言原样不动。回滚即 revert 本 PR。 - 先看:`ui/packages/app-shell/src/views/metadata-admin/inspectors/flow-value-envelope.test.ts` 第 71–82 行。 - 两分钟验证:`pnpm --dir ui exec vitest run packages/app-shell/src/views/metadata-admin/inspectors/flow-value-envelope.test.ts`,预期 11/11 通过。 - 需要你做的:无,席位落地。 ## What changes `flow-value-envelope.test.ts`, case "offers the envelope on exactly the six hand-table key/value maps the ledger names": the expected `value`-role list of `FLOW_NODE_EXPRESSION_PATHS` gains `'connector_action:input.*'` (sorted, between `assignment:assignments.*` and `create_record:fields.*`), and the comment above it says the list grew at #27968 / #28150 with the one entry rooted in `connectorConfig`. The six-map `offered` assertion is unchanged: `isValueEnvelopeSlot` answers only for `config`-rooted maps. ## Tests <details><summary>Red on origin/main c48cd2c → green with the fix</summary> ``` # origin/main c48cd2c pnpm --dir ui exec vitest run packages/app-shell/src/views/metadata-admin/inspectors/flow-value-envelope.test.ts :: exit 1 × offers the envelope on exactly the six hand-table key/value maps the ledger names + "connector_action:input.*", Tests 1 failed | 10 passed (11) # this branch pnpm --dir ui exec vitest run packages/app-shell/src/views/metadata-admin/inspectors/flow-value-envelope.test.ts :: exit 0 Tests 11 passed (11) ``` </details> ## Verification <details><summary>dispatch-gates --commands, re-derived against this diff</summary> ``` node scripts/check-closing-keyword-parity.mjs :: exit 0 node scripts/check-closing-keyword-parity.mjs --self-test :: exit 0 node scripts/check-comment-mask-corpus.mjs :: exit 0 node scripts/check-sdui-manifest.mjs :: exit 0 node scripts/check-sdui-manifest.mjs --self-test :: exit 0 pnpm --filter @objectstack/spec run check:duration-unit-keys :: exit 0 pnpm check:cross-package-test-inputs :: exit 0 pnpm check:dispatcher-error-vocabulary :: exit 0 pnpm check:driver-memory-census :: exit 0 pnpm check:engine-double-contract :: exit 0 pnpm check:gitlink-declared :: exit 0 pnpm check:nul-bytes :: exit 0 pnpm check:published-files :: exit 0 pnpm check:query-options-erasure :: exit 0 pnpm check:refd-timer-probe :: exit 0 pnpm check:skill-identifier-liveness :: exit 0 pnpm check:test-source-alias :: exit 0 pnpm check:tier-file-adoption :: exit 0 pnpm check:type-check-coverage :: exit 0 pnpm check:undeclared-dep-imports :: exit 0 pnpm check:watch-hint-literal :: exit 0 pnpm check:where-matcher :: exit 0 pnpm check:type-check-debt :: (re-running without the 300s cap; result in the os-dev-report comment) pnpm --dir ui exec vitest run scripts/ :: (running; result in the os-dev-report comment) ``` </details> ## Acceptance notes - Changeset: none. `@object-ui/app-shell` is private and its `files[]` (`dist`, `src/styles.css`, README, CHANGELOG, LICENSE) does not ship test sources, so the diff publishes nothing; `skip-changeset` rides the create. - #28184 (the merge-queue-triage anchor this red opened) closes with this PR, per the card's acceptance. - The Studio envelope editor for `connectorConfig.input` stays with #28164 (blocked); this PR does not touch it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01L9qibviuUXqPDLL8ToR4Nm Co-authored-by: Claude <noreply@anthropic.com>
1 parent 01178c0 commit 70209b8

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

‎ui/packages/app-shell/src/views/metadata-admin/inspectors/flow-value-envelope.test.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,14 @@ describe('isValueEnvelopeSlot — read off the spec expression ledger (objectui#
7171
// The ledger's whole `value`-role list at 18.0.0-next.0. The six `KEY.*`
7272
// maps above are the ones a key/value cell serves; the rest are single
7373
// values (a filter, a collection, a recipient list, a record id) or a
74-
// nested path, which this editor does not render per entry.
74+
// nested path, which this editor does not render per entry. The list grew
75+
// at #27968 / #28150 with the one entry rooted in `connectorConfig`
76+
// (`connector_action:input.*`), which `isValueEnvelopeSlot` does not offer.
7577
expect(
7678
FLOW_NODE_EXPRESSION_PATHS.filter((e) => e.role === 'value').map((e) => `${e.nodeType}:${e.path}`).sort(),
7779
).toEqual([
7880
'assignment:assignments.*',
81+
'connector_action:input.*',
7982
'create_record:fields.*',
8083
'delete_record:filter',
8184
'get_record:filter',

0 commit comments

Comments
 (0)