Skip to content

Commit 7686671

Browse files
committed
test(platform-objects): the two form-catalog count pins move by the dataset form's Duration row
The measures repeater's `duration` row adds one leaf to the dataset form and one authored row label per translated locale: the positive control goes 679 -> 680 and the dataset panel's leaf count 38 -> 39. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKPixnkg91qCkQCVFDJuqW
1 parent 3f3f095 commit 7686671

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

‎packages/platform-objects/src/apps/translations/object-lifecycle-panel-echo-decisions.test.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1217,7 +1217,10 @@ describe('#19403 round 10 — the verdicts, on the live bundles', () => {
12171217
// authored in all three locales.
12181218
// 679 since the flow form offers `requiredPermissions` (who may start the
12191219
// flow) — one row label, authored in all three locales.
1220-
expect(translated.length, `${locale} positive control`).toBe(679);
1220+
// 680 since the dataset form's measures repeater offers `duration` (the
1221+
// time between two datetime fields) — one row label, authored in all
1222+
// three locales.
1223+
expect(translated.length, `${locale} positive control`).toBe(680);
12211224
}
12221225
// ⭐ DARK — the blindness, executable. On a synthetic two-locale catalog the
12231226
// all-three predicate returns 0 while the per-locale one returns 1, so the

‎packages/platform-objects/src/apps/translations/report-form-echo-decisions.test.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
// echoes in two locales TODAY. It is OUT of this population, asserted by
6060
// name — a walk that over-reached into the object form would sweep in 32
6161
// undecided leaves, and the assertion is what notices. `datasetForm` —
62-
// the sibling semantic-layer panel, 38 leaves, 0 echoing — is excluded
62+
// the sibling semantic-layer panel, 39 leaves, 0 echoing — is excluded
6363
// too, and that exclusion is asserted rather than trusted precisely
6464
// because a wrong sweep of it would NOT go red.
6565
// (2) INWARD, AUTHORED. 38 of this population's own 44 leaves come back
@@ -889,7 +889,8 @@ describe('#19403 round 9 — the population, DERIVED from `reportForm`', () => {
889889
// It is fully authored, so a wrong sweep of it would NOT go red — which is
890890
// exactly why the exclusion is asserted instead of trusted.
891891
// 38 since #25330: the dimensions repeater offers `nullLabel`.
892-
expect(DATASET_LEAVES.length).toBe(38);
892+
// 39 since the measures repeater offers `duration`.
893+
expect(DATASET_LEAVES.length).toBe(39);
893894
const datasetEchoes = DATASET_LEAVES.filter((l) =>
894895
TRANSLATED_LOCALES.some(([, forms]) => forms.dataset?.[l.kind === 'section' ? 'sections' : 'fields']?.[l.path]?.[l.prop] === l.en),
895896
);

0 commit comments

Comments
 (0)