Skip to content

Commit 7b1ae33

Browse files
docs(adr): record the #28971 personal-view ruling at ADR-0131 D13 and ADR-0017 (#29321)
<!-- claude-projects-attribution: {"github_login":"os-steve"} --> _Requested by **Steve** · [project thread](https://claude.ai/code/project/chan_01FdL1XeUyvVNxLreh3F4Qi9?thread=cmsg_01FdL1XeUyvVNxLreh3F4Qi9GqmFgkV9YDorkr4xtiZg1i)_ Fixes #29038 Clause-②: no Metadata-protocol: none ## 维护者速读 - 改了什么:在 ADR-0131 D13 和 ADR-0017 的 `personal` 层下各追加一条日期注(2026-11-02),记录 #28971 的裁决 C。 - 为什么改:两份 ADR 仍把"个人视图"写成搁置方向;裁决后它是用户所有的数据对象,不是视图项,也不复用 `scope: 'personal'`。 - 风险与回滚:纯文档、只增不改,不发布任何包;回滚即 revert 本 PR。 - 先看:`docs/adr/0131-total-organization-ownership-no-null-organization-id.md` D13 后的注;`docs/adr/0017-object-has-many-view.md` 第 2 节 `personal` 条下的注。 - 两分钟验证:`git diff origin/main...HEAD --stat` 应只见两文件、+22/−0。 - 需要你做的:批准本 PR(docs/adr 是受管面,Tier H)。 ## What changes Two append-only dated notes, each citing the ruling of record `6570568131` on #28971 (letter C, maintainer 「同意」): - `docs/adr/0131-total-organization-ownership-no-null-organization-id.md`: a blockquote note after the D13 paragraph, before D14. - `docs/adr/0017-object-has-many-view.md`: an indented blockquote note under the `personal` bullet of section 2's "Three scopes" list. Each note says the three things the card asks for: 1. Named personal views are a user-owned D3 object, as D13 anticipated, so the direction is ruled, no longer parked. 2. They are not view items, and they do not reuse `scope: 'personal'`. 3. The first version follows #28949, #28948, #28950 and #28912. Each note also points at #29037 as the card that retires the inert `personal` declarations, and says the text it sits under stays as written and is read through the note. The ADR-0017 note also covers its Status line's "a per-user view scope is a parked v18 direction". No existing ADR text changes: the diff is +22 / −0. Neither Status line was edited (the card's acceptance says no other text changes); see Acceptance notes. ## Why ADR-0131 D13 called a per-user "personal view" scope "the parked v18 direction" and said that, if pulled, it "returns as a user-owned D3 object". The maintainer pulled it on #28971. Without a note, both records still read as parked. ## Verification Gates derived by `node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack` on head `29c1fd16`: 21 commands, all run, all exit 0. `--ran` reconciliation: 21 derived, 21 run, 0 NOT-MEASURED, 0 UNRUN (a DERIVED zero). <details><summary>Gate readings (head 29c1fd1)</summary> - `node scripts/check-adr-links.mjs` and `--self-test`: exit 0 - `node scripts/check-closing-keyword-parity.mjs` and `--self-test`: exit 0 - `node scripts/check-comment-mask-corpus.mjs`: exit 0 - `node scripts/ci/plan-test-core-shards.mjs --self-test`: exit 0 - `pnpm --filter @objectstack/lint run check:doc-formula-expressions`: exit 0 (after `turbo run build --filter='@objectstack/lint...'` under os-verify-lock, VERDICT command-exit 0) - `pnpm check:adr-anchors`, `check:adr-index`, `check:adr-symbol-anchors`: exit 0. `adr-index --report`: "docs/adr/README.md is current", so no index regeneration. - `pnpm check:ci-filter-parity`, `check:closed-ceremony-text`, `check:cross-package-test-inputs`, `check:doc-authoring`, `check:driver-memory-census`, `check:gitlink-declared`, `check:nul-bytes`, `check:pm-governed-merges`, `check:pm-prior-rulings`, `check:refd-timer-probe`, `check:watch-hint-literal`: exit 0 </details> Governed tier: `node scripts/pm/check-governed-merges.mjs --test` on both paths answers `governed: true`, `tier: "H"` (surface `docs/adr/**`). This PR stays a draft and waits for a GOVERNED_APPROVERS approval. No changeset: `docs/adr/**` publishes nothing, so the PR carries `skip-changeset`. No tests or packages are touched, so there are no forced test edits and no ablation. ## Acceptance notes - Neither ADR's `**Status**:` line gained an `Amended` entry. Both files use that line for amendments, but the card's acceptance says no other text in either ADR changes. If the reviewer wants a Status-line pointer, it is a one-line follow-up. --- _Generated by [Claude Code](https://claude.ai/code/session_01ADHkmPtNBPh7cTMHdPYPrT)_ --------- Co-authored-by: Claude <noreply@anthropic.com>
1 parent f129848 commit 7b1ae33

2 files changed

Lines changed: 25 additions & 0 deletions

File tree

‎docs/adr/0017-object-has-many-view.md‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,20 @@ has-many ViewItem.**
7070
- `shared` — authored at runtime, org-wide; gated by `view.manageShared`.
7171
- `personal` — authored at runtime, visible only to its `owner`;
7272
available to any user with object read.
73+
74+
> **Note (2026-11-02, ruling of record `6570568131` on
75+
> [#28971](https://github.com/objectstack-ai/objectstack/issues/28971), letter C, 「同意」) — named
76+
> personal views are a user-owned ADR-0131 D3 object, not this layer.** The per-user direction this bullet
77+
> describes, and that the Status line above calls "a parked v18 direction", is ruled: a reader's named
78+
> personal view is a row of a user-owned data object, as
79+
> [ADR-0131](./0131-total-organization-ownership-no-null-organization-id.md) D13 anticipated. It is not
80+
> a view item, and it does not reuse `scope: 'personal'`. The first version follows #28949, #28948,
81+
> #28950 and #28912. The same ruling sets two design constraints: a personal view's id does not use the
82+
> `<object>.<viewKey>` view-item name syntax, and no unnamed preference layer sits on top of a personal
83+
> view. They bear on how §3.1's `ViewItemNameSchema` and section 3's overlay text are read; that text
84+
> is unchanged. Retiring the inert `personal` declarations is #29037's, not this note's. The bullet and the
85+
> Status line stay as written, and this note governs how they are read.
86+
7387
- **Dual-read loader** — existing aggregated `defineView` containers are
7488
**auto-expanded** into ViewItems at load time *and* still registered
7589
under the bare `<object>` key, so legacy consumers keep working with no

‎docs/adr/0131-total-organization-ownership-no-null-organization-id.md‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -912,6 +912,17 @@ user-owned D3 object, not as this table. ADR-0017 carries the amendment note.
912912
D6/D7; only its reserved organization column goes (C0, before 17.3). Each retirement of an authorable
913913
shape is an [ADR-0087](./0087-metadata-protocol-upgrade-contract.md) entry.
914914

915+
> **Note (2026-11-02, ruling of record `6570568131` on [#28971](https://github.com/objectstack-ai/objectstack/issues/28971),
916+
> letter C, 「同意」) — named personal views are a user-owned D3 object; the direction is ruled, no longer
917+
> parked.** The paragraph above keeps a per-user "personal view" scope as "the parked v18 direction" and
918+
> says that, if pulled, it "returns as a user-owned D3 object, not as this table". The maintainer pulled
919+
> it: a reader's named personal view is a row of a user-owned data object, as this paragraph anticipated.
920+
> It is not a view item (ADR-0017's `ViewItem`), and it does not reuse `scope: 'personal'`;
921+
> `sys_view_definition` stays retired. The first version follows #28949, #28948, #28950 and #28912 and
922+
> gets its own execution card once the four cards above have landed. Retiring the inert `scope: 'personal'` and `sharing.type: 'personal'`
923+
> declarations is #29037's, not this note's. The paragraph stays as written, and this note governs how its
924+
> "parked" clause is read; ADR-0017 carries the matching note beside its `personal` layer.
925+
915926
### D14 — Staging: one pre-17.3 column fix, everything else on the v18 line
916927

917928
Maintainer, 2026-09-04: 「我发 17.3,然后后续这么大的改动应该放到 v18」. Two consequences:

0 commit comments

Comments
 (0)