You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 8269772
Browse filesBrowse the repository at this point in the historyBrowse files
fix(spec): mark clientSource as declared, not yet served, until the server slice reads it
Contract review 6569108322 on #28920:
- The key's describe carries `[PLANNED — not enforced]` and says what an
instance that declares it does meanwhile (held degraded off MCP over
http; dynamic registration on MCP over http). It names ADR-0143 D2.1,
not the tracker id, because check:doc-authoring refuses an issue id in
customer-facing spec prose; the adjacent comment names #28866.
Reference regenerated.
- The liveness ledger's `connector/auth` row records the key as `planned`
until #28866: the walker does not descend into the auth union, so that
row is the only ledger coordinate over it.
- A test pins the marker, the ADR reference, no tracker id in the
describe, and the ledger sentence, so #28866 drops them together.
- The authorization_code `credentialRef` describe names the installer form.
- ADR-0143: a pointer under D3's persisted list to the 2026-11-02 D2.1 note,
and the note's Slices bullet states the interim behaviour.
- The changeset names the marker and the ledger row.
Claude-Session: https://claude.ai/code/session_01ADHkmPS39tCwZRCvghgPQf
Co-authored-by: Claude <noreply@anthropic.com>
Copy file name to clipboardExpand all lines: .changeset/28864-oauth2-installer-client.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -31,6 +31,6 @@ connectors: [{
31
31
-**What it means.** The administrator of each deployment registers their own client with the vendor, against that deployment's callback, and enters its id and secret on the instance's connection. The definition names no client and no secret.
32
32
-**What it refuses.** A `clientId` beside `clientSource` is refused at publish, located at `auth.clientId`: the definition would name two clients. A `credentialRef` without its `clientId` is refused as before, and its message now names this form. An unknown value is refused at `auth.clientSource`. On `grant: 'client_credentials'` the key is refused with guidance, because that grant keeps no connection to enter a client on.
33
33
-**What it does not change.** The endpoints stay declared, or discovered on `provider: 'mcp'` over http: the installer owns the client, not the vendor's authorization server. An instance that names a pre-registered `clientId` without the key parses exactly as before. That form is kept for an app whose author registers the callback of every deployment that installs it, such as an organization's own app.
34
-
-**Not yet served.** The automation service does not read the key yet. The connection door that takes the installer's client, and the form that asks for it, land in follow-up changes. Until then an instance that declares it on a non-MCP provider is held degraded, with a reason naming the missing `clientId`, and is never called without a client. On `provider: 'mcp'` over http the service runs the MCP authorization flow as it does for an instance that leaves its client to dynamic registration.
34
+
-**Not yet served.** The automation service does not read the key yet. The connection door that takes the installer's client, and the form that asks for it, land in follow-up changes. Until then an instance that declares it on a non-MCP provider is held degraded, with a reason naming the missing `clientId`, and is never called without a client. On `provider: 'mcp'` over http the service runs the MCP authorization flow as it does for an instance that leaves its client to dynamic registration. The key's reference row carries `[PLANNED — not enforced]` until then, and the liveness ledger's `connector/auth` row records it as `planned`.
Copy file name to clipboardExpand all lines: content/docs/references/integration/connector.mdx
+8-8Lines changed: 8 additions & 8 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -270,8 +270,8 @@ const result = ConnectorSchema.parse(data);
270
270
|**clientId**|`string`| optional | OAuth2 client id of a pre-registered client (not a secret). Required, except where the client comes from elsewhere: `provider: 'mcp'` over http may register one dynamically, and with `clientSource: 'installer'` the administrator enters it on the connection, so it is not named here. |
271
271
|**grant**|`'authorization_code'`| ✅ | An administrator connects once; the platform refreshes the grant per dispatch. |
272
272
|**authorizationUrl**|`string`| optional | Authorization endpoint. Required (except `provider: 'mcp'` over http, which discovers it). |
273
-
|**clientSource**|`Enum<'installer'>`| optional | Where the OAuth client comes from. `'installer'`: the administrator of each deployment registers their own client with the vendor, against that deployment's callback, and enters its id and secret on the instance's connection, so the definition names no `clientId` and no `credentialRef`. Omit it to name a pre-registered `clientId` here, or to let `provider: 'mcp'` over http register a client. |
274
-
|**credentialRef**|`string`| optional | Secrets-layer reference resolved to the client secret of a pre-registered client (requires `clientId`). Omit for a public client. Never an inline secret. |
273
+
|**clientSource**|`Enum<'installer'>`| optional |[PLANNED — not enforced]Where the OAuth client comes from. `'installer'`: the administrator of each deployment registers their own client with the vendor, against that deployment's callback, and enters its id and secret on the instance's connection, so the definition names no `clientId` and no `credentialRef`. Omit it to name a pre-registered `clientId` here, or to let `provider: 'mcp'` over http register a client. Not served yet: the automation service reads it once the server half of the ADR-0143 D2.1 amendment lands. Until then, off `provider: 'mcp'` over http, an instance that declares it is held degraded for a missing `clientId`; on `provider: 'mcp'` over http the provider registers a client dynamically instead of taking the installer's. |
274
+
|**credentialRef**|`string`| optional | Secrets-layer reference resolved to the client secret of a pre-registered client (requires `clientId`). Omit for a public client, and with `clientSource: 'installer'`, where the administrator enters the secret on the connection. Never an inline secret. |
@@ -565,8 +565,8 @@ This schema accepts one of the following structures:
565
565
|**clientId**|`string`| optional | OAuth2 client id of a pre-registered client (not a secret). Required, except where the client comes from elsewhere: `provider: 'mcp'` over http may register one dynamically, and with `clientSource: 'installer'` the administrator enters it on the connection, so it is not named here. |
566
566
|**grant**|`'authorization_code'`| ✅ | An administrator connects once; the platform refreshes the grant per dispatch. |
567
567
|**authorizationUrl**|`string`| optional | Authorization endpoint. Required (except `provider: 'mcp'` over http, which discovers it). |
568
-
|**clientSource**|`Enum<'installer'>`| optional | Where the OAuth client comes from. `'installer'`: the administrator of each deployment registers their own client with the vendor, against that deployment's callback, and enters its id and secret on the instance's connection, so the definition names no `clientId` and no `credentialRef`. Omit it to name a pre-registered `clientId` here, or to let `provider: 'mcp'` over http register a client. |
569
-
|**credentialRef**|`string`| optional | Secrets-layer reference resolved to the client secret of a pre-registered client (requires `clientId`). Omit for a public client. Never an inline secret. |
568
+
|**clientSource**|`Enum<'installer'>`| optional |[PLANNED — not enforced]Where the OAuth client comes from. `'installer'`: the administrator of each deployment registers their own client with the vendor, against that deployment's callback, and enters its id and secret on the instance's connection, so the definition names no `clientId` and no `credentialRef`. Omit it to name a pre-registered `clientId` here, or to let `provider: 'mcp'` over http register a client. Not served yet: the automation service reads it once the server half of the ADR-0143 D2.1 amendment lands. Until then, off `provider: 'mcp'` over http, an instance that declares it is held degraded for a missing `clientId`; on `provider: 'mcp'` over http the provider registers a client dynamically instead of taking the installer's. |
569
+
|**credentialRef**|`string`| optional | Secrets-layer reference resolved to the client secret of a pre-registered client (requires `clientId`). Omit for a public client, and with `clientSource: 'installer'`, where the administrator enters the secret on the connection. Never an inline secret. |
570
570
571
571
---
572
572
@@ -604,8 +604,8 @@ This schema accepts one of the following structures:
604
604
|**clientId**|`string`| optional | OAuth2 client id of a pre-registered client (not a secret). Required, except where the client comes from elsewhere: `provider: 'mcp'` over http may register one dynamically, and with `clientSource: 'installer'` the administrator enters it on the connection, so it is not named here. |
605
605
|**grant**|`'authorization_code'`| ✅ | An administrator connects once; the platform refreshes the grant per dispatch. |
606
606
|**authorizationUrl**|`string`| optional | Authorization endpoint. Required (except `provider: 'mcp'` over http, which discovers it). |
607
-
|**clientSource**|`Enum<'installer'>`| optional | Where the OAuth client comes from. `'installer'`: the administrator of each deployment registers their own client with the vendor, against that deployment's callback, and enters its id and secret on the instance's connection, so the definition names no `clientId` and no `credentialRef`. Omit it to name a pre-registered `clientId` here, or to let `provider: 'mcp'` over http register a client. |
608
-
|**credentialRef**|`string`| optional | Secrets-layer reference resolved to the client secret of a pre-registered client (requires `clientId`). Omit for a public client. Never an inline secret. |
607
+
|**clientSource**|`Enum<'installer'>`| optional |[PLANNED — not enforced]Where the OAuth client comes from. `'installer'`: the administrator of each deployment registers their own client with the vendor, against that deployment's callback, and enters its id and secret on the instance's connection, so the definition names no `clientId` and no `credentialRef`. Omit it to name a pre-registered `clientId` here, or to let `provider: 'mcp'` over http register a client. Not served yet: the automation service reads it once the server half of the ADR-0143 D2.1 amendment lands. Until then, off `provider: 'mcp'` over http, an instance that declares it is held degraded for a missing `clientId`; on `provider: 'mcp'` over http the provider registers a client dynamically instead of taking the installer's. |
608
+
|**credentialRef**|`string`| optional | Secrets-layer reference resolved to the client secret of a pre-registered client (requires `clientId`). Omit for a public client, and with `clientSource: 'installer'`, where the administrator enters the secret on the connection. Never an inline secret. |
609
609
610
610
611
611
---
@@ -876,8 +876,8 @@ Connector type
876
876
|**clientId**|`string`| optional | OAuth2 client id of a pre-registered client (not a secret). Required, except where the client comes from elsewhere: `provider: 'mcp'` over http may register one dynamically, and with `clientSource: 'installer'` the administrator enters it on the connection, so it is not named here. |
877
877
|**grant**|`'authorization_code'`| ✅ | An administrator connects once; the platform refreshes the grant per dispatch. |
878
878
|**authorizationUrl**|`string`| optional | Authorization endpoint. Required (except `provider: 'mcp'` over http, which discovers it). |
879
-
|**clientSource**|`Enum<'installer'>`| optional | Where the OAuth client comes from. `'installer'`: the administrator of each deployment registers their own client with the vendor, against that deployment's callback, and enters its id and secret on the instance's connection, so the definition names no `clientId` and no `credentialRef`. Omit it to name a pre-registered `clientId` here, or to let `provider: 'mcp'` over http register a client. |
880
-
|**credentialRef**|`string`| optional | Secrets-layer reference resolved to the client secret of a pre-registered client (requires `clientId`). Omit for a public client. Never an inline secret. |
879
+
|**clientSource**|`Enum<'installer'>`| optional |[PLANNED — not enforced]Where the OAuth client comes from. `'installer'`: the administrator of each deployment registers their own client with the vendor, against that deployment's callback, and enters its id and secret on the instance's connection, so the definition names no `clientId` and no `credentialRef`. Omit it to name a pre-registered `clientId` here, or to let `provider: 'mcp'` over http register a client. Not served yet: the automation service reads it once the server half of the ADR-0143 D2.1 amendment lands. Until then, off `provider: 'mcp'` over http, an instance that declares it is held degraded for a missing `clientId`; on `provider: 'mcp'` over http the provider registers a client dynamically instead of taking the installer's. |
880
+
|**credentialRef**|`string`| optional | Secrets-layer reference resolved to the client secret of a pre-registered client (requires `clientId`). Omit for a public client, and with `clientSource: 'installer'`, where the administrator enters the secret on the connection. Never an inline secret. |
Copy file name to clipboardExpand all lines: packages/spec/liveness/connector.json
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -64,7 +64,7 @@
64
64
"verifiedAt": "2026-09-17",
65
65
"evidence": "packages/services/service-automation/src/plugin.ts#materializeDeclaredConnectors — `auth = await this.resolveInstanceAuth(entry.auth, resolver, name, provider)` resolves the declared `credentialRef` through the secrets/env layer and puts the RESOLVED credential on the provider context; a failure there degrades or fails the instance by name (ADR-0097 §3). packages/connectors/connector-rest/src/rest-provider.ts, packages/connectors/connector-openapi/src/openapi-provider.ts and packages/connectors/connector-mcp/src/mcp-provider.ts each read `ctx.auth` and use it to sign the upstream call. packages/spec/src/integration/connector.zod.ts#DeclarativeConnectorEntrySchema refuses it on an entry with no `provider`.",
66
66
"producer": "packages/services/service-automation/src/plugin.ts#materializeDeclaredConnectors — the ADR-0097 reconcile: it builds the desired set from the declared `connectors:` items, resolves the provider factory and calls `engine.registerConnector(def, handlers, 'declarative')`. This is the ONLY seam by which an authored entry reaches the connector registry, so it is the producer every `live` row below depends on (#4837): without it a declared connector is a stored document and nothing else.",
67
-
"note": "The live half of the pair whose other half (`authentication`) is refused ANY VALUE BUT `{ type: 'none' }` — the key itself is accepted and inert, so ⛔ do not compress this to '`authentication` is refused' (see that row): this key is how an authored connector carries a credential at all, and it carries a REFERENCE, never the secret."
67
+
"note": "The live half of the pair whose other half (`authentication`) is refused ANY VALUE BUT `{ type: 'none' }` — the key itself is accepted and inert, so ⛔ do not compress this to '`authentication` is refused' (see that row): this key is how an authored connector carries a credential at all, and it carries a REFERENCE, never the secret. 2026-11-02 (#28864): one member of this union is `planned`, not `live` — `clientSource` on the `oauth2` `authorization_code` shape (ADR-0143 D2.1 amendment), until #28866 makes the automation service read the installer's client from the connection. The walker does not descend into the `auth` union, so this row's `live` verdict is the only ledger coordinate over the key and would otherwise cover it unseen; its `.describe()` carries `[PLANNED — not enforced]`. Meanwhile an instance that declares it is held degraded for a missing `clientId` off `provider: 'mcp'` over http (`oauth2NotServableReason` in service-automation's plugin.ts), and on MCP over http the provider registers a client dynamically instead of taking the installer's. When #28866 lands, drop this sentence and the marker together."
0 commit comments