Skip to content

Commit 88531fa

Browse files
chore(ui-tooling): drop the dead turbo globalDependencies marker and three scripts nothing runs (slice 1 of #25920) (#26004)
<!-- claude-projects-attribution: {"github_login":"os-elon-musk"} --> _Requested by **Elon** · [project thread](https://claude.ai/code/project/chan_01WedDzV26nniwxv7jC88B9D?thread=cmsg_01WedDzV26nniwxv7jC88B9D7sHdFfY8QjwRsxKSLngGfv)_ Part of #25920 — slice 1 of the unwired-tooling cleanup. The card stays open for the slices listed at the end. ## Summary Re-measured on `main` 05f7758 (after the objectui merge, so every card path reads with a `ui/` prefix). Of the 68 `check:*` / `census:*` names in `ui/package.json`, 28 are run by no root workflow; 13 of those are still referenced from the inert `ui/.github/workflows` (left to the `ui/.github` retirement), 1 is run by package build scripts, and the rest plus the test-only censuses come to about 25,000 lines of script and test. That is far over one PR, so this slice takes the dead turbo entry and the three files with no reference at all, at 1,485 changed lines (+5 / −1,480). Per item: - `ui/turbo.objectui.json` `globalDependencies` → **delete the entry.** It named `node_modules/@objectstack/spec/.spec-main-shape-gate.json`, a marker only objectstack's spec injection wrote. `@objectstack/spec` is `workspace:^` in all 33 ui manifests now and nothing in the tree writes the marker (`git grep spec-main-shape` outside CHANGELOGs: only this entry, one test fixture path string, and the guide paragraph). The ci-cd-pipeline guide's "What stays here" bullet, which justified the entry, is rewritten. - `ui/scripts/eval-console.mjs` → **delete.** A one-off Playwright probe that writes to a hard-coded path on one developer's machine. No alias, no workflow, zero references. - `ui/scripts/release-bump.cjs` → **delete.** A manual version bumper the changesets release lane replaced. No alias, no workflow, zero references. - `ui/scripts/census-recorder-wait-shape.mjs` + its test + `fixtures/census-recorder-wait-shape/` → **delete.** A hand-run census (its header: "answers WHERE TO LOOK, never WHAT IS WRONG"); no alias, no workflow, nothing names it but its own test. Nothing is wired in this PR: the triage comment on the card puts any new gate with the maintainer, so the gate-shaped scripts are listed below for a ruling instead. ## Verification (head f7fda0f) - Exact-name `git grep` across the whole tree (AGENTS.md, skills, .claude, docs, every manifest) for each deleted file and alias: no hits outside the deleted files themselves. No governed text touched. - `dispatch-gates --commands` derived 18 families; all 18 run locally, all exit 0; `--ran` reconciliation: 18 derived, 18 run, 0 NOT MEASURED, 0 UNRUN. - Inventory readers: `node scripts/check-ci-filter-parity.mjs` exit 0 and `--self-test` exit 0; `node scripts/pm/dispatch-gates.self-test.mjs` exit 0. - ui suites that read the turbo config or the scripts inventory (14 files: select-type-check-scope, the five turbo-* input/output pins, turbo-task-guard-coverage, workspace-root, ci-cd-pipeline-doc, markdown-test-inputs, check-unreferenced-sources, package-scripts-vitest-projects, vitest-invocation-guard, check-dist-completeness): 14 files, 533 tests passed. - The 50 `pnpm --dir ui run …` gate commands root `ci.yml` runs: 43 exit 0 (`check:spec-symbols`, `check:action-forward-parity`, `check:designer-field-key-parity` and `type-check:scripts` first ran before `packages/spec/dist` existed and are green on a re-run after it was built). The other 7 (`check:doc-examples`, `check:doc-json`, `check:doc-snippets`, `check:readme-exports`, `check:skill-examples` and its `--self-test`, `type-check:vitest-setup`) stop on unbuilt `@object-ui/*` `dist/` (each prints the missing path): NOT MEASURED locally, CI's Lint UI / Type Check UI lanes own them. None of their output names a deleted file. - `check:commit-card-trailers --range origin/main..HEAD` green. - No changeset: nothing under any package's published `files[]` changes (ui scripts, the parked turbo config and a guide page). ## Remaining slices (numbers are script + test lines on 05f7758) Delete candidates — report-only instruments no gate reads: | Script (alias) | Lines | Note | |---|---|---| | `coverage-red-cause-census.mjs` + `coverage-red-cause-suspects.json` | 617 | test-only; one `markdown-test-inputs.mjs` row | | `extract-mdx-demos.mjs` | 683 | test-only; one-off MDX migration tool | | `tsconfig-test-parity-census.mjs` (`census:tsconfig-test-parity`) | 430 | named as the instrument by six test comments, one tsconfig comment and `ui/docs/audits/2026-09-test-tsconfig-parity-census.md`; those pointers move with it | | `page-key-read-census.mjs` (`census:page-key-reads`) | 1,146 | exit 0 by design | | `dollar-dialect-alias-census.mjs` (`census:dollar-dialect-aliases`) | 1,109 | exit 0 by design | | `changeset-polarity-census.mjs` (`census:changeset-polarity`) | 3,525 | exit 0 by design; includes fixtures | | `check-component-surface-parity.mjs` (`check:component-surface-parity`) | 2,584 | exit 0 always; its header quotes a director ruling's authority order | | six unbuilt CLI aliases (`cli`, `objectui`, `doctor`, `studio`, `generate`, `g`), `start`, `site:start`, `test:unit`, `test:integration` | ~10 | manifest lines only; `build:all` is already gone | Gate-shaped (exit 1 on a breach) — wire-or-delete is a maintainer ruling per the card's triage: | Script (alias) | Lines | |---|---| | `check-lint-rule-coverage.mjs` | 1,814 | | `check-unused-dependencies.mjs` | 1,099 | | `check-registry-bare-name-collisions.mjs` | 994 | | `check-comment-mask-corpus.mjs` + test-only `check-hand-rolled-comment-mask.mjs` | 1,279 + 715 | | `check-ui-root-lookups.mjs` | 785 | | `check-pending-changeset-literals.mjs` | 403 | | `body-dialect-census.mjs` / `body-dialect-producer-scan.mjs` (ruling objectui#6771 calls the liveness reading a hard gate; imported by other scripts) | 1,658 + 1,794 | Kept: `check:dist-completeness` (run by 14 package `build` scripts); `cross-file-line-citation-census.mjs` (library of the line-citation gate). Left to the `ui/.github` retirement (referenced only by `ui/.github/workflows`): `check:i18n-dead-keys`, `check:node-esm-load`, `check:published-dist`, `check:eager-closure`, `check:eager-locale-catalogues`, `check:sdui-registration-pins`, `check:governed-queue-guard`, `check:merge-queue-head`, `check:required-check-set`, `check:lockfile-integrity`, `check:lockfile-dedupe`, `check:changeset-claims`, `check:new-line-citations`. Later slice under this dispatch: the mechanical tsconfig dedupe. Not in this dispatch: the dedupe-wrapper swap (a workflow change), the vite factory, the UMD condition. ## Acceptance notes - The ci-cd-pipeline guide's "Spec Shape Gate — moved to objectstack" section still describes `spec-shape-gate.yml` hourly runs that no longer exist in this repository; only the bullet this diff falsified is rewritten here. --- _Generated by [Claude Code](https://claude.ai/code/session_012eXtKYmXEnCc1GExP4go12)_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_012eXtKYmXEnCc1GExP4go12 Co-authored-by: Claude <noreply@anthropic.com>
1 parent c86c823 commit 88531fa

13 files changed

Lines changed: 5 additions & 1480 deletions

‎ui/content/docs/guide/ci-cd-pipeline.md‎

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2167,15 +2167,11 @@ those cards and in git history.
21672167
`scripts/ci/spec-shape-retirements.json`, beside the objectui card that removes the downstream
21682168
use. The gate reads a diagnostic matching a registered retirement as known rather than new;
21692169
that file's own header states the entry grammar and when an entry is deleted.
2170-
- **What stays here.** `turbo.json` still names
2171-
`node_modules/@objectstack/spec/.spec-main-shape-gate.json` in `globalDependencies`. objectstack's
2172-
injection writes that marker — the name is kept on purpose — into every copy of the spec it
2173-
replaces, so a tree holding an injected spec never shares a turbo hash with an installed one. That
2174-
matters when somebody reproduces the gate locally in a linked worktree, whose `.turbo/cache` is
2175-
shared with its siblings: a forced run skips cache reads but still writes, and without the marker
2176-
an ordinary `pnpm type-check` in a sibling could replay a verdict taken against the injected spec
2177-
([#12114](https://github.com/objectstack-ai/objectui/issues/12114)). An installed tree carries no
2178-
marker, and an absent global dependency hashes as nothing.
2170+
- **What stays here.** Nothing. `turbo.json` used to name
2171+
`node_modules/@objectstack/spec/.spec-main-shape-gate.json` in `globalDependencies`, a marker the
2172+
objectstack injection wrote into every copy of the spec it replaced. Since this tree became the
2173+
`ui/` workspace of objectstack the spec is a workspace package, nothing writes the marker, and
2174+
[objectstack#25920](https://github.com/objectstack-ai/objectstack/issues/25920) removed the entry.
21792175

21802176

21812177
## Release Workflows

‎ui/scripts/__tests__/census-recorder-wait-shape.test.ts‎

Lines changed: 0 additions & 152 deletions
This file was deleted.

‎ui/scripts/__tests__/fixtures/census-recorder-wait-shape/f1-member-push-member-read.fixture.ts‎

Lines changed: 0 additions & 20 deletions
This file was deleted.

‎ui/scripts/__tests__/fixtures/census-recorder-wait-shape/f2-member-push-bare-read.fixture.ts‎

Lines changed: 0 additions & 22 deletions
This file was deleted.

‎ui/scripts/__tests__/fixtures/census-recorder-wait-shape/f3-bare-push-member-read.fixture.ts‎

Lines changed: 0 additions & 23 deletions
This file was deleted.

‎ui/scripts/__tests__/fixtures/census-recorder-wait-shape/f4-window-crosses-test.fixture.ts‎

Lines changed: 0 additions & 57 deletions
This file was deleted.

‎ui/scripts/__tests__/fixtures/census-recorder-wait-shape/f5-window-truncated.fixture.ts‎

Lines changed: 0 additions & 24 deletions
This file was deleted.

‎ui/scripts/__tests__/fixtures/census-recorder-wait-shape/f6-absence-read-must-stay-flagged.fixture.ts‎

Lines changed: 0 additions & 30 deletions
This file was deleted.

‎ui/scripts/__tests__/fixtures/census-recorder-wait-shape/harness.ts‎

Lines changed: 0 additions & 30 deletions
This file was deleted.

0 commit comments

Comments
 (0)