Repository navigation
Commit 99fa527
docs(skills): teach connector_action input as an evaluated value slot and the openapi include allowlist (#28012)
<!-- claude-projects-attribution: {"github_login":"os-elon-musk"} -->
_Requested by **Elon** · [project
thread](https://claude.ai/code/project/chan_01WedDzV26nniwxv7jC88B9D?thread=cmsg_01WedDzV26nniwxv7jC88B9DQaSHbveqsCnSo8ERWam3N6)_
domain:skills#2 · os-elon-musk · session_016WV4cwkH2Pj7G4DWB8WTaf
Fixes #27982
The family card folds #27987 (closed by triage as a duplicate of this
card), so its two locations are fixed here too.
## What changes
The automation skill re-teaches two things from the code, at the five
locations the card lists:
1. `skills/objectstack-automation/SKILL.md`, the `connector_action` row:
`connectorConfig.input` is a value-slot map like `subflow` `input`; `os
validate` does not judge it yet, so a malformed envelope fails at run
time. (Was: "sent as written — no CEL or `{{ }}` in it".)
2. `references/integration-recipes.md`, the "Holds on every recipe"
input bullet: a top-level CEL envelope is evaluated, any other value is
sent as written (`{…}` and `{{ }}` are literal text), with one example
that reads a record field into the input (`input: { customer: { dialect:
'cel', source: 'record.stripe_id' } }`), and the same registration-gap
note.
3. `references/integration-recipes.md`, recipe 1's closing sentence:
`providerConfig.include` allowlists operation keys as the `mcp`
provider's does (absent = every operation; a non-array or unknown entry
is fatal); trimming still keeps the package small. (Was: "The `openapi`
provider has no `include` key — the trimmed document is the allowlist".)
4. and 5. `evals/integrations-declared.json` case 1 `expected_output`:
the trimmed document stays, with `include` named as the alternative
allowlist; the per-contract payload now reads the record through a CEL
envelope, so the "Three gaps" become two. Assertions are unchanged.
Plus a `@objectstack/skills` patch changeset and one ratchet row
(below).
## Why
- **Input slot.**
`packages/services/service-automation/src/builtin/connector-nodes.ts`
(after PR #27980) calls `resolveValueSlotMap(engine, cfg.input,
variables, 'input', context)` before dispatch.
`builtin/value-slot-map.ts` lists `connector_action`
`connectorConfig.input` beside `subflow`/`map` `input`, `script`
`inputs`, `screen` `defaults` and `notify` `templateData`: an
envelope-shaped top-level value is evaluated, a malformed one throws,
and every other value is a literal copy.
- **Registration gap.** #27968 measured that a malformed CEL envelope, a
template envelope and a bare `'{rec.id}'` all register under
`connectorConfig.input`, because the spec ledger
`FLOW_NODE_EXPRESSION_PATHS` only addresses `node.config`. The texts
therefore do not tell the author that a `{…}` token there is refused (as
Valid-but-silently-wrong item 1 says for the ledger slots); they say it
is literal text. The skill names no card number, as elsewhere in the
skills tree.
- **`include`.**
`packages/connectors/connector-openapi/src/openapi-provider.ts:54-84`
declares `providerConfig.include` with "the same allowlist meaning as
the `mcp` provider's `include`"; `resolveIncludeList` returns
`undefined` when absent and throws on a non-array or a non-string entry;
`:293-298` refuses an entry the document does not carry.
## Token budget
- `SKILL.md`: 6457 / 6457, no row change. Paid in the same file by
cutting the row's restatement "(a `connectors:` entry with a `provider`,
…)" of § *Integrations are declared, not coded*.
- `references/integration-recipes.md`: 2204 → 2236 (+32). Three
same-file restatements cut first: recipe 1's comment "3.x only, … every
`$ref` dereferenced offline" (the paragraph under the recipe says it),
recipe 5's ", written from the vendor's docs" (its heading says it), the
OAuth bullet's "four variants and" (the Holds `auth` bullet lists them).
The remainder moves the row on the standing path: maintainer ruling
2026-10-27 「A:先削重复,余额按实测提高」, made the gate-recognised path by ruling
record 6513306068 on #27847. Arithmetic is in the row comment.
- The eval file is measured, not ratcheted (6513306068);
`ui/scripts/check-skill-eval-tokens.mjs` is green (every `must_contain`
token taught by its bundle).
## Verification
Head `1f28d891`, base `origin/main` `8f41b2d1`. `node
scripts/pm/dispatch-gates.mjs --commands` derives 64 families;
reconciled with `--ran`: **60 exit 0, 4 NOT MEASURED, 0 red, 0 unrun.**
- Green, among them: `check-skills-token-ratchet.mjs` (and
`--self-test`), `check:skill-docs`, `check:skill-refs`,
`check:skill-compatibility`, `check:skill-frame-sync`,
`check:skill-identifier-liveness`, `check:pm-skill-id-lint`,
`check-changeset-no-major`, `check-empty-changeset`,
`check-closing-keyword-parity`, `check:doc-formula-expressions` (after
`turbo run build --filter=@objectstack/formula
--filter=@objectstack/lint`).
- Also run by hand: `node ui/scripts/check-skill-eval-tokens.mjs` exit
0; `integrations-declared.json` parses, its assertions are unchanged,
and the new `expected_output` holds every `must_contain` token and no
`must_not_contain` token.
- NOT MEASURED (exit 3, prerequisite: a whole-tree `dist`):
`check:dts-closure`, `check:dual-build-cjs-loads`,
`check:lean-entry-closure`, `check:sourcemap-no-sources-content`. This
diff touches no package source or build output; CI sweeps them.
Clause-②: no
Metadata-protocol: none
## Human Minimum
- [x] 1. Schemas start as Zod; `packages/spec` holds no runtime logic.
(not touched)
- [x] 2. Every name I added uses the casing for its kind. (no names
added)
- [x] 3. No formatter ran; `pnpm lint` passes. (no lint-covered source
changed)
- [x] 4. One issue, one branch off an up-to-date `main`, one pull
request.
- [x] 5. A change that publishes carries a changeset, and both
declaration lines are filled in here and in the changeset.
- [x] 6. `packages/spec` touched: n/a.
- [x] 7. No hand edits to `content/docs/references/`,
`packages/*/CHANGELOG.md` or `content/docs/releases/`.
- [x] 8. Title, body and comments are in English (the 维护者速读 block is the
repo's Chinese channel).
## Acceptance notes
- None beyond the card. The registration half stays on #27968.
## 维护者速读
- 改了什么:自动化技能三个文件五处文字:连接器节点的 `input` 改教为会求值的值槽,`openapi` 提供方改教为有
`include` 白名单;评测用例 1 随之更正。
- 为什么改:执行器已按值槽求值 `input`(#27980),`include` 也已上线(#27387),旧文字会让 AI
把按记录取值当成平台缺口、把裁剪文档当成唯一白名单。
- 风险与回滚:只改说明文字与评测期望,不动代码;回滚即还原本 PR。
- 先看:`skills/objectstack-automation/references/integration-recipes.md` 的
Holds 第二条与配方 1 末句。
- 两分钟验证:`node scripts/check-skills-token-ratchet.mjs` 与 `node
ui/scripts/check-skill-eval-tokens.mjs` 均为 0。
- 需要你做的:contract review owed(fable),席位复核 PASS 之前不求批。
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_016WV4cwkH2Pj7G4DWB8WTaf
Co-authored-by: Claude <noreply@anthropic.com>1 parent ab75996 commit 99fa527
5 files changed
Lines changed: 43 additions & 10 deletions
File tree
- .changeset
- scripts
- skills/objectstack-automation
- evals
- references
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
868 | 868 | | |
869 | 869 | | |
870 | 870 | | |
871 | | - | |
| 871 | + | |
| 872 | + | |
| 873 | + | |
| 874 | + | |
| 875 | + | |
| 876 | + | |
| 877 | + | |
| 878 | + | |
| 879 | + | |
| 880 | + | |
| 881 | + | |
| 882 | + | |
| 883 | + | |
| 884 | + | |
| 885 | + | |
| 886 | + | |
| 887 | + | |
| 888 | + | |
| 889 | + | |
872 | 890 | | |
873 | 891 | | |
874 | 892 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
| 88 | + | |
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
19 | | - | |
20 | | - | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
34 | | - | |
| 35 | + | |
35 | 36 | | |
36 | 37 | | |
37 | 38 | | |
| |||
60 | 61 | | |
61 | 62 | | |
62 | 63 | | |
63 | | - | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
64 | 67 | | |
65 | 68 | | |
66 | 69 | | |
| |||
124 | 127 | | |
125 | 128 | | |
126 | 129 | | |
127 | | - | |
| 130 | + | |
128 | 131 | | |
129 | 132 | | |
130 | 133 | | |
| |||
141 | 144 | | |
142 | 145 | | |
143 | 146 | | |
144 | | - | |
| 147 | + | |
145 | 148 | | |
146 | 149 | | |
147 | 150 | | |
| |||
0 commit comments