Skip to content

Commit b0c2209

Browse files
pm-dispatch(review): the seat requests the approvers in the same round as its ACCEPT, large-diff PRs included, and never reports "awaiting approval" before the request is sent (#30045)
<!-- claude-projects-attribution: {"github_login":"os-support-ai"} --> _Requested by **Yibo Wang** · [project thread](https://claude.ai/code/project/chan_01BVUyyPie8gHwoPM18iABwB?thread=cmsg_01BVUyyPie8gHwoPM18iABwB1HYv38UREmspmKSByfEg1B)_ No card: maintainer-directed in the project thread (「修改 pm-dispatch/os-dev 技能」, after 「为什么等我批的现在没有推送給 os-zhuang,是技能的问题吗」). ## 维护者速读 - 改了什么:`SKILL.md`〈路径分叉〉三行就地改写(行数不变):③ 请审在席位 ACCEPT + 现 head PASS 落案的**同一轮**发出;>3000 行 PR 明写也走 ③ 请审;④ 轮报现读请审人,**没请审就不许在聊天里说「等你批」**。 - 为什么改:规则(10-29 的 #27385)本来就要求席位交棒时请审 os-zhuang/hotlong,但席位没执行:#30028 已有 ACCEPT + 同 head PASS 却无人被请;#29993、#29998 这类 >3000 行拆分 PR 被「Tier S 不交人」误读成不请;聊天里却报了「等你批」。 - 风险与回滚:只改技能文本 3 行,不动脚本、门禁、workflow;回滚 = revert 本 PR。 - 先看:`.claude/skills/pm-dispatch/SKILL.md` L187、L197、L201。 - 两分钟验证:`pnpm check:pm-skill-ratchet && pnpm check:pm-skill-id-lint && pnpm check:skill-frame-sync`,三条皆绿(行数 319/319,每行 ≤120 字节)。 - 需要你做的:审阅并批准本 PR(`.claude/**` 属 Tier S,但这是 PM 自身规则 PR,按〈路径分叉〉末行留给维护者)。 ## What changes `.claude/skills/pm-dispatch/SKILL.md`, three lines rewritten in place (319 lines before and after, each ≤120 bytes): - **L197, step ③:** the approver request (`pr_request_reviewers`) goes out in the **same round** that the seat's ACCEPT and a same-head contract PASS are both on record, not "after" at some later point. - **L187, the >3000-line rule:** it already swaps ACCEPT for the four end-of-review steps with no Tier S exception; it now names step ③ explicitly, so L198's "Tier S hands off to nobody" no longer reads as covering a large diff on ungoverned paths (the split PRs). - **L201, step ④:** the round report reads the requested reviewers live, and a seat never reports a PR to the maintainer in chat as awaiting approval before the request is on the PR; it sends the request first. `os-dev.md` is unchanged: a dev's `pr_create` still carries no assignees and requests nobody. That is the rule the maintainer asked for on 2026-10-29 (「这个是技能的bug,应该是开发完了你审核通过才会推送给我审核」, 「审核人是 os-zhuang 和 hotlong」), landed in #27385, and this PR keeps it. Only the seat-side hand-off is tightened. ## Why Measured on 2026-11-04 ~10:10Z, the six PRs reported in chat as waiting for the maintainer: | PR | Seat ACCEPT on current head | PASS on current head | Requested reviewers before | os-zhuang review | |:--|:--|:--|:--|:--| | #29968 | yes | yes | none | APPROVED | | #30004 | yes | yes | none | APPROVED | | #30028 | yes (09:11Z) | yes | **none** | none | | #29993 (35,227 lines) | no | no (PASS names an older head) | **none** | none | | #29998 (24,422 lines) | no | no | **none** | none | | #30030 | no | yes | **none** | none | #30028 was a due hand-off with no request. The two splits are over 3000 lines and owe the same end-of-review steps, but L198's "Tier S hands off to nobody" plus a patrol (H43) that reads only register paths left them with no request and no warning. As a one-off, `os-zhuang` was requested on #30028, #29993, #29998 and #30030 from the project thread; #29968 and #30004 already carry an `os-zhuang` approval, so they wait on the seat's landing, not on a review. Out of scope, follow-up if wanted: H43 in `scripts/pm/check-half-states.mjs` reads governed-register PRs only, so it cannot flag a >3000-line PR whose request is missing. ## Verification The 20 commands `node scripts/pm/dispatch-gates.mjs --commands` derives for this diff, run on head `262327bc`, all exit 0 (`pnpm --filter @objectstack/lint run check:doc-formula-expressions` after `turbo run build --filter=@objectstack/formula --filter=@objectstack/lint`). Key lines: - `check-skill-line-ratchet`: green, SKILL.md at its 319 ceiling. - `check-skill-id-lint`: 110 files clean. - `check-skill-frame-sync` and `check-governed-prose`: green. Clause-②: no Metadata-protocol: none ## Human Minimum - [x] 1. Schemas start as Zod; `packages/spec` holds no runtime logic. (not touched) - [x] 2. Every name I added uses the casing for its kind. (none added) - [ ] 3. No formatter ran; `pnpm lint` passes. (no formatter ran; `pnpm lint` not run for a three-line skill text edit) - [x] 4. One issue, one branch off an up-to-date `main`, one pull request. - [x] 5. A change that publishes carries a changeset, and both declaration lines are filled in here and in the changeset. (nothing publishes; `skip-changeset`) - [x] 6. `packages/spec` touched: its generated artifacts are regenerated and committed. (not touched) - [x] 7. No hand edits to `content/docs/references/`, `packages/*/CHANGELOG.md` or `content/docs/releases/`. - [x] 8. Title, body and comments are in English. (the 维护者速读 block is Chinese by the skill's own rule) - [x] The *Before Submitting* list in CONTRIBUTING.md is done. --- _Generated by [Claude Code](https://claude.ai/code/session_01WGufzgFA14BKgQ96yvMZbA)_ Co-authored-by: Claude <noreply@anthropic.com>
1 parent 318bc76 commit b0c2209

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

‎.claude/skills/pm-dispatch/SKILL.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ PM 的工作是循环:选卡 → 认领 → 派发 → 收集 → 复核 → 报
184184
- governed 面同含 `AGENTS.md`+`CLAUDE.md`;`GOVERNED_REPOS` 同治理、行可限仓,执行席恒随落地仓车道。
185185
- 另含 `ui/docs/adr/**`+`ui/.claude/**`+`ui/skills/**`+`ui/AGENTS.md`+`ui/CLAUDE.md`+`ui/.github/workflows/**`。
186186
- 路径面命中 Tier H ⇒ ACCEPT 换终局四件套,混合 diff ⛔ 不按比例判;要拆让 dev 单独开 PR。
187-
- 改动 >3000 行(含生成物)同换终局四件套,⛔ 无 Tier S 例外;读数 = PR additions+deletions。
187+
- 改动 >3000 行(含生成物)同换终局四件套含③请审,⛔ 无 Tier S 例外;读数=PR additions+deletions。
188188
- ① 席位记录落 PR 先于 `pr_ready`/入队且钉 head:速读六行+席位意见,其下 `## 席位核对`。
189189
- ② PR 悬着等人批,同笔挂 `needs-user-decision`;人工直合即审核记录,授权批准 ⇒ 席位落地。
190190
- 指针 `ACCEPT → PR #n comment <id>`;受管/spec 面欠完整复核 ①–④,席未达档起隔离达档复核。
@@ -194,11 +194,11 @@ PM 的工作是循环:选卡 → 认领 → 派发 → 收集 → 复核 → 报
194194
- PR 上的标签 = 待维护者审阅,不入六态;与请审同为等人批清单,随获批或撤回判决离开。
195195
- 批准判定单源 = 队列守卫常量 `GOVERNED_APPROVERS`:授权账户 APPROVED 即算,⛔ 不卡 `commit_id`。
196196
- 批准后再推亦不过期;席位落地 = 过落地前检、清标、ready、auto-merge,踢出/变基同法。
197-
- ③ 请审 = 席位交棒:ACCEPT 与现 head 同形 PASS 俱在案后,中继 `pr_request_reviewers` 请审批人。
197+
- ③ 请审 = 席位交棒:ACCEPT 与现 head 同形 PASS 俱在案,同轮中继 `pr_request_reviewers` 请审批人。
198198
- 作者是审批人 ⇒ `assign` 它、请其余(请它必 422);⛔ 永不派/请席位自身账号;Tier S 不交人。
199199
- `pr_create` 不请不派;`pr_ready` 只补交棒漏;非例外 head 移 ⇒ 撤挂回等;脱中继 PR 自读请/派。
200200
- 速读「需要你做的」求批点名 PASS 评论 id+`Head-sha`;无 PASS ⇒ 写 contract review owed 不求批。
201-
- ④ 轮次报告单列 awaiting a human merge。
201+
- ④ 轮报单列 awaiting a human merge 并现读请审人;⛔ 未请审不在 chat 报「等你批」,先补请。
202202
- skills 车道自有 PR:纯代码面如 `scripts/pm/` 由本席按达档自审(清单不减)后落地。
203203
- 受管面两层:Tier S = `.claude/**` 全树,余皆 Tier H 等人批;S 经达档复核 PASS 后 ready → 入队。
204204
- 入队资格:每 check 绿或预期 skip,⛔ 非必查子集;名单 check-expected-skips.mjs 只判 objectstack。

0 commit comments

Comments
 (0)