Skip to content

Commit b1cdf2f

Browse files
committed
chore(ui): past-tense the comments that still named the removed vscode-extension
Claude-Session: https://claude.ai/code/session_01QSeKYm29SiQaonK2q8F7CS Co-authored-by: Claude <noreply@anthropic.com>
1 parent ca2951c commit b1cdf2f

15 files changed

Lines changed: 57 additions & 48 deletions

‎ui/packages/core/src/utils/dataset-format.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ function formatMeasureDate(v: unknown, format: string | undefined, locale: strin
305305
* lived in `@object-ui/i18n`, which depends on `i18next`/`react-i18next` and
306306
* peer-depends on React, while this package is the React-free engine (AGENTS.md
307307
* §3: "No UI-lib deps. Logic only.") and a runtime dependency of React-FREE
308-
* consumers — the `object-ui` VS Code extension and `@object-ui/data-objectstack`.
308+
* consumers — `@object-ui/data-objectstack`, and then the VS Code extension too.
309309
*
310310
* #4576 removed the boundary rather than working around it: `formatDisplayNumber`
311311
* is pure, so it moved DOWN into this package (`./number-display.ts`) and

‎ui/packages/core/src/utils/number-display.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@
3232
* It used to live in `@object-ui/i18n`, and that home cost the repo a real
3333
* defect. `@object-ui/core`'s `utils/dataset-format.ts` could not import it —
3434
* `core` is the React-free engine (AGENTS.md §3: "No UI-lib deps. Logic only.")
35-
* and is a runtime dependency of React-FREE consumers (the `object-ui` VS Code
36-
* extension, `@object-ui/data-objectstack`), while `i18n` depends on
35+
* and is a runtime dependency of React-FREE consumers (`@object-ui/data-objectstack`,
36+
* and then the VS Code extension too), while `i18n` depends on
3737
* `i18next`/`react-i18next` and peer-depends on React. So `formatMeasure` kept
3838
* a parallel `Intl` implementation, the two drifted, and a German session read
3939
* `1.234,5 %` from a list cell beside `1.234,5%` from a dashboard measure

‎ui/packages/types/src/__tests__/package-exports-manifest.test.ts‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,11 @@
2020
* `require` condition rather than adding a second build format — is the
2121
* contract-honest fix; see the PR body for the full premise verification
2222
* (nothing in-repo `require()`s this package, and the one in-repo CJS-format
23-
* bundle consumer, `packages/vscode-extension` via `tsup --format cjs` with
24-
* `noExternal: ['@object-ui/types', ...]`, builds byte-identically with the
25-
* condition present or absent — it resolves the value imports it re-exports
26-
* via the `import` condition regardless of its own output format).
23+
* bundle consumer of the time, the VS Code extension via `tsup --format cjs`
24+
* with `noExternal: ['@object-ui/types', ...]`, built byte-identically with the
25+
* condition present or absent — it resolved the value imports it re-exported
26+
* via the `import` condition regardless of its own output format; that
27+
* package has since left the workspace, objectstack#25910).
2728
*
2829
* ## What this test is, and is not
2930
*

‎ui/packages/types/src/zod/form.zod.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -987,9 +987,9 @@ export const CommandSchema = BaseSchema.extend({
987987
* the author shipped the bad metadata anyway.
988988
*
989989
* This is deliberately NOT an answer to "which validator is canonical"
990-
* (objectui#5449, objectui#4631): a third hand-rolled implementation lives in
991-
* `packages/vscode-extension/src/providers/SchemaValidator.ts`, and whether
992-
* the end state is one canonical validator or a contract the others defer to
990+
* (objectui#5449, objectui#4631): a third hand-rolled implementation lived in
991+
* the VS Code extension's `SchemaValidator.ts` until objectstack#25910 removed
992+
* that package, and whether the end state is one canonical validator or a contract the others defer to
993993
* is a maintainer architecture call. Closing the authoring-time gap is not,
994994
* and is all that happens here.
995995
*/

‎ui/scripts/__tests__/check-doc-component-types.test.ts‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1793,10 +1793,12 @@ describe('the three snippets this gate found on its first run stay fixed', () =>
17931793
// ordinary docs edit.
17941794
const read = (rel: string) => fs.readFileSync(path.join(repoRoot, rel), 'utf8');
17951795

1796-
it('`heading` is gone from the two page schemas that taught it', () => {
1796+
it('`heading` is gone from the page schema that taught it', () => {
17971797
// Nothing registers `heading`. `h1` is registered by `html-elements.tsx`'s
1798-
// TAGS loop and renders `schema.children`, which is what both snippets want.
1799-
for (const file of ['content/docs/utilities/runner.mdx', 'content/docs/utilities/vscode-extension.mdx']) {
1798+
// TAGS loop and renders `schema.children`, which is what the snippet wants.
1799+
// The second page that taught it, the VS Code extension's, was deleted with
1800+
// that package (objectstack#25910).
1801+
for (const file of ['content/docs/utilities/runner.mdx']) {
18001802
const body = read(file);
18011803
expect(body, `${file} still teaches the unregistered \`heading\` type`).not.toContain('"type": "heading"');
18021804
expect(body).toContain('"type": "h1"');

‎ui/scripts/__tests__/check-published-dist-tooling.test.ts‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,7 @@ describe('discoverPublishedPackages', () => {
441441
it('drops packages npm never receives, and keeps the ones under apps/', () => {
442442
const root = makeWorkspace({
443443
'packages/core': { name: '@object-ui/core' },
444-
'packages/vscode-extension': { name: 'object-ui', private: true },
444+
'packages/editor-ext': { name: 'ext-x', private: true },
445445
'apps/console': { name: '@object-ui/console' },
446446
});
447447
expect(discoverPublishedPackages(root).map((p: { name: string }) => p.name)).toEqual([
@@ -461,9 +461,10 @@ describe('discoverPublishedPackages', () => {
461461
});
462462

463463
it('excludes THIS repository’s private fixed-group member by name', () => {
464-
// `packages/vscode-extension` is named `object-ui`, is in the fixed group
465-
// (changesets versions it) and is `private`. Reading the fixed group alone
466-
// would put an unpublishable package in scope.
464+
// `object-ui` (the VS Code extension) was in the fixed group and `private`
465+
// until objectstack#25910 removed it; the pin keeps the name out of scope
466+
// should it return. Reading the fixed group alone would put an
467+
// unpublishable package in scope.
467468
const names = discoverPublishedPackages(repoRoot).map((p: { name: string }) => p.name);
468469
expect(names).not.toContain('object-ui');
469470
expect(names).toContain('@object-ui/console');

‎ui/scripts/__tests__/doc-version-claims.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ import { labelPath, skillBundleBase, skillsWalk } from '../skill-bundle-root.mjs
300300
* NOT ONE of the four earned an inventory entry, and that is the half of this change
301301
* worth carrying forward. They were not a floor this project declares — of the 46
302302
* workspace manifests, ZERO declare `engines.node` or `engines.pnpm`, the only
303-
* `engines` block outside the root being `packages/vscode-extension`'s `engines.vscode`
303+
* `engines` block outside the root being the VS Code extension's `engines.vscode`
304304
* — and not one it tests: 26 of the 27 `node-version:` declarations in
305305
* `.github/workflows` read `'22.x'` and the 27th reads `'22'`, so nothing anywhere runs
306306
* the Node 20 those bullets named. A number a reader will act on, restating no manifest

‎ui/scripts/__tests__/package-files-exist.test.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -373,8 +373,8 @@ describe('package.json `files` entries exist on disk (objectui#3663)', () => {
373373
*
374374
* `!private && license` — the two conditions that together turn "MIT" from a
375375
* label into an obligation. A private package makes no distribution and owes no
376-
* text (`object-ui`, the vscode-extension, is exactly that case and is excluded
377-
* on purpose). A package declaring no license at all is a different defect that
376+
* text (`@object-ui/test-support` is exactly that case and is excluded on
377+
* purpose). A package declaring no license at all is a different defect that
378378
* this guard deliberately does not invent a verdict about.
379379
*
380380
* The population is DERIVED from the same workspace scan as the guard above, so
@@ -479,7 +479,7 @@ describe('published packages that declare a license ship its text (objectui#3696
479479
' cp LICENSE <package-dir>/LICENSE # all 38 are byte-identical, blob cf2ca285',
480480
'',
481481
'If the package should NOT be published, mark it `"private": true` instead — that is the',
482-
'other true direction, and it is why `object-ui` (the vscode-extension) is not listed here.',
482+
'other true direction, and it is why `@object-ui/test-support` is not listed here.',
483483
'',
484484
...violations,
485485
].join('\n'),
@@ -562,8 +562,8 @@ describe('published packages that declare a license ship its text (objectui#3696
562562
// The `private` limb only means something while some private package would
563563
// otherwise be reported. Asserting the specimen set is NON-EMPTY first is
564564
// what keeps this from becoming a test that passes because it examines
565-
// nothing — today it is `object-ui` (packages/vscode-extension), which
566-
// declares "MIT" and has no LICENSE file.
565+
// nothing — today it is `@object-ui/test-support`, which declares "MIT"
566+
// and has no LICENSE file.
567567
const privateOwingIfPublished = packages.filter(
568568
(p) => p.private && p.license !== undefined && licenseTextFiles(p).length === 0,
569569
);

‎ui/scripts/__tests__/quick-reference-commands-4149.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -384,8 +384,8 @@ describe('the UI workspace guide — the published-package count is not written
384384
/**
385385
* The row used to state the count ("39 published packages", later 36, then 35), and
386386
* this test derived the true number to hold the prose to it. The first hand-written
387-
* figure counted directories and missed that `packages/vscode-extension` (published
388-
* to the VS Code marketplace, not to npm) is `private: true` — off by one, in the
387+
* figure counted directories and missed that the VS Code extension (published to
388+
* the VS Code marketplace, not to npm; removed since, objectstack#25910) was `private: true` — off by one, in the
389389
* direction that overstates. Holding it exact then cost a doc edit on every package
390390
* retirement, for a number the manifests already answer (`private` in each one). So
391391
* the row names the published packages without counting them, and this test keeps it

‎ui/scripts/check-changeset-presence.mjs‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -665,9 +665,10 @@ export function readReleaseConfig(root) {
665665
* produce two different guarded surfaces.
666666
*
667667
* A package with NO `files` field publishes its whole directory. That is not read
668-
* as "everything counts": the one such package here (`packages/vscode-extension`)
669-
* is `private: true` and reaches no registry, and taking the absent field as a
670-
* blanket would guard every tsconfig and doc page in it. Absent means clause (c)
668+
* as "everything counts": such a package that is `private: true` reaches no
669+
* registry (the VS Code extension was the case here until objectstack#25910
670+
* removed it), and taking the absent field as a blanket would guard every
671+
* tsconfig and doc page in it. Absent means clause (c)
671672
* matches nothing, and clauses (a) and (b) still apply.
672673
*/
673674
function publishedEntries(manifest) {

0 commit comments

Comments
 (0)