Repository navigation
Commit b322b5d
fix(console): a record page leaves out related lists and rail entries of an object the install does not hold (#27180)
<!-- claude-projects-attribution: {"github_login":"os-warren"} -->
_Requested by **Warren** · [project
thread](https://claude.ai/code/project/chan_01U5RdnAAmkSQmZbqh6FtqZ8?thread=cmsg_01U5RdnAAmkSQmZbqh6FtqZ8GUdk9SEEZXQX6B5hTkWx4K)_
Fixes #26988
Clause-②: no
Metadata-protocol: none
## 维护者速读
- 改了什么:记录页上,绑定到当前安装里不存在的对象的相关列表和右栏条目不再绘制,也不再为它发 `/meta/object`、`/data`
请求。
- 为什么改:ADR-0141 之后模块对象可以真实缺席,页面却照画「Crm Quote 0 — No related records
found」这类拿原始名拼出的假标题,并打出一串 404。
- 风险与回滚:只在已注册对象列表非空时裁剪,与仪表盘 `requiresObject` 同一规则;回滚即撤掉
`RecordDetailView.tsx` 里两处 `pruneUnregisteredRecordPageObjects` 调用。
-
先看:`recordPageChildObjects.ts`(裁剪函数)、`RecordDetailView.tsx`(`assignedPage`
/ `assignedSlots` 两个 memo)、新测试文件。
- 两分钟验证:`pnpm --dir ui exec vitest run
packages/app-shell/src/views/RecordDetailView.unregisteredObjectLists-26988.test.tsx`,预期
2 个用例通过。
- 需要你做的:无,席位落地。
## What changes
- `recordPageChildObjects.ts` gains
`pruneUnregisteredRecordPageObjects(page, registered)`. It reads the
same two arms as `recordPageChildObjects` (now shared helpers): a
`record:related_list` block whose `properties.objectName` or
`dataSource.object` names an object the registered list does not hold is
removed; a `record:reference_rail` entry whose `objectName` does is
removed, and a rail left with no entries goes with it. Only a string
names an object. While the registered list is empty it returns the page
untouched (the deferral `DashboardView` makes), and it is
identity-preserving: a page or subtree with nothing to leave out is
returned itself.
- `RecordDetailView` prunes the authored page and a slotted page's slots
right where `assignedPage` / `assignedSlots` are resolved, so the
effective page, the synthesized page, the composed page and the history
page all read one pruned page.
- The registered list is the view's own `objects` prop, the list
`deriveRelatedLists` already reads. It is not `useMetadata().objects`:
that getter loads the whole registry, which the scoped record route
(objectui#13046) exists to avoid. On that route `objects` is the scope:
the package's objects plus every object the page binds, each asked by
name.
- The child-write subscription from #26890 reads the pruned page. An
object the install does not hold cannot be written, so there is nothing
to watch on it.
- Derived related lists (`deriveRelatedLists`) were already safe: they
come from the registered objects only.
## Tests
- `RecordDetailView.unregisteredObjectLists-26988.test.tsx` uses the
real page. It has a related list bound by `objectName`, one bound by
`dataSource.object`, and a rail entry, all three for absent objects,
beside a registered contact list and rail entry.
- Absent arm: no humanized name ("Crm Quote" and the others), no rows,
and no data-source call or `fetch` URL names any of the three objects.
The contact list and rail entry still draw and read.
- Present arm: the same page draws all three and reads every object.
- `recordPageChildObjects.test.ts`: pins what is left out and what is
kept, the deferral (an empty set prunes nothing), identity preservation,
that the authored page is never mutated, and that non-string names are
kept.
- Ablation: `scripts/ablation-replace.mjs` replaced the guard line `if
(registered.size === 0) return page;` with an unconditional `return
page;`. The absent-arm test went red (`expected '…' not to contain 'Crm
Quote'`) and the present arm stayed green. The tool restored the file
(blob == HEAD, `git diff HEAD` empty).
## Acceptance notes
- On a scoped record route (a full declared record page in a packaged
app), the scope still asks `/meta/object/NAME` once for each name the
page binds, absent ones included. That read is how the console learns
the object is absent; it is the one existence check, and this PR adds
none. Everything the page itself asked (each block's schema read and
`/data` read) is gone.
- A tab or container whose only content was a pruned list stays, now
empty. Pruning containers is not part of this card.
- `record:line_items` (`childObject`) is not pruned. It is outside this
card's two arms.
## Verification
Gate readings and the head they were taken on are in the os-dev report
comment on #26988.
## Human Minimum
- [x] 1. Schemas start as Zod; `packages/spec` holds no runtime logic.
- [x] 2. Every name I added uses the casing for its kind.
- [x] 3. No formatter ran; `pnpm lint` passes. (Local: eslint on the
four changed files, 0 errors; the repo-wide run is CI's.)
- [x] 4. One issue, one branch off an up-to-date `main`, one pull
request.
- [x] 5. A change that publishes carries a changeset, and both
declaration lines are filled in here and in the changeset. (Nothing
publishes here, so no changeset.)
- [x] 6. `packages/spec` touched: its generated artifacts are
regenerated and committed. (Not touched.)
- [x] 7. No hand edits to `content/docs/references/`,
`packages/*/CHANGELOG.md` or `content/docs/releases/`.
- [x] 8. Title, body and comments are in English.
- [x] The *Before Submitting* list in CONTRIBUTING.md is done.
`@object-ui/app-shell` is `private: true` and nothing else changed, so
this PR takes `skip-changeset`.
---
_Generated by [Claude
Code](https://claude.ai/code/session_01JQwxbaQJGyCfqGqBduLgbq)_
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent c26d643 commit b322b5d
4 files changed
Lines changed: 516 additions & 9 deletions
File tree
- ui/packages/app-shell/src/views
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
795 | 795 | | |
796 | 796 | | |
797 | 797 | | |
798 | | - | |
799 | | - | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
800 | 821 | | |
801 | 822 | | |
802 | 823 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
0 commit comments