Skip to content

Commit da4d45a

Browse files
committed
test(app-shell,plugin-detail): declare the two notification widget keys in the form-type drift guards
Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L9qibzyvUbUU6pC3x3Amrx
1 parent 87fe1d0 commit da4d45a

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

‎ui/packages/app-shell/src/utils/paramValueShape.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,8 @@ export const PARAM_VALUE_SHAPES: Readonly<Record<string, ParamValueShapeSpec>> =
179179
'recipient-picker': { base: 'string', cardinality: 'scalar', widgetHintOnly: true, note: 'Recipient id string. Widget-hint only — not a declarable param type.' },
180180
'position-ref': { base: 'string', cardinality: 'scalar', widgetHintOnly: true, note: 'Position name string. Widget-hint only — not a declarable param type.' },
181181
'permission-ref': { base: 'string', cardinality: 'scalar', widgetHintOnly: true, note: 'Permission-set name string. Widget-hint only — not a declarable param type.' },
182+
'notification-topic': { base: 'string', cardinality: 'scalar', widgetHintOnly: true, note: 'Notification topic string. Widget-hint only — not a declarable param type.' },
183+
'notification-channel': { base: 'string', cardinality: 'scalar', widgetHintOnly: true, note: 'Notification channel string. Widget-hint only — not a declarable param type.' },
182184
});
183185

184186
/** Concrete `base[]` tag for a base shape. */

‎ui/packages/plugin-detail/src/__tests__/inlineEditTypeCoverage.test.tsx‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -231,9 +231,11 @@ describe('inline-edit type coverage — every type has exactly one decision (#42
231231
expect(byBucket).toEqual({
232232
excluded: [
233233
'auto_number', 'autonumber', 'composite', 'filter-condition', 'formula',
234-
'grid', 'html', 'object', 'object-ref', 'password',
234+
'grid', 'html', 'notification-channel', 'notification-topic',
235+
'object', 'object-ref', 'password',
235236
// objectui#7611: the registry-name pickers, widget hints like
236-
// `object-ref`.
237+
// `object-ref` — and their fillable arm's two keys above
238+
// (objectstack#31062).
237239
'permission-ref', 'position-ref',
238240
'recipient-picker', 'record', 'repeater', 'richtext', 'secret',
239241
'summary', 'vector',

0 commit comments

Comments
 (0)