Repository navigation
Commit e0fe7d3
test(ui-e2e): delete the vacuous MSW worker test and the unused msw declarations (#26032)
<!-- claude-projects-attribution: {"github_login":"os-elon-musk"} -->
_Requested by **Elon** · [project
thread](https://claude.ai/code/project/chan_01WedDzV26nniwxv7jC88B9D?thread=cmsg_01WedDzV26nniwxv7jC88B9DX3GDGkbVgX1bfDK2kArSWv)_
Part of #25914 — the in-scope half (triage 2026-10-24: "delete the
vacuous MSW test"). The card stays open for the items left to the
maintainer, listed at the end.
Clause-②: no
Metadata-protocol: none
## Summary
Re-measured on `main` 88531fa:
- `ui/apps/console/public/mockServiceWorker.js` does not exist, so
`ui/e2e/console-rendering.spec.ts` "should include the MSW service
worker in the build output" always took its silent `return` (SPA
fallback served `text/html`) and asserted nothing. **Deleted.**
- objectui#13453 did not retire `msw`: it was still declared in
`ui/package.json` (devDependency plus the `"msw": { "workerDirectory":
["public"] }` block), `ui/packages/plugin-form` and
`ui/packages/plugin-grid` (devDependencies). `git grep` for `'msw'`,
`msw/*`, `setupServer`, `setupWorker` outside the lockfile finds no
importer in code; the only hit is the example snippet in
`ui/skills/objectui/guides/testing.md`, which is consumer guidance and
imports nothing here. **Removed**, together with the generated worker
`ui/public/mockServiceWorker.js` that the `workerDirectory` block
produced and the console `.gitignore` entry for a worker nothing
generates any more.
- `pnpm-lock.yaml` regenerated with `pnpm install --lockfile-only`: the
three importer entries go; `msw@2.15.0` stays in the lock as an optional
peer of another package, so its transitive entries flip to `optional:
true` rather than disappearing.
## Verification (head d1dc66c)
- `dispatch-gates --commands` derived 42 families; `--ran`
reconciliation: 42 derived, 38 run (all exit 0), 4 NOT MEASURED (exit 3,
need whole-tree `dist/`: `check:dts-closure`,
`check:dual-build-cjs-loads`, `check:lean-entry-closure`,
`check:sourcemap-no-sources-content`), 0 UNRUN. CI's Build/Lint lanes
own those four.
- `pnpm install --frozen-lockfile` against the new lock: exit 0.
- e2e test list (there is no e2e completeness gate;
`check-test-completeness` reads vitest logs only): `playwright test
--list --project=chromium` → 77 tests in 12 files (one fewer than
`main`); `console-rendering.spec.ts` lists its remaining 3 tests.
- `check:commit-card-trailers --range origin/main..HEAD` green.
- No changeset: only devDependencies and test/config files change;
nothing in any package's published output moves.
## Left for a maintainer ruling (out of scope here)
- Making the 4-spec live allowlist (`test:e2e:live:ci`) a required check
— a new gate.
- Moving the informational live lane (`live-e2e.yml`) from every PR to
daily only — a governed workflow change.
- Triage of the 18 live specs that run in no CI (objectui#13104's list
is the starting point).
## Noticed, not changed
- `ui/apps/console/vercel.json` still excludes `mockServiceWorker.js`
from its SPA rewrite; harmless, left as deploy config.
- `ui/.claude/skills/objectui-contributor/guides/console-development.md`
still tells contributors to start a mock API with
`@objectstack/plugin-msw`, which `docs/upgrading-to-11.md` says was
removed.
- `console-rendering.spec.ts`'s console-error filter still ignores `MSW`
/ `mockServiceWorker` messages; inert, left alone.
---
_Generated by [Claude
Code](https://claude.ai/code/session_01ATRAHgc6RT4GLFAL1N5Zfy)_
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01ATRAHgc6RT4GLFAL1N5Zfy
Co-authored-by: Claude <noreply@anthropic.com>1 parent 712770b commit e0fe7d3
7 files changed
Lines changed: 45 additions & 403 deletions
File tree
- ui
- apps/console
- e2e
- packages
- plugin-form
- plugin-grid
- public
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
31 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | 70 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
152 | | - | |
153 | 152 | | |
154 | 153 | | |
155 | 154 | | |
| |||
171 | 170 | | |
172 | 171 | | |
173 | 172 | | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | 173 | | |
180 | 174 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
48 | 47 | | |
49 | 48 | | |
50 | 49 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
52 | 51 | | |
53 | 52 | | |
54 | 53 | | |
| |||
0 commit comments