Skip to content

Commit e55a4e7

Browse files
committed
test(metadata-protocol): count overrides in the served /meta/types property pins
The override declaration adds one top-level property to `action`, `app`, `dashboard`, `dataset`, `flow`, `page` and `report`; the degenerate-derivation suite pins each served count, so each moves by one and the `action` sample names the new key. The excluded types keep their counts. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ihL2fi9zfJhUTubyJYb6V
1 parent e0253ce commit e55a4e7

1 file changed

Lines changed: 12 additions & 4 deletions

File tree

‎packages/metadata-protocol/src/protocol.meta-types-degenerate-derivation.test.ts‎

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -259,10 +259,13 @@ describe('#17501 — /meta/types serves a real schema for `action`, and moves no
259259
// joined the accepted set, and the sample names it.
260260
// [#27944] 49 → 50: `submitText` (the param dialog's submit button
261261
// label) joined the accepted set, and the sample names it.
262-
expect(Object.keys(properties).length + retiredTopLevelCount('action')).toBe(50);
262+
// [#28404] 50 → 51: `overrides` (the ADR-0146 D2 override declaration
263+
// a `<base>.custom` item carries) joined the accepted set, and the
264+
// sample names it.
265+
expect(Object.keys(properties).length + retiredTopLevelCount('action')).toBe(51);
263266
// A sample an author would actually address, and the one #17500's
264267
// repeater titles need a node to sit on.
265-
for (const key of ['name', 'label', 'objectName', 'type', 'params', 'locations', 'outcomeMessages', 'requiresMembershipReach', 'disabledReason', 'pressed', 'submitText']) {
268+
for (const key of ['name', 'label', 'objectName', 'type', 'params', 'locations', 'outcomeMessages', 'requiresMembershipReach', 'disabledReason', 'pressed', 'submitText', 'overrides']) {
266269
expect(Object.keys(properties)).toContain(key);
267270
}
268271
});
@@ -357,9 +360,14 @@ describe('#17501 — /meta/types serves a real schema for `action`, and moves no
357360
// [#27945] `field` 80 → 81: `lookupAutofill`, the fields a pick in a
358361
// lookup fills.
359362
// [#28022] `app` 22 → 23: `landing`, the per-audience landing list.
363+
// [#28404] `app` 23 → 24, `dashboard` 20 → 21, `dataset` 16 → 17, `flow`
364+
// 22 → 23, `page` 26 → 27, `report` 23 → 24: `overrides`, the ADR-0146 D2
365+
// override declaration, on each overridable type. The excluded types
366+
// (`agent`, `field`, `hook`, `object`, `position`, `skill`, `tool`) do not
367+
// gain it, and their counts stay.
360368
const CARD_PROPERTY_COUNTS: Record<string, number> = {
361-
agent: 24, app: 23, dashboard: 20, dataset: 16, field: 81, flow: 22,
362-
hook: 23, object: 49, page: 26, position: 13, report: 23, skill: 16, tool: 14,
369+
agent: 24, app: 24, dashboard: 21, dataset: 17, field: 81, flow: 23,
370+
hook: 23, object: 49, page: 27, position: 13, report: 24, skill: 16, tool: 14,
363371
};
364372

365373
it.each(Object.entries(CARD_PROPERTY_COUNTS))(

0 commit comments

Comments
 (0)