Repository navigation
Commit e638193
refactor(app-shell): move ObjectView's leaf pieces into objectViewChrome.tsx (slice 3) (#26310)
<!-- claude-projects-attribution: {"github_login":"os-steve"} -->
_Requested by **Steve** · [project
thread](https://claude.ai/code/project/chan_01FdL1XeUyvVNxLreh3F4Qi9?thread=cmsg_01FdL1XeUyvVNxLreh3F4Qi9VtKf3F9dzJPJM4RRtABaEc)_
Part of #25992 (slice 3 of the move-only split, under the standing claim
and the seat's continuation note; slices 1 and 2 landed as #26152 and
#26233, and the card stays open for the component body).
Clause-②: no
Metadata-protocol: none
## Seam table (measured on `main` 96635f5)
`ui/packages/app-shell/src/views/ObjectView.tsx` was 3254 lines. What
was still module-level besides imports and the slice 1-2 re-exports:
| Piece | Kind | Who reads it | This slice |
|---|---|---|---|
| `ConsoleObjectViewProps` | exported interface | `ObjectView` /
`ObjectViewInner`, `views/index.ts` type re-export, 4 tests by path |
stays: it is the component's own props contract |
| `ObjectNotFoundState` | exported React component | the `ObjectView`
wrapper, `console/AppContent.tsx` (imports it from
`views/ObjectView.js`) | moves |
| `VIEW_TABS_MIN_WIDTH`, `viewTabsFitNow`, `useViewTabsFit` | file-local
constant, function, hook | `ObjectViewInner` (the tab strip decision) |
moves |
| `keepInlineEditModeForTheSession` (with its docblock) | file-local
no-op callback | `ObjectViewInner` (the list's inline-edit toggle) |
moves |
| `ObjectView`, `ObjectViewInner` | the component | | stays (later
slices, by concern) |
No test reads any of the moved lines out of `ObjectView.tsx` as source
text (checked over every test that reads `ObjectView.tsx`), so this
slice needs no test edit at all.
## What moved
The contiguous block from the `ObjectNotFoundState` docblock through
`keepInlineEditModeForTheSession` moves verbatim, in its original order,
into a new sibling
`ui/packages/app-shell/src/views/objectViewChrome.tsx`. `ObjectView.tsx`
imports `ObjectNotFoundState`, `useViewTabsFit` and
`keepInlineEditModeForTheSession` back and re-exports
`ObjectNotFoundState`, the one moved name it exported, from the same
path. `useViewTabsFit` and `keepInlineEditModeForTheSession` gain the
`export` keyword in the new module because the component still calls
them; `ObjectView.tsx` does not re-export them, so it publishes no new
name. `Table as TableIcon` leaves `ObjectView.tsx`'s lucide import with
its only reader. The package entry is untouched. `ObjectView.tsx` goes
from 3254 to 3171 lines.
Move-only proof: the multiset of non-blank lines of the base
`ObjectView.tsx` equals new `ObjectView.tsx` plus
`objectViewChrome.tsx`, after normalising the two added `export`
keywords. The only differing lines are imports, the re-export and its
comment, and the new module's header.
## Test edits
None.
## Verification
At 668d82f, under the shared verify lock: `pnpm install
--frozen-lockfile`; app-shell dependency closure build; `pnpm --filter
@object-ui/app-shell type-check` (src and `tsconfig.test.json`); 117
test files (every `views/ObjectView.*` test, every
`console/__tests__/AppContent*` test, and every other test that reads
`ObjectView.tsx` as source) passed, 1425 tests; Console build (turbo,
71/71 tasks). eslint on both source files: 0 errors. The 30 derived
dispatch gates: all exit 0. The rest of the app-shell suite is left to
CI `Test UI`: it reaches these names only through the unchanged import
path.
## Acceptance notes
- `ObjectNotFoundState`'s docblock still says "this module's
`ObjectView` draws it for an absence"; the wrapper that draws it is now
in the sibling file. Kept verbatim because the slice is move-only.
- The inline-edit docblock sits directly above the view-tabs docblock,
as it did in `ObjectView.tsx`; the order is unchanged.
Changeset: `.changeset/25992-objectview-chrome-split.md` (patch,
`@object-ui/app-shell`).
---
_Generated by [Claude
Code](https://claude.ai/code/session_01QciHBvFJXnhZqXmdqpDtpz)_
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent 14b5597 commit e638193
3 files changed
Lines changed: 118 additions & 89 deletions
File tree
- .changeset
- ui/packages/app-shell/src/views
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| |||
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
| 128 | + | |
128 | 129 | | |
129 | 130 | | |
130 | 131 | | |
| |||
155 | 156 | | |
156 | 157 | | |
157 | 158 | | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
158 | 163 | | |
159 | 164 | | |
160 | 165 | | |
| |||
186 | 191 | | |
187 | 192 | | |
188 | 193 | | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | | - | |
201 | | - | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | | - | |
222 | | - | |
223 | | - | |
224 | | - | |
225 | | - | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | | - | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | | - | |
250 | | - | |
251 | | - | |
252 | | - | |
253 | | - | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
263 | | - | |
264 | | - | |
265 | | - | |
266 | | - | |
267 | | - | |
268 | | - | |
269 | | - | |
270 | | - | |
271 | | - | |
272 | | - | |
273 | | - | |
274 | | - | |
275 | | - | |
276 | | - | |
277 | 194 | | |
278 | 195 | | |
279 | 196 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
0 commit comments