Repository navigation
Commit e6c4409
ci(ui-merge): port objectui's lockfile-integrity gate into Type Check UI and retire lockfile-dedupe and the shadcn-check report (#26995)
<!-- claude-projects-attribution: {"github_login":"os-steve"} -->
_Requested by **Steve** · [project
thread](https://claude.ai/code/project/chan_01FdL1XeUyvVNxLreh3F4Qi9?thread=cmsg_01FdL1XeUyvVNxLreh3F4Qi953MBpM3iLJAsd1HJwbM7eJ)_
Part of #26717 (slice 2: roster rows 19, 18 and 26 land here; row 7-docs
stays open on the card for the seat's decision, see Acceptance notes.
Row 17 is out of scope by #25914's ruling.)
Clause-②: no
Metadata-protocol: none
## 维护者速读
- 改了什么:objectui 剩下的三个"移植或退役"检查处理完。锁文件重复检查(lockfile-integrity)接进根 CI 的
`Type Check UI`,只在 PR 上跑,发现问题只打一条报错注释,不挡合并,和 objectui 当年一样。另外两个退役:锁文件
dedupe 报告(90 天 145 次运行从未失败)和 shadcn 每周报告的分类脚本,连同它们的测试一起删掉。
- 为什么改:objectui 并入后这些检查没有在任何地方运行;要么接回来,要么明确删掉,不留半死的脚本。
- 风险与回滚:`Type Check UI` 是必需检查,但新步骤带 `continue-on-error`,它红了不会让这个 job
红,所以不会挡任何 PR。删掉的脚本没有别的读者。回滚就是 revert 本 PR。
- 先看:`.github/workflows/ci.yml` 里 `Type Check UI` 新加的
`check:lockfile-integrity`
步骤;`ui/scripts/__tests__/check-lockfile-integrity.test.ts` 新加的四条接线测试。
- 两分钟验证:`pnpm --dir ui run check:lockfile-integrity --base-ref
origin/main`,预期 `VERDICT clean — no package gained a copy.`,退出码 0。
- 需要你做的:本 PR 改了 `ci.yml`(Tier H),需要你明确批准;另外第 7-docs 行(objectui
文档站构建)记录里没定,席位会把选项拿给你。
## What changes
Rows of the #25697 workflow roster (comment 6388182608), read from the
objectui workflows #26058 deleted (`lockfile-integrity.yml`,
`lockfile-dedupe.yml`, `shadcn-check.yml` at `aa2f8e31f3`'s parent).
| Row | objectui workflow | Disposition here |
|---|---|---|
| 19 | `lockfile-integrity.yml` (`check:lockfile-integrity`) |
**ported**: one step of `Type Check UI`, `check:lockfile-integrity —
compare this pull request's lockfile with its merge base` |
| 18 | `lockfile-dedupe.yml` (`check:lockfile-dedupe`, report-only since
objectui#9562's ruling A) | **retired**: alias,
`ui/scripts/check-lockfile-dedupe.mjs` and its test deleted; nothing
replaces it, by choice (#25920: 145 runs / 90 days / 0 failures) |
| 26 | `shadcn-check.yml` (weekly report) | **retired**:
`ui/scripts/shadcn-check-report.mjs` (the workflow's classifier and
issue-body renderer) and its test deleted; nothing replaces the weekly
report, by choice |
- **Row 19, the step.** `if: github.event_name == 'pull_request'`,
`continue-on-error: true`, before `pnpm install`, running `pnpm --dir ui
run check:lockfile-integrity --base-ref "origin/${BASE_REF}"` with
`BASE_REF` from `github.base_ref`. Why this job: it already checks out
with `fetch-depth: 0`, so `origin/BASE` and the merge base are in the
clone (objectui paid a separate job for that history), and the `ui`
paths filter lists `pnpm-lock.yaml`, so every lockfile change runs it.
Before the install because the script needs only Node builtins and two
repo modules, as objectui ran it; Lint UI's pre-install import graph
check holds that. `continue-on-error` keeps objectui's classification: a
finding prints `::error title=Lockfile integrity::PACKAGES` on the pull
request and does not fail the required job. Making it blocking stays the
maintainer's call (`NOT_A_GATE` in
`ui/scripts/dependabot-merge-gate.mjs`). No new job, no new check-run
context, no new required context.
- **Row 26, what stays.** `shadcn:check` and `shadcn:analyze` (and
`shadcn-sync.js`, `shadcn-local-patches.mjs`, `component-analysis.js`)
are not retired: they are the components package's maintainer commands,
read by `ui/packages/components/README.md`, `README_SHADCN_SYNC.md`,
`shadcn-components.json`, the other four `shadcn:*` aliases and
`scripts/regen-artifacts.mjs`. The weekly workflow only scheduled them;
its own artifact was the classifier, and that is what goes. The two ui
tests that read `shadcn-sync` (`shadcn-local-patches.test.ts`,
`shadcn-sync-fetch-cache.test.ts`) test those live scripts and stay.
### Forced test edits
- `ui/scripts/__tests__/check-lockfile-integrity.test.ts`: the note
saying the port would "bring both pins back against the root job" is
replaced by those pins, read from root `ci.yml` through
`helpers/root-ci`: the step exists and runs the gate against the pull
request base; the job checks out with `fetch-depth: 0` before it; the
step is `continue-on-error` and before the install; no other root
workflow carries the alias. 13 → 17 cases.
- `ui/scripts/__tests__/check-lockfile-dedupe.test.ts` and
`ui/scripts/__tests__/shadcn-check-report.test.ts`: deleted with the
scripts they test.
## Tests
Measured in this worktree on head `a463a624`.
<details><summary>Row 19: the step's command, and its
counter-probe</summary>
- `pnpm --dir ui run check:lockfile-integrity --base-ref origin/main`
(the step's `run:` with `BASE_REF=main`): exit 0, `base:
7bb8084…:pnpm-lock.yaml (1941 resolutions) head: …/pnpm-lock.yaml (1941
resolutions)`, `VERDICT clean — no package gained a copy.`
- Counter-probe: the root `pnpm-lock.yaml` mutated with the test's
sample (a) (a second `ai@7.0.65(zod@4.6.7)` snapshot beside
`ai@7.0.118(zod@4.6.7)`; marker count 1 on disk), then the same command:
exit 1, `VERDICT 1 lockfile-integrity finding(s): 1 duplication(s).` and
`::error title=Lockfile integrity::ai — see the run log; this is a
lockfile regression, not a bundle regression (objectui#8326).` Restored
by `git checkout HEAD -- pnpm-lock.yaml` under a trap; blob `8b64d515`
before and after; `git diff HEAD` empty; re-run exit 0, `VERDICT clean`.
- `pnpm --dir ui exec vitest run
scripts/__tests__/check-lockfile-integrity.test.ts`: 17 passed.
</details>
<details><summary>Rows 18 and 26: every reader gone</summary>
- `git grep -n -F check:lockfile-dedupe`: no hits (exit 1).
- `git grep -n -F shadcn-check-report --
':!ui/content/docs/guide/ci-cd-pipeline.md'
':!ui/scripts/dependabot-merge-gate.mjs'`: no hits. The two remaining
mentions are prose about objectui's deleted workflows (Acceptance
notes).
- `git grep -n -F check-lockfile-dedupe --
':!ui/content/docs/guide/ci-cd-pipeline.md'
':!ui/scripts/workspace-root.mjs'`: no hits. Same reason.
</details>
## Acceptance notes
- **Row 7-docs (`@object-ui/site`, objectui `ci.yml` "Build Docs") is
not decided here.** The card says to decide it with F14 / docs-deploy
(sub-issue 4 row 10). Read: #25712's item 5 says objectui's
`docs-deploy.yml` should become "a second deploy job in this repo's
`docs-deploy.yml` (the site stays a separate Vercel project) — the
project id/secrets are the maintainer's"; #26058 then deleted it with
"(none; objectui's site is a separate Vercel project)", and root
`docs-deploy.yml` deploys `apps/docs` only. F14 (now on #25753) is the
rewrite of `ui/content/docs/guide/ci-cd-pipeline.md`, not a build
decision. So the record decides the deploy, which never landed, and not
the per-PR build row. The options go to the seat in the card report; the
card stays open (`Part of`).
- `ui/content/docs/guide/ci-cd-pipeline.md` (F14, #25753) still
describes `lockfile-integrity.yml`, `lockfile-dedupe.yml` and
`shadcn-check.yml` as live, as it does every other deleted objectui
workflow. Outside this card's file surface; F14 rewrites it.
- `ui/scripts/workspace-root.mjs`'s docblock still names
`check-lockfile-dedupe.mjs` as one of two pre-install importers, and
`ui/scripts/dependabot-merge-gate.mjs` still classifies `Lockfile Dedupe
Check` (`OPTIONAL_CONTEXTS`) and names `shadcn-check-report.mjs` in its
header. Prose and context names from objectui's CI, outside the surface;
`dependabot-merge-gate.mjs` runs in no root workflow.
- The card delta named `dispatch-gates --tier` MANDATORY for `ci.yml`;
measured on this change set it reports no path-derived mandate (`the
surface hits none of the 4 declared glob(s)`).
## Verification
Final head `a463a624`, after a root `pnpm build` (VERDICT command-exit
0, 12m30s under `os-verify-lock`).
<details><summary>Gate sweep and reconciliation</summary>
- `node scripts/pm/dispatch-gates.mjs --commands --repo
objectstack-ai/objectstack` derived 74 commands for this change set (7
paths, 2175 changed lines). All 74 ran and exited 0, each exit code
captured before any pipe. Among them: `pnpm --dir ui exec vitest run
scripts/` under `os-verify-lock` (176 files passed, 2 skipped; 5032
tests passed, 2 skipped; VERDICT command-exit 0), `pnpm
check:pm-dispatch-gates` (fast tier, 1935 cases), `pnpm
check:required-contexts`, `pnpm check:ci-filter-parity`, `pnpm
check:pm-expected-skips`, `pnpm check:workflow-step-name-quoting` and
`pnpm check:published-files`.
- `node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack
--ran LEDGER`: `✓ 74 derived famil(ies) accounted for — 74 run, 0
NOT-MEASURED`, 0 UNRUN.
- `origin/main` moved 11 commits after the base `7bb80845`; none touches
this PR's files, so it is not merged in.
- Not run locally: `pnpm lint` and the full test suites, which are CI's
run.
</details>
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01ADHkmSracEMN5RmM9xs4Fu
Co-authored-by: Claude <noreply@anthropic.com>1 parent 6328a07 commit e6c4409
7 files changed
Lines changed: 82 additions & 2093 deletions
File tree
- .github/workflows
- ui
- scripts
- __tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3418 | 3418 | | |
3419 | 3419 | | |
3420 | 3420 | | |
| 3421 | + | |
| 3422 | + | |
| 3423 | + | |
| 3424 | + | |
| 3425 | + | |
| 3426 | + | |
| 3427 | + | |
| 3428 | + | |
| 3429 | + | |
| 3430 | + | |
| 3431 | + | |
| 3432 | + | |
| 3433 | + | |
| 3434 | + | |
| 3435 | + | |
| 3436 | + | |
| 3437 | + | |
| 3438 | + | |
| 3439 | + | |
| 3440 | + | |
| 3441 | + | |
| 3442 | + | |
| 3443 | + | |
| 3444 | + | |
| 3445 | + | |
| 3446 | + | |
3421 | 3447 | | |
3422 | 3448 | | |
3423 | 3449 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
88 | 87 | | |
89 | 88 | | |
90 | 89 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
| |||
38 | 39 | | |
39 | 40 | | |
40 | 41 | | |
41 | | - | |
| 42 | + | |
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
| |||
191 | 192 | | |
192 | 193 | | |
193 | 194 | | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | | - | |
201 | | - | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
202 | 230 | | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
203 | 250 | | |
204 | 251 | | |
205 | 252 | | |
| |||
0 commit comments