Skip to content

Commit e8ffbe6

Browse files
committed
chore(pm): H63's prose and remedy no longer point at the deleted sweep
The row's printed remedy named the one-time sweep as the owner of the standing backlog. It now says what the rule says: a carrier already in the shape is the triage round's to fix by hand, removing the marker when it grades the card. The comments and test names that described the sweep as a second reader of the screen are reworded the same way. Wording only. H63's predicate and the screen are unchanged. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J8VVAmM3BRQQcQSA67VE3L
1 parent cb18498 commit e8ffbe6

1 file changed

Lines changed: 21 additions & 25 deletions

File tree

‎scripts/pm/check-half-states.mjs‎

Lines changed: 21 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -14950,14 +14950,14 @@ export function h73RuledCardStillInBox(issue, nowMs = Date.now()) {
1495014950
}
1495114951

1495214952
// ---------------------------------------------------------------------------
14953-
// The stale-`finding` screen — ONE rule, two readers (#16904)
14953+
// The stale-`finding` screen — the rule H63 reads (#16904)
1495414954
//
1495514955
// `finding` is defined by the state model as a TRANSIENT marker — 「观察类记录,
1495614956
// 恒 = 待首次定级;定级即离标;不占队列不进收件箱」 — so `label:finding` answers
1495714957
// exactly one question: what has not been graded yet. It does not. The filing
1495814958
// card measured 385 of 395 carriers already graded across both boards; a later
1495914959
// triage round re-measured 185 of 226; a hand strip cleared 38 more; and the
14960-
// one-time sweep that closes the backlog left objectstack and objectui at 0.
14960+
// one-time sweep that closed the backlog left objectstack and objectui at 0.
1496114961
//
1496214962
// A population that was refilled three times by hand is a population that
1496314963
// refills, and the reason is an API shape rather than carelessness: the strip
@@ -15084,23 +15084,19 @@ export function staleFindingScreen(issue) {
1508415084
// ---------------------------------------------------------------------------
1508515085
// H63 (#16904) — a graded card still wearing the ungraded marker
1508615086
//
15087-
// The row over the screen above. ⛔ Report-only, like everything here: the
15088-
// one-time sweep is the tool that strips, it is run once per board by the seat
15089-
// that owns that board, and this row exists precisely because that run is a
15090-
// point measurement of a population that refills. The remedy a row prescribes
15091-
// is a grading write that also drops the marker, never a strip performed from
15092-
// this script.
15087+
// The row over the screen above. ⛔ Report-only, like everything here: triage
15088+
// removes the marker by hand when it grades the card, and this row exists
15089+
// because that step is easy to forget, so the population refills. The remedy a
15090+
// row prescribes is a grading write that also drops the marker, never a strip
15091+
// performed from this script.
1509315092
//
15094-
// ## Why it fires on the SWEEP's set exactly, `pm:seat` skip included
15093+
// ## Why it fires on the screen's set exactly, `pm:seat` skip included
1509515094
//
15096-
// The row's job is to make the refill visible, and "the refill" is only
15097-
// meaningful against the thing that was emptied. A row whose population were
15098-
// merely similar would drift from the tool's over the first change to either;
15099-
// sharing the screen makes 「what the sweep would strip today」 the row's literal
15100-
// reading. The `pm:seat` exclusion travels with it for the same reason it
15101-
// exists in the tool: a seat registry post is not a card in the grading pool,
15102-
// so its marker is not an ungraded card's marker, and reporting it would send a
15103-
// reader to strip a label that is doing its job.
15095+
// The row's job is to make the refill visible, so its population is the
15096+
// screen's stale set itself rather than something merely similar. The `pm:seat`
15097+
// exclusion is part of that set: a seat registry post is not a card in the
15098+
// grading pool, so its marker is not an ungraded card's marker, and reporting
15099+
// it would send a reader to strip a label that is doing its job.
1510415100
//
1510515101
// ## Population and cost
1510615102
//
@@ -15133,8 +15129,8 @@ export function h63StaleFindingBesideGrade(issue) {
1513315129
'returns four wrong rows in five is discharged by sampling or skipped. Two lanes have already ' +
1513415130
'declined to dispatch a card in this shape, which is the strict reading of 不占队列. Remedy — WHO ' +
1513515131
'and HOW: the seat that next writes a grade on this card, dropping the marker in the SAME write ' +
15136-
'(「定级即离标」); the standing backlog is the one-time sweep\'s, run once per board by the seat ' +
15137-
'that owns it, ⛔ never a loop from here. ⛔ Report-only: no label is written from this script, and ' +
15132+
'(「定级即离标」); a carrier already in this shape is the triage round\'s to fix by hand, removing ' +
15133+
'the marker when it grades the card, ⛔ never a loop from here. ⛔ Report-only: no label is written from this script, and ' +
1513815134
'⛔ no grade is ever synthesised — a card with no priority has not been read and belongs in the ' +
1513915135
'ungraded pool, not in the queue. Boundaries: a card carrying ONLY the marker is the pool the ' +
1514015136
'index exists for and is clean here; a `pm:seat` post is never judged; closed-card residue is ' +
@@ -23749,8 +23745,8 @@ async function sweepInto(findings, seen, seenPrs, seenMerged, seenUnscoped, seen
2374923745
// H63 (#16904) — the same listing for the same reason: `finding` is not one
2375023746
// of the labels the label loop pages, so a carrier holding no `pm:*` state
2375123747
// is first visible HERE. One label read on a row this listing already
23752-
// holds, through the screen the one-time sweep strips on — so the row's
23753-
// population IS the sweep's target set rather than an approximation of it.
23748+
// holds, through the stale-`finding` screen — so the row's population IS
23749+
// the screen's stale set rather than an approximation of it.
2375423750
const staleFinding = h63StaleFindingBesideGrade(issue);
2375523751
if (staleFinding) findings.push([issue, 'H63', staleFinding]);
2375623752
// H68 (#18901) — the class-(b) declaration with no `Seam:` line, on this
@@ -28120,7 +28116,7 @@ async function selfTest() {
2812028116
t('H63: …naming BOTH triggers, state first', row63(gradedCarrier(['finding', 'pm:queue', 'priority:p3'])).includes('`pm:queue`, `priority:p3`'), true);
2812128117
t('H63: every grading state is a trigger — `needs-user-decision` included', typeof h63StaleFindingBesideGrade(gradedCarrier(['finding', GOVERNED_PR_DECISION_LABEL])), 'string');
2812228118

28123-
// ── Direction 2: it is SILENT where the sweep leaves the card, each silence
28119+
// ── Direction 2: it is SILENT where the screen leaves the card, each silence
2812428120
// with a lit control on the byte-identical card ─────────────────────────
2812528121
t('⛔ H63: `finding` ALONE is NOT a finding — that is the pool the index exists FOR', h63StaleFindingBesideGrade(gradedCarrier(['finding'])), null);
2812628122
t('H63 control: …and the same card with one grading state fires', typeof h63StaleFindingBesideGrade(gradedCarrier(['finding', 'pm:blocked'])), 'string');
@@ -28136,10 +28132,10 @@ async function selfTest() {
2813628132
t('H63 control: …and the byte-identical OPEN row fires', typeof h63StaleFindingBesideGrade(gradedCarrier(['finding', 'pm:queue'])), 'string');
2813728133
t('⛔ H63: a PULL REQUEST row that slipped into the listing is not a card', h63StaleFindingBesideGrade(gradedCarrier(['finding', 'pm:queue'], { pull_request: {} })), null);
2813828134
t('⛔ H63: a card without the marker is not this row\'s business', h63StaleFindingBesideGrade(gradedCarrier(['pm:queue', 'priority:p2'])), null);
28139-
t('⛔ H63: an unreadable `labels` reads as no marker and is silent — the SCREEN\'s behaviour, shared with the tool that writes', h63StaleFindingBesideGrade(gradedCarrier([], { labels: undefined })), null);
28135+
t('⛔ H63: an unreadable `labels` reads as no marker and is silent — the SCREEN\'s behaviour', h63StaleFindingBesideGrade(gradedCarrier([], { labels: undefined })), null);
2814028136
t('⛔ H63: a missing row does not crash', h63StaleFindingBesideGrade(undefined), null);
2814128137

28142-
// ── The screen itself, as the sweep judges it ────────────────────────────
28138+
// ── The screen itself ─────────────────────────────────────────────────────
2814328139
t('H63 screen: a graded carrier is `stale`', staleFindingScreen(gradedCarrier(['finding', 'pm:queue'])).verdict, 'stale');
2814428140
t('H63 screen: …the ungraded pool is `leave`, and REPORTED rather than dropped', staleFindingScreen(gradedCarrier(['finding'])).kind, 'ungraded');
2814528141
t('H63 screen: …and the seat post is `skip`, with the reason on the row', staleFindingScreen(gradedCarrier(['finding', 'pm:seat'])).detail.includes('pm:seat'), true);
@@ -28161,7 +28157,7 @@ async function selfTest() {
2816128157
t('H63 text: ⛔ no less-than fragment — the body is written into a GitHub issue', /[<>]/.test(row63(gradedCarrier(['finding', 'pm:queue']))), false);
2816228158
t('H63 text: the state model is QUOTED, not paraphrased', row63(gradedCarrier(['finding', 'pm:queue'])).includes('定级即离标'), true);
2816328159
t('H63 text: WHO acts — the seat that next writes a grade, in the SAME write', row63(gradedCarrier(['finding', 'pm:queue'])).includes('SAME write'), true);
28164-
t('H63 text: …and the standing backlog is named as the one-time sweep\'s, ⛔ never a loop from here', row63(gradedCarrier(['finding', 'pm:queue'])).includes('⛔ never a loop from here'), true);
28160+
t('H63 text: …and a carrier already in the shape is triage\'s to fix by hand, ⛔ never a loop from here', row63(gradedCarrier(['finding', 'pm:queue'])).includes('⛔ never a loop from here'), true);
2816528161
t('H63 text: ⛔ no label is written from this script', row63(gradedCarrier(['finding', 'pm:queue'])).includes('no label is written from this script'), true);
2816628162
t('H63 text: ⛔ and no grade is ever synthesised — the constraint a hand sweep learned by breaking it', row63(gradedCarrier(['finding', 'pm:queue'])).includes('no grade is ever synthesised'), true);
2816728163
t('H63 text: the marker constant is printed, ⛔ never a re-typed literal', row63(gradedCarrier(['finding', 'pm:queue'])).includes(`\`${STALE_FINDING_LABEL}\``), true);

0 commit comments

Comments
 (0)