Skip to content

Commit edce052

Browse files
committed
wip: walled-boot pin double throws only for branding
Claude-Session: https://claude.ai/code/session_01UmqzD97e14iws6hmVhgZ5y Co-authored-by: Claude <noreply@anthropic.com>
1 parent 8f53588 commit edce052

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

‎packages/plugins/plugin-auth/src/auth-plugin.test.ts‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -535,7 +535,11 @@ describe('AuthPlugin', () => {
535535
// for an unregistered namespace), so a binding that skipped the listing
536536
// check would log the warn this pins away.
537537
it('a walled boot (branding not listed) neither reads it nor warns about it', async () => {
538-
const settings = makeSettings(new Error("Unknown settings namespace: 'branding'"), { brandingListed: false });
538+
const settings = makeSettings({ value: undefined, source: 'default' }, { brandingListed: false });
539+
settings.get.mockImplementation(async (namespace: string) => {
540+
if (namespace === 'branding') throw new Error("Unknown settings namespace: 'branding'");
541+
return { value: undefined, source: 'default' };
542+
});
539543
await bootWithSettings(settings);
540544

541545
expect(settings.get).not.toHaveBeenCalledWith('branding', 'workspace_name', expect.anything());

‎packages/services/service-settings/src/settings-service-plugin.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,8 @@ import { settingsBuiltinTranslations } from './translations/index.js';
6868
* "Not offered" is the registry's own answer, so every door agrees without a
6969
* second rule: the namespace is absent from `GET /api/settings`, a read or
7070
* write of it is refused `404 UNKNOWN_NAMESPACE` by the path every unknown
71-
* namespace takes, and the runtime-config door finds nothing to read.
71+
* namespace takes, and the runtime-config door finds nothing to read. Its
72+
* Setup entry travels with it ({@link UNWALLED_ONLY_SETUP_NAV}).
7273
*
7374
* Such a manifest is held back at `init()` and registered from the
7475
* `kernel:ready` hook once the posture IN FORCE is known: during `init()` the

0 commit comments

Comments
 (0)