Repository navigation
Commit f085c3c
committed
fix(service-datasource)!: refuse creating a datasource named after a route literal
`GET /datasources/drivers` (the driver catalog) is mounted before
`GET /datasources/:name`, so a runtime datasource named `drivers` was
created but its detail read never reached. assertValidName now refuses every
literal the admin registrar mounts beside a same-method `/:name` route, from
the one list the registrar mounts the literal from; `default` is unchanged
and `test` stays creatable (no `POST /:name` sibling).
Claude-Session: https://claude.ai/code/session_01ADHkmPjMhxWBYAk48z4Mam
Co-authored-by: Claude <noreply@anthropic.com>1 parent 41bae08 commit f085c3c
4 files changed
Lines changed: 32 additions & 2 deletions
File tree
- .changeset
- packages/services/service-datasource/src
- __tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
204 | | - | |
| 204 | + | |
205 | 205 | | |
206 | 206 | | |
207 | 207 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| 48 | + | |
48 | 49 | | |
49 | 50 | | |
50 | 51 | | |
| |||
692 | 693 | | |
693 | 694 | | |
694 | 695 | | |
695 | | - | |
| 696 | + | |
696 | 697 | | |
697 | 698 | | |
698 | 699 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| 46 | + | |
46 | 47 | | |
47 | 48 | | |
48 | 49 | | |
| |||
1385 | 1386 | | |
1386 | 1387 | | |
1387 | 1388 | | |
| 1389 | + | |
| 1390 | + | |
| 1391 | + | |
| 1392 | + | |
| 1393 | + | |
| 1394 | + | |
| 1395 | + | |
| 1396 | + | |
| 1397 | + | |
| 1398 | + | |
1388 | 1399 | | |
1389 | 1400 | | |
1390 | 1401 | | |
| |||
0 commit comments