|
32 | 32 | * item in it carries an `overrides` block; |
33 | 33 | * - the same holds on a restart over the same database; |
34 | 34 | * - the pair's export carries the overriding item with its `overrides` block |
35 | | - * (view, dashboard, report; see `pairServed`); |
36 | | - * - CONTROL: the pair's override row is published, and for view, dashboard |
37 | | - * and report the effective read of the base's name serves it, so the base |
38 | | - * export's answer is the export's own. |
| 35 | + * (every type since #29613; see `pairServed`); |
| 36 | + * - CONTROL: the pair's override row is published, and the effective read of |
| 37 | + * the base's name serves it, so the base export's answer is the export's |
| 38 | + * own. |
39 | 39 | */ |
40 | 40 | import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, it, vi } from 'vitest'; |
41 | 41 | import { mkdtempSync, rmSync } from 'node:fs'; |
@@ -116,20 +116,21 @@ const SERVICE_COLLECTIONS = { |
116 | 116 |
|
117 | 117 | /** |
118 | 118 | * `pairServed`: whether the pair's export and the effective read serve the |
119 | | - * override. For the five types #29640 left in the bare slot neither does on |
120 | | - * this boot shape (the pair's per-package layer lists none of them, and the |
121 | | - * effective read serves the base's document; #29613), so only the base's half |
122 | | - * is pinned for them. |
| 119 | + * override. [#29613] True for every type: page, app, dataset, doc and book |
| 120 | + * were false while the reads declined their pair override as a sealed overlay |
| 121 | + * (the pair's per-package layer listed none of them, and on this boot shape, |
| 122 | + * with a `MetadataManager`, the effective read served the base's document). |
| 123 | + * The reads now serve it from its row, as a dashboard's. |
123 | 124 | */ |
124 | 125 | const TYPES = [ |
125 | 126 | { type: 'view', plural: 'viewItems', name: VIEW, pairServed: true }, |
126 | 127 | { type: 'dashboard', plural: 'dashboards', name: DASHBOARD, pairServed: true }, |
127 | 128 | { type: 'report', plural: 'reports', name: REPORT, pairServed: true }, |
128 | | - { type: 'page', plural: 'pages', name: 'showcase_start_here', pairServed: false }, |
129 | | - { type: 'app', plural: 'apps', name: 'showcase_app', pairServed: false }, |
130 | | - { type: 'dataset', plural: 'datasets', name: 'showcase_task_metrics', pairServed: false }, |
131 | | - { type: 'doc', plural: 'docs', name: 'showcase_index', pairServed: false }, |
132 | | - { type: 'book', plural: 'books', name: 'showcase_manual', pairServed: false }, |
| 129 | + { type: 'page', plural: 'pages', name: 'showcase_start_here', pairServed: true }, |
| 130 | + { type: 'app', plural: 'apps', name: 'showcase_app', pairServed: true }, |
| 131 | + { type: 'dataset', plural: 'datasets', name: 'showcase_task_metrics', pairServed: true }, |
| 132 | + { type: 'doc', plural: 'docs', name: 'showcase_index', pairServed: true }, |
| 133 | + { type: 'book', plural: 'books', name: 'showcase_manual', pairServed: true }, |
133 | 134 | ] as const; |
134 | 135 |
|
135 | 136 | /** The base's body, as the showcase's `defineStack` carries it: one fresh copy per reader. */ |
|
0 commit comments