Skip to content

Commit f82fd68

Browse files
committed
refactor(cloud-connection): place fieldPatchTargetRefusalsOf above the override write gate's docblock
The new step-2e helper sat between evaluateOverrideWriteGate and its own docblock, stacking two docblocks and leaving the gate undocumented. Moved unchanged; no behaviour change. Claude-Session: https://claude.ai/code/session_01FEkQ5nSMgkteiemkoN31vf Co-authored-by: Claude <noreply@anthropic.com>
1 parent 043407e commit f82fd68

1 file changed

Lines changed: 26 additions & 26 deletions

File tree

‎packages/cloud-connection/src/marketplace-install-local-plugin.ts‎

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -3247,32 +3247,6 @@ export class MarketplaceInstallLocalPlugin implements Plugin {
32473247
return null;
32483248
};
32493249

3250-
/**
3251-
* [ADR-0146 D2, ruling A on #28390; #28410] THE OVERRIDE WRITE GATE at the
3252-
* managed install — the door a package's items enter through as code
3253-
* (`manifest.register`), so the publish doors never see them. The rule is
3254-
* the publish doors' own (`judgeOverrideWrite`), over the walk `os
3255-
* validate` takes (`overrideWriteItemsOf`):
3256-
*
3257-
* - `refusals` — the incoming package's items the gate refuses: an
3258-
* undeclared same name a read-only package in its dependency closure
3259-
* ships, or an `overrides` declaration the gate does not admit (a
3260-
* dependent declaring, a base outside the closure, an excluded type,
3261-
* an object, a flow or action while their channel waits). A `.custom`
3262-
* package's admitted declarations install as at publish.
3263-
* - `collisions` — on a (re)install of a base, the names an installed
3264-
* dependent (a package whose closure holds this one) already holds,
3265-
* undeclared, that this version now ships. Listed on the answer, never
3266-
* refused (see {@link OverrideUpgradeCollision}).
3267-
*
3268-
* The card placed this gate point at `installPackage`; that door takes a
3269-
* manifest and no items (`PackageInstallManifestSchema`), and the
3270-
* unmanaged install copies through the save door (already gated), so the
3271-
* managed install is where a package's items arrive unjudged.
3272-
*
3273-
* Reads nothing it cannot: with no `objectql` registry or no protocol
3274-
* listing, the gate has no closure to judge and answers empty.
3275-
*/
32763250
/**
32773251
* [ADR-0146 D10, second rule] Step 2e of {@link handleInstall}: every
32783252
* `objectExtensions[].fieldPatches` entry the converted body carries —
@@ -3304,6 +3278,32 @@ export class MarketplaceInstallLocalPlugin implements Plugin {
33043278
return bodies.flatMap(({ body, prefix }) => fieldPatchTargetRefusals(body.objectExtensions, getTarget, prefix));
33053279
};
33063280

3281+
/**
3282+
* [ADR-0146 D2, ruling A on #28390; #28410] THE OVERRIDE WRITE GATE at the
3283+
* managed install — the door a package's items enter through as code
3284+
* (`manifest.register`), so the publish doors never see them. The rule is
3285+
* the publish doors' own (`judgeOverrideWrite`), over the walk `os
3286+
* validate` takes (`overrideWriteItemsOf`):
3287+
*
3288+
* - `refusals` — the incoming package's items the gate refuses: an
3289+
* undeclared same name a read-only package in its dependency closure
3290+
* ships, or an `overrides` declaration the gate does not admit (a
3291+
* dependent declaring, a base outside the closure, an excluded type,
3292+
* an object, a flow or action while their channel waits). A `.custom`
3293+
* package's admitted declarations install as at publish.
3294+
* - `collisions` — on a (re)install of a base, the names an installed
3295+
* dependent (a package whose closure holds this one) already holds,
3296+
* undeclared, that this version now ships. Listed on the answer, never
3297+
* refused (see {@link OverrideUpgradeCollision}).
3298+
*
3299+
* The card placed this gate point at `installPackage`; that door takes a
3300+
* manifest and no items (`PackageInstallManifestSchema`), and the
3301+
* unmanaged install copies through the save door (already gated), so the
3302+
* managed install is where a package's items arrive unjudged.
3303+
*
3304+
* Reads nothing it cannot: with no `objectql` registry or no protocol
3305+
* listing, the gate has no closure to judge and answers empty.
3306+
*/
33073307
private evaluateOverrideWriteGate = async (
33083308
ctx: PluginContext,
33093309
manifestId: string,

0 commit comments

Comments
 (0)