Skip to content
This repository was archived by the owner on Nov 4, 2026. It is now read-only.

Commit 0e2ddd4

Browse files
claude[bot]claude
andauthored
feat(types): NamedListView declares the 17 protocol members, each with a read point (objectui#8980) (#9534)
Fixes #8980 `NamedListView` (`@object-ui/types`) declared **none** of the 17 live members the protocol declares on the same surface. objectui was NARROWER than the protocol on all 17 — the direction the maintainer's standing principle forbids. This declares all 17 with their types taken from the protocol, and gives every one of them a read point in the same delivery. Governing ruling: director-seat class-one adjudication, objectui#8980 comment `5651818304`, 2026-09-13. Its four items are executed as written; none is re-litigated here. ## Premise, re-derived on this branch — the card still holds Re-measured at `origin/main` `bbc9dc34e3`, non-shallow, against the resolved `@objectstack/spec@17.4.0`, with the instrument self-tested on a firing positive control (two real interfaces, 9 and 2 members, both verified against source) and a non-firing negative control (a nonexistent interface name, exit 3): | reading | value | | --- | --- | | `ObjectListViewSchema` shape keys | **50** | | `NamedListView` members, before | **47** | | in protocol, absent from objectui | **22** | | of those, protocol tombstones | **5** — `bordered` `performance` `responsive` `striped` `virtualScroll` | | ⇒ live protocol members objectui did not declare | **17** ✅ | **The counting rule, published with the number** — the seat deliberately certified no total, so this is mine and is stated so it can be re-derived: *top-level property signatures at brace-depth 1 of the `export interface NamedListView` body, line and block comments stripped, `readonly` and `?` allowed; members of nested object-literal types are NOT counted.* Under that rule the interface reads 47 before and **64** after. The interface's own census pin (`object-view-unmirrored-keys-7779.test.ts`) walks the same population with the TypeScript parser and agrees. **The tombstones are measured, not assumed.** Each refuses a plausible value with a message naming its 17.0.0 removal. ⚠️ Six other keys also refused my first probe values (`name` `pageName` on a 2-character minimum, `data` `kanban` `gantt` `timeline` `chart` `grouping` on missing required inner fields) — that is the PROBE's fault and not six more tombstones, the same self-correction the earlier seat recorded. The discriminator is the refusal MESSAGE, not the refusal. ⚠️ The card's line citation had drifted as the seat warned: `NamedListView` opens at `objectql.ts:2088`, not `:2073`. Everything here binds to the SYMBOL. ## Ruled item 3 — `tabs`, measured before it was declared The protocol spends the word `tabs` on two different keys, and this establishes which one the list shape carries: - `ObjectListViewSchema` is `ListViewShapeSchema.omit({ userFilters }).extend({ userFilters: ObjectUserFiltersSchema })`, so the **top-level `tabs: z.array(ViewTabSchema)`** passes through untouched. That is the key declared here. - `userFilters.tabs` is the one `ObjectUserFiltersSchema` OMITS as page-only, in its own words: *"an object view's tab bar is its saved-view switcher (ViewTabBar), and a second one would collide."* objectui#9517's landing on this same file does not change that reading: it moved the user-filter FIELD shape and declared the container a dialect, not the container's `tabs`. objectui's `userFilters` dialect keeps carrying its own legacy `tabs` separately, so the two keys now sit on one interface and the declaration says so. ## What each of the 17 reaches `ObjectView` has three exits and the members do not all leave by the same one. | member | read point | | --- | --- | | `kanban` `calendar` `gallery` `timeline` `gantt` `map` | `generateViewSchema` — the AUTHORED path — now resolves the protocol's top-level block and merges the legacy `options.KIND` nesting under it, so each reaches `ObjectKanban` / `ObjectCalendar` / `ObjectGallery` / `ObjectTimeline` / `ObjectGantt` / `ObjectMap` | | `chart` `tree` | the same branch, on the one route objectui#5321 leaves open to a named view (see the report below) | | `grouping` `rowColor` | `ObjectGrid` on the authored grid path (it already reads both), and `ListView` through the host delegation | | `fieldOrder` `appearance` `userActions` | `ListView` through the host delegation. `fieldOrder` is the live third key of the protocol's `columns` times `hiddenFields` times `fieldOrder` composition — objectstack#15184 **ruling B**, read on the card rather than assumed: that card is OPEN, and its ruling B KEPT the key | | `data` | `ListView` — and the `as any` cast the renderer reached this key through is gone, which is objectui#7928's open half answered | | `name` | the named-view tab strip, between `label` and the record key | | `tabs` `pageName` | ⚠️ no renderer behaviour — REPORTED, see below | **The merge is per-KIND and per-KEY, not wholesale**, and identity is preserved when no canonical block is declared — which is the whole existing population, since these keys could not be authored before this change. So the renderer produces byte-identical nodes for every stored document, and there is an absence-control case beside every fix arm asserting exactly that. ## Ruled item 2's report — three members measured, none invented, none dropped *"A member for which the renderer has no behaviour to attach is REPORTED on this card with the measurement."* Posted in full on objectui#8980. - **`tabs`** — no reader on this surface. objectui's tab bar for an object is the HOST-owned saved-view switcher (ADR-0053); the only `tabs` read under `packages/plugin-list` is `UserFilters`' `config.tabs`, which is the page-only key, not this one. - **`pageName`** — `page` is not a member of `NamedListView['type']` (seven values against the protocol's ten), so no authored named view can select the branch this key configures. - **`chart` / `tree`** — READ, and the pin proves it, but objectui#5321 ruled both view KINDS host-composition-only. A named view reaches them only by declaring no `type` of its own while a host `views` entry selects the kind. The read is real; the authored route to it is not. All three stay declared. ⛔ No read point was invented to make the count come out even, and ⛔ no member was dropped to avoid the report. ## Types are taken from the protocol Sixteen index this package's own spec-derived `list-view` node type (`ListViewSchema`), whose members arrive from `SpecListViewSchema.shape` by reference — the derivation `NamedListView.userFilters` already used one member up, and the one that keeps a named view and the `list-view` node it is relayed INTO the same type for every key that crosses. `name` indexes the protocol's own published authored type (`ListView`, `@objectstack/spec/ui`) instead: on the node that spelling resolves through `BaseSchema.name`, the component-name slot — a different contract wearing the same word. ⚠️ **A first cut put that derivation in the zod mirror and was correctly refused** by `imported-defaults-8317.test.ts`: importing a spec schema into a mirror is a crossing of the objectui#8317 import boundary and must appear in that file's differential. The type-only import in `objectql.ts` crosses no boundary and the mirror is untouched. ## Two narrowings the protocol owns, found by tsc while writing the pins Reported rather than worked around, because the declared face is now the protocol's: - **`gantt` requires `titleField`** alongside `startDateField` / `endDateField`. Unlike the four blocks this package keeps a local `.partial()` dialect for, `gantt` flows into the mirror straight from `SpecListViewSchema.shape`, so the protocol's required bindings are required here. - **`chart` is the ADR-0021 dataset-bound shape only** (`dataset` + `values` required). The renderer still carries a legacy inline-aggregate branch below it (`xAxisField` / `valueField` / `aggregation`) that the declared face cannot express. ⛔ Not widened locally — that legacy shape still reaches the branch through the untyped `options.chart` bag, and narrowing an authoring surface toward the protocol is the direction the principle asks for. ## The census ledger is re-taken, not adjusted `object-view-unmirrored-keys-7779.test.ts` pins `NamedListView`'s population by name and by count, and its own failure message names the four files that carry the figures together. All four are updated in this change: **64 declared = 21 read + 43 unread** (was 47 = 6 + 41, plus one undeclared cast read). `tabs` and `pageName` are two of the 43, and the ledger's docblock says that is the ruled outcome rather than an oversight. The instrument agreement is re-pinned too: parser 64 = strict regex 64, loose regex 76 — still a gap of exactly 12, because every new member is a single-line type reference that adds no nested object literal. ⭐ One genuine ledger change beyond the numbers: the AST derivation and the `currentNamedViewConfig?.KEY` regex it replaced now disagree by one NAME, not just by sites — `name` is read only at the tab strip. The difference is asserted by name rather than smoothed over. ## Verification Run from the repo root in a dedicated worktree, every heavy run through the shared verify lock. - `pnpm exec vitest run packages/types/ packages/plugin-view/` — **229 files / 4707 tests passed**, lock VERDICT command-exit 0. - `pnpm --filter @object-ui/types --filter @object-ui/plugin-view type-check` — exit 0. It covers the new test file: its first run reported the two fixture errors that produced the `gantt` / `chart` findings above, so the coverage is a reading and not an assumption. - `pnpm --filter '@object-ui/plugin-view^...' build` — exit 0, 16 projects. The `@object-ui/types` dependency closure is EMPTY (it depends only on `@objectstack/spec` and `zod`), so that package's own closure build is a no-op and is reported as such rather than as a pass. - Gate families derived by hand from this repo's own `package.json` and `.github/workflows/`, ⛔ not from the sibling repo's `dispatch-gates.mjs`, which answers only about the tree it lives in: `check:control-bytes` `check:new-line-citations` `check:spec-symbols` `check:vi-mock-specifiers` `check:vi-mock-inherit` `check:vi-mock-override-shape` `check:test-path-roots` `check:changeset-claims` `check:comment-mask-corpus` `check:unreferenced-sources` `check:lint-rule-coverage` `check:handler-key-reads` `check:changeset-presence` — **all exit 0**. - `check:eager-closure`, `check:sdui-registration-pins` and `check:readme-exports` are **NOT MEASURED** here, ⛔ not red: each refuses for a missing console/workspace build in its own words ("this is a broken gauge, not a passing budget"; "the population COLLAPSED — this run proves nothing", citing 21 unbuilt packages). CI builds and owns them. - `eslint` on the six changed files: **0 errors**, 115 pre-existing warnings, exit 0. Package-scoped `lint` for both affected packages: **0 errors** (286 + 348 warnings, none new-rule). The narrowing is a measurement, with its three pieces: the covered population is `eslint .` minus this config's own `ignores`; the file count is 6, read from `--format json`; and the invariance holds because the config configures NO type-aware linting (zero `project` / `projectService` entries), so this diff cannot move the verdict on any file it does not touch. Measured on final head `0e69156`. - Control bytes: `grep -naP` over every changed file finds none, with a firing positive control on a synthetic file. ## Reverse verification — direction predicted before the run The renderer alone was restored to the merge-base on disk (blob `b6c0cc566b` to `008aa55149`, mutation proven by hash comparison AND by five marker counts going 4/1/1/1/1 to 0/0/0/0/0), the new pin re-run, then restored under a `trap ... EXIT INT TERM` and proven back by blob hash and an empty `git diff HEAD` on that path. Predicted: every FIX arm RED, every CONTROL arm GREEN. Measured: **13 failed, 7 passed** — the 13 are exactly the fix arms (six view kinds, the chart/tree route, the canonical-wins and per-key-merge arms, the grid pair, the delegation six, the `userActions` merge, the `name` fallback) and the 7 that stayed green are the controls (the legacy-nesting control, both absence controls, the `label` precedence and record-key controls, the `tabs`/`pageName` absence pin, and the `data` behavioural arm — which passes on both trees because the old cast relayed the same value, exactly as that case's own comment says, its source half being pinned in the types census instead). ⚠️ No `dist` preflight: this repo's root vitest config aliases every `@object-ui/*` specifier to that package's `src`, so the suite runs from source and an on-disk proof is the right evidence here. ## Scope - **`Clause-②: no`**, measured: the runtime accept set does not move. `ObjectViewSchema.listViews` is UNMIRRORED on the zod side and rides `BaseSchema`'s passthrough, so no parse changes; the TS face gains optional members, which widens rather than narrows. The `--pair` exit code is reported to the PM seat. - ⛔ No label added or removed, `needs:contract-review` included — labels are the PM seat's alone. - The 19 legacy spellings `NamedListView` declares beyond the protocol are objectui#7924's remedy and are untouched (ruled item 4). That card shares this file and is serial behind this one. - ⛔ `packages/app-shell` is NOT touched, though it is where `name` is written today (`mergeViewsIntoObjects` stamps `name: key` on every composed entry and primary-view promotion matches on it — recorded at the declaration as the evidence that this key has been travelling on this surface undeclared). It is outside the claim's declared file surface. - ⛔ Opened as a draft. Not undrafted, approved, enqueued or merged. --- _Generated by [Claude Code](https://claude.ai/code/session_01L5xpA5q533BgTTNADibEFt)_ --------- Co-authored-by: Claude <noreply@anthropic.com>
1 parent 061226c commit 0e2ddd4

8 files changed

Lines changed: 950 additions & 94 deletions
Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
---
2+
'@object-ui/types': minor
3+
'@object-ui/plugin-view': minor
4+
---
5+
6+
**`NamedListView` declares the 17 members the protocol declares on the same
7+
surface, and each one now has a read point** (objectui#8980, director-seat
8+
class-one adjudication of 2026-09-13, under the maintainer's standing principle
9+
that the objectstack protocol is the source of truth and objectui catches up to
10+
it rather than the other way round).
11+
12+
`appearance` `calendar` `chart` `data` `fieldOrder` `gallery` `gantt` `grouping`
13+
`kanban` `map` `name` `pageName` `rowColor` `tabs` `timeline` `tree`
14+
`userActions` — all seventeen were declared by `ObjectListViewSchema`
15+
(`@objectstack/spec/ui`), the declared value type of both `ViewSchema.listViews`
16+
and `ObjectSchema.listViews`, and by none of them by `@object-ui/types`. An
17+
author writing the shape the protocol teaches got a view that rendered as though
18+
nothing had been configured, with no diagnostic anywhere.
19+
20+
**Types are taken from the protocol, not restated.** Sixteen index this
21+
package's own spec-derived `list-view` node type (`ListViewSchema`), whose
22+
members arrive from `SpecListViewSchema.shape` by reference — the derivation
23+
`NamedListView.userFilters` already used, and the one that keeps a named view
24+
and the `list-view` node it is relayed into the same type for every key that
25+
crosses. `name` indexes the protocol's own published authored type (`ListView`,
26+
`@objectstack/spec/ui`) directly, because on the node that spelling resolves
27+
through `BaseSchema.name` — the component-name slot, a different contract
28+
wearing the same word.
29+
30+
**What an author can now do that silently did nothing before:**
31+
32+
| key | reaches |
33+
| --- | --- |
34+
| `kanban` `calendar` `gallery` `timeline` `gantt` `map` | the renderer `ObjectView` dispatches to for that `type` — `ObjectKanban`, `ObjectCalendar`, `ObjectGallery`, `ObjectTimeline`, `ObjectGantt`, `ObjectMap` — at the protocol's own top level. The legacy `options.<kind>` nesting keeps working; a canonical block wins key-by-key over it, so a partially declared block does not blank its legacy neighbour |
35+
| `chart` `tree` | the same dispatch, on the one route objectui#5321 leaves open to a named view (it declares no `type`, a host `views` entry selects the kind) |
36+
| `grouping` `rowColor` | `ObjectGrid` on the authored grid path, and `ListView` through the host delegation |
37+
| `fieldOrder` `appearance` `userActions` | `ListView` through the host delegation. `fieldOrder` is the live third key of the protocol's `columns` × `hiddenFields` × `fieldOrder` composition (objectstack#15184 ruling B) |
38+
| `data` | `ListView` — and the `as any` cast the renderer used to reach this key through is gone, which answers objectui#7928's open half |
39+
| `name` | the named-view tab strip, between `label` and the record key |
40+
41+
**Two members are declared and NOT read, and that is the ruled outcome rather
42+
than an oversight** — the ruling requires a member with no renderer behaviour to
43+
be reported with its measurement, never silently dropped from the type.
44+
`tabs` on the list shape is the `ViewTabSchema[]` multi-tab definition list (not
45+
`userFilters.tabs`, which the protocol omits from an object view as page-only),
46+
and objectui's tab bar for an object is the host-owned saved-view switcher
47+
(ADR-0053). `pageName` configures the protocol's `type: 'page'` branch, and
48+
`page` is not a member of `NamedListView['type']`. Both measurements are reported
49+
on objectui#8980.
50+
51+
**Compatibility.** Every addition is an optional member, and every read is a new
52+
rung whose source could not be authored before this change — so on existing
53+
documents the renderer produces the same nodes it produced before, proven by an
54+
absence-control case beside each fix. The 19 legacy spellings `NamedListView`
55+
declares beyond the protocol are objectui#7924's remedy and are untouched.

‎.changeset/object-view-unmirrored-keys-7779.md‎

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,20 +45,21 @@ three spec-modelled keys are optional slots on `ListViewSchema` and
4545
`ObjectListViewSchema`; the six local keys have no spec slot anywhere.
4646

4747
**`listViews` stays unmirrored, on the ruling's own fallback clause.** The
48-
declaration's value is the local `NamedListView` — **47 declared top-level
49-
members**, of which the renderer reads six: `label`, `type`, `columns`,
50-
`filter`, `sort`, `options`. It reads a seventh key off a named view, `data`,
51-
but `data` is **not a declared member of `NamedListView` at all**: it reaches
52-
the renderer through an `as any` cast on the named-view config in
53-
`packages/plugin-view/src/ObjectView.tsx`, so it never was one of the declared
54-
members a mirror would have to carry. The spec's `ViewSchema.listViews` is a
48+
declaration's value is the local `NamedListView` — **64 declared top-level
49+
members** (⚠️ re-taken at objectui#8980, which added the seventeen the protocol
50+
declares on this surface to the 47 this entry first measured), of which the
51+
renderer reads **21** off a named view. `data` is one of the 21 now: it used to
52+
reach the renderer through an `as any` cast on the named-view config in
53+
`packages/plugin-view/src/ObjectView.tsx` and be declared nowhere, and the
54+
objectui#8980 ruling declared it by name — objectui#7928's open half, answered.
55+
The spec's `ViewSchema.listViews` is a
5556
record of the STRICT `ObjectListViewSchema`, which requires `columns` and
5657
refuses `options`, ObjectQL tuple filters and `default` — that is, it refuses
5758
the named views this package's own README and
5859
`content/docs/api/schema-reference.md` teach (`{ label: 'All Users' }` fails at
5960
`columns`; `filter: [["owner", "=", "..."]]` fails at `filter.0`). Mirroring the
6061
spec value would lose documented behaviour; mirroring the local value would
61-
enforce **41 unread members** (47 declared, minus the 6 that are both declared
62+
enforce **43 unread members** (64 declared, minus the 21 that are both declared
6263
and read) into the contract — the
6364
very thing ruling B refused for the six local keys. The key therefore stays in
6465
the parity ledger with that measurement, pinned, until the maintainer decides its

‎packages/plugin-view/src/ObjectView.tsx‎

Lines changed: 110 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1317,7 +1317,51 @@ export const ObjectView: React.FC<ObjectViewProps> = ({
13171317

13181318
// Resolve type-specific options from current named view or active view
13191319
// Per @objectstack/spec, type-specific config MUST be nested under the view type key
1320-
const viewOptions = currentNamedViewConfig?.options || activeView || {};
1320+
const legacyViewOptions: Record<string, any> = currentNamedViewConfig?.options || activeView || {};
1321+
1322+
// ⭐ objectui#8980 — THE CANONICAL, PROTOCOL-DECLARED PLACE FOR THE EIGHT
1323+
// VIEW-KIND BLOCKS, read here for the first time.
1324+
//
1325+
// The protocol carries `kanban` / `calendar` / `gallery` / `timeline` /
1326+
// `gantt` / `map` / `chart` / `tree` at the TOP LEVEL of a list view
1327+
// (`ObjectListViewSchema`, the declared value type of `ViewSchema.listViews`).
1328+
// objectui read them only out of the legacy untyped `options` bag above, so
1329+
// all eight were undeclared on `NamedListView` and an author writing the
1330+
// shape the protocol teaches got a view that rendered as if nothing had been
1331+
// configured. Director-seat ruling of 2026-09-13 on objectui#8980, item 2:
1332+
// each declared member gets a read point in the same delivery.
1333+
//
1334+
// MERGE, not replace, and per-KIND rather than wholesale: the legacy nesting
1335+
// stays working (stored views carry it, and it is where the legacy field
1336+
// aliases `groupField` / `imageField` / `dateField` live), while a canonical
1337+
// block wins key-by-key over the legacy one for the same kind. A partially
1338+
// declared canonical block therefore does not blank its legacy neighbour.
1339+
//
1340+
// ⚠️ IDENTITY IS PRESERVED WHEN NOTHING CANONICAL IS DECLARED — the `else`
1341+
// arm hands back the very object the line above produced. That is the whole
1342+
// population today (the keys could not be authored before this change), so
1343+
// this change is provably inert on every existing document.
1344+
const canonicalViewKindBlocks: Record<string, unknown> = {
1345+
kanban: currentNamedViewConfig?.kanban,
1346+
calendar: currentNamedViewConfig?.calendar,
1347+
gallery: currentNamedViewConfig?.gallery,
1348+
timeline: currentNamedViewConfig?.timeline,
1349+
gantt: currentNamedViewConfig?.gantt,
1350+
map: currentNamedViewConfig?.map,
1351+
chart: currentNamedViewConfig?.chart,
1352+
tree: currentNamedViewConfig?.tree,
1353+
};
1354+
const declaredKinds = Object.keys(canonicalViewKindBlocks)
1355+
.filter((kind) => canonicalViewKindBlocks[kind] != null);
1356+
const viewOptions: Record<string, any> = declaredKinds.length === 0
1357+
? legacyViewOptions
1358+
: declaredKinds.reduce(
1359+
(acc, kind) => ({
1360+
...acc,
1361+
[kind]: { ...(legacyViewOptions[kind] ?? {}), ...(canonicalViewKindBlocks[kind] as object) },
1362+
}),
1363+
{ ...legacyViewOptions } as Record<string, any>,
1364+
);
13211365

13221366
// Dev-mode warning for flat property access violations
13231367
if (process.env.NODE_ENV === 'development') {
@@ -1742,6 +1786,20 @@ export const ObjectView: React.FC<ObjectViewProps> = ({
17421786
sort: viewSort || schema.table?.sort,
17431787
pagination: schema.table?.pagination,
17441788
selection: schema.table?.selection,
1789+
// ⭐ objectui#8980 — the AUTHOR-REACHABLE read point for two of the
1790+
// seventeen. `ObjectGrid` already reads both (`schema.grouping` in its
1791+
// group-field memo and its reference collector, `useRowColor(schema.rowColor)`),
1792+
// and this default content renderer is where an authored `object-view`
1793+
// with a `type: 'grid'` named view actually lands — the `renderListView`
1794+
// delegation above runs only for a HOST (objectui#5097).
1795+
//
1796+
// NAMED-VIEW SOURCED ONLY. ⛔ No `activeView` rung: the host `views` path
1797+
// has never fed these two slots on this branch, and widening it here would
1798+
// be a behaviour change on a surface this card does not own. Undefined is
1799+
// what `ObjectGrid` reads today for both keys, so the value only ever
1800+
// changes for a document that authors the protocol key.
1801+
grouping: currentNamedViewConfig?.grouping,
1802+
rowColor: currentNamedViewConfig?.rowColor,
17451803
pageSize: schema.table?.pageSize,
17461804
selectable: schema.table?.selectable,
17471805
className: schema.table?.className,
@@ -1963,7 +2021,11 @@ export const ObjectView: React.FC<ObjectViewProps> = ({
19632021
densityMode: activeView?.densityMode,
19642022
groupBy: activeView?.groupBy,
19652023
groupBy2: activeView?.groupBy2,
1966-
grouping: activeView?.grouping,
2024+
// objectui#8980 — the protocol declares `grouping` on a named list
2025+
// view and `ListView` reads it (`schema.grouping`); the named view had
2026+
// no rung here at all. Canonical source first, host `views` entry
2027+
// second — the precedence every other pair on this branch uses.
2028+
grouping: currentNamedViewConfig?.grouping ?? activeView?.grouping,
19672029
options: currentNamedViewConfig?.options || activeView,
19682030
// Toolbar policy — one vocabulary (#2890). The host node and the
19692031
// active view may still carry the legacy bare `show*` flags, so both
@@ -1973,6 +2035,11 @@ export const ObjectView: React.FC<ObjectViewProps> = ({
19732035
userActions: {
19742036
...(normalizeListViewSchema(schema ?? {}) as { userActions?: object }).userActions,
19752037
...(normalizeListViewSchema(activeView ?? {}) as { userActions?: object }).userActions,
2038+
// objectui#8980 — the named view is the most specific source, so it
2039+
// folds in LAST. Spread rather than `??` on purpose: this slot is a
2040+
// merge of toggle sets, not a winner-takes-all pick, and a named
2041+
// view that toggles one action must not blank the rest.
2042+
...currentNamedViewConfig?.userActions,
19762043
},
19772044
compactToolbar: activeView?.compactToolbar ?? (schema as any).compactToolbar,
19782045
allowExport: activeView?.allowExport ?? (schema as any).allowExport,
@@ -1991,7 +2058,10 @@ export const ObjectView: React.FC<ObjectViewProps> = ({
19912058
// the objectui#5097 HOST-COMPOSITION exemption the 2026-08-18
19922059
// ruling fixed at 27, which is a ruling and not a refactor.
19932060
// `grouping` above is the precedent for a view-only rung here.
1994-
rowColor: activeView?.rowColor,
2061+
// objectui#8980 adds the named-view rung ahead of it — still
2062+
// VIEW-SOURCED ONLY, still no `(schema as any)` fallback, so the
2063+
// objectui#5097 exemption stays fixed at 27 names.
2064+
rowColor: currentNamedViewConfig?.rowColor ?? activeView?.rowColor,
19952065
// Propagate view-config properties (Bug 4 / items 14-22)
19962066
inlineEdit: activeView?.inlineEdit ?? (schema as any).inlineEdit,
19972067
wrapHeaders: activeView?.wrapHeaders ?? (schema as any).wrapHeaders,
@@ -2005,7 +2075,13 @@ export const ObjectView: React.FC<ObjectViewProps> = ({
20052075
// ViewData source override (spec `data` key) — e.g. gantt views fed
20062076
// by a composite api endpoint; without this pick the api provider
20072077
// never reaches the renderer.
2008-
data: (currentNamedViewConfig as any)?.data ?? (activeView as any)?.data ?? (schema as any).data,
2078+
// objectui#8980 / objectui#7928's open half: the cast on the
2079+
// named-view config is GONE — `data` is a declared `NamedListView`
2080+
// member now, so the read and the declaration are one fact. The
2081+
// `activeView` and node rungs keep their casts: the host `views` entry
2082+
// is an untyped host shape and `data` on the node is one of the 27
2083+
// objectui#5097 host-composition keys.
2084+
data: currentNamedViewConfig?.data ?? (activeView as any)?.data ?? (schema as any).data,
20092085
// Propagate new spec properties (P0/P1/P2)
20102086
navigation: activeView?.navigation ?? (schema as any).navigation,
20112087
selection: activeView?.selection ?? (schema as any).selection,
@@ -2014,6 +2090,23 @@ export const ObjectView: React.FC<ObjectViewProps> = ({
20142090
filterableFields: activeView?.filterableFields ?? (schema as any).filterableFields,
20152091
resizable: activeView?.resizable ?? (schema as any).resizable,
20162092
hiddenFields: activeView?.hiddenFields ?? (schema as any).hiddenFields,
2093+
// objectui#8980 — TWO SLOTS THAT HAD NO RUNG ON THIS BRANCH AT ALL.
2094+
//
2095+
// `fieldOrder` is the live third key of the protocol's
2096+
// `columns` x `hiddenFields` x `fieldOrder` composition — objectstack#15184
2097+
// ruling B (2026-09-11) KEPT it and ruled the composition into the
2098+
// contract: `columns` projects, `hiddenFields` (the line above)
2099+
// subtracts, `fieldOrder` orders what survives. `ListView` applies all
2100+
// three in one memo; only this relay never carried the third.
2101+
//
2102+
// `appearance` carries `showDescription` and the ADR-0047
2103+
// `allowedVisualizations` whitelist, both read by `ListView`.
2104+
//
2105+
// View-sourced only, like `grouping` / `rowColor` above: ⛔ no
2106+
// `(schema as any)` fallback, so the objectui#5097 exemption is
2107+
// untouched.
2108+
fieldOrder: currentNamedViewConfig?.fieldOrder,
2109+
appearance: currentNamedViewConfig?.appearance ?? activeView?.appearance,
20172110
rowActions: activeView?.rowActions ?? (schema as any).rowActions,
20182111
rowActionDefs: (activeView as any)?.rowActionDefs ?? (schema as any).rowActionDefs,
20192112
bulkActions: activeView?.bulkActions ?? (schema as any).bulkActions,
@@ -2089,7 +2182,19 @@ export const ObjectView: React.FC<ObjectViewProps> = ({
20892182
<TabsList className="w-auto">
20902183
{entries.map(([key, view]) => (
20912184
<TabsTrigger key={key} value={key} className="text-sm">
2092-
{view.label || key}
2185+
{/*
2186+
* objectui#8980 — `name` is the protocol's own identity for a
2187+
* view, distinct from the record KEY it is filed under. It slots
2188+
* between the two as the display fallback: a view that declares
2189+
* one shows it instead of a synthetic key.
2190+
*
2191+
* ⚠️ MEASURED INERT ON THE LIVE PRODUCER, deliberately:
2192+
* `@object-ui/app-shell`'s `applyViewItem` stamps `name: key` on
2193+
* every composed `listViews` entry, so `view.name || key` is the
2194+
* same string there and no existing tab label moves. It changes
2195+
* only for an authored view whose `name` differs from its key.
2196+
*/}
2197+
{view.label || view.name || key}
20932198
</TabsTrigger>
20942199
))}
20952200
</TabsList>

0 commit comments

Comments
 (0)