This repository was archived by the owner on Nov 4, 2026. It is now read-only.
Repository navigation
Commit 0ffc423
fix(components): page:header stops drawing an empty breadcrumb slot; the key is ignored until the spec retires it (objectui#11166) (#11172)
Fixes #11166
Clause-②: no
Implements the renderer and docs half of triage `5903152845` (ruling
RETIRE). The spec half is objectstack-ai/objectstack#20758; this PR does
not depend on it. Dispatched by the `domain:ui` seat 2 PM, session
`https://claude.ai/code/session_011p7ikEivgXefNDaE5S5Uec`, branch
`claude/issue-11166-page-header-breadcrumb-retire`.
## What changed
- **Renderer.** `PageHeaderRenderer` in
`packages/components/src/renderers/layout/containers.tsx` no longer
reads `breadcrumb`. It drops both empty `data-page-breadcrumb-slot`
divs: the record-chip layout's (above `RecordTitleChip`) and the bare
layout's (above the title row). An authored `breadcrumb` (`true` or
`false`, in `properties` or on the node) renders exactly like an absent
key: no slot and no error. ⛔ No trail is drawn in its place.
- **Registration.** `inputs` keeps `{ name: 'breadcrumb', type:
'boolean' }` and adds a description saying the key is ignored. It stays
declared while the installed spec (17.4.0) still accepts the key; the
measured reasons are in Zone 2 item 2 below. It leaves at the pin bump
that brings objectstack#20758's tombstone, when the parity file's
forward direction will name it.
- **Docs.** `content/docs/layout/page-header.mdx` drops the key's
prop-table row, the "renders an empty slot element" paragraph, and the
layout diagram's `(breadcrumb slot)` line. **One sentence** replaces the
paragraph. I chose one sentence over none because the spec still
publishes the key as "Show breadcrumb", default `true`, and this page is
where an author learns it draws nothing.
- **Declared surface extension: `content/docs/guide/layout.md`.** It is
outside the claimed surface, but this change makes it false, so it is a
must-fix.
- Its `page:header` Schema API excerpt listed `breadcrumb?: boolean //
default true — the breadcrumb slot above the title`. That line goes.
- Three callouts called the key "a boolean display toggle (for the slot
above the title)". They now say it is a boolean the renderer ignores.
- Same file, same defect class: the overview bullet "PageHeader -
Consistent page headers with title, breadcrumbs, and actions" drops
"breadcrumbs". Neither the canonical renderer nor `@object-ui/layout`'s
`PageHeader` draws one; the latter's render body has no breadcrumb
element.
- The claim did not check open PRs against this file. Please check for
overlap before landing.
- **Changeset.** `'@object-ui/components': patch`, which names the
visible spacing shift.
## Zone 2 measurements (base `c2a8d23c6`)
1. **Sites.** All confirmed by content:
- the read `const breadcrumb = (schema?.breadcrumb ??
schema?.properties?.breadcrumb) !== false;`;
- the two `{breadcrumb && (...data-page-breadcrumb-slot...)}` blocks;
- the "breadcrumb/action slots" section comment, now "action slot".
**Root class strings are byte-unchanged.** The bare root is `flex
flex-col gap-2 pb-4 border-b`, and the record root keeps `gap-3
sm:gap-4`. The demo pin `pageheader-with-actions.test.tsx` stays green
on `gap-2` / `pb-4` / `border-b`.
**The rendered spacing does move.** Measured in Chromium 1194 (headless)
with plain CSS equal to the Tailwind utilities, not the built
stylesheet:
| Layout | Title offset in the header | Header height |
|---|---|---|
| bare | 8px, now 0px | 56px, now 48px |
| record | 4px, now 0px | 60px, now 56px |
The empty div was a flex item in the root's `gap-2` column (bare), or
carried `mb-1` (record). A header that already set `breadcrumb: false`
does not move.
2. **Registration inputs list `breadcrumb`.** ⛔ The parity file
`apps/console/src/__tests__/registry-inputs-spec-parity.test.ts` is
untouched.
- It has no `page:header.breadcrumb` row. `NO_READ_SITE_TO_PIN` lives in
its member-pin ledger, which covers array- and object-armed inputs only,
and `breadcrumb` is boolean. So removing the read moves no row, and the
file stays green at head.
- Why the input must stay, measured with a one-off probe (not kept):
- with the input declared, an authored `breadcrumb: true` draws **zero**
manifest diagnostics;
- with the input filtered out, it draws `unknown-prop`, whose message
says page:header has no prop "breadcrumb";
- the control, the key absent with the input filtered out, draws zero.
- Dropping the input would also be demanded back by the parity file's
reverse direction, which reads every accepted spec key. Covering it
needs an `UNPUBLISHED_EXEMPTIONS` entry in that file, which belongs to
objectui#11086.
3. **Docs.** The key leaves all three sites. One sentence was chosen
(see above).
4. **Existing pins.** None moved.
- `git grep -n breadcrumb -- '*.test.*'` under `packages/components` and
`examples/schema-catalog` hits only `ui:breadcrumb` and config-panel
suites.
- The objectui#11162 demo pins assert the root class strings, which did
not change.
- The `actions-slot` pins are green: the full components suite is below,
and the new pin asserts `data-page-actions-slot` in both layouts.
## Tests (all at head `8ef26fe20`, unless marked)
- **New pin:
`packages/components/src/__tests__/page-header-breadcrumb-ignored-11166.test.tsx`.**
It mounts through the real `SchemaRenderer` and registry, in both
layouts.
- In each layout, three authored spellings are tested:
`properties.breadcrumb: true`, `breadcrumb: true` on the node, and
`properties.breadcrumb: false`.
- Each renders no slot and no `breadcrumb` text anywhere in the header,
with no `console.error`.
- Each renders the same header markup as the absent-key CONTROL, with
React ids blanked. The control asserts the `h1` and
`data-page-actions-slot`, so the test cannot pass on an empty header.
- Result: `Tests 8 passed (8)`, run at `26bc72b6e`, where
`containers.tsx` has the same blob as head.
- **`@object-ui/components` plus `examples/schema-catalog`.** Run as
`pnpm exec vitest run packages/components/ examples/schema-catalog/
--shard=N/4`, four shards under the verify lock. The unsharded run hit
the 560s timeout on the shared box, so it was sharded.
| Shard | Test files | Tests |
|---|---|---|
| 1/4 | 94 passed | 1354 passed, 7 skipped |
| 2/4 | 94 passed | 1534 passed, 10 skipped |
| 3/4 | 93 passed | 1796 passed |
| 4/4 | 92 passed, 1 skipped | 827 passed, 7 skipped |
That is 374 files, which equals the 376 `*.test.*` files `git ls-files`
lists minus two `.snap` files.
- **Cross-package readers: 75 files, 75 passed, 2006 tests.** This
covers every test outside those two trees that reads `containers.tsx` or
the two edited docs pages from disk, or names `page:header`. That
includes:
- `registry-inputs-spec-parity`, `public-contract` and
`component-input-union-specimens`;
- `widget-dom-leak-sweep`, `block-config*` and
`PageBlockInspector.i18n`;
- the RecordDetailView header suites, `page-breadcrumbs-refusal-8871`
and `zod-mirror-parity`;
- `scripts/__tests__/check-doc-component-types` and
`doc-version-claims`.
- **Type-check.** `pnpm --filter @object-ui/components type-check` exits
0, after `pnpm --workspace-concurrency=2 --filter
'@object-ui/components^...' build`. `tsc -p tsconfig.test.json
--listFiles` includes the new pin.
### Ablation (fix committed first; mutation and restore via
`ablation-replace.mjs` WRAP mode)
Each leg re-planted the old read-plus-slot in one layout only.
- **Bare leg: 4 failed, 4 passed.** Exactly the four bare rows went red:
the control, both `true` spellings, and `false` because it no longer
matches the control.
- **Record leg: 4 failed, 4 passed.** Exactly the four record rows went
red.
- **Restore.** After both legs, the blob equals HEAD (`c07608e4cc2a`),
`git diff HEAD` is empty, and `git status` is clean.
## Gates
**Pass (exit 0):**
- `check:doc-types`
- `check:doc-snippets`: 679 of 679 blocks judged, 0 failed. It ran after
`turbo run build` over its own `--build-filter` closure (35/35 tasks);
the first run exited 2 on unbuilt packages.
- `check:doc-examples`: exited 2 on the first run, then passed after the
same build.
- `docs:check-links`
- `check:doc-fences`
- `check:doc-example-ids`
- `check:doc-example-readers`
- `check-doc-expression-carriage`
- `check:control-bytes`, plus a self-scan of the five changed files for
control bytes, which found none
- `check:new-line-citations`
- `check-changeset-presence`
- `changeset:check`
- `check-changeset-overwrite`
- `check:changeset-claims`
- `check:pending-changeset-literals`
- `check:installed-pin-claims`
- `check:handler-key-reads`
- `check:action-forward-parity`
- `check:element-data-source-declaration`
- `check:designer-field-key-parity`
- `check:prompt-keys`
- `check:spec-symbols`
- `check:unreferenced-sources`
- `check:readme-exports`
- `check:test-path-roots`
- `check:vi-mock-specifiers` / `inherit` / `override-shape`
- `lint:coverage`
- `type-check:coverage`
- `check:phantom-deps`
- `check:self-import`
- `check:i18n-designer-parity`
- `check:metadata-write-doors`
**Not governed.** `check-governed-queue-guard --test` over the five
paths reports NOT GOVERNED. The PR stays draft because it was
dispatched.
**NOT MEASURED: `check:sdui-registration-pins`.** Reason: it needs a
console bundle (`apps/console/dist/assets`) and exits 2 without one.
This diff adds or removes no registration and moves no `sideEffects`.
Left to CI.
**ESLint, a proven narrowing of CI's `pnpm lint`:**
- Population, read from eslint's own config: of the five changed files,
only the two `.tsx` files match a configuration. For the `.md` / `.mdx`
/ changeset files eslint reports "File ignored because no matching
configuration was supplied".
- Count, read from `--format json`: 2 files, 0 errors.
- The new pin has 0 messages.
- `containers.tsx` has 97 warnings, identical to base by rule:
`no-explicit-any` 89, `only-export-components` 7, `exhaustive-deps` 1.
Base was read via `--stdin` at the same path.
- Invariance: `eslint.config.js` enables no type-aware linting (no
`parserOptions.project` / `projectService`), so this diff cannot move a
verdict on an untouched file.
## Acceptance notes (not filed)
- **At the pin bump carrying objectstack#20758's tombstone:**
- the `breadcrumb` entry in `inputs` must go; the parity file's forward
direction will name it;
- so must the one sentence in each doc page that says "accepts it until
objectstack#20758 retires it".
- Carrier: the objectui spec pin-bump PR.
- **The bare root's `gap-2` now spaces a single child,** the title row,
so it is inert. It is kept because the ruling moves no class and the
demo pin and docs quote it. Polish; carrier: none.
- **A stale test comment.** In
`packages/types/src/__tests__/page-breadcrumbs-refusal-8871.test.ts`,
the LIT CONTROL comment calls `.breadcrumb` "the live `page:header`
toggle", which is no longer true. The control itself still fires on many
other hits, and the test is green. It is an unpublished comment;
carrier: none.
- **Triage fact, for objectstack-ai/objectstack#20758's measurement.**
Triage says the spec's `nav:breadcrumb` "has no objectui renderer". The
parity file's `EXPECTED_WITHOUT_INPUTS` lists `nav:breadcrumb` as
"Registered, spec-carried, and deliberately propless". This is a
read-only inference; carrier: objectstack-ai/objectstack#20758.
- `content/docs/guide/slotted-pages.md`'s example still authors
`breadcrumb: true`. That file belongs to objectui#11165 and is left
untouched. The value renders without error and is ignored.
## Out-of-scope finding (reported to the seat for filing, class c)
**The Studio page designer still offers a "Show breadcrumb" toggle for
`page:header`.**
- The producer is `BLOCK_CONFIG['page:header']` in
`packages/app-shell/src/views/metadata-admin/previews/block-config.ts`,
labelled by `engine.inspector.pageBlock.field.page:header.breadcrumb`
(en "Show breadcrumb", zh "显示面包屑").
- It writes `breadcrumb` into stored page metadata, which the renderer
now ignores. Once objectstack#20758's tombstone is installed, the
platform will refuse the whole node by name.
- That file's own `icon` precedent pin says "A retirement that leaves
its producer standing makes the failure worse, not better."
- `block-config.test.ts` pins the field set as `['title', 'subtitle',
'breadcrumb']`.
- It is not fixed here: it adds `packages/app-shell` and i18n to the
verification surface, which fails condition ④ of the bounded in-place
fix.
---
_Generated by [Claude
Code](https://claude.ai/code/session_011p7ikEivgXefNDaE5S5Uec)_
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent cecd6a0 commit 0ffc423
5 files changed
Lines changed: 201 additions & 24 deletions
File tree
- .changeset
- content/docs
- guide
- layout
- packages/components/src
- __tests__
- renderers/layout
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
199 | 199 | | |
200 | 200 | | |
201 | 201 | | |
202 | | - | |
203 | | - | |
| 202 | + | |
| 203 | + | |
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
| |||
300 | 300 | | |
301 | 301 | | |
302 | 302 | | |
303 | | - | |
304 | 303 | | |
305 | 304 | | |
306 | 305 | | |
| |||
318 | 317 | | |
319 | 318 | | |
320 | 319 | | |
321 | | - | |
322 | | - | |
323 | | - | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
324 | 323 | | |
325 | 324 | | |
326 | 325 | | |
| |||
698 | 697 | | |
699 | 698 | | |
700 | 699 | | |
701 | | - | |
| 700 | + | |
702 | 701 | | |
703 | 702 | | |
704 | 703 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
49 | 48 | | |
50 | 49 | | |
51 | 50 | | |
| |||
68 | 67 | | |
69 | 68 | | |
70 | 69 | | |
71 | | - | |
72 | | - | |
| 70 | + | |
| 71 | + | |
73 | 72 | | |
74 | 73 | | |
75 | 74 | | |
| |||
146 | 145 | | |
147 | 146 | | |
148 | 147 | | |
149 | | - | |
150 | 148 | | |
151 | 149 | | |
152 | 150 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1283 | 1283 | | |
1284 | 1284 | | |
1285 | 1285 | | |
1286 | | - | |
| 1286 | + | |
1287 | 1287 | | |
1288 | 1288 | | |
1289 | 1289 | | |
| |||
1505 | 1505 | | |
1506 | 1506 | | |
1507 | 1507 | | |
1508 | | - | |
| 1508 | + | |
| 1509 | + | |
| 1510 | + | |
| 1511 | + | |
| 1512 | + | |
| 1513 | + | |
1509 | 1514 | | |
1510 | 1515 | | |
1511 | 1516 | | |
| |||
2340 | 2345 | | |
2341 | 2346 | | |
2342 | 2347 | | |
2343 | | - | |
2344 | | - | |
2345 | | - | |
2346 | | - | |
2347 | | - | |
2348 | | - | |
2349 | 2348 | | |
2350 | 2349 | | |
2351 | 2350 | | |
| |||
2376 | 2375 | | |
2377 | 2376 | | |
2378 | 2377 | | |
2379 | | - | |
2380 | | - | |
2381 | | - | |
2382 | 2378 | | |
2383 | 2379 | | |
2384 | 2380 | | |
| |||
2413 | 2409 | | |
2414 | 2410 | | |
2415 | 2411 | | |
2416 | | - | |
| 2412 | + | |
| 2413 | + | |
| 2414 | + | |
| 2415 | + | |
| 2416 | + | |
| 2417 | + | |
| 2418 | + | |
| 2419 | + | |
2417 | 2420 | | |
2418 | 2421 | | |
2419 | 2422 | | |
| |||
0 commit comments