This repository was archived by the owner on Nov 4, 2026. It is now read-only.
Repository navigation
Commit 3ef0b51
fix(plugin-map, plugin-gantt): objectName is not a required registration input (objectui#7470) (#10390)
Fixes #7470
Clause-②: no
## What changed
Ruling 5809231477 (letter align, maintainer 「同意」), executed as written:
- `objectName` loses `required: true` on every map and gantt
registration key, re-derived by symbol on `origin/main` `62bc8a250`:
`object-map` (namespace `plugin-map`), `map` (namespace `view`) and
`object-gantt` (namespace `plugin-gantt`). The bare `gantt` key is
already retired (objectui#8008), so gantt has one key today, not two.
- Its `description` now states the rule: the record source is one of
`data`, `staticData` and `objectName`, and the `object-map` /
`object-gantt` schema refuses a block that declares none of them.
- `packages/plugin-gantt/README.md`: the "`objectName` (required)"
sentence is corrected.
- No one-of vocabulary was added to the input declaration. The
renderers' read order and the zod mirrors are unchanged.
## Why the description is true (hypothesis 3)
`requireRecordSource` in `packages/types/src/zod/objectql.zod.ts` checks
`RECORD_SOURCE_KEYS` (`data`, `staticData`, `objectName`) and adds an
issue with `params.code` `RECORD_SOURCE_REQUIRED` when none is present.
It is attached with `superRefine(requireRecordSource('object-map'))` on
`ObjectMapSchema` and `superRefine(requireRecordSource('object-gantt'))`
on `ObjectGanttSchema`. The new tests assert this directly, so the
sentence in the description is checked by a test, not copied prose.
## What the required flag did at runtime
`sdui-parser`'s `validateTree` turns a required input into a
`missing-required-prop` ERROR. A `staticData`-only map or gantt drew
that error while the schema accepted the block and the renderer drew it.
After this change it no longer does.
## Hypothesis 2: pins and generated artefacts
No pin or generated artefact asserted `required: true` for these inputs.
`apps/console/public/manifest.json` (public-tier manifest) carries no
map or gantt entry. No test in `plugin-map` / `plugin-gantt` read the
inputs' `required`. `content/docs/plugins/plugin-map.mdx` and
`plugin-gantt.mdx` already say "At least one of data / staticData /
objectName is required", which is correct, so they are not touched.
`packages/plugin-map/README.md` makes no required claim.
## Tests
New tests:
`packages/plugin-map/src/index.recordSourceInput-7470.test.tsx` (both
map keys) and
`packages/plugin-gantt/src/__tests__/recordSourceInput-7470.test.ts`.
For each key they check four things: `objectName` is declared
(non-vacuity) and is not required; the description names the three
sources; the named schema refuses a block with no source, with
`RECORD_SOURCE_REQUIRED`; and, as a control, the same schema accepts a
`staticData`-only block.
All runs are on head `2083a24f8`:
- `pnpm exec vitest run packages/plugin-map/ packages/plugin-gantt/`:
`Test Files 97 passed (97)`, `Tests 705 passed (705)`.
- Reverse verification, done after the fix was committed. The mutation
was put back with `ablation-replace.mjs`, and each anchor was confirmed
to hit once. `required: true` restored on `object-gantt` gave `1 failed
/ 9 passed`. On `object-map` alone it gave `× 'object-map' — objectName
is declared and not required`, and on `map` alone `× 'view:map' — …`.
Each file was restored with `git checkout HEAD`, the restore was proved
by matching the HEAD blob hash, and `git diff HEAD` was empty
afterwards. The re-run was 10/10 green. The first map attempt was a
no-op: the anchor was ambiguous (x2) and the tool refused it, so it was
redone with per-key anchors.
- `type-check` (`tsc --noEmit && tsc -p tsconfig.test.json`) for both
packages: exit 0, after building the dependency closure. `--listFiles`
confirms that both new test files are in the test program.
## Acceptance notes
- The `map` key has no zod arm. `safeValidateSchema` on a `map` node
with `staticData` gives `invalid_union` ("Invalid input"), while
`object-map` with the same content passes. So on the `map` key the
description's sentence talks about the `object-map` schema, and a bare
`map` node is refused whatever it carries. This is reported to the seat
as a finding and not changed here.
- `data` / `staticData` are still not declared inputs on map or gantt.
`validateTree` therefore reports a `staticData`-only block as
`unknown-prop`, which is a warning, not an error. The ruling did not
order declaring them, so this is reported to the seat.
- `object-calendar` / `calendar` have the same disagreement one plugin
over: `objectName` is `required: true` while `ObjectCalendarSchema`
carries `requireRecordSource('object-calendar')`. That is out of this
card's ruling and reported to the seat.
## Gates (local, targeted)
Exit 0: `check:new-line-citations` (`VERDICT … 0 new citation(s)`),
`check:control-bytes`, `check:element-data-source-declaration`,
`check:component-surface-parity` (report-only; its divergences are on
the `map` / `gantt` config inputs and existed before this change),
`check:changeset-claims` (it points at
`.changeset/6470-gantt-dependency-field-deprecated.md`, which names the
gantt README; I read that paragraph and it is still true),
`check:pending-changeset-literals`, `check:vi-mock-*`,
`check:test-path-roots`, `check:registry-bare-names`,
`check:phantom-deps`, changeset presence, and
`check-governed-queue-guard --test` (NOT GOVERNED).
NOT MEASURED, left to CI:
- `check:sdui-registration-pins` exited 2 because the console build it
reads was absent.
- `check:readme-exports` exited 1 because only part of the packages were
built, so its population collapsed below its floors.
ESLint over the 4 touched source and test files: 0 errors (warnings
only, the same kinds as the file's existing ones). The config is not
type-aware, so this diff cannot change verdicts on untouched files.
Session `https://claude.ai/code/session_01D486C1axmXnrkJMNUfz2eb`,
`domain:ui#3` seat.
---
_Generated by [Claude
Code](https://claude.ai/code/session_01D486C1axmXnrkJMNUfz2eb)_
Co-authored-by: Claude <noreply@anthropic.com>1 parent ce6bd99 commit 3ef0b51
6 files changed
Lines changed: 206 additions & 5 deletions
File tree
- .changeset
- packages
- plugin-gantt
- src
- __tests__
- plugin-map/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
141 | | - | |
142 | | - | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
143 | 145 | | |
144 | 146 | | |
145 | 147 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
115 | 120 | | |
116 | 121 | | |
117 | 122 | | |
118 | 123 | | |
119 | 124 | | |
120 | | - | |
| 125 | + | |
121 | 126 | | |
122 | 127 | | |
123 | 128 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
62 | 67 | | |
63 | 68 | | |
64 | 69 | | |
65 | 70 | | |
66 | 71 | | |
67 | | - | |
| 72 | + | |
68 | 73 | | |
69 | 74 | | |
70 | 75 | | |
| |||
74 | 79 | | |
75 | 80 | | |
76 | 81 | | |
77 | | - | |
| 82 | + | |
78 | 83 | | |
79 | 84 | | |
80 | 85 | | |
0 commit comments