This repository was archived by the owner on Nov 4, 2026. It is now read-only.
Repository navigation
Commit 3fbdd4a
test(plugin-list): date the two query-absence controls to a settle window, not to mount (objectui#8705) (#8742)
* test(plugin-list): date the two query-absence controls to a settle window, not to mount (objectui#8705)
`ListView.objectProviderBinding-7477.test.tsx` asserts at two sites that no
query is started: the `object` provider that names no object must invent no
binding, and the `value` provider must never gain an `objectName`. Both
`expect(dataSource.find).not.toHaveBeenCalled()` reads sat straight after a
`waitFor` that is satisfied on the FIRST commit, so the absence was dated to
mount. An implementation strictly worse than the bug — one that fires
`dataSource.find` 50ms after every mount — passed both of them.
No anchor is available on either path: the `value` provider leaves `loading`
false from the first commit and never settles, and the object-provider-without-
object path only flips `loading` from the same branch a query would start from,
which cannot postdate a deferred one. The absence is watched over a bounded
250ms window instead — larger than the macrotask RTL's `asyncWrapper` already
drains for free, so a `setTimeout(…, 0)` regression can no longer hide inside
the pre-existing window.
The assertions themselves are unchanged; what they claim is objectui#7477's
contract. The other three absence reads in this file were swept and measured
to be a different shape — `dataSource.find` has already been called when each
of them runs, because `ListView` withholds the view spy behind its loading
skeleton until the query resolves — so they are left untouched.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YBWFb5YgMU5dw8p2VKj16S
* chore(changeset): declare the settle-window repair as releasing nothing (objectui#8705)
`check-changeset-presence.mjs` scores the edited test file as published source
of `@object-ui/plugin-list`; the change is test-only, so it declares an EMPTY
frontmatter — the gate's explicit exemption, not a workaround.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YBWFb5YgMU5dw8p2VKj16S
* test(plugin-list): record the measured mount-dating, not the inferred one (objectui#8705)
The file's own account of why the two pins were vacuous now cites the
measurement rather than the mechanism: in both tests the kanban spy has already
recorded two props entries by the time `render` returns, so the `waitFor` never
yields. The `loading` transition on the object-provider-without-object path is
labelled as what it is — read from the `useState` initializer — and its role is
narrowed to what it can actually date: a synchronous query, never a deferred
one.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YBWFb5YgMU5dw8p2VKj16S
---------
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>1 parent 5e96b45 commit 3fbdd4a
2 files changed
Lines changed: 76 additions & 1 deletion
File tree
- .changeset
- packages/plugin-list/src/__tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
51 | 84 | | |
52 | 85 | | |
53 | 86 | | |
54 | 87 | | |
55 | | - | |
| 88 | + | |
56 | 89 | | |
57 | 90 | | |
58 | 91 | | |
| |||
140 | 173 | | |
141 | 174 | | |
142 | 175 | | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
143 | 199 | | |
144 | 200 | | |
145 | 201 | | |
| |||
201 | 257 | | |
202 | 258 | | |
203 | 259 | | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
204 | 265 | | |
205 | 266 | | |
206 | 267 | | |
| |||
214 | 275 | | |
215 | 276 | | |
216 | 277 | | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
217 | 282 | | |
218 | 283 | | |
219 | 284 | | |
| |||
0 commit comments