Skip to content
This repository was archived by the owner on Nov 4, 2026. It is now read-only.

Commit 6230156

Browse files
committed
Merge origin/main (6c57c77) into claude/issue-10981-silence-clause-closure
Picks up PR #11018 (objectui#10996), which re-pinned the eager-closure baseline and ceiling that turned main's own Bundle Analysis red. Claude-Session: https://claude.ai/code/session_012UwY3ahMixEFkfTUxMVkYm Co-authored-by: Claude <noreply@anthropic.com>
2 parents ebd156e + 6c57c77 commit 6230156

60 files changed

Lines changed: 2401 additions & 203 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
---
2+
---
3+
4+
Comment-only in `@object-ui/app-shell`, `@object-ui/components`, `@object-ui/plugin-detail`,
5+
`@object-ui/plugin-form` and `@object-ui/plugin-grid`: docblocks and code comments that cited
6+
an `objectstack` issue or pull request by a bare number, which answers 404 in objectstack and
7+
resolves to an unrelated issue or pull request in this repository, now cite the commit in
8+
that repository that landed the change, written as objectstack and a 9-character sha
9+
(objectui#10803, the eighth batch). One of them sits inside a quotation of an objectstack
10+
source comment; there the commit stands in square brackets in place of the quoted number.
11+
Comments that named objectstack's card for the effective operation set on detail and form
12+
surfaces by its bare number, or qualified with this repository's name, now read
13+
`objectstack#3546`: in this repository that number is an unrelated card. None of these
14+
comment edits moves a claim or changes a code or type token. No published behaviour changes
15+
through them, so this declares no release.
16+
17+
The same repair in the one pending changeset that carried such a citation is prose-only, and
18+
its frontmatter is byte-identical.

‎.changeset/10885-object-view-route2-named-view-rest.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,6 @@ A named view's `navigation`, `fieldOrder` and `inlineEdit` now reach the registe
1515
What moves: only a named view that authors one of these three members. The objectui#5097 host-composition relay is unchanged.
1616

1717
`Clause-②: no` — no declared type, accepted key or published export moves. A renderer starts honouring members the spec already declares on a named view.
18+
19+
⚠️ **Dated note, 2026-09-28 — the New button now opens a create form under `split` and `popover` — objectui#10975.**
20+
Later in this same release, under a `split` or `popover` navigation, the node's own or the active named view's, the New button's create form opens on the surface the node uses with no `navigation`: the modal for `layout: 'modal'`, the drawer otherwise. A record opened to view or edit still opens beside the list. The sentence above that says the New button opens no form is kept as the reading of this change; the objectui#10975 entry states what ships.
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
---
2+
'@object-ui/app-shell': patch
3+
'@object-ui/i18n': patch
4+
---
5+
6+
fix(app-shell): a failed reaction write takes the reaction back and says so, instead of staying shown as applied (objectui#10899)
7+
8+
A reaction click on the record page's discussion shows at once and is stored in
9+
the background with a `sys_comment` update. That update was issued from inside
10+
the React state updater and its rejection was discarded, so a refused write
11+
left the reaction on screen as applied, with no message, until a reload. In a
12+
StrictMode development build the updater also ran twice, so one click sent two
13+
updates.
14+
15+
`RecordDetailView` now computes the toggle and issues the write from the click
16+
handler, one write per click. When a write is refused, the row shows the newest
17+
reaction set a write stored or can still store, and a localized error toast
18+
(`detail.reactionFailed`, new in all ten packs) says the reaction was not
19+
saved. A refused click that a later click's write also carries is kept, because
20+
each write stores the row's whole reaction set. The stored
21+
`{ emoji: userIds[] }` shape is unchanged.
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
'@object-ui/plugin-view': patch
3+
---
4+
5+
Under a `split` or `popover` navigation, `ObjectView`'s New button now opens a create form (objectui#10975).
6+
7+
Both surfaces draw a form only beside a selected record, and New clears the selected record, so until now the button did nothing under either mode. That held for the node's own `navigation` and, since objectui#10885, for the active named view's. The create form now opens on the surface the node uses with no `navigation`: the modal for `layout: 'modal'`, the drawer otherwise. A `layout: 'page'` node with an `onNavigate` handler still hands New to the router, as before. A record opened to view or edit still opens beside the list under `split`, and in the popover under `popover`.
8+
9+
`Clause-②: no` — no declared type, accepted key or published export moves.
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
---
2+
'@object-ui/types': minor
3+
---
4+
5+
feat(types): `ObjectMapConfigSchema` is `.strict()`, so `objectui validate` refuses an undeclared key in an `object-map` node's `map` block (objectui#5157)
6+
7+
⚠️ **The accept set narrows.** `ObjectMapSchema.map` is `ObjectMapConfigSchema`, which used
8+
to be a plain `z.object()`: a key it did not declare was stripped and the node parsed clean.
9+
The card's own typo, `latitudeFieId`, therefore validated clean and was never read, and neither
10+
`objectui validate` nor the runtime named it (only a TypeScript author's compiler did). The block is now closed, as ruled on objectui#5157 (letter A, carrying the earlier
11+
ruling that limits the change to the `map` block):
12+
13+
- **`safeValidateSchema` / `objectui validate`** refuse a `map` block carrying an undeclared
14+
key with an `unrecognized_keys` issue at `map` that names the key, and exit 1. One level
15+
down — the node inside a container's `children` — the refusal arrives as an
16+
`invalid_union` at `children`, and the arm detail `objectui validate` prints under it
17+
names the key at `children → 0 → map`.
18+
- **`objectui check`** is advisory and only uses validation to recognise a file: a root
19+
`object-map` document with no structural root key now moves into its "did not validate"
20+
list; a document whose root carries a structural key (`children`, `className`, …) is not
21+
validated by `check` and still passes it.
22+
- **The runtime keeps warning, not throwing.** `ObjectMap` still renders; its existing
23+
`safeParse` of the block now fails, so `[ObjectMap] Invalid map configuration` is warned
24+
in the console, naming the key.
25+
- `.shape` is unchanged, so `ObjectMap`'s `FLAT_MAP_CONFIG_KEYS` and the view flatten
26+
whitelists see the same keys.
27+
28+
**Measured breakage: none.** The pre-landing sweep the ruling required found no `map` block
29+
in authored metadata (objectui examples, apps and docs; objectstack examples and apps)
30+
carrying an undeclared key. Its population is held as a fixture in
31+
`packages/types/src/__tests__/object-map-config-strict-5157.test.ts`, which re-parses every
32+
block under the strict schema on each run; the fixture names the commits the population was
33+
enumerated at, and a block added since is not in it.
34+
35+
Other component sub-block schemas are untouched: whether they close the same way is a
36+
separate decision.
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
---
2+
'@object-ui/app-shell': minor
3+
---
4+
5+
**Narrowing — `ObjectView`'s props are the declared `ConsoleObjectViewProps`, not `any`.**
6+
7+
`ObjectView`, the route-level object surface this package exports, took a bare
8+
`any` for its props. That erased the prop names as well as their types: a
9+
misspelled prop compiled clean and was silently dropped, and a mount that left
10+
out `objects` compiled and then threw on first render at `objects.find(...)`.
11+
12+
Its props are now the exported `ConsoleObjectViewProps`:
13+
14+
- `dataSource: DataSource` — the published `@object-ui/types` contract, required;
15+
- `objects: any[]` — required;
16+
- `onEdit: (record: Record<string, unknown>) => void` — required;
17+
- `externalRefreshKey?: number`.
18+
19+
**What this means for a consumer.** Nothing observable changes at runtime; the
20+
one runtime byte is an optional call behind an existing guard. At the type
21+
level, `onEdit` and `objects` are now required (a mount without them is a
22+
compile error, TS2739), a misspelled prop is a compile error (TS2322), and
23+
`dataSource` must be a `DataSource`. A mount that passes the four props with
24+
values of the declared types compiles as before. An `onEdit` handler whose
25+
parameter is a narrower record type (for example an interface with required
26+
fields) is now refused under `strictFunctionTypes` and must accept
27+
`Record<string, unknown>`, and `externalRefreshKey` must be a number. The name
28+
is `ConsoleObjectViewProps`
29+
because `@object-ui/plugin-view` already exports `ObjectViewProps` for its
30+
schema-driven view, a different shape.
31+
32+
Marked `minor`, not `major`: this repo's fixed release group is pinned to the
33+
`@objectstack` major, so a narrowing is declared in the narrative rather than in
34+
the bump.

‎.changeset/7980-agent-key-envelope-read.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ surface was `packages/app-shell/**` — not as a ruling that it should stay priv
2020

2121
**The console fix this unblocks.** The Integrations page's "Connect an AI agent" section
2222
read `json?.error?.message` and stopped, so a refused key mint dropped two declared
23-
things: the producer's marked `error.userMessage` (the #9934 channel, whose presence *is*
23+
things: the producer's marked `error.userMessage` (the objectstack `79c46da90` channel, whose presence *is*
2424
the marking) and `error.code`. The 5xx band is where that cost most — the producing door
2525
substitutes the generic `Internal server error` into `message` while the mark rides
2626
through untouched, so a marked 500/503 showed the developer the generic sentence and
Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
---
2+
'@object-ui/types': minor
3+
---
4+
5+
**BREAKING (shipped as `minor` — see below):** thirteen node types now refuse
6+
both content channels by name. Each one's renderer reads neither `body` nor
7+
`children`, so an authored child list on it rendered nothing, with no
8+
render-time error or warning and no element; only the parser tier's
9+
`not-a-container` warning (objectui#9910) noticed it (objectui#9256).
10+
11+
- `markdown`, `chart`, `bar-chart`, `code-editor`, `detail`, `report`: both keys
12+
are now `?: never` on the TypeScript face (`MarkdownSchema`, `ChartSchema`,
13+
`BarChartSchema`, `CodeEditorSchema`, `DetailSchema`,
14+
`ReportComponentSchema`) and a by-name refusal on the zod mirror, each kept a
15+
member of the mirror shape.
16+
- `list-view`: a by-name refusal on the zod mirror. `ListViewSchema`'s
17+
TypeScript face is derived from that mirror, so it refuses both keys too.
18+
- `page-designer`, `data-model-designer`, `process-designer`,
19+
`report-designer`, `object-manager`, `field-designer`: `?: never` on the
20+
TypeScript face (`PageDesignerSchema`, `DataModelDesignerSchema`,
21+
`ProcessDesignerSchema`, `ReportDesignerSchema`, `ObjectManagerSchema`,
22+
`FieldDesignerSchema`). None of them has a zod mirror, so the TypeScript face
23+
is the only one that changes.
24+
25+
What moves for an author:
26+
27+
- `children` on any of these nodes type-checked, and parsed green where a zod
28+
mirror exists; it is now refused at authoring time and, where a zod mirror
29+
exists, at `safeParse` time, at its own path.
30+
- `body` was already refused on these faces, by `BaseSchema`. On the zod
31+
mirrors its refusal message now names what the node renders instead, where
32+
it used to point at `children`, which these nodes do not read either.
33+
34+
No render behaviour changes: nothing read these keys, which is the whole reason
35+
they could be refused.
36+
37+
Migration: each of these nodes renders from its own keys, so there is no channel
38+
to move the content to. Put it in the key the node does render (`markdown`'s
39+
`content`, a `detail` tab's `content`, a chart's `data`), place it beside the
40+
node in a container that reads `children`, or drop it.
41+
42+
`minor` rather than `major` because this repo's version policy forbids `major`
43+
in any changeset — one `fixed` group — and records `minor` plus an explicit
44+
breaking note as the spelling for a breaking change here.

‎content/docs/plugins/plugin-map.mdx‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,15 @@ to `onMarkerClick` is not `===` the authored object.
146146
}
147147
```
148148

149+
The block is closed (objectui#5157). A key it does not declare — a typo such as
150+
`latitudeFieId` — is refused by `objectui validate` with an `unrecognized_keys`
151+
issue at `map` that names the key (on a root node; a nested node reports under
152+
`invalid_union` at `children`, with the key in the arm detail). At runtime
153+
`ObjectMap` does not throw: it renders from the declared keys, and the console
154+
warns `[ObjectMap] Invalid map configuration`, naming the same key. A typo that
155+
leaves the block with no coordinate binding, as `latitudeFieId` does, draws the
156+
refusal described under "An unconfigured map refuses" rather than a map.
157+
149158
## Configuration
150159

151160
### An unconfigured map refuses

‎content/docs/plugins/plugin-view.mdx‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -354,6 +354,11 @@ Without an `onNavigate` handler, `page` mode has nowhere to send the user, so
354354
keep the two together. `navigation: { mode: 'none' }` (or `preventNavigation`)
355355
makes rows inert. An active named view (`listViews`, under Read/List) that
356356
declares its own `navigation` replaces this one, as a whole, while it is shown.
357+
Under `split` or `popover`, which open only beside a record the user picked, the
358+
New button's create form opens on the `layout` surface instead: the modal for
359+
`layout: 'modal'`, the drawer otherwise, whether the mode is this node's or an
360+
active named view's. A `page` layout with `onNavigate` still hands New to your
361+
router.
357362

358363
With no host `onRowClick`, a Cmd/Ctrl-click or middle-click on a row opens the
359364
record as a full page in a new browser tab. Inert rows stay inert: `mode: 'none'`,
@@ -447,7 +452,9 @@ edit to the user. Its `navigation` replaces the node's `navigation` as a whole:
447452
the row click, and the surface and width of the record, create and edit forms,
448453
follow the active named view, on this path, and on a host's `renderListView`
449454
when the host wires the `onRowClick` it is handed and passes `ObjectView` no
450-
`onRowClick` of its own. `label` and `data`, also declared on both, are not
455+
`onRowClick` of its own. Under a named `split` or `popover`, the create form
456+
opens on the `layout` surface, as under Opening a record. `label` and `data`,
457+
also declared on both, are not
451458
handed to the grid on this path: the named view's `label` is already the tab's
452459
text, and `data` waits on objectui#10971, because `ListView` and `ObjectGrid`
453460
pick different objects for it.

0 commit comments

Comments
 (0)