This repository was archived by the owner on Nov 4, 2026. It is now read-only.
Repository navigation
Commit 64563a9
feat(plugin-map)!: retire the bare
Fixes #10393
Clause-②: yes
Retires the bare `map` node type key registered by
`@object-ui/plugin-map` (and with it the namespaced twin `view:map`),
executing the objectui#8008 family ruling (record `5603555117`, route 3:
retire the bare registration, keep `object-*`). `object-map` is now the
one spelling. The stored view type `map` (`NamedListView.type`,
`defaultViewType`, `CreateViewDialog`) is **not** touched.
Implemented by the `os-dev` agent dispatched by the `domain:ui` seat 2
PM, session `https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN`.
Head measured: `ec6e667dd` (code at `c6d3f38b2`; `ec6e667dd` is a
prose-only rework on top). Base: `09ab32bff`.
## Guard (triage `5825154518`, narrowed by the claim): does not fire
No non-test source resolves the renderer through `map` / `view:map`.
Measured on the base tree, per site:
| instrument | hits in non-test source | control |
| --- | --- | --- |
| literal registry call on `map` / `view:map` (`get` / `has` /
`getConfig` / `register` / `registerLazy` …) | 2 registrations only:
`plugin-map/src/index.tsx` and `apps/console/src/register-plugins.ts`
(both removed here). `InterfaceListPage`'s `allowedSet.has('map')` is a
Set of view types, not the registry | `object-map` fires on the same
pattern (both registrations + the `Registry.ts` doc example); an absent
name (`zzmapabsent`) stays silent (exit 1) |
| a `view:` key built by template or concatenation | 2 hits, both
`data-objectstack` metadata CACHE keys (`view:` + object + view name),
not registry lookups | the 2 hits are the matcher firing |
| a node emitted with literal `type: 'map'` | 0 of 28 repo-wide hits are
non-test | `object-map` fires in 11 non-test files |
| a node type taken from a stored view type | `ObjectView` and
`ListView` both have a `case 'map'` that emits `object-map`; the other
`type: view.type` sites build tab items, not nodes | — |
The 22 `type: 'map'` sites in 10 `ObjectMap.*.test.tsx` files all hand
the node straight to the `ObjectMap` component's `schema` prop (JSX, not
`SchemaRenderer`). That component does not read `type` for resolution,
so they are **left as they are**. The only `schema.type` reads in
`ObjectMap.tsx` are warning-memo keys. That file is held by
objectui#10525 and is not edited.
## Named refusal or plain unregistration: plain unregistration
In `@object-ui/types` the literal `'map'` appears only in the stored
view-type unions (`defaultViewType`, `NamedListView.type`,
`ObjectViewSchema.defaultViewType`'s zod enum). It never appears as a
component node type. The firing control is `'object-map'`: `objectql.ts`
plus its zod mirror. `AnyComponentSchema` has no `map` arm, so there is
nothing to turn into a named refusal. This matches the `gantt` precedent
and is recorded in the tombstone docblock in `plugin-map/src/index.tsx`.
## What changed, and why each file
- `packages/plugin-map/src/index.tsx`: removes
`ComponentRegistry.register('map', …, { namespace: 'view' })` and adds a
tombstone docblock in the form of `plugin-gantt`'s. The comment that
said two inline lists were pinned identical now describes one list.
- `apps/console/src/register-plugins.ts`: removes the lazy `map` /
`view:map` stub. This is the same move objectui#8865 made for `gantt`.
The lazy `object-map` stub stays.
- `packages/core/src/utils/record-source.ts`: removes the `'view:map'`
and `map` rows from `RECORD_SOURCE_DATA_ARM_BY_TYPE` and updates the doc
comment (the one-block-spelling note on `ObjectMap.tsx`, and the alias
example now uses `view:calendar` / `calendar`). Two sentences said every
one of these renderers is registered twice. That was already false for
`gantt` and this change makes it false for `map`, so both now say
"most".
- `packages/cli/src/utils/known-schema-types.ts`: regenerated with `node
scripts/regenerate-known-schema-types.mjs`. Bare `map` leaves the list.
`view:map` stays, because the opt-in protocol placeholder registers it.
That is the same outcome as `view:gantt` in objectui#8865, and the
changeset says so.
- `.github/prompts/component.prompt.md`: the list-view `Keys:` bullet
taught `view:map`. After this change that key answers only the
placeholder, so `check:prompt-keys` would go red. It now teaches
`object-map`, and the prose names `view:map` among the retired
namespaced spellings.
`scripts/__tests__/check-prompt-component-keys.test.ts` follows: the
keys-line pin, and `view:map` added to the prose-only tombstones.
- `packages/plugin-map/README.md`: now says one registered type is
`object-map`. It keeps the sentence that a stored `map` view compiles to
`object-map`, and adds a retirement note that separates the two layers.
The false bare-array sentence carried from objectui#10392's ACCEPT is
corrected (see below).
- Pins that enumerated the retired keys drop them. They still pass on
the `object-map` rows:
- `index.recordSourceInput-7470.test.tsx` and
`index.recordSourceInputs-10394.test.tsx` drop the `view:map` row. The
10394 "both keys publish identical lists" row is removed because only
one list is left.
- `index.registration.test.tsx` drops its `has('map', 'view')`
non-vacuity line. `has('object-map', 'plugin-map')` stays.
- `ObjectMap.schemaDataShorthand.test.tsx` 3d now asserts the renderer's
key group is EXACTLY `object-map` and `plugin-map:object-map`.
- `SchemaRenderer.dataPropArm-9571.test.tsx` and
`SchemaRenderer.legacyPropsDataStrip-9758.test.tsx` (`@object-ui/react`,
test-only) drop `view:map` and `map` from their object-arm lists. Those
lists mirror the table rows removed above.
- New pin
`packages/plugin-map/src/index.bareMapKeyRetired-10393.test.tsx`:
- row 1: `map` / `view:map` resolve nothing; the firing control is that
`object-map` resolves.
- row 2: both authoring faces now refuse a `map` node. The html tier
(`validateTree` over the live registry) reports `unknown-component`, and
the Zod face (`safeValidateSchema`) refuses it as before. The control is
that the same content spelled `object-map` passes both.
- row 3: the source registers exactly one key, read off disk with
comments masked.
- `.changeset/10393-retire-bare-map-key.md`: `@object-ui/plugin-map`
minor, with a **BREAKING** body (never `major`, per AGENTS.md §9).
`@object-ui/core`, `@object-ui/cli` and `@object-ui/console` are patch.
It names the two docs pages and the pending entry below.
- `.changeset/10392-registration-record-source-inputs.md` (pending, same
release; prose only, frontmatter byte-identical): its sentence that
`object-map`, `map` and `object-gantt` gained `data` / `staticData`
inputs now reads as of its own change ("At this change both were
declared on all three"). A dated note follows it, headed "Dated note,
2026-09-25 — the bare `map` registration has since been retired —
objectui#10393". This is the form PR objectui#10533 used. A re-grep of
every pending `.changeset/*.md` found no other present-tense claim that
`map` is a registered key. `7470-designer-objectname-not-required.md`
names `map` in the past tense and stays true, so it is left as is.
Checked and left alone (the other packages objectui#8865 touched):
`runner` and `sdui-parser`. In that PR their changes were the kanban
manual-registration map and the kanban quick-add. Neither package
references a `map` node key.
**The stored layer is untouched, and existing tests already pin it.**
Nothing is duplicated here:
- `plugin-view/src/__tests__/ObjectView.mapFlatten.test.tsx`: a stored
`type: 'map'` view emits an `object-map` node. Re-run green in this
change.
- `plugin-map/src/ObjectMap.listViewMapConfigReach.test.tsx`: a
`viewType: 'map'` list view draws markers through `object-map`. Green.
## Bare-array sentence carried from objectui#10392's ACCEPT (README and
two docs pages)
The README claimed that `staticData`, a bare array under `data` and
`data: { provider: 'value', items }` "all reach the same in-memory
adapter". That has been false since objectui#8348 / #10394. The sentence
now matches the registration's `data` description: a bare array under
`data` is not a record source, the ladder falls through to `staticData`
and then `objectName`, and inline rows belong under `staticData`. Two
more phrases in the same README said "an inline `data` array" (the
`titleField` row and the `dataSource` prop row). They now read `data: {
provider: 'value', items }` configuration. This is the same claim in the
same file, fixed in place.
Two public docs pages taught the same false sentence. The seat folded
them into this PR, and both now match the README wording:
- `content/docs/plugins/plugin-map.mdx`, the `filter` / `sort`
paragraph. It used to say "`staticData`, a bare array under `data`, or
`data: { provider: 'value' }`". It now says `staticData` or `data: {
provider: 'value', items }`, and states that a bare array under `data`
is not a record source.
- `content/docs/fields/location.mdx`, the `Note` under the map example.
It used to say "an `objectName` (or an explicit `data` array)". It now
says inline rows go under `staticData` or a `data: { provider: 'value',
items }` configuration, and that a bare array under `data` is not a
record source.
Both edits are prose outside fenced code blocks.
## Red then green, for every new or strengthened pin
Red leg: `packages/plugin-map/src/index.tsx` was restored to base
`09ab32bff` with `git checkout BASE -- path`, after the fix was
committed.
- The mutation landed on disk: `label: 'Map View'` count went 0 → 1 and
the tombstone count 1 → 0.
- The restore was `git checkout HEAD -- path` under a trap. The blob
hash after the restore equals the HEAD blob `58dd6164…`, and `git diff
HEAD` is empty.
| pin | on base | on head `c6d3f38b2` |
| --- | --- | --- |
| bareMapKeyRetired row 1 (`map` resolves nothing) | ✗ `expected true to
be false` | ✓ |
| row 1 FIRING CONTROL (`object-map` resolves) | ✓ | ✓ |
| row 2 (both faces refuse `map`) | ✗ `expected [] to deeply equal [
'unknown-component' ]` | ✓ |
| row 2 CONTROL (`object-map` passes both) | ✓ | ✓ |
| row 3 (source registers one key) | ✗ `expected [ 'object-map', 'map' ]
to deeply equal [ 'object-map' ]` | ✓ |
| schemaDataShorthand 3d (key group is exactly the two `object-map`
keys) | ✗ received `map`, `object-map`, `plugin-map:object-map`,
`view:map` | ✓ |
Base leg: `Tests 4 failed | 11 passed (15)`. Head leg: `Tests 15 passed
(15)`.
## Local verification (code and tests at `c6d3f38b2`; prose rework
re-gated at `ec6e667dd`)
- Tests: `pnpm exec vitest run packages/plugin-map/
packages/core/src/utils/__tests__/` plus the two react files,
`check-prompt-component-keys`, `known-schema-types-derivation-5115`,
`report-namespace-agreement-6416` and `check-lucide-icon-record-names`.
Result: `Test Files 113 passed (113)`, `Tests 1904 passed (1904)`.
- More tests: the 10 `apps/console` tests that import
`register-plugins`, `packages/cli/`, `catalog-gallery-render`,
`ObjectView.mapFlatten` and `check-doc-component-types`. Result: `Test
Files 33 passed (33)`, `Tests 1296 passed (1296)`.
- Type check: `type-check` for `@object-ui/plugin-map`, `core`, `react`,
`cli` and `console`. All `Done`, and the lock reported `VERDICT
command-exit 0`. The test programs of `plugin-map` and `react` list the
changed test files, counted with `--listFilesOnly`.
- Gates that passed, each exit 0:
- `check:prompt-keys`: "OK Every key taught as available is answered by
a real renderer …"
- `check:doc-types`: "✅ Every documented component type is registered."
- `check:registry-bare-names`: "✓ no new bare-name collision"
- `check:element-data-source-declaration`: OK
- `check:handler-key-reads`: OK
- `check:new-line-citations`: "VERDICT new-cross-file-line-citations: 0
new citation(s)"
- `check:control-bytes`: OK
- `check-changeset-presence`: "✅ 11 source file(s) of 5 released
package(s) changed, and this change declares 1 changeset(s)"
- `check-changeset-no-major` and `check-changeset-overwrite`: ✅
- `check:pending-changeset-literals`: ✅
- `check-doc-links`: "Links are valid across 17 scan roots."
- `check:doc-fences`: ✅
- `check:readme-exports`: "543 real, 0 wrong-path, 0 fabricated"
- `check-vi-mock-specifiers`, `check-vi-mock-inherit`,
`check-vi-mock-override-shape` and `check-test-path-roots`: ✅
- Report-only: `check:component-surface-parity` (exit 0; the `view:map`
rows leave its population). `check-changeset-claims` (exit 0) flags 8
pending changesets that name a touched file. Each paragraph was re-read
and none is falsified; see Acceptance notes.
- ESLint on the 12 touched code files: 0 errors, 32 warnings, all on
lines this change does not touch. This is a sanity run, **not** a proven
narrowing; the full lint belongs to CI.
- NOT MEASURED: `check:sdui-registration-pins` exited 2, a prerequisite:
it needs `apps/console/dist/assets`, which only a console bundle build
produces. Its derived key set (`--list`) holds no `map` or `object-map`
key, so this diff moves nothing it pins.
- Re-gated at `ec6e667dd`, after the prose-only rework (docs and
changesets):
- these gates exited 0: `check-doc-links` ("Links are valid across 17
scan roots."), `check:doc-fences` (✅), `check:doc-types` ("✅ Every
documented component type is registered."),
`check:pending-changeset-literals` ("✅ No test source names a pending
changeset."), `check-changeset-presence` (✅), `check-changeset-no-major`
(✅), `check:new-line-citations` ("0 new citation(s)"),
`check:control-bytes` (✅) and `check:prompt-keys` (OK);
- `check-changeset-overwrite` exited 0 and reported, as expected, the
one intended modification: `10392-registration-record-source-inputs.md`,
with the same declaration at base and now;
- `check:changeset-claims` exited 0 and reported one new pending entry
naming a touched file: `8221-retire-legacy-string-sort.md` names
`plugin-map.mdx`. The paragraph was re-read and still holds (the docs
still teach `sort` as an array only);
- tests: `doc-version-claims`, `changeset-polarity-census`,
`check-changeset-claims`, `check-pending-changeset-literals`,
`check-changeset-presence`, `check-changeset-overwrite`,
`check-changeset-fixed`, `check-doc-links`,
`component-node-vocabulary-7434`, `check-doc-expression-carriage` and
`check-prompt-component-keys` gave `Test Files 11 passed (11)`, `Tests
532 passed (532)`, with the lock reporting `VERDICT command-exit 0`;
- not run: `check:doc-snippets`. No fenced code block changed.
## Acceptance notes
- `view:map` survives as a **placeholder** key in the console
(`registerPlaceholders()` → `PROTOCOL_COMPONENTS`) and on the generated
CLI list. That is the same state objectui#8865 left `view:gantt` /
`view:kanban` in. Removing it from `PROTOCOL_COMPONENTS` would be a
separate decision and is out of scope here.
- `.changeset/10392-registration-record-source-inputs.md` is handled
above: it now reads as of its own change and carries the dated note,
with frontmatter byte-identical.
- `skills/objectui/guides/architecture.md` ("Pattern A: The Component
Registry") shows a user registering their OWN `MapRenderer` as `map`
under `namespace: 'plugin-map'`. It is an extension example, not a claim
about this plugin, and it stays true. It is also a governed surface, so
it is left alone.
---
_Generated by [Claude
Code](https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN)_
---------
Co-authored-by: Claude <noreply@anthropic.com>map node type key; object-map is the one spelling (objectui#10393) (#10540)1 parent fee1da5 commit 64563a9
18 files changed
Lines changed: 315 additions & 88 deletions
File tree
- .changeset
- .github/prompts
- apps/console/src
- content/docs
- fields
- plugins
- packages
- cli/src/utils
- core/src/utils
- plugin-map
- src
- react/src/__tests__
- scripts/__tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
28 | 37 | | |
29 | 38 | | |
30 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
90 | | - | |
91 | | - | |
| 90 | + | |
| 91 | + | |
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
| 97 | + | |
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
51 | 52 | | |
52 | 53 | | |
53 | 54 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
131 | 131 | | |
132 | 132 | | |
133 | 133 | | |
134 | | - | |
| 134 | + | |
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
127 | 129 | | |
128 | 130 | | |
129 | 131 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
231 | 231 | | |
232 | 232 | | |
233 | 233 | | |
234 | | - | |
235 | 234 | | |
236 | 235 | | |
237 | 236 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
| 103 | + | |
104 | 104 | | |
| 105 | + | |
105 | 106 | | |
106 | 107 | | |
107 | 108 | | |
| |||
317 | 318 | | |
318 | 319 | | |
319 | 320 | | |
320 | | - | |
321 | | - | |
| 321 | + | |
| 322 | + | |
322 | 323 | | |
323 | 324 | | |
324 | 325 | | |
| |||
345 | 346 | | |
346 | 347 | | |
347 | 348 | | |
348 | | - | |
| 349 | + | |
349 | 350 | | |
350 | 351 | | |
351 | 352 | | |
| |||
366 | 367 | | |
367 | 368 | | |
368 | 369 | | |
369 | | - | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
370 | 373 | | |
371 | 374 | | |
372 | 375 | | |
| |||
383 | 386 | | |
384 | 387 | | |
385 | 388 | | |
386 | | - | |
387 | | - | |
388 | 389 | | |
389 | 390 | | |
390 | 391 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | | - | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
12 | 14 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
17 | 26 | | |
18 | 27 | | |
19 | 28 | | |
| |||
88 | 97 | | |
89 | 98 | | |
90 | 99 | | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
97 | 108 | | |
98 | 109 | | |
99 | 110 | | |
| |||
113 | 124 | | |
114 | 125 | | |
115 | 126 | | |
116 | | - | |
| 127 | + | |
117 | 128 | | |
118 | 129 | | |
119 | 130 | | |
| |||
212 | 223 | | |
213 | 224 | | |
214 | 225 | | |
215 | | - | |
| 226 | + | |
216 | 227 | | |
217 | 228 | | |
218 | 229 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
| 69 | + | |
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
| |||
190 | 190 | | |
191 | 191 | | |
192 | 192 | | |
193 | | - | |
194 | | - | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
195 | 196 | | |
196 | 197 | | |
197 | 198 | | |
198 | 199 | | |
199 | | - | |
200 | | - | |
201 | | - | |
| 200 | + | |
202 | 201 | | |
203 | 202 | | |
204 | 203 | | |
| |||
0 commit comments