Skip to content
This repository was archived by the owner on Nov 4, 2026. It is now read-only.

Commit 64563a9

Browse files
feat(plugin-map)!: retire the bare map node type key; object-map is the one spelling (objectui#10393) (#10540)
Fixes #10393 Clause-②: yes Retires the bare `map` node type key registered by `@object-ui/plugin-map` (and with it the namespaced twin `view:map`), executing the objectui#8008 family ruling (record `5603555117`, route 3: retire the bare registration, keep `object-*`). `object-map` is now the one spelling. The stored view type `map` (`NamedListView.type`, `defaultViewType`, `CreateViewDialog`) is **not** touched. Implemented by the `os-dev` agent dispatched by the `domain:ui` seat 2 PM, session `https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN`. Head measured: `ec6e667dd` (code at `c6d3f38b2`; `ec6e667dd` is a prose-only rework on top). Base: `09ab32bff`. ## Guard (triage `5825154518`, narrowed by the claim): does not fire No non-test source resolves the renderer through `map` / `view:map`. Measured on the base tree, per site: | instrument | hits in non-test source | control | | --- | --- | --- | | literal registry call on `map` / `view:map` (`get` / `has` / `getConfig` / `register` / `registerLazy` …) | 2 registrations only: `plugin-map/src/index.tsx` and `apps/console/src/register-plugins.ts` (both removed here). `InterfaceListPage`'s `allowedSet.has('map')` is a Set of view types, not the registry | `object-map` fires on the same pattern (both registrations + the `Registry.ts` doc example); an absent name (`zzmapabsent`) stays silent (exit 1) | | a `view:` key built by template or concatenation | 2 hits, both `data-objectstack` metadata CACHE keys (`view:` + object + view name), not registry lookups | the 2 hits are the matcher firing | | a node emitted with literal `type: 'map'` | 0 of 28 repo-wide hits are non-test | `object-map` fires in 11 non-test files | | a node type taken from a stored view type | `ObjectView` and `ListView` both have a `case 'map'` that emits `object-map`; the other `type: view.type` sites build tab items, not nodes | — | The 22 `type: 'map'` sites in 10 `ObjectMap.*.test.tsx` files all hand the node straight to the `ObjectMap` component's `schema` prop (JSX, not `SchemaRenderer`). That component does not read `type` for resolution, so they are **left as they are**. The only `schema.type` reads in `ObjectMap.tsx` are warning-memo keys. That file is held by objectui#10525 and is not edited. ## Named refusal or plain unregistration: plain unregistration In `@object-ui/types` the literal `'map'` appears only in the stored view-type unions (`defaultViewType`, `NamedListView.type`, `ObjectViewSchema.defaultViewType`'s zod enum). It never appears as a component node type. The firing control is `'object-map'`: `objectql.ts` plus its zod mirror. `AnyComponentSchema` has no `map` arm, so there is nothing to turn into a named refusal. This matches the `gantt` precedent and is recorded in the tombstone docblock in `plugin-map/src/index.tsx`. ## What changed, and why each file - `packages/plugin-map/src/index.tsx`: removes `ComponentRegistry.register('map', …, { namespace: 'view' })` and adds a tombstone docblock in the form of `plugin-gantt`'s. The comment that said two inline lists were pinned identical now describes one list. - `apps/console/src/register-plugins.ts`: removes the lazy `map` / `view:map` stub. This is the same move objectui#8865 made for `gantt`. The lazy `object-map` stub stays. - `packages/core/src/utils/record-source.ts`: removes the `'view:map'` and `map` rows from `RECORD_SOURCE_DATA_ARM_BY_TYPE` and updates the doc comment (the one-block-spelling note on `ObjectMap.tsx`, and the alias example now uses `view:calendar` / `calendar`). Two sentences said every one of these renderers is registered twice. That was already false for `gantt` and this change makes it false for `map`, so both now say "most". - `packages/cli/src/utils/known-schema-types.ts`: regenerated with `node scripts/regenerate-known-schema-types.mjs`. Bare `map` leaves the list. `view:map` stays, because the opt-in protocol placeholder registers it. That is the same outcome as `view:gantt` in objectui#8865, and the changeset says so. - `.github/prompts/component.prompt.md`: the list-view `Keys:` bullet taught `view:map`. After this change that key answers only the placeholder, so `check:prompt-keys` would go red. It now teaches `object-map`, and the prose names `view:map` among the retired namespaced spellings. `scripts/__tests__/check-prompt-component-keys.test.ts` follows: the keys-line pin, and `view:map` added to the prose-only tombstones. - `packages/plugin-map/README.md`: now says one registered type is `object-map`. It keeps the sentence that a stored `map` view compiles to `object-map`, and adds a retirement note that separates the two layers. The false bare-array sentence carried from objectui#10392's ACCEPT is corrected (see below). - Pins that enumerated the retired keys drop them. They still pass on the `object-map` rows: - `index.recordSourceInput-7470.test.tsx` and `index.recordSourceInputs-10394.test.tsx` drop the `view:map` row. The 10394 "both keys publish identical lists" row is removed because only one list is left. - `index.registration.test.tsx` drops its `has('map', 'view')` non-vacuity line. `has('object-map', 'plugin-map')` stays. - `ObjectMap.schemaDataShorthand.test.tsx` 3d now asserts the renderer's key group is EXACTLY `object-map` and `plugin-map:object-map`. - `SchemaRenderer.dataPropArm-9571.test.tsx` and `SchemaRenderer.legacyPropsDataStrip-9758.test.tsx` (`@object-ui/react`, test-only) drop `view:map` and `map` from their object-arm lists. Those lists mirror the table rows removed above. - New pin `packages/plugin-map/src/index.bareMapKeyRetired-10393.test.tsx`: - row 1: `map` / `view:map` resolve nothing; the firing control is that `object-map` resolves. - row 2: both authoring faces now refuse a `map` node. The html tier (`validateTree` over the live registry) reports `unknown-component`, and the Zod face (`safeValidateSchema`) refuses it as before. The control is that the same content spelled `object-map` passes both. - row 3: the source registers exactly one key, read off disk with comments masked. - `.changeset/10393-retire-bare-map-key.md`: `@object-ui/plugin-map` minor, with a **BREAKING** body (never `major`, per AGENTS.md §9). `@object-ui/core`, `@object-ui/cli` and `@object-ui/console` are patch. It names the two docs pages and the pending entry below. - `.changeset/10392-registration-record-source-inputs.md` (pending, same release; prose only, frontmatter byte-identical): its sentence that `object-map`, `map` and `object-gantt` gained `data` / `staticData` inputs now reads as of its own change ("At this change both were declared on all three"). A dated note follows it, headed "Dated note, 2026-09-25 — the bare `map` registration has since been retired — objectui#10393". This is the form PR objectui#10533 used. A re-grep of every pending `.changeset/*.md` found no other present-tense claim that `map` is a registered key. `7470-designer-objectname-not-required.md` names `map` in the past tense and stays true, so it is left as is. Checked and left alone (the other packages objectui#8865 touched): `runner` and `sdui-parser`. In that PR their changes were the kanban manual-registration map and the kanban quick-add. Neither package references a `map` node key. **The stored layer is untouched, and existing tests already pin it.** Nothing is duplicated here: - `plugin-view/src/__tests__/ObjectView.mapFlatten.test.tsx`: a stored `type: 'map'` view emits an `object-map` node. Re-run green in this change. - `plugin-map/src/ObjectMap.listViewMapConfigReach.test.tsx`: a `viewType: 'map'` list view draws markers through `object-map`. Green. ## Bare-array sentence carried from objectui#10392's ACCEPT (README and two docs pages) The README claimed that `staticData`, a bare array under `data` and `data: { provider: 'value', items }` "all reach the same in-memory adapter". That has been false since objectui#8348 / #10394. The sentence now matches the registration's `data` description: a bare array under `data` is not a record source, the ladder falls through to `staticData` and then `objectName`, and inline rows belong under `staticData`. Two more phrases in the same README said "an inline `data` array" (the `titleField` row and the `dataSource` prop row). They now read `data: { provider: 'value', items }` configuration. This is the same claim in the same file, fixed in place. Two public docs pages taught the same false sentence. The seat folded them into this PR, and both now match the README wording: - `content/docs/plugins/plugin-map.mdx`, the `filter` / `sort` paragraph. It used to say "`staticData`, a bare array under `data`, or `data: { provider: 'value' }`". It now says `staticData` or `data: { provider: 'value', items }`, and states that a bare array under `data` is not a record source. - `content/docs/fields/location.mdx`, the `Note` under the map example. It used to say "an `objectName` (or an explicit `data` array)". It now says inline rows go under `staticData` or a `data: { provider: 'value', items }` configuration, and that a bare array under `data` is not a record source. Both edits are prose outside fenced code blocks. ## Red then green, for every new or strengthened pin Red leg: `packages/plugin-map/src/index.tsx` was restored to base `09ab32bff` with `git checkout BASE -- path`, after the fix was committed. - The mutation landed on disk: `label: 'Map View'` count went 0 → 1 and the tombstone count 1 → 0. - The restore was `git checkout HEAD -- path` under a trap. The blob hash after the restore equals the HEAD blob `58dd6164…`, and `git diff HEAD` is empty. | pin | on base | on head `c6d3f38b2` | | --- | --- | --- | | bareMapKeyRetired row 1 (`map` resolves nothing) | ✗ `expected true to be false` | ✓ | | row 1 FIRING CONTROL (`object-map` resolves) | ✓ | ✓ | | row 2 (both faces refuse `map`) | ✗ `expected [] to deeply equal [ 'unknown-component' ]` | ✓ | | row 2 CONTROL (`object-map` passes both) | ✓ | ✓ | | row 3 (source registers one key) | ✗ `expected [ 'object-map', 'map' ] to deeply equal [ 'object-map' ]` | ✓ | | schemaDataShorthand 3d (key group is exactly the two `object-map` keys) | ✗ received `map`, `object-map`, `plugin-map:object-map`, `view:map` | ✓ | Base leg: `Tests 4 failed | 11 passed (15)`. Head leg: `Tests 15 passed (15)`. ## Local verification (code and tests at `c6d3f38b2`; prose rework re-gated at `ec6e667dd`) - Tests: `pnpm exec vitest run packages/plugin-map/ packages/core/src/utils/__tests__/` plus the two react files, `check-prompt-component-keys`, `known-schema-types-derivation-5115`, `report-namespace-agreement-6416` and `check-lucide-icon-record-names`. Result: `Test Files 113 passed (113)`, `Tests 1904 passed (1904)`. - More tests: the 10 `apps/console` tests that import `register-plugins`, `packages/cli/`, `catalog-gallery-render`, `ObjectView.mapFlatten` and `check-doc-component-types`. Result: `Test Files 33 passed (33)`, `Tests 1296 passed (1296)`. - Type check: `type-check` for `@object-ui/plugin-map`, `core`, `react`, `cli` and `console`. All `Done`, and the lock reported `VERDICT command-exit 0`. The test programs of `plugin-map` and `react` list the changed test files, counted with `--listFilesOnly`. - Gates that passed, each exit 0: - `check:prompt-keys`: "OK Every key taught as available is answered by a real renderer …" - `check:doc-types`: "✅ Every documented component type is registered." - `check:registry-bare-names`: "✓ no new bare-name collision" - `check:element-data-source-declaration`: OK - `check:handler-key-reads`: OK - `check:new-line-citations`: "VERDICT new-cross-file-line-citations: 0 new citation(s)" - `check:control-bytes`: OK - `check-changeset-presence`: "✅ 11 source file(s) of 5 released package(s) changed, and this change declares 1 changeset(s)" - `check-changeset-no-major` and `check-changeset-overwrite`: ✅ - `check:pending-changeset-literals`: ✅ - `check-doc-links`: "Links are valid across 17 scan roots." - `check:doc-fences`: ✅ - `check:readme-exports`: "543 real, 0 wrong-path, 0 fabricated" - `check-vi-mock-specifiers`, `check-vi-mock-inherit`, `check-vi-mock-override-shape` and `check-test-path-roots`: ✅ - Report-only: `check:component-surface-parity` (exit 0; the `view:map` rows leave its population). `check-changeset-claims` (exit 0) flags 8 pending changesets that name a touched file. Each paragraph was re-read and none is falsified; see Acceptance notes. - ESLint on the 12 touched code files: 0 errors, 32 warnings, all on lines this change does not touch. This is a sanity run, **not** a proven narrowing; the full lint belongs to CI. - NOT MEASURED: `check:sdui-registration-pins` exited 2, a prerequisite: it needs `apps/console/dist/assets`, which only a console bundle build produces. Its derived key set (`--list`) holds no `map` or `object-map` key, so this diff moves nothing it pins. - Re-gated at `ec6e667dd`, after the prose-only rework (docs and changesets): - these gates exited 0: `check-doc-links` ("Links are valid across 17 scan roots."), `check:doc-fences` (✅), `check:doc-types` ("✅ Every documented component type is registered."), `check:pending-changeset-literals` ("✅ No test source names a pending changeset."), `check-changeset-presence` (✅), `check-changeset-no-major` (✅), `check:new-line-citations` ("0 new citation(s)"), `check:control-bytes` (✅) and `check:prompt-keys` (OK); - `check-changeset-overwrite` exited 0 and reported, as expected, the one intended modification: `10392-registration-record-source-inputs.md`, with the same declaration at base and now; - `check:changeset-claims` exited 0 and reported one new pending entry naming a touched file: `8221-retire-legacy-string-sort.md` names `plugin-map.mdx`. The paragraph was re-read and still holds (the docs still teach `sort` as an array only); - tests: `doc-version-claims`, `changeset-polarity-census`, `check-changeset-claims`, `check-pending-changeset-literals`, `check-changeset-presence`, `check-changeset-overwrite`, `check-changeset-fixed`, `check-doc-links`, `component-node-vocabulary-7434`, `check-doc-expression-carriage` and `check-prompt-component-keys` gave `Test Files 11 passed (11)`, `Tests 532 passed (532)`, with the lock reporting `VERDICT command-exit 0`; - not run: `check:doc-snippets`. No fenced code block changed. ## Acceptance notes - `view:map` survives as a **placeholder** key in the console (`registerPlaceholders()` → `PROTOCOL_COMPONENTS`) and on the generated CLI list. That is the same state objectui#8865 left `view:gantt` / `view:kanban` in. Removing it from `PROTOCOL_COMPONENTS` would be a separate decision and is out of scope here. - `.changeset/10392-registration-record-source-inputs.md` is handled above: it now reads as of its own change and carries the dated note, with frontmatter byte-identical. - `skills/objectui/guides/architecture.md` ("Pattern A: The Component Registry") shows a user registering their OWN `MapRenderer` as `map` under `namespace: 'plugin-map'`. It is an extension example, not a claim about this plugin, and it stays true. It is also a governed surface, so it is left alone. --- _Generated by [Claude Code](https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN)_ --------- Co-authored-by: Claude <noreply@anthropic.com>
1 parent fee1da5 commit 64563a9

18 files changed

Lines changed: 315 additions & 88 deletions

‎.changeset/10392-registration-record-source-inputs.md‎

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,21 @@ on the registrations disagreed with that rule in two ways:
1919
(objectui#10392).
2020
- `object-map`, `map` and `object-gantt` did not declare `data` or
2121
`staticData`, so the validator reported a block authored on either as an
22-
unknown prop. Both are now declared, on the schema's own arms: `data` is a
23-
`{ provider, … }` data-source configuration (an object, so a bare array there
24-
now draws a type diagnostic, matching the schema), and `staticData` is an
25-
array of records. Each description says what the renderer does with the key,
26-
including that the map does not implement the `api` provider
27-
(objectui#10394).
22+
unknown prop. At this change both were declared on all three, on the schema's
23+
own arms: `data` is a `{ provider, … }` data-source configuration (an object,
24+
so a bare array there draws a type diagnostic, matching the schema), and
25+
`staticData` is an array of records. Each description says what the renderer
26+
does with the key, including that the map does not implement the `api`
27+
provider (objectui#10394).
28+
29+
⚠️ **Dated note, 2026-09-25 — the bare `map` registration has since been
30+
retired — objectui#10393.** Later in this same release `@object-ui/plugin-map`
31+
stopped registering the bare `map` key (and its namespaced twin `view:map`),
32+
so `map` declares nothing: a node authored `"type": "map"` resolves no
33+
renderer, and the html tier reports it as `unknown-component`. The
34+
`object-map` and `object-gantt` registrations keep both inputs exactly as
35+
described above. The rest of this entry is kept as the reading of this
36+
change; the objectui#10393 entry states what ships.
2837

2938
The renderers' read order and the zod schemas are unchanged. The
3039
`@object-ui/plugin-gantt` README sentence that listed the registration's inputs
Lines changed: 62 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,62 @@
1+
---
2+
'@object-ui/plugin-map': minor
3+
'@object-ui/core': patch
4+
'@object-ui/cli': patch
5+
'@object-ui/console': patch
6+
---
7+
8+
**BREAKING (node type key):** `@object-ui/plugin-map` no longer registers the bare
9+
`map` node type key, and its namespaced twin `view:map` goes with it. A node
10+
authored `"type": "map"` no longer resolves a renderer. Write
11+
`"type": "object-map"` — the one spelling the plugin serves (objectui#10393,
12+
executing the objectui#8008 family ruling of 2026-09-09 that retired the bare
13+
`gantt` and `kanban` keys).
14+
15+
**Why.** The registry mounted a `map` node while the published declaration refused
16+
it: `ObjectMapSchema.type` is the literal `'object-map'` and `AnyComponentSchema`
17+
has no `map` arm, so `safeValidateSchema` answered a `map` node with
18+
`invalid_union` while the html tier accepted it. Two faces, opposite verdicts.
19+
No schema face ever declared `map` as a component node type, so there is no arm
20+
to turn into a named refusal: unregistering is the whole retirement, exactly as
21+
it was for `gantt`. After it, the html tier (`validateTree` over the live
22+
registry) reports a `map` node as `unknown-component`, matching the Zod face.
23+
24+
**⛔ No stored document moves.** The string `map` names two different things at
25+
two different layers, and only one of them is retiring:
26+
27+
| layer | value | who writes it | retired? |
28+
| --- | --- | --- | --- |
29+
| stored `NamedListView.type` / `defaultViewType` | `"map"` | `CreateViewDialog`, persisted per tenant | **no — untouched** |
30+
| node type key | `map`, `view:map` | hand-authored JSON | **yes** |
31+
32+
`ObjectView` and `ListView` map a stored `map` view onto the node type they
33+
render, and both already emit `object-map`, so every map view created through
34+
the console keeps rendering. Nothing in a tenant database changes, and ⛔ nothing
35+
should be migrated there.
36+
37+
**What moved with it.**
38+
39+
- `@object-ui/console` drops its lazy `map` / `view:map` registration stub; the
40+
lazy `object-map` stub is unchanged.
41+
- `@object-ui/core`: `recordSourceDataArmForType` no longer lists the `map` and
42+
`view:map` rows, since no block is registered under either key.
43+
- `@object-ui/cli`: the generated known-type list that `objectui check` reads no
44+
longer contains bare `map`, so the check now flags it. ⚠️ `view:map` stays on
45+
that list, because the opt-in protocol placeholder (`registerPlaceholders()`
46+
in `@object-ui/components`) registers it — in the console a `view:map` node
47+
renders that placeholder panel, not a map, and `objectui check` does not flag
48+
it. Search documents for `view:map` directly.
49+
50+
The `@object-ui/plugin-map` README now describes one registered type, and its
51+
sentence claiming a bare array under `data` reaches the in-memory adapter is
52+
corrected: a bare array under `data` is not a record source on the map
53+
(objectui#8348), so inline rows belong under `staticData`. The same false claim
54+
is corrected on the two docs pages that carried it, `plugins/plugin-map.mdx`
55+
and `fields/location.mdx`.
56+
57+
**One pending entry in this same release is superseded in part.** The
58+
objectui#10392 / #10394 entry (`10392-registration-record-source-inputs.md`)
59+
says `object-map`, `map` and `object-gantt` gained `data` / `staticData`
60+
inputs. It now reads as of its own change and carries a dated note naming this
61+
card: `map` declares nothing after this retirement, while `object-map` and
62+
`object-gantt` keep both inputs.

‎.github/prompts/component.prompt.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,14 +87,14 @@ Responsible for rendering records. The specific `type` determines the Props cont
8787
> ⚠️ **A `Keys` entry is a REGISTRY key; a `Required Types` entry is a spec `type` value. They are
8888
> not the same vocabulary and they have diverged.** `{ "type": "kanban" }` inside a `ListView`
8989
> config is spec-valid, but the board component is registered as `object-kanban` — the namespaced
90-
> `view:kanban` and `view:gantt` spellings retired with the bare `kanban` / `gantt` registrations and
91-
> now answer only the opt-in protocol PLACEHOLDER panel. A document naming one passes
90+
> `view:kanban`, `view:gantt` and `view:map` spellings retired with the bare `kanban` / `gantt` / `map`
91+
> registrations and now answer only the opt-in protocol PLACEHOLDER panel. A document naming one passes
9292
> `objectui check` and then draws nothing. Write the key from the `Keys` bullet, and where a
9393
> presentation is a config value rather than a component, write it as a prop. Enforced by
9494
> `pnpm check:prompt-keys`.
9595
9696
#### 1. List Views (Collection)
97-
* **Keys:** `view:grid`, `object-kanban`, `view:map`, `view:calendar`, `object-gantt`, etc.
97+
* **Keys:** `view:grid`, `object-kanban`, `object-map`, `view:calendar`, `object-gantt`, etc.
9898
* **Contract:** Must implement `ListViewComponentProps`.
9999
```typescript
100100
type ListViewComponentProps = {

‎apps/console/src/register-plugins.ts‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,11 @@ ComponentRegistry.registerLazy('object-map', () => import('@object-ui/plugin-map
4444
namespace: 'plugin-map',
4545
category: 'view',
4646
});
47-
ComponentRegistry.registerLazy('map', () => import('@object-ui/plugin-map'), {
48-
namespace: 'view',
49-
category: 'view',
50-
});
47+
// ⛔ The bare `map` node type key is RETIRED (objectui#10393, executing the
48+
// objectui#8008 family ruling of 2026-09-09) — `object-map` above is the
49+
// surviving spelling. The STORED `NamedListView.type` value `map` is a
50+
// different layer and is untouched: `ObjectView`'s `switch (viewType)` already
51+
// emits `object-map` for it.
5152

5253
ComponentRegistry.registerLazy('object-tree', () => import('@object-ui/plugin-tree'), {
5354
namespace: 'plugin-tree',

‎content/docs/fields/location.mdx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ the renderer:
131131
}
132132
```
133133

134-
**Note**: the map plots the records it fetches, so it takes an `objectName` (or an explicit `data` array) rather than a `bind` path, and it derives its markers from those records — a `markers` key on the node is not read. Every marker setting lives under the declared `map` input.
134+
**Note**: the map plots the records it fetches, so it takes an `objectName` (or inline rows under `staticData`, or a `data: { provider: 'value', items }` configuration — a bare array under `data` is not a record source) rather than a `bind` path, and it derives its markers from those records — a `markers` key on the node is not read. Every marker setting lives under the declared `map` input.
135135

136136
## Validation
137137

‎content/docs/plugins/plugin-map.mdx‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,10 +120,12 @@ const schema: ObjectMapSchema = {
120120
```
121121

122122
`filter` and `sort` are not object-only keys (objectui#9061). They narrow and
123-
order inline rows — `staticData`, a bare array under `data`, or
124-
`data: { provider: 'value' }` — exactly as they narrow and order fetched ones,
125-
and the platform row ceiling (2,000 plotted rows with a footnote naming both
126-
numbers) applies to inline rows too. The ceiling is applied to the **filtered**
123+
order inline rows — `staticData` or `data: { provider: 'value', items }` —
124+
exactly as they narrow and order fetched ones. A bare array under `data` is not
125+
a record source on the map (objectui#8348): the ladder falls through to
126+
`staticData`, then `objectName`, so inline rows belong under `staticData`. The
127+
platform row ceiling (2,000 plotted rows with a footnote naming both numbers)
128+
applies to inline rows too. The ceiling is applied to the **filtered**
127129
set, so a large inline array that a `filter` cuts below the ceiling plots every
128130
matching row and shows no footnote. Inline rows reach the map as the in-memory
129131
adapter's own deep copy, so they must be JSON-serializable and a record handed

‎packages/cli/src/utils/known-schema-types.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,6 @@ export const KNOWN_SCHEMA_TYPES: readonly string[] = [
231231
'location',
232232
'lookup',
233233
'main',
234-
'map',
235234
'mark',
236235
'markdown',
237236
'marketplace:installed-list',

‎packages/core/src/utils/record-source.ts‎

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,9 @@ export function resolveRecordSourceObjectName(
100100
* a block the ruling does not decide, and it is reported rather than guessed.
101101
*
102102
* The arm is passed BY THE CALL SITE rather than looked up from `schema.type`
103-
* on purpose. Every one of these renderers is registered twice — `object-grid`
103+
* on purpose. Most of these renderers are registered twice — `object-grid`
104104
* and the `view:grid` alias `grid`, `object-calendar` and `calendar`, and so on
105+
* (the bare `gantt` and `map` keys are retired, objectui#8008 / objectui#10393)
105106
* — so a node reaches the same component under either spelling, and a table
106107
* keyed by `type` would answer for one tag and silently miss the other. A
107108
* REQUIRED parameter makes the arm a compile-time obligation at each of the
@@ -317,8 +318,8 @@ export function resolveRecordSourceConfig<Arm extends RecordSourceDataArm>(
317318
* ## Why a type-keyed table exists beside the REQUIRED parameter
318319
*
319320
* {@link RecordSourceDataArm}'s docblock states, correctly, why
320-
* {@link resolveRecordSourceConfig} takes the arm as a required PARAMETER: each
321-
* of these renderers is registered under two spellings, a node reaches the same
321+
* {@link resolveRecordSourceConfig} takes the arm as a required PARAMETER: most
322+
* of these renderers are registered under two spellings, a node reaches the same
322323
* component under either, and a table keyed by `type` would answer for one tag
323324
* and silently miss the other. That argument is about a call site that already
324325
* has one block in front of it — there a parameter is strictly better, and it
@@ -345,7 +346,7 @@ export function resolveRecordSourceConfig<Arm extends RecordSourceDataArm>(
345346
* ⚠️ ONE `register()` CALL PRODUCES SEVERAL KEYS, and a row must be written for
346347
* each of them — `SchemaRenderer` looks this table up with the raw
347348
* `schema.type`, which is whatever spelling the author wrote. A registration
348-
* with `namespace: 'view'` is reachable as `view:map` AND as bare `map`; one
349+
* with `namespace: 'view'` is reachable as `view:calendar` AND as bare `calendar`; one
349350
* with `skipFallback` is reachable ONLY under its namespaced key. MEASURED via
350351
* `ComponentRegistry.getAllTypes()` with the five plugins loaded, grouped by
351352
* the renderer each key resolves to.
@@ -366,7 +367,9 @@ export function resolveRecordSourceConfig<Arm extends RecordSourceDataArm>(
366367
* it does not compute one.
367368
*
368369
* - `ObjectGrid.tsx`'s `getDataConfig` — `'view-data'`.
369-
* - `ObjectMap.tsx`'s `getDataConfig` — `'view-data'`.
370+
* - `ObjectMap.tsx`'s `getDataConfig` — `'view-data'`. One block spelling
371+
* only: the bare `map` key (and with it `view:map`) is retired
372+
* (objectui#10393).
370373
* - `ObjectGantt.tsx`'s `rawDataConfig` — `'view-data'`. One block spelling
371374
* only: the bare `gantt` key is retired (objectui#8008).
372375
* - `ObjectCalendar.tsx`'s `dataConfig` — `'array'`.
@@ -383,8 +386,6 @@ const RECORD_SOURCE_DATA_ARM_BY_TYPE: Readonly<Record<string, RecordSourceDataAr
383386
'view:grid': 'view-data',
384387
'object-map': 'view-data',
385388
'plugin-map:object-map': 'view-data',
386-
'view:map': 'view-data',
387-
map: 'view-data',
388389
'object-gantt': 'view-data',
389390
'plugin-gantt:object-gantt': 'view-data',
390391
// — array arm: `z.array(...)`, pre-fetched records —

‎packages/plugin-map/README.md‎

Lines changed: 25 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,22 @@ marker comes from a record's own coordinate fields, and the first paint frames t
77
records that were fetched. It is a *view over data* — there is no authored marker
88
list, and no pin you place by hand.
99

10-
Importing the package registers two component types on the `ComponentRegistry`,
11-
both resolving to the same renderer:
10+
Importing the package registers one component type on the `ComponentRegistry`:
11+
`object-map`, the object-bound renderer. Inside an `ObjectView`, a stored `map`
12+
view is compiled to an `object-map` node, so a saved map view ends at the same
13+
component.
1214

13-
- `object-map` — the object-bound renderer
14-
- `map` — the bare spec view-type name (`ViewTypeSchema`'s `'map'`), for a node
15-
authored with it directly. Inside an `ObjectView`, a `map` view is compiled to
16-
an `object-map` node, so both spellings end at the same component.
15+
> **The bare `map` node type key is retired** (objectui#10393, following the
16+
> objectui#8008 ruling that retired `gantt`). The registry used to accept a node
17+
> authored `"type": "map"` (and its namespaced twin `view:map`) while the
18+
> published declaration refused it — `ObjectMapSchema.type` is the literal
19+
> `'object-map'` and no schema arm names `map` — so a validated document could not
20+
> use the key the registry took. Write `"type": "object-map"`.
21+
>
22+
> ⚠️ The **stored view type** `"map"` — what a saved `listViews[].type` or
23+
> `defaultViewType` holds — is a **different layer and is unchanged**. Do not
24+
> rewrite it: `ObjectView` maps a stored `map` view onto the `object-map` node
25+
> type, so no saved view moves.
1726
1827
## Installation
1928

@@ -88,12 +97,14 @@ is honoured as well.
8897

8998
**The provider does not change which query keys apply** (objectui#9061, the port
9099
of objectui#8769). An authored `filter` and `sort` narrow and order the rows on
91-
**every** provider, inline ones included — `staticData`, a bare array under
92-
`data`, and `data: { provider: 'value', items }` all reach the same in-memory
93-
adapter the other providers go through, so `filter` is evaluated with the same
94-
matcher. Before objectui#9061 the inline provider skipped that query and plotted
95-
every authored row with an authored `filter` silently dropped. The platform row
96-
ceiling (2,000 drawn rows, with a footnote naming both numbers — objectui#7210,
100+
**every** provider, inline ones included — `staticData` and
101+
`data: { provider: 'value', items }` both reach the same in-memory adapter the
102+
other providers go through, so `filter` is evaluated with the same matcher. A
103+
bare array under `data` is not a record source on this map (objectui#8348): the
104+
ladder falls through to `staticData`, then `objectName`, so inline rows belong
105+
under `staticData`. Before objectui#9061 the inline provider skipped that query
106+
and plotted every authored row with an authored `filter` silently dropped. The
107+
platform row ceiling (2,000 drawn rows, with a footnote naming both numbers — objectui#7210,
97108
ruling a′) applies to inline rows too, and it is applied to the **filtered** set,
98109
never to the raw one: a large inline array that a `filter` cuts below the ceiling
99110
plots every matching row and shows no footnote.
@@ -113,7 +124,7 @@ The declared configuration input. Every key is optional:
113124
| `latitudeField` | Record field holding the latitude. Needs `longitudeField` alongside it; both values must be numbers. |
114125
| `longitudeField` | Record field holding the longitude. |
115126
| `locationField` | Single field holding both coordinates — see the formats below. Used when the lat/lng pair yields nothing. |
116-
| `titleField` | Field shown as the marker title. Omitted, the title is resolved by the object's own record-title precedence (`@object-ui/core`'s `getRecordDisplayName`, ADR-0079): the declared `nameField`, its deprecated `displayNameField` alias, the legacy `titleFormat` template, a type-aware pick from the object's fields, then name-ish keys read straight off the record — the rung that answers when no object definition reached the view, as `staticData` and an inline `data` array never fetch one. `Record #<id>` is the floor; `Marker` is reached only by a record carrying no id at all. |
127+
| `titleField` | Field shown as the marker title. Omitted, the title is resolved by the object's own record-title precedence (`@object-ui/core`'s `getRecordDisplayName`, ADR-0079): the declared `nameField`, its deprecated `displayNameField` alias, the legacy `titleFormat` template, a type-aware pick from the object's fields, then name-ish keys read straight off the record — the rung that answers when no object definition reached the view, as `staticData` and an inline `data: { provider: 'value', items }` configuration never fetch one. `Record #<id>` is the floor; `Marker` is reached only by a record carrying no id at all. |
117128
| `descriptionField` | Field shown under the title in the marker popup. |
118129
| `zoom` | Zoom level. Declaring it opts this view out of the auto-fit (see below). |
119130
| `center` | `[latitude, longitude]` — a two-number **tuple**, latitude first. Declaring it opts this view out of the auto-fit. |
@@ -212,7 +223,7 @@ declare const dataSource: ObjectMapProps['dataSource'];
212223
| Prop | Description |
213224
| --- | --- |
214225
| `schema` | The map schema — the keys above. |
215-
| `dataSource` | Resolves the `object` provider. Not needed for `staticData` or an inline `data` array. |
226+
| `dataSource` | Resolves the `object` provider. Not needed for `staticData` or an inline `data: { provider: 'value', items }` configuration. |
216227
| `className` | Classes for the wrapper around the map. |
217228
| `data` | Records to render directly, bypassing the component's own fetch — the shape `ListView` passes when it already holds the rows. Tracked live: passing a new array after mount (e.g. once a host's own in-flight query resolves) updates the map. |
218229
| `onMarkerClick` | Called with the clicked record. |

‎packages/plugin-map/src/ObjectMap.schemaDataShorthand.test.tsx‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ import { describe, it, expect, vi } from 'vitest';
6666
import { SchemaRenderer, SchemaRendererProvider } from '@object-ui/react';
6767
import { ComponentRegistry, recordSourceDataArmForType } from '@object-ui/core';
6868
import { ObjectMap } from './ObjectMap';
69-
// Registers `object-map` and its `view:map` alias — row 3 renders through it.
69+
// Registers `object-map` — row 3 renders through it.
7070
import './index';
7171
import type { DataSource } from '@object-ui/types';
7272

@@ -190,15 +190,14 @@ describe('ObjectMap — the bare-array `schema.data` shorthand is retired (objec
190190
// namespaced key and a bare one, and `SchemaRenderer` looks the arm up with
191191
// the raw `schema.type`. A key added without a row in
192192
// `recordSourceDataArmForType` turns this red instead of silently answering
193-
// `'undeclared'` and keeping the prop seat. Unlike `plugin-grid`, this
194-
// plugin claims the bare `map` key too — no `skipFallback` here.
193+
// `'undeclared'` and keeping the prop seat. The bare `map` key and its
194+
// `view:map` twin are retired (objectui#10393), so the group is exactly the
195+
// one registration's two keys.
195196
const siblings = ComponentRegistry.getAllTypes().filter(
196197
(type) => ComponentRegistry.get(type) === ComponentRegistry.get('object-map'),
197198
);
198199

199-
expect(siblings).toEqual(
200-
expect.arrayContaining(['object-map', 'plugin-map:object-map', 'view:map', 'map']),
201-
);
200+
expect([...siblings].sort()).toEqual(['object-map', 'plugin-map:object-map']);
202201
for (const type of siblings) {
203202
expect([type, recordSourceDataArmForType(type)]).toEqual([type, 'view-data']);
204203
}

0 commit comments

Comments
 (0)