This repository was archived by the owner on Nov 4, 2026. It is now read-only.
Repository navigation
Commit 6bca0e4
feat(types)!: retire the legacy ActionSchema onSuccess/onFailure callback pair and delete ActionCallback (objectui#7068) (#7832)
`@object-ui/types` published a THIRD meaning of `onSuccess`: the legacy
`crud.ts` `ActionSchema` carried `onSuccess?` / `onFailure?` as Phase-2
`ActionCallback` objects, zod-mirrored and taught by two docs pages, with zero
producers outside the package's own fixture and zero runtime readers, while
`@objectstack/spec`'s `ActionSchema` refuses the shape at publish. Maintainer
ruling option 1 (2026-09-05): retire it, both faces, docs in the same PR.
- crud.ts: `ActionCallback` DELETED (the objectui#7664 / PR #7743 route for a
standalone retired type); `onSuccess?: never` / `onFailure?: never` with the
RETIRED docblocks — tombstones, not deletions, because `BaseSchema`'s index
signature would admit a deleted key
- crud.zod.ts: `ActionCallbackSchema` and its inferred alias DELETED; the two keys
are `retirementTombstone()` named refusals whose guidance names the spec's
`{ navigate, openIn }` block on `UIActionSchema` and `successMessage` /
`errorMessage`
- both barrels drop the two names; parity ledger drops the pair
(`EXPECTED_MIRROR_PAIRS` 159 -> 158, header chain extended); the 7340 handler
census records the two new `on*?: never` members (26 -> 28, `onFailure` in
the name net)
- phase2-schemas fixture no longer authors the callback shape; new pin
action-callback-retired-7068: both faces refuse at path with the guidance
(direct, via DetailSchema.actions, via the union door), base-vs-extended
contrast on both faces, neighbours stay legal, absence of the deleted names
(barrel object + AST), spec comparison (refuses the callback shape, accepts
the navigation block), docs corpus scan, tsc legs
- docs: the three enhanced-actions.mdx fences author successMessage /
errorMessage; "Callbacks" becomes a "Post-success behaviour" note (no fence);
schema-overview.md fragment / bullet / checklist row rewritten; the stale
doc-types `message` exemption removed
- changeset (types minor, "Breaking for authored metadata")
Claude-Session: https://claude.ai/code/session_01BAZFhALsQsGqxui8sNqM8s
Co-authored-by: Claude <noreply@anthropic.com>1 parent 3faaa7d commit 6bca0e4
12 files changed
Lines changed: 565 additions & 147 deletions
File tree
- .changeset
- content/docs
- core
- guide
- packages/types/src
- __tests__
- zod
- scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
| 57 | + | |
| 58 | + | |
65 | 59 | | |
66 | 60 | | |
67 | 61 | | |
| |||
302 | 296 | | |
303 | 297 | | |
304 | 298 | | |
305 | | - | |
306 | | - | |
307 | | - | |
| 299 | + | |
308 | 300 | | |
309 | | - | |
310 | | - | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
311 | 308 | | |
312 | | - | |
313 | | - | |
314 | | - | |
315 | | - | |
316 | | - | |
317 | | - | |
318 | | - | |
319 | | - | |
320 | | - | |
321 | | - | |
322 | | - | |
323 | | - | |
324 | | - | |
325 | | - | |
326 | | - | |
327 | | - | |
328 | | - | |
329 | | - | |
330 | | - | |
331 | | - | |
332 | | - | |
333 | | - | |
334 | | - | |
335 | | - | |
336 | | - | |
| 309 | + | |
337 | 310 | | |
338 | | - | |
339 | | - | |
340 | | - | |
341 | | - | |
342 | | - | |
343 | | - | |
344 | | - | |
345 | | - | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
346 | 318 | | |
347 | 319 | | |
348 | 320 | | |
| |||
446 | 418 | | |
447 | 419 | | |
448 | 420 | | |
449 | | - | |
450 | | - | |
451 | | - | |
452 | | - | |
453 | | - | |
454 | | - | |
455 | | - | |
456 | | - | |
457 | | - | |
458 | | - | |
459 | | - | |
460 | | - | |
461 | | - | |
462 | | - | |
463 | | - | |
464 | | - | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
465 | 424 | | |
466 | 425 | | |
467 | 426 | | |
| |||
514 | 473 | | |
515 | 474 | | |
516 | 475 | | |
517 | | - | |
| 476 | + | |
518 | 477 | | |
519 | 478 | | |
520 | 479 | | |
521 | 480 | | |
522 | 481 | | |
523 | 482 | | |
524 | 483 | | |
525 | | - | |
| 484 | + | |
526 | 485 | | |
527 | 486 | | |
528 | 487 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
| 73 | + | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
85 | 84 | | |
86 | 85 | | |
87 | 86 | | |
| |||
94 | 93 | | |
95 | 94 | | |
96 | 95 | | |
97 | | - | |
| 96 | + | |
98 | 97 | | |
99 | 98 | | |
100 | 99 | | |
| |||
274 | 273 | | |
275 | 274 | | |
276 | 275 | | |
277 | | - | |
| 276 | + | |
278 | 277 | | |
279 | 278 | | |
280 | 279 | | |
| |||
300 | 299 | | |
301 | 300 | | |
302 | 301 | | |
303 | | - | |
| 302 | + | |
304 | 303 | | |
305 | 304 | | |
306 | 305 | | |
| |||
0 commit comments