This repository was archived by the owner on Nov 4, 2026. It is now read-only.
Repository navigation
Commit 7bf133d
test(i18n-gate): pin the factory half's abstention counters on main, as the hand-rolled half already is (#8605)
`scripts/check-i18n-call-site-keys.mjs` keeps two parallel halves of one class —
the factory walk (objectui#7567) and the declared hand-rolled registry
(objectui#7877) — with parallel counters. Their MAIN-LINE pin cases in
`scripts/__tests__/check-i18n-call-site-keys.test.ts` were not parallel.
'and main is measured, not merely green' pins all four of the hand-rolled
abstentions including `handRolledMatchingRows === handRolledComparedRows`.
'main carries no factory drift, over a surface big enough for that to mean
something' pinned two of four — `factoryUnreadableTables` and
`factoryUnreadableRows` — and neither `factoryRowsNoEnKey`,
`factoryUnjudgedRows`, nor the matching/compared equality. That is the wrong
half to leave unpinned: the factory half takes its population from the SOURCE,
so it absorbs a new table without anybody choosing to. `factoryRowsNoEnKey`
went 5 to 0 when objectui#7887 retired the `timeline.relative.*` rows and
nothing in this repository failed, because the only carriers of that number
were comments.
The three missing lines are now mirrored into the factory case. Measured on
this tree before pinning (`analyze(repoRoot)`, the same call the case reads):
factoryTables 32, factorySites 32, factoryRows 846, factoryComparedRows 846,
factoryMatchingRows 846, factoryRowsNoEnKey 0, factoryUnjudgedRows 0,
factoryUnreadableTables 0, factoryUnreadableRows 0 — so all three read clean
and no observed non-zero was pinned to make anything green.
The existing `factoryTables > 25` and `factoryComparedRows > 500` lower bounds
are kept unchanged: without them a zero degrades from a reading into "the scan
found nothing". No threshold lowered, no assertion removed, no test skipped.
Note for a future reader: `factoryRowsNoEnKey` and `factoryUnjudgedRows` are
also asserted `.toBe(1)` further up the same file, by two SYNTHETIC fixture
cases. Those prove the counters can move; they are not a reading on main. A
grep that only asks whether the symbol is ever expected somewhere conflates
the two.
Fixes #8423
Claude-Session: https://claude.ai/code/session_01FhBNJcLRZLe8M87VcUgpKr
Co-authored-by: Claude <noreply@anthropic.com>1 parent 5cc8c28 commit 7bf133d
2 files changed
Lines changed: 29 additions & 0 deletions
File tree
- .changeset
- scripts/__tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1502 | 1502 | | |
1503 | 1503 | | |
1504 | 1504 | | |
| 1505 | + | |
| 1506 | + | |
| 1507 | + | |
| 1508 | + | |
| 1509 | + | |
| 1510 | + | |
| 1511 | + | |
| 1512 | + | |
| 1513 | + | |
| 1514 | + | |
| 1515 | + | |
| 1516 | + | |
| 1517 | + | |
| 1518 | + | |
| 1519 | + | |
| 1520 | + | |
| 1521 | + | |
1505 | 1522 | | |
1506 | 1523 | | |
1507 | 1524 | | |
| |||
0 commit comments