This repository was archived by the owner on Nov 4, 2026. It is now read-only.
Repository navigation
Commit 92c2a69
feat(app-shell): Publish opens the pending-changes sheet to confirm, Changes opens it to review (objectui#12517) (#12595)
Fixes #12517
Clause-②: no
## What changed
**Target 3 — one sheet, one component, one prop.** `DraftChangesPanel`
takes `posture`, either `review` (the default) or `confirm`. The Studio
keeps one `changesPosture` state beside `changesOpen`. Publish sets
`confirm` and Changes sets `review`, each before opening, and the single
`DraftChangesPanel` mount passes it. The Home page, `DraftPreviewBar`
and `CommitTimeline` pass nothing and keep the review behaviour. Publish
is still review-then-confirm (objectui#2261): the header click only
opens the sheet, and only the footer's Publish all publishes.
**Target 1 — Publish opens to confirm.** When the list first arrives on
each open, every row is expanded, a summary line above the list counts
what the publish carries (for example `4 items · 2 object · 1 app · 1
page`), and focus moves to Publish all. The line is built from the
panel's existing per-type grouping, the one that draws the `OBJECT · 2`
headings, so there is no second classification. A row the author
collapses stays collapsed while the rows classify. The seed runs in a
layout effect, so no frame shows the list collapsed first.
**Target 2 — Changes opens to review.** Rows stay collapsed, focus lands
on the list, and Publish all is in the footer, unfocused. There is no
summary line.
**Constraints kept.** With nothing pending, Publish stays disabled and
described by `publish-none-reason` (objectui#12303); on a read-only
package the reason still rides its wrapper. `studio-changes-count` and
the other test ids are unchanged. The objectui#12510 pin
`DraftChangesPanel.accessibleNames-12510` stays green.
New language-pack keys under `preview.changes`: `summaryItems` (with
plural forms) and `summaryType`, in all ten locales.
## Deviations
- The type segments show the raw canonical type, the same token the
group headings show (`2 object`), not a localized plural noun. The panel
has no type-label table, and it sits on the console's eager graph, so it
cannot import the metadata-admin one.
- Publish all does not exist until the list loads, so focus starts on
the list and moves to Publish all when the list arrives, unless the
author has already moved it.
- The confirm posture reads each draft's detail at open (two reads per
row), because every row is expanded. The review posture still reads
lazily on expand.
## Screenshots
These are on the never-merged evidence branch
`claude/issue-12517-evidence`, at a writable package with four drafts of
three types, 1280 px wide.
- Publish, confirm posture, dark:
https://github.com/objectstack-ai/objectui/blob/a4de5c7d69509c1521ed0f5047f8671417d2da9d/docs/design/studio-redesign/findings/12517/12517-publish-confirm-dark.png?raw=true
- Publish, confirm posture, light:
https://github.com/objectstack-ai/objectui/blob/a4de5c7d69509c1521ed0f5047f8671417d2da9d/docs/design/studio-redesign/findings/12517/12517-publish-confirm-light.png?raw=true
- Changes, review posture, dark:
https://github.com/objectstack-ai/objectui/blob/a4de5c7d69509c1521ed0f5047f8671417d2da9d/docs/design/studio-redesign/findings/12517/12517-changes-review-dark.png?raw=true
- Changes, review posture, light:
https://github.com/objectstack-ai/objectui/blob/a4de5c7d69509c1521ed0f5047f8671417d2da9d/docs/design/studio-redesign/findings/12517/12517-changes-review-light.png?raw=true
Read from the DOM at capture, in both themes: confirm showed
`data-posture=confirm`, four `aria-expanded=true` and active element
`draft-changes-publish`; review showed `data-posture=review`, four
`aria-expanded=false` and active element `draft-changes-list`.
## Test evidence (head 737592f)
- `pnpm exec vitest run
packages/app-shell/src/views/studio-design/StudioDesignSurface.`: 82
files, 560 tests passed.
- `pnpm exec vitest run` over every `DraftChangesPanel*`,
`DraftPreviewBar*` and `CommitTimeline*` test, plus `packages/i18n/`: 98
files passed, 1413 tests passed, 13 skipped.
- Full `pnpm --filter @object-ui/app-shell test`, once, on ad97f9d: 1427
files passed, 1 skipped; 13553 tests passed, 9 skipped; exit 0. One ru
locale value and a merge of main came after this run. On 737592f only
the two targeted batches above were re-run.
- `type-check` for `@object-ui/app-shell` and `@object-ui/i18n`, build,
`check:i18n-keys`, `check:i18n-drift`, `check:i18n-designer-parity`,
`check:new-line-citations` and `check-changeset-presence` all exit 0.
eslint on the touched files: 0 errors.
- New pins: `DraftChangesPanel.posture-12517.test.tsx` (confirm, review,
and a CONTROL for a host that passes no posture) and
`StudioDesignSurface.publishPosture-12517.test.tsx` (which door passes
which posture, and that nothing pending still leaves Publish disabled
with its reason). Each was ablated once and went red: seeding moved back
to a passive effect, the seed removed, and Publish set to review. Each
was restored with `git diff HEAD` empty.
## Acceptance notes
- For a NEW object, the drill-in lists `_packageId` under Also changed.
That is a framework key shown as the author's edit, the same shape as
the read-decoration keys stripped earlier. It is reported to the seat,
not fixed here.
- In dark mode the New and Update badges keep their light fills. This is
pre-existing polish, not in this card's scope.
---
_Generated by [Claude
Code](https://claude.ai/code/session_01MxLBRTq32u4PebqJCjFXW7)_
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent 7b5e558 commit 92c2a69
15 files changed
Lines changed: 487 additions & 6 deletions
File tree
- .changeset
- packages
- app-shell/src
- preview
- __tests__
- views/studio-design
- i18n/src/locales
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
471 | 471 | | |
472 | 472 | | |
473 | 473 | | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
474 | 484 | | |
475 | 485 | | |
| 486 | + | |
| 487 | + | |
476 | 488 | | |
477 | 489 | | |
478 | 490 | | |
479 | 491 | | |
480 | 492 | | |
481 | 493 | | |
482 | 494 | | |
| 495 | + | |
483 | 496 | | |
484 | 497 | | |
485 | 498 | | |
| |||
514 | 527 | | |
515 | 528 | | |
516 | 529 | | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
517 | 562 | | |
518 | 563 | | |
519 | 564 | | |
| |||
652 | 697 | | |
653 | 698 | | |
654 | 699 | | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
655 | 707 | | |
656 | 708 | | |
657 | 709 | | |
| |||
663 | 715 | | |
664 | 716 | | |
665 | 717 | | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
666 | 730 | | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
667 | 734 | | |
668 | | - | |
| 735 | + | |
669 | 736 | | |
670 | 737 | | |
671 | 738 | | |
| |||
854 | 921 | | |
855 | 922 | | |
856 | 923 | | |
| 924 | + | |
857 | 925 | | |
858 | 926 | | |
859 | 927 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
0 commit comments