This repository was archived by the owner on Nov 4, 2026. It is now read-only.
Repository navigation
Commit 95a7c8d
fix(types): content-channel refusals name the parser tier's not-a-container warning (objectui#10928) (#10956)
Fixes #10928
Clause-②: no — message and `.describe()` text only; every accept or
refuse verdict stays byte-identical (auxiliary face).
Implemented by the `os-dev` dispatched from the `domain:spec` seat,
session `https://claude.ai/code/session_012UwY3ahMixEFkfTUxMVkYm`
(`mode:subagent`). Base `5c94589f0`, head `5833df79f`.
## What changed
Only the false clause changes. It changes on every refusal of a node
whose renderer reads NEITHER content channel (family D and the E3
residual, objectui#9256). "no error, no warning, no element" now reads:
> no render-time error or warning and no element; only the parser tier's
`not-a-container` warning (objectui#9910) noticed it
This is the wording the objectui#10907 changesets settled on. Every site
is in the past tense, so the clause is too. Every other byte of each
string is unchanged; the proof is below.
- **zod mirror.** The refusal message and its `.describe()` text are one
string. There are 131 literal sites in the 12 `*.zod.ts` files, plus the
two builders that compose the rest:
- the shared `neitherContentChannelGuidance` in `zod/tombstone.zod.ts`
(13 consts, 26 arms);
- `ai.zod.ts`'s local `neitherChannel` (6 arms).
- The shared builder's three source lines were re-wrapped by hand. Its
string value changes only in the clause.
- **TypeScript face.** 149 `body?: never` / `children?: never` docblocks
in the 12 matching `packages/types/src/*.ts` files. They ship in the
emitted `.d.ts`.
- **Only comment and string lines move.** Every changed line in the 12
TS files is a JSDoc continuation line. Every changed line in the zod
files is a string-literal line. Other changed lines: 0 on each face
(`git diff -U0`, filtered).
- **New pin:**
`packages/types/src/__tests__/content-channel-parser-tier-clause-10928.test.ts`.
- **Changeset:**
`.changeset/10928-content-channel-parser-tier-clause.md`,
`@object-ui/types: patch`.
## The parser tier, measured before the clause was written
**Instrument.** A one-shot probe, deleted and not committed. It builds
the manifest from the live registry the way
`container-declaration-ratchet.test.tsx` does: every KNOWN key, through
`manifestFromConfigs`. `components`, `fields` and 18 of the 19
`plugin-*` packages (all but `plugin-designer`) are imported. It then
runs `validateTree` once per leg.
**Population.** Every registry key, bare and namespaced, of the 81 node
types whose refusal says "reads NEITHER content channel". That is 177
keys: 164 real registrations and 13 lazy stubs that have no inputs yet.
None of the 177 declares a `children` input.
| leg added to the bare node | diagnostic it adds, identical on all 177
keys |
|---|---|
| `children: [node]` | `not-a-container` (warning) |
| `body: [node]` or `body: node` | `not-a-container` (warning), from
`checkRetiredBodyDialect` over the same containment predicate |
| `body: 'hi'` (a scalar) | `unknown-prop` (warning) |
| neither key | nothing |
**Controls.** `div`, `ui:div`, `span` and `ui:span` declare `children`.
On them, adding `children` adds nothing, and adding a `body` list adds
`unknown-prop`.
**Reading.** The dispatch assumed that a node "with `body` (not
`children`)" stays silent. It does not: a `body` child list draws the
same `not-a-container`. So the settled clause is true for both members,
which share one string. A scalar `body` draws `unknown-prop` instead;
see the Acceptance notes.
## Census, base `5c94589f0` vs head `5833df79f`
The card's 126 and 139 come from a line-bound grep. The same clause also
sits on 25 sites where a line break or a `'…' + '…'` join falls inside
it: 15 zod (the shared builder among them) and 10 TS docblocks. So the
count below joins those first.
| face | old clause, base → head | new clause, base → head | control
`NEITHER content channel`, base / head |
|---|---|---|---|
| zod | 141 → 8 | 0 → 133 | 137 / 137 |
| TS docblocks | 149 → 0 | 0 → 149 | 162 / 162 |
- The absent-token control `qqzz_absent_token_9999` reads 0 in every
cell.
- **The 8 old clauses left on the zod face are all in
`HeaderBarSchema`:** `title`, `logo`, `nav`, `left`, `center`, `right`,
`sticky` and `height`.
- Those keys are not content channels. The parser tier answers each of
them with `unknown-prop`, not `not-a-container`.
- So the settled clause would be false there, and they are left
untouched; see the Acceptance notes.
- The in-scope count is therefore 282 = 133 + 149, and each of those
sites moved from the old clause to the new one.
- **Emitted `dist`**, after `pnpm --filter @object-ui/types build` at
head, joined the same way:
- `.d.ts`: old 0, new 149.
- JS: the 16 old clauses left are the 8 `HeaderBarSchema` strings, twice
(`zod/navigation.zod.js` and `zod/index.zod.js`).
The command, exactly as run. The enumeration and the read both come from
REF, and `__tests__` is excluded. JSDoc continuations and `'…' + '…'`
joins are removed, and an escaped quote is unescaped.
```
for REF in 5c94589 5833df7; do for FACE in zod ts; do
if [ "$FACE" = zod ]; then X='--exclude=*/__tests__/*'; P=packages/types/src/zod; else X='--exclude=*/zod/*'; P=packages/types/src; fi
printf '%s %-3s ' "$REF" "$FACE"
git archive "$REF" "$P" | tar -xO --exclude='*/__tests__/*' "$X" | perl -0777 -ne 's/\n[ \t]*\*[ \t]?/ /g; s/\x27[ \t]*\n[ \t]*\+[ \t]*\x27//g; s/\\\x27/\x27/g; my $o = () = /no\s+error,\s+no\s+warning,\s+no\s+element/g; my $n = () = /no\s+render-time\s+error\s+or\s+warning\s+and\s+no\s+element;\s+only\s+the\s+parser\s+tier\x27s\s+`not-a-container`\s+warning\s+\(objectui#9910\)\s+noticed\s+it/g; my $c = () = /NEITHER\s+content\s+channel/g; my $z = () = /qqzz_absent_token_9999/g; print "old=$o new=$n control=$c absent=$z\n"'
done; done
```
## Verdicts unchanged, and every other byte of every message
**Instrument.** A one-shot probe, deleted and not committed. It records
777 keyed entries, taken once at base and once at head:
- every exported zod schema (241), each over 6 generic inputs: `{}`, a
`children` list, a `body` list, a scalar `body`, a scalar `children`,
and both keys;
- the `.describe()` text of every direct shape member of 196 object
schemas;
- `safeValidateSchema` over 85 node types, each over 4 legs: none,
`children`, a `body` list and a scalar `body`.
**Result.**
- Success flags, issue codes and issue paths are identical at base and
head (116 successes at both).
- Messages and describe texts: take the head payload and substitute the
old clause back for the new one. The result is byte-identical to the
base payload. So each string changed in the clause and nowhere else.
- The old clause occurs 915 times in the base payload and 8 times in the
head payload. Those 8 are the `HeaderBarSchema` refusals.
- On the built `dist`, `safeValidateSchema({ type: 'accordion',
children: [...] })` answers `invalid_type` at `children`, and its
message carries the new clause.
## Reverse verification (ablation), after the fix was committed
**Instrument.** objectstack's `scripts/ablation-replace.mjs`, in WRAP
mode. The anchor must hit the declared number of times, and the on-disk
blob must move. The restore is proven by blob == HEAD and an empty `git
diff HEAD`. Each leg puts the old clause back in one message source and
runs the new pin.
| mutation | blob mutated to | red / 10 | red tests |
|---|---|---|---|
| the shared builder, back to its base text | `8ff6af3b9` (the base
blob) | 5 | both builder tests, `object-grid` × 2, the population |
| `accordion`'s two literal arms | `751bf2d6f` | 3 | `accordion` × 2,
the population |
| `ai.zod.ts`'s `neitherChannel`, back to its base text | `1fd44f9e0`
(the base blob) | 3 | `ai-form-assist` × 2, the population |
- Each leg restored to its HEAD blob (`da56e22f5`, `f7d88b6c5`,
`a40e67ff6`) with an empty `git diff HEAD`.
- The types tests import `../zod/*` source directly, so no build sits
between a mutation and the run.
## The pin, and why it holds the prose rather than the parser
`@object-ui/types` declares no workspace dependency, and its tests
import none. So `@object-ui/sdui-parser` cannot be imported from here
without declaring it (`check:phantom-deps`). The claim's file surface
also put the pin under `packages/types/src/__tests__/`.
What the pin holds:
- **The shared builder.** The clause stands exactly where the retired
one stood, and the retired one is gone.
- **One arm per message source,** each read through its refusal: a
literal (`accordion`), the shared builder (`object-grid`) and the local
builder (`ai-form-assist`). Each answers code `invalid_type` at the
key's own path, and its message carries the clause.
- **The population.** Every exported member whose refusal is the
family-D sentence carries the clause, so a later slice that copies an
older literal goes red. Non-vacuity is asserted by name over the three
sources, not by count.
The parser behaviour the clause describes stays pinned where the parser
and the registry live, and the new file's header names those pins:
- `containment-declared-slot-9910.test.ts` and
`body-dialect-6771.test.ts`, in `packages/sdui-parser`;
- `container-declaration-ratchet.test.tsx`, in `packages/components`. It
holds declared-slot ⇔ rendered-list over the live registry.
Whether to add a live-registry behavioural pin in `packages/components`
as well is left as an open question for the seat.
## Gates, head `5833df79f`
The gate list was derived by hand from objectui's root `package.json`
and `.github/workflows/`, against this diff.
| gate | result |
|---|---|
| `pnpm --filter @object-ui/types build` (tsc, vite, dist completeness)
| exit 0; "1 package(s) complete (134 emitted files verified)" |
| `pnpm --filter @object-ui/types type-check` (tsc, examples, tests) |
exit 0; `tsc -p tsconfig.test.json --listFiles` lists the new pin |
| `pnpm --filter @object-ui/types lint` | exit 0, 0 errors; the warnings
are existing `no-explicit-any`, none on the new file |
| `pnpm exec vitest run packages/types/` | 267 files, 5917 tests, all
passed |
| `check-changeset-presence` · `changeset:check` ·
`check-changeset-overwrite` | exit 0 each |
| `check:pending-changeset-literals` · `check:control-bytes` ·
`check:new-line-citations` (0 new) | exit 0 each |
| `check:handler-key-reads` · `type-check:coverage` · `lint:coverage` ·
`check:test-path-roots` · `check:unreferenced-sources` ·
`check:phantom-deps` · `check:published-tsconfig-exclude` ·
`check:esm-specifiers` · `check:spec-symbols` ·
`check:component-surface-parity` · `check:doc-types` | exit 0 each |
| `check:changeset-claims` | report-only, exit 0. Each pending changeset
it names for a touched file was read; none quotes the replaced clause. |
| governed guard `--test` over the diff's paths | NOT GOVERNED (lit
control `AGENTS.md`: exit 3) |
- **NOT MEASURED: `check:readme-exports`.** It judges README
self-imports against every package's `dist/*.d.ts`. This tree built only
`@object-ui/types`, so the gate printed "could not be judged … run `pnpm
build` first" and exited 1. That is a prerequisite, not a finding. This
diff touches no README and no export.
- **NOT MEASURED, left to CI:** `pnpm test` beyond `packages/types`, the
`dom` / `dom-heavy` projects, E2E and `test:dist`.
## Serial constraints
- **Open PRs**, mapped at hand-back: 13 open, files API, every page.
Only objectui#10930 touches a file here: `zod/complex.zod.ts`, in the
`GlobalFilterSchema` JSDoc.
- `git merge-tree` of this head against its head `1daf7edf7` is clean.
- Its head adds no old-clause site.
- **`main`** moved two commits since the base, to `06a96e948`. Neither
touches `packages/types` or `packages/sdui-parser`, and `git merge-tree`
against it is clean.
## Acceptance notes: out of scope, not changed here
- **`HeaderBarSchema`'s nine non-channel refusals**
(`zod/navigation.zod.ts`).
- Eight carry the same "no error, no warning, no element": `title`,
`logo`, `nav`, `left`, `center`, `right`, `sticky` and `height`.
`variant` says "no error, no warning, no class".
- The parser tier answers each of the nine keys with `unknown-prop`
(measured, same probe).
- `safeValidateSchema({ type: 'header-bar', title: 'T' })` hands back
the "no warning" message (measured on the built `dist`).
- Same defect class as this card, but the fix needs a different clause,
one naming `unknown-prop`. So it is reported to the seat, not swept
here.
- **The nine objectui#8284 `body?: never` docblocks** on `box`, `span`,
`container`, `flex`, `stack`, `grid`, `scroll-area`, `form` and `toggle`
(in `layout.ts` and `form.ts`).
- They say a `body` "rendered an EMPTY element with no error and no
warning".
- Each of those registrations declares `children`, and a `body` list on
it draws `unknown-prop` (measured on every bare and `ui:` key).
- TypeScript face only. Same class; reported, not changed.
- **A scalar `body`** on a reads-neither node draws `unknown-prop`, not
`not-a-container`. The clause speaks of an authored content value, which
in both channels is a child list or a node. The scalar case is not
written into it.
---
_Generated by [Claude
Code](https://claude.ai/code/session_012UwY3ahMixEFkfTUxMVkYm)_
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent 462c858 commit 95a7c8d
27 files changed
Lines changed: 584 additions & 286 deletions
File tree
- .changeset
- packages/types/src
- __tests__
- zod
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
255 | 255 | | |
256 | 256 | | |
257 | 257 | | |
258 | | - | |
| 258 | + | |
| 259 | + | |
259 | 260 | | |
260 | 261 | | |
261 | 262 | | |
| |||
281 | 282 | | |
282 | 283 | | |
283 | 284 | | |
284 | | - | |
| 285 | + | |
| 286 | + | |
285 | 287 | | |
286 | 288 | | |
287 | 289 | | |
| |||
468 | 470 | | |
469 | 471 | | |
470 | 472 | | |
471 | | - | |
| 473 | + | |
| 474 | + | |
472 | 475 | | |
473 | 476 | | |
474 | 477 | | |
| |||
494 | 497 | | |
495 | 498 | | |
496 | 499 | | |
497 | | - | |
| 500 | + | |
| 501 | + | |
498 | 502 | | |
499 | 503 | | |
500 | 504 | | |
| |||
652 | 656 | | |
653 | 657 | | |
654 | 658 | | |
655 | | - | |
| 659 | + | |
| 660 | + | |
656 | 661 | | |
657 | 662 | | |
658 | 663 | | |
| |||
678 | 683 | | |
679 | 684 | | |
680 | 685 | | |
681 | | - | |
| 686 | + | |
| 687 | + | |
682 | 688 | | |
683 | 689 | | |
684 | 690 | | |
| |||
0 commit comments