This repository was archived by the owner on Nov 4, 2026. It is now read-only.
Repository navigation
Commit 99878d8
fix(sdui-parser): validateTree no longer calls a declared bind unknown (objectui#11008) (#11042)
Fixes #11008
Clause-②: no
Seat `domain:ui#2`, PM session `session_011p7ikEivgXefNDaE5S5Uec`,
branch `claude/issue-11008-bind-base-prop` (PM claim `5882983059`).
Route 1 of the card, per triage direction `5874689995` and review
addendum `5874136200`.
## What this changes
`validateTree` (`@object-ui/sdui-parser`) keeps a `BASE_PROPS` set of
keys every node may carry without an `unknown-prop` warning.
`BaseSchema` declares `bind` and `hidden` for every node, and no
registration declares either as an input. So the undeclared-key branch
answered every authored one with `unknown-prop` (`has no prop "bind"`),
including on the nodes that honour it: `list`, `tree-view` and the
`object-*` widgets read `bind` through `useDataScope`, and
`SchemaRenderer`'s hide chain reads `hidden` for every node. Both keys
now join `BASE_PROPS`.
- `packages/sdui-parser/src/validate.ts`: `'hidden'` and `'bind'` join
`BASE_PROPS`. The docblock says why, names the accepted cost
(`data-table` + `bind` is now silent at this tier), and says why
`placeholder` stays out.
- `packages/types/src/base.ts`: the `BaseSchema.bind` docblock, in its
objectui#10981 wording, drops the parser half. It names the render-time
`[ObjectUI] DataTable bind:` console warning (objectui#6575) as the one
signal and says the parser tier is silent.
-
`packages/types/src/__tests__/silence-clause-parser-tier-closure-10981.test.ts`:
`BIND_CLAUSE` is rewritten to that sentence. A negative assertion on the
retired "`unknown-prop` warning both name it" wording is added, and the
header's `bind` bullet records the move.
- New pin
`packages/sdui-parser/src/__tests__/base-props-bind-hidden-11008.test.ts`
(the tier's reading of a manifest):
- both keys draw nothing in every value shape `BaseSchema` admits;
- the near-miss `bindTo` / `hide` still draws one `unknown-prop` naming
it;
- a registration that declares `placeholder` keeps its `type-mismatch`.
- New pin
`packages/components/src/renderers/__tests__/bind-base-prop-parser-tier-11008.test.tsx`,
in the shape of `header-bar-unknown-prop-parser-tier-10981.test.tsx`
(live registry):
- no registration declares either key;
- `list` / `tree-view` + `bind` or `hidden` draw nothing;
- `data-table` + `bind` draws nothing;
- the lit control, `bindTo` on `data-table`, draws `unknown-prop`;
- across every live registration, neither key draws a diagnostic naming
it.
- `.changeset/11008-bind-base-prop.md`: `patch` for
`@object-ui/sdui-parser` and `@object-ui/types`, because the docblock
ships in the emitted `.d.ts`.
Landing site as the claim declared it. No producer outside `sdui-parser`
/ `types` was involved.
## Bounded in-place fix: `hidden` (dispatch zone 2, item 2)
Both keys the addendum named were measured through `validateTree` before
deciding:
- **`hidden` is included.** It drew `unknown-prop` on every registered
type and is declared by none. That is the same defect class, fixed the
same mechanical way in the same file, and checked by the same gate
family. It is pinned beside `bind` in both new files.
- **`placeholder` is left out.** It draws `unknown-prop` on the types
that do not declare it. But the input family (`input`, `textarea`,
`select`, `combobox`, `date-picker`, `element:text_input`, …) declares
it as a typed input, and `BASE_PROPS` membership skips the
declared-input lookup. Adding it would silence those registrations'
`type-mismatch`, so the fix is not the same. It is left as it was, and
the sdui-parser pin holds the type check it would have silenced.
## Measurements
The probe was a temporary vitest file, deleted after use and never
committed. It loaded `@object-ui/components`, `@object-ui/fields`,
fourteen `plugin-*` packages and `plugin-tree` into the registry (488
known types at `b3c96d6bc`). It then built the manifest over every known
key with `manifestFromConfigs` and ran `validateTree` once per key per
type.
| key | types drawing `unknown-prop` before | after | registrations
declaring it |
|---|---|---|---|
| `bind` | 488 of 488 | 0 | 0 |
| `hidden` | 488 of 488 | 0 | 0 |
| `placeholder` | 470 | 470 | 18, each answering `placeholder: 424242`
with `type-mismatch`, before and after |
`bind` on each reader the docblock names drew `has no prop "bind"`
before this change. The readers are `list`, `tree-view`, `object-chart`,
`object-data-table`, `object-pivot`, `object-grid`, `object-kanban`,
`object-gallery` and `object-timeline`. After the change, each draws
nothing beyond its own bindless control's diagnostics
(`missing-required-prop` for `objectName` and the like). `data-table` +
`bind` also drew `unknown-prop` before and draws nothing after.
## Tests and gates
The union ran after the final commit, at HEAD `2e74398a2`:
- `pnpm exec vitest run packages/sdui-parser/ packages/types/`, plus
three components pins (the two parser-tier pins and
`skill-guide-data-table-binding.test.tsx`) and six `scripts/__tests__`
changeset-state suites: **306 files, 6959 tests passed**.
- The parser's consumer radius is every other test file importing
`@object-ui/sdui-parser` (apps/console, cli, components, layout,
plugin-*, schema-catalog, scripts, vscode-extension): **46 files, 893
tests passed**.
- Gates at HEAD, each exit 0: `check-changeset-presence`,
`check-control-bytes`, `check-new-cross-file-line-citations` (0 new),
`check-pending-changeset-literals`, `check-changeset-no-major`.
`check-governed-queue-guard --test` over the six paths answers NOT
GOVERNED.
Earlier runs, on the tree whose only later change is the changeset text:
- `pnpm --filter @object-ui/PKG type-check` for `sdui-parser`, `types`
and `components` exits 0 after `pnpm --filter
'@object-ui/components^...' build`. `tsc --listFilesOnly` confirms that
each package's test project reads the new or edited test file.
- `pnpm exec eslint` on the five changed code files: 0 errors. The 20
warnings are pre-existing `no-explicit-any` in `base.ts`, outside this
diff's hunk.
- `check-changeset-claims`, `check-test-path-roots`,
`check-phantom-dependencies`, `check-package-self-import` and
`check-shell-escape-residue` each exit 0.
Declared narrowing: the full `pnpm test`, the repo-wide `pnpm lint` and
the full type-check farm are CI's.
## Reverse verification (one-off; both legs committed first, and neither
left behind a permanent test)
Both mutations used objectstack's `scripts/ablation-replace.mjs`, which
wraps the command, checks the anchor count and blob change, and restores
with `git checkout HEAD` plus a blob comparison.
1. **Deleting `'hidden',` and `'bind',` from `BASE_PROPS`.** Anchor 1 →
0, blob `0f8971827c72` → `43ca588eb800`.
- Result: **6 failed, 6 passed (12)**. Every fix row went red: the
`bind` / `hidden` value-shape rows, `list`, `tree-view`, `data-table`,
and the all-registrations row.
- The controls stayed green: the bare node, `bindTo` / `hide`, the
`placeholder` type check, the "no registration declares either key" row,
and `bindTo` on `data-table`.
- Restored: blob equals HEAD `0f8971827c72`, and `git diff HEAD` is
empty.
- A first attempt in replace mode was refused by the tool, because the
replacement was a substring of the anchor (count 1 → 1). It was restored
at once, so it was a no-op, not a measurement.
2. **Planting the retired "`unknown-prop` warning both name it" wording
back into the `bind` docblock.** Blob `b55fd9e624f4` → `90beeaf14308`.
- Result: **1 failed, 8 passed (9)**. The failure is the `bind` docblock
row.
- Restored: blob equals HEAD `b55fd9e624f4`.
Direction was red both times, as expected. On the resolution path: the
root vitest alias maps `@object-ui/sdui-parser` to
`packages/sdui-parser/src`, so each mutation reached the subject without
a build.
## For objectui#11009 (`domain:skills`): what the `protocol.md` sentence
must say
`skills/objectui/rules/protocol.md`'s "**Readers only.**" paragraph ends
"…renders its header over an empty body — no error, no warning." After
this change, the true sentence names the console warning only, and says
the parser tier does not flag the key. For example:
> `data-table` does NOT: it reads its rows from an inline `data` array
on the node, so a `bind` on it is ignored and the table renders its
header over an empty body. Nothing on the page says why; the one signal
is a render-time console warning (`[ObjectUI] DataTable bind:`). The
parser tier does not flag it either: `bind` is a base prop there, legal
on every node.
`skills/**` is not touched here.
## Acceptance notes
- **The `metric-card` in `widgets` candidate row** (review `5878173500`)
is not taken. `validateTree`'s traversal is untouched (seat decision).
It remains a note for whoever next touches that traversal.
- **The same family, measured but not fixed here** (outside the
dispatch's two named keys):
- `visibleWhen`, `hiddenOn` and `testId` draw `unknown-prop` on all 488
types and are declared by none. `SchemaRenderer`'s hide chain reads
`visibleWhen` / `hiddenOn` for every node, and it strips and re-emits
`testId`. The mechanical fix would be the same.
- The canonical ADR-0089 `visibleWhen` warns, while the deprecated
`visibleOn`, which is in `BASE_PROPS`, stays silent.
- `name`, `label`, `description`, `data` and `ariaLabel`, like
`placeholder`, are declared as typed inputs by some registrations. For
those, joining `BASE_PROPS` trades away type checks, which is a decision
rather than a mechanical fix.
- These go to the seat as one family, for a closure card.
- **The parser's JSX type surface still refuses both keys.**
`SduiBaseProps` in `packages/sdui-parser/src/codegen.ts` (written into
`sdui-intrinsics.d.ts` by `scripts/gen-manifest.ts`) is a second
hand-kept base-prop list. Measured: with the generated types, `tsc`
refuses `bind` and `hidden` on `list` with TS2322, while a declared
`title` compiles. Not touched here (file surface); reported.
- **objectstack's save-gate copy of `validate.ts` keeps the pre-change
`BASE_PROPS`.** `validateJsxPages` runs it when a manifest is resolved.
`check-sdui-lockstep.mjs` compares the code set, the parse grammar
region and the containment predicate, so it cannot see this split. A
port to that copy is owed; reported.
- **A pending changeset now describes superseded wording.**
`.changeset/10981-silence-clause-parser-tier-closure.md` describes the
intermediate `bind` docblock wording (the parser half). Both entries
release together. This PR's changeset names the supersession, and the
objectui#10981 body is not edited here.
---
_Generated by [Claude
Code](https://claude.ai/code/session_011p7ikEivgXefNDaE5S5Uec)_
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent 2eaf5be commit 99878d8
6 files changed
Lines changed: 270 additions & 16 deletions
File tree
- .changeset
- packages
- components/src/renderers/__tests__
- sdui-parser/src
- __tests__
- types/src
- __tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
63 | 86 | | |
64 | 87 | | |
65 | 88 | | |
| |||
81 | 104 | | |
82 | 105 | | |
83 | 106 | | |
| 107 | + | |
| 108 | + | |
84 | 109 | | |
85 | 110 | | |
86 | 111 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | | - | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
28 | 32 | | |
29 | 33 | | |
30 | 34 | | |
| |||
38 | 42 | | |
39 | 43 | | |
40 | 44 | | |
41 | | - | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
42 | 48 | | |
43 | 49 | | |
44 | 50 | | |
| |||
62 | 68 | | |
63 | 69 | | |
64 | 70 | | |
65 | | - | |
66 | | - | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
67 | 78 | | |
68 | 79 | | |
69 | 80 | | |
| |||
166 | 177 | | |
167 | 178 | | |
168 | 179 | | |
169 | | - | |
| 180 | + | |
170 | 181 | | |
171 | 182 | | |
172 | 183 | | |
| 184 | + | |
173 | 185 | | |
174 | 186 | | |
175 | 187 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
277 | 277 | | |
278 | 278 | | |
279 | 279 | | |
280 | | - | |
281 | | - | |
282 | | - | |
283 | | - | |
284 | | - | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
285 | 288 | | |
286 | 289 | | |
287 | 290 | | |
| |||
0 commit comments