This repository was archived by the owner on Nov 4, 2026. It is now read-only.
Repository navigation
Commit a1ddb5b
test(plugin-map,plugin-timeline): pin what these two waits were standing on (#8713)
Both `contractEnvelope-6839` pins were green for reasons their wait
expressions did not state.
`ObjectMap` carries the family's only absence-shaped wait — `queryByText('Loading
map...')` is null. An absence nothing entered is satisfied by a mount that never
started: with the component mutated to `return null` unconditionally, an
implementation strictly worse than the bug, the refusal case still passed. And
the panel is a settle signal, not a rows signal — it stands in for "the rows are
on screen" only because `setData` and `setLoading(false)` land in one React
commit, which nothing asserted. With `setData` deferred by 50ms and the
`records` arm restored to `extractRecords`, the refusal case read zero markers
and passed while the settled map plotted two.
`ObjectTimeline` waited for `getByTestId('timeline-renderer')`'s
`data-item-count` to be not-null. That clause is inert: the renderer double
writes the attribute unconditionally, so once `getByTestId` stops throwing the
attribute is always a string, and the throw was the entire gate. It named a row
count and gated on a mount, so `"0"` satisfied it — under the same deferral the
wait was satisfied at `data-item-count="0"` while the settled timeline drew two
rows.
`markersThrough` now asserts the loading panel is on screen before waiting for
it to go, and that the marker count read at the transition survives a 50ms
settle window. `itemsThrough` takes the count its arm claims, gates the wait on
that value, requires it to survive the same window, and observes the loading
skeleton first so a renderer mounted empty on the first paint is not read as a
settled zero. 50ms rather than 0ms because RTL's `asyncWrapper` drains one
macrotask, so a 0ms deferral hides inside the window meant to detect it.
Test-only; no component was changed.
Refs objectui#8709
Claude-Session: https://claude.ai/code/session_01YBWFb5YgMU5dw8p2VKj16S
Co-authored-by: Claude <noreply@anthropic.com>1 parent 5ece49b commit a1ddb5b
3 files changed
Lines changed: 159 additions & 10 deletions
File tree
- .changeset
- packages
- plugin-map/src
- plugin-timeline/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
37 | 57 | | |
38 | 58 | | |
39 | 59 | | |
40 | | - | |
| 60 | + | |
41 | 61 | | |
42 | 62 | | |
43 | 63 | | |
| |||
72 | 92 | | |
73 | 93 | | |
74 | 94 | | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
75 | 106 | | |
76 | 107 | | |
77 | 108 | | |
| |||
105 | 136 | | |
106 | 137 | | |
107 | 138 | | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
108 | 150 | | |
109 | 151 | | |
110 | 152 | | |
| |||
114 | 156 | | |
115 | 157 | | |
116 | 158 | | |
117 | | - | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
118 | 182 | | |
119 | 183 | | |
120 | 184 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
35 | 52 | | |
36 | 53 | | |
37 | 54 | | |
38 | | - | |
| 55 | + | |
39 | 56 | | |
40 | 57 | | |
41 | 58 | | |
| |||
55 | 72 | | |
56 | 73 | | |
57 | 74 | | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
58 | 86 | | |
59 | 87 | | |
60 | 88 | | |
| |||
69 | 97 | | |
70 | 98 | | |
71 | 99 | | |
72 | | - | |
73 | | - | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
74 | 108 | | |
75 | 109 | | |
76 | 110 | | |
| |||
87 | 121 | | |
88 | 122 | | |
89 | 123 | | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
90 | 139 | | |
91 | 140 | | |
92 | 141 | | |
93 | 142 | | |
94 | 143 | | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
95 | 152 | | |
96 | | - | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
97 | 157 | | |
98 | | - | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
99 | 174 | | |
100 | 175 | | |
101 | 176 | | |
| |||
113 | 188 | | |
114 | 189 | | |
115 | 190 | | |
116 | | - | |
| 191 | + | |
117 | 192 | | |
118 | 193 | | |
119 | 194 | | |
120 | | - | |
| 195 | + | |
121 | 196 | | |
122 | 197 | | |
123 | 198 | | |
124 | 199 | | |
125 | 200 | | |
126 | 201 | | |
127 | | - | |
| 202 | + | |
128 | 203 | | |
129 | 204 | | |
130 | 205 | | |
| |||
0 commit comments