This repository was archived by the owner on Nov 4, 2026. It is now read-only.
Repository navigation
Commit ae923ec
feat(app-shell): the draft status chip sits in one place in every Studio item header (objectui#12524) (#12589)
Fixes #12524
Clause-②: no
## What changed
- **Target 1 (one place).** `StudioItemHeader` takes the item's status
as data (a new `status` prop: label and an optional tooltip) and draws
one shared amber chip, `StudioStatusChip`, right after the identity (the
title, then the api-name or kind chips) and before the meta. The
identity chips sit in an always-rendered `contents` wrapper
(`data-slot="identity-chips"`). It draws no box, so the layout is
unchanged, and the chip is the same child of the same title row in Data,
Automations, Interfaces and Access. The title stays a direct child of
the row, which the objectui#11665 pin reads.
- **Target 2 (actions only on the right).** Interfaces' "Unpublished
draft" leaves the actions slot. The right slot keeps, in order: the
autosaving spinner, the read-only link, Open in Data, Design / Run, and
the properties toggle. Data's saved-at meta and Automations' Enabled
switch stay at the right. Access's read-only link is an action, so it
stays there too (objectui#12453 behaviour unchanged).
- **Target 3 (the header places it).** Data, Automations and Interfaces
pass `status` with the `engine.studio.unpublishedDraft` text; Access
passes its writable "This package's objects · saved as draft" note
(`engine.studio.access.banner`, tooltip
`engine.studio.access.bannerTitle`). No pillar writes the chip markup
any more. No i18n keys added or retired; every existing data-testid
stays.
## Decisions and deviations
- Slot shape: a typed `status` prop rather than `chips`. The header owns
both the chip's position and its look, and the prop refuses markup or a
link, so a pillar cannot misplace or restyle it.
- Access: the writable note is treated as Access's status (the only
draft signal the pillar shows, and the card's measured Access chip). In
a read-only package the link stays in actions. Permission sets have no
per-set draft status today.
- The open-set Access header (the permission matrix page) is unchanged:
its note stays at the tab row's right end, where objectui#12456 put it
so the set's label is not truncated. That file is outside this change.
- The chip now has `shrink-0 whitespace-nowrap`. At 1280 px in the
Automations header, main's chip wrapped to two lines (37 px) while the
title still truncated; it now stays on one line (21 px). The title
truncation exists either way, from that pane's width.
- Deviation list against the artboards: no change beyond the above.
## Screenshots (1280 px, a writable package with a draft object, flow,
page and app; console at d9376cc against HotCRM 63db83e)
- Data:
[light](https://github.com/objectstack-ai/objectui/blob/33ef46f53/docs/design/studio-redesign/findings/12524/12524-data-header-light.png?raw=true)
·
[dark](https://github.com/objectstack-ai/objectui/blob/33ef46f53/docs/design/studio-redesign/findings/12524/12524-data-header-dark.png?raw=true)
- Automations:
[light](https://github.com/objectstack-ai/objectui/blob/33ef46f53/docs/design/studio-redesign/findings/12524/12524-automations-header-light.png?raw=true)
·
[dark](https://github.com/objectstack-ai/objectui/blob/33ef46f53/docs/design/studio-redesign/findings/12524/12524-automations-header-dark.png?raw=true)
- Interfaces:
[light](https://github.com/objectstack-ai/objectui/blob/33ef46f53/docs/design/studio-redesign/findings/12524/12524-interfaces-header-light.png?raw=true)
·
[dark](https://github.com/objectstack-ai/objectui/blob/33ef46f53/docs/design/studio-redesign/findings/12524/12524-interfaces-header-dark.png?raw=true)
· whole window
[light](https://github.com/objectstack-ai/objectui/blob/33ef46f53/docs/design/studio-redesign/findings/12524/12524-interfaces-full-light.png?raw=true)
·
[dark](https://github.com/objectstack-ai/objectui/blob/33ef46f53/docs/design/studio-redesign/findings/12524/12524-interfaces-full-dark.png?raw=true)
- Access:
[light](https://github.com/objectstack-ai/objectui/blob/33ef46f53/docs/design/studio-redesign/findings/12524/12524-access-header-light.png?raw=true)
·
[dark](https://github.com/objectstack-ai/objectui/blob/33ef46f53/docs/design/studio-redesign/findings/12524/12524-access-header-dark.png?raw=true)
The screenshots live on the never-merged branch
`claude/issue-12524-evidence`; this branch carries no PNG.
## Test evidence (head d9376cc)
- New: `StudioItemHeader.statusPlace-12524.test.tsx`, 4 passed. It
renders the four real pillars with a draft and asserts the chip is a
child of the title row at one shared index, after the title and the
identity chips, outside the actions. It also asserts the Interfaces
actions keep their order with no chip among them. CONTROL: no draft, no
chip (Data, Automations, Interfaces); a read-only package, no Access
status, and the read-only link in the actions slot.
- Ablation: moving the Interfaces chip back into the actions turns 2 of
4 red. After restoring with `git checkout HEAD`, `git diff HEAD` is
empty.
- Full app-shell suite (the file set of `pnpm --filter
@object-ui/app-shell test`), run in 8 shards because of the session's
10-minute command cap: 1420 files passed and 1 skipped; 13538 tests
passed and 9 skipped. The existing
`StudioDesignSurface.flowCanvasChip-11665` pin is green, unmodified.
- `type-check` (source and test configs), `build`, eslint on the touched
files (0 errors), `check:i18n-keys`, `check:i18n-drift`,
`check-changeset-presence` and `check:new-line-citations`: all exit 0.
## Acceptance notes
- Permission sets show no item-level draft status: the Access note says
how edits save, not whether this set has a pending draft. Recorded only;
not part of this change.
Session: `https://claude.ai/code/session_01GzRy6FiHuy1vpBecH2KRYM`
---
_Generated by [Claude
Code](https://claude.ai/code/session_01GzRy6FiHuy1vpBecH2KRYM)_
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent 3eb3ec1 commit ae923ec
4 files changed
Lines changed: 361 additions & 37 deletions
File tree
- .changeset
- packages/app-shell/src/views/studio-design
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| |||
4017 | 4017 | | |
4018 | 4018 | | |
4019 | 4019 | | |
| 4020 | + | |
| 4021 | + | |
| 4022 | + | |
4020 | 4023 | | |
4021 | 4024 | | |
4022 | | - | |
4023 | | - | |
4024 | | - | |
4025 | | - | |
4026 | | - | |
4027 | 4025 | | |
4028 | 4026 | | |
4029 | 4027 | | |
| |||
5828 | 5826 | | |
5829 | 5827 | | |
5830 | 5828 | | |
5831 | | - | |
5832 | | - | |
5833 | | - | |
5834 | | - | |
5835 | | - | |
5836 | | - | |
5837 | | - | |
| 5829 | + | |
5838 | 5830 | | |
5839 | 5831 | | |
5840 | 5832 | | |
| |||
7456 | 7448 | | |
7457 | 7449 | | |
7458 | 7450 | | |
7459 | | - | |
7460 | | - | |
7461 | | - | |
7462 | | - | |
7463 | | - | |
7464 | | - | |
7465 | | - | |
| 7451 | + | |
7466 | 7452 | | |
7467 | 7453 | | |
7468 | 7454 | | |
| |||
8009 | 7995 | | |
8010 | 7996 | | |
8011 | 7997 | | |
8012 | | - | |
| 7998 | + | |
| 7999 | + | |
| 8000 | + | |
| 8001 | + | |
| 8002 | + | |
| 8003 | + | |
| 8004 | + | |
| 8005 | + | |
| 8006 | + | |
8013 | 8007 | | |
8014 | 8008 | | |
8015 | 8009 | | |
8016 | 8010 | | |
8017 | 8011 | | |
8018 | | - | |
8019 | | - | |
8020 | | - | |
8021 | | - | |
8022 | | - | |
8023 | | - | |
8024 | | - | |
8025 | 8012 | | |
8026 | 8013 | | |
8027 | 8014 | | |
| |||
8051 | 8038 | | |
8052 | 8039 | | |
8053 | 8040 | | |
8054 | | - | |
| 8041 | + | |
8055 | 8042 | | |
8056 | 8043 | | |
8057 | 8044 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
0 commit comments